[Engine-devel] Consider iowait add into usage CPU percentage
--_000_B63C858E777679458338A30A991BB524015C66EBG1W3780americas_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi All, On engine core, The usage CPU percentage is calculated by %sys + %usr class VdsBrokerObjectsBuilder function updateVDSStatisticsData vds.setCpuSys(AssignDoubleValue(xmlRpcStruct, VdsProperties.cpu_sys)); vds.setCpuUser(AssignDoubleValue(xmlRpcStruct, VdsProperties.cpu_us= er)); if (vds.getCpuSys() !=3D null && vds.getCpuUser() !=3D null) { vds.setUsageCpuPercent((int) (vds.getCpuSys() + vds.getCpuUser(= ))); } On vdsm, The %sys, %usr and %idle is calculated like below workflow, class API function getStats decStats =3D self._cif._hostStats.get() class clientIF function __init__ self._hostStats =3D sampling.HostStatsThread(log=3Dlog) self._hostStats.start() class HostStatsThread function get hs0, hs1 =3D self._samples[0], self._samples[-1] ... jiffies =3D (hs1.totcpu.user - hs0.totcpu.user) % (2 ** = 32) stats['cpuUser'] =3D jiffies / interval / self._ncpus jiffies =3D (hs1.totcpu.sys - hs0.totcpu.sys) % (2 ** 32) stats['cpuSys'] =3D jiffies / interval / self._ncpus stats['cpuIdle'] =3D max(0.0, 100.0 - stats['cpuUser'] - stats['cpu= Sys']) class HostSample function __init__ self.totcpu =3D TotalCpuSample() class TotalCpuSample function __init__ self.user, userNice, self.sys, self.idle =3D \ map(int, file('/proc/stat').readline().split()[1:5]) self.user +=3D userNice Question1: Why stats['cpuIdle'] do not use the sampling data totcpu.idle fo= r calculating? Question2: There is another data named iowait in /proc/stat, do we need to = consider add this into usage CPU percentage for calculating? Best Regards, Jason Liao --_000_B63C858E777679458338A30A991BB524015C66EBG1W3780americas_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style><!-- /* Font Definitions */ @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:"HP Simplified"; panose-1:2 11 6 4 2 2 4 2 2 4;} @font-face {font-family:"YaHei Consolas Hybrid"; panose-1:2 11 5 9 2 2 4 2 2 4;} @font-face {font-family:"\@YaHei Consolas Hybrid"; panose-1:2 11 5 9 2 2 4 2 2 4;} @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; margin-bottom:.0001pt; text-align:justify; text-justify:inter-ideograph; font-size:10.5pt; font-family:"Calibri","sans-serif";} a:link, span.MsoHyperlink {mso-style-priority:99; color:#0563C1; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {mso-style-priority:99; color:#954F72; text-decoration:underline;} span.EmailStyle17 {mso-style-type:personal-compose; font-family:"HP Simplified","sans-serif"; color:windowtext;} .MsoChpDefault {mso-style-type:export-only;} /* Page Definitions */ @page WordSection1 {size:612.0pt 792.0pt; margin:72.0pt 90.0pt 72.0pt 90.0pt;} div.WordSection1 {page:WordSection1;} --></style><!--[if gte mso 9]><xml> <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" /> </xml><![endif]--><!--[if gte mso 9]><xml> <o:shapelayout v:ext=3D"edit"> <o:idmap v:ext=3D"edit" data=3D"1" /> </o:shapelayout></xml><![endif]--> </head> <body lang=3D"ZH-CN" link=3D"#0563C1" vlink=3D"#954F72" style=3D"text-justi= fy-trim:punctuation"> <div class=3D"WordSection1"> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">Hi All,<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">On engine core, The usage CPU perce= ntage is calculated by %sys + %usr<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class VdsBrokerObjectsBuilder <o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function updateVDSStatisticsData<o:= p></o:p></span></p> <p class=3D"MsoNormal" style=3D"margin-left:21.0pt;text-indent:21.0pt"><spa= n lang=3D"EN-US" style=3D"font-family:"HP Simplified","sans-= serif"">vds.setCpuSys(AssignDoubleValue(xmlRpcStruct, VdsProperties.cp= u_sys));<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; vds.setCpuUser(AssignDoubleValue(xmlRpcStruct, VdsProperties.cpu_us= er));<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; if (vds.getCpuSys() !=3D null && vds.getCpuUser() !=3D null= ) {<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; vds.setUsageCpuPercent((int) (vds.getCpuSys= () + vds.getCpuUser()));<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; }<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">On vdsm, The %sys, %usr and %idle i= s calculated like below workflow,<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class API<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function getStats<o:p></o:p></span>= </p> <p class=3D"MsoNormal" style=3D"margin-left:21.0pt;text-indent:21.0pt"><spa= n lang=3D"EN-US" style=3D"font-family:"HP Simplified","sans-= serif"">decStats =3D self._cif._hostStats.get()<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class clientIF<o:p></o:p></span></p=
<p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function __init__<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; s= elf._hostStats =3D sampling.HostStatsThread(log=3Dlog)<o:p></o:p></span></p=
</p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; stats['cpuUser'] =3D jiffies / interval / self._ncpus<o:p></o:p></s=
</span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; stats['cpuSys'] =3D jiffies / interval / self._ncpus<o:p></o:p></sp= an></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; stats['cpuIdle'] =3D max(0.0, 100.0 - stats['cpuUser'] - stats['cpu= Sys'])<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class HostSample<o:p></o:p></span><= /p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function __init__<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; s= elf.totcpu =3D TotalCpuSample()<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class TotalCpuSample<o:p></o:p></sp= an></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function __init__<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; self.user, userNice, self.sys, self.idle =3D \<o:p></o:p></sp= an></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; map(int, file('/proc/stat').readline().spli= t()[1:5])<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; self.user +=3D userNice<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">Question1: Why stats[‘cpuIdle= ’] do not use the sampling data totcpu.idle for calculating?<o:p></o:=
<p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; self._hostStats.start()<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class HostStatsThread<o:p></o:p></s= pan></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function get<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; h= s0, hs1 =3D self._samples[0], self._samples[-1]<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; &= #8230;<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; j= iffies =3D (hs1.totcpu.user - hs0.totcpu.user) % (2 ** 32)<o:p></o:p></span= pan></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; jiffies =3D (hs1.totcpu.sys - hs0.totcpu.sys) % (2 ** 32)<o:p></o:p= p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">Question2: There is another data na= med iowait in /proc/stat, do we need to consider add this into usage CPU pe= rcentage for calculating?<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><b><span lang=3D"EN-US" style=3D"font-size:9.0pt;fon= t-family:"HP Simplified","sans-serif";color:black">Best= Regards,<br> </span></b><span lang=3D"EN-US" style=3D"font-size:9.0pt;font-family:"= HP Simplified","sans-serif";color:#717172">Jason Liao</span>= <span lang=3D"EN-US"><o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> </div> </body> </html> --_000_B63C858E777679458338A30A991BB524015C66EBG1W3780americas_--
=C4=EA</span><span lang=3D"EN-US" style=3D"font-size:11.0pt">3</span><span=
--_000_B63C858E777679458338A30A991BB524015D1CBEG1W3780americas_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 SGkgQWxsLA0KDQpBbnkgZmVlZGJhY2sgZm9yIHRoaXMgdG9waWM/DQpBZGQgRG9yb24gYW5kIE1h cnRpbiBpbiB0aGUgbWFpbCBsaXN0Lg0KDQpCZXN0IFJlZ2FyZHMsDQpKYXNvbiBMaWFvDQoNCkZy b206IHZkc20tZGV2ZWwtYm91bmNlc0BsaXN0cy5mZWRvcmFob3N0ZWQub3JnIFttYWlsdG86dmRz bS1kZXZlbC1ib3VuY2VzQGxpc3RzLmZlZG9yYWhvc3RlZC5vcmddIE9uIEJlaGFsZiBPZiBMaWFv LCBDaHVhbiAoSmFzb24gTGlhbywgSFBzZXJ2ZXJzLUNvcmUtT0UtUFNDKQ0KU2VudDogMjAxNMTq M9TCMTHI1SAxNDowMg0KVG86IHZkc20tZGV2ZWw7IGVuZ2luZS1kZXZlbEBvdmlydC5vcmcNCkNj OiBMaWFuZywgU2hhbmctQ2h1biAoRGF2aWQgTGlhbmcsIEhQc2VydmVycy1Db3JlLU9FLVBTQyk7 IFZpbm9kLCBDaGVndTsgR2lsYWQgQ2hhcGxpaw0KU3ViamVjdDogW3Zkc21dIENvbnNpZGVyIGlv d2FpdCBhZGQgaW50byB1c2FnZSBDUFUgcGVyY2VudGFnZQ0KDQpIaSBBbGwsDQoNCk9uIGVuZ2lu ZSBjb3JlLCBUaGUgdXNhZ2UgQ1BVIHBlcmNlbnRhZ2UgaXMgY2FsY3VsYXRlZCBieSAlc3lzICsg JXVzcg0KDQpjbGFzcyBWZHNCcm9rZXJPYmplY3RzQnVpbGRlcg0KZnVuY3Rpb24gdXBkYXRlVkRT U3RhdGlzdGljc0RhdGENCnZkcy5zZXRDcHVTeXMoQXNzaWduRG91YmxlVmFsdWUoeG1sUnBjU3Ry dWN0LCBWZHNQcm9wZXJ0aWVzLmNwdV9zeXMpKTsNCiAgICAgICAgdmRzLnNldENwdVVzZXIoQXNz aWduRG91YmxlVmFsdWUoeG1sUnBjU3RydWN0LCBWZHNQcm9wZXJ0aWVzLmNwdV91c2VyKSk7DQog ICAgICAgIGlmICh2ZHMuZ2V0Q3B1U3lzKCkgIT0gbnVsbCAmJiB2ZHMuZ2V0Q3B1VXNlcigpICE9 IG51bGwpIHsNCiAgICAgICAgICAgIHZkcy5zZXRVc2FnZUNwdVBlcmNlbnQoKGludCkgKHZkcy5n ZXRDcHVTeXMoKSArIHZkcy5nZXRDcHVVc2VyKCkpKTsNCiAgICAgICAgfQ0KDQpPbiB2ZHNtLCBU aGUgJXN5cywgJXVzciBhbmQgJWlkbGUgaXMgY2FsY3VsYXRlZCBsaWtlIGJlbG93IHdvcmtmbG93 LA0KDQpjbGFzcyBBUEkNCmZ1bmN0aW9uIGdldFN0YXRzDQpkZWNTdGF0cyA9IHNlbGYuX2NpZi5f aG9zdFN0YXRzLmdldCgpDQpjbGFzcyBjbGllbnRJRg0KZnVuY3Rpb24gX19pbml0X18NCiAgICAg ICAgICAgICAgICAgICBzZWxmLl9ob3N0U3RhdHMgPSBzYW1wbGluZy5Ib3N0U3RhdHNUaHJlYWQo bG9nPWxvZykNCiAgICAgICAgc2VsZi5faG9zdFN0YXRzLnN0YXJ0KCkNCmNsYXNzIEhvc3RTdGF0 c1RocmVhZA0KZnVuY3Rpb24gZ2V0DQogICAgICAgICAgICAgICAgICAgaHMwLCBoczEgPSBzZWxm Ll9zYW1wbGVzWzBdLCBzZWxmLl9zYW1wbGVzWy0xXQ0KICAgICAgICAgICAgICAgICAgIKGtDQog ICAgICAgICAgICAgICAgICAgamlmZmllcyA9IChoczEudG90Y3B1LnVzZXIgLSBoczAudG90Y3B1 LnVzZXIpICUgKDIgKiogMzIpDQogICAgICAgIHN0YXRzWydjcHVVc2VyJ10gPSBqaWZmaWVzIC8g aW50ZXJ2YWwgLyBzZWxmLl9uY3B1cw0KICAgICAgICBqaWZmaWVzID0gKGhzMS50b3RjcHUuc3lz IC0gaHMwLnRvdGNwdS5zeXMpICUgKDIgKiogMzIpDQogICAgICAgIHN0YXRzWydjcHVTeXMnXSA9 IGppZmZpZXMgLyBpbnRlcnZhbCAvIHNlbGYuX25jcHVzDQogICAgICAgIHN0YXRzWydjcHVJZGxl J10gPSBtYXgoMC4wLCAxMDAuMCAtIHN0YXRzWydjcHVVc2VyJ10gLSBzdGF0c1snY3B1U3lzJ10p DQpjbGFzcyBIb3N0U2FtcGxlDQpmdW5jdGlvbiBfX2luaXRfXw0KICAgICAgICAgICAgICAgICAg IHNlbGYudG90Y3B1ID0gVG90YWxDcHVTYW1wbGUoKQ0KY2xhc3MgVG90YWxDcHVTYW1wbGUNCmZ1 bmN0aW9uIF9faW5pdF9fDQogICAgICAgICBzZWxmLnVzZXIsIHVzZXJOaWNlLCBzZWxmLnN5cywg c2VsZi5pZGxlID0gXA0KICAgICAgICAgICAgbWFwKGludCwgZmlsZSgnL3Byb2Mvc3RhdCcpLnJl YWRsaW5lKCkuc3BsaXQoKVsxOjVdKQ0KICAgICAgICBzZWxmLnVzZXIgKz0gdXNlck5pY2UNCg0K UXVlc3Rpb24xOiBXaHkgc3RhdHNboa5jcHVJZGxloa9dIGRvIG5vdCB1c2UgdGhlIHNhbXBsaW5n IGRhdGEgdG90Y3B1LmlkbGUgZm9yIGNhbGN1bGF0aW5nPw0KDQpRdWVzdGlvbjI6IFRoZXJlIGlz IGFub3RoZXIgZGF0YSBuYW1lZCBpb3dhaXQgaW4gL3Byb2Mvc3RhdCwgZG8gd2UgbmVlZCB0byBj b25zaWRlciBhZGQgdGhpcyBpbnRvIHVzYWdlIENQVSBwZXJjZW50YWdlIGZvciBjYWxjdWxhdGlu Zz8NCg0KQmVzdCBSZWdhcmRzLA0KSmFzb24gTGlhbw0KDQo= --_000_B63C858E777679458338A30A991BB524015D1CBEG1W3780americas_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dgb2312"> <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style><!-- /* Font Definitions */ @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} @font-face {font-family:"HP Simplified"; panose-1:2 11 6 4 2 2 4 2 2 4;} @font-face {font-family:"YaHei Consolas Hybrid"; panose-1:2 11 5 9 2 2 4 2 2 4;} @font-face {font-family:"\@YaHei Consolas Hybrid"; panose-1:2 11 5 9 2 2 4 2 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; margin-bottom:.0001pt; text-align:justify; text-justify:inter-ideograph; font-size:10.5pt; font-family:"Calibri","sans-serif";} a:link, span.MsoHyperlink {mso-style-priority:99; color:#0563C1; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {mso-style-priority:99; color:#954F72; text-decoration:underline;} span.EmailStyle17 {mso-style-type:personal; font-family:"HP Simplified","sans-serif"; color:windowtext;} span.EmailStyle18 {mso-style-type:personal-reply; font-family:"HP Simplified","sans-serif"; color:#7030A0;} .MsoChpDefault {mso-style-type:export-only; font-size:10.0pt;} @page WordSection1 {size:612.0pt 792.0pt; margin:72.0pt 90.0pt 72.0pt 90.0pt;} div.WordSection1 {page:WordSection1;} --></style><!--[if gte mso 9]><xml> <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" /> </xml><![endif]--><!--[if gte mso 9]><xml> <o:shapelayout v:ext=3D"edit"> <o:idmap v:ext=3D"edit" data=3D"1" /> </o:shapelayout></xml><![endif]--> </head> <body lang=3D"ZH-CN" link=3D"#0563C1" vlink=3D"#954F72" style=3D"text-justi= fy-trim:punctuation"> <div class=3D"WordSection1"> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif";color:#7030A0">Hi All,<o:p></o:p></s= pan></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif";color:#7030A0"><o:p> </o:p></sp= an></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif";color:#7030A0">Any feedback for this= topic? <o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif";color:#7030A0">Add Doron and Martin = in the mail list.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif";color:#7030A0"><o:p> </o:p></sp= an></p> <div> <p class=3D"MsoNormal"><b><span lang=3D"EN-US" style=3D"font-size:9.0pt;fon= t-family:"HP Simplified","sans-serif";color:black">Best= Regards,<br> </span></b><span lang=3D"EN-US" style=3D"font-size:9.0pt;font-family:"= HP Simplified","sans-serif";color:#717172">Jason Liao</span>= <span lang=3D"EN-US" style=3D"color:#7030A0"><o:p></o:p></span></p> </div> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif";color:#7030A0"><o:p> </o:p></sp= an></p> <div> <div style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm = 0cm 0cm"> <p class=3D"MsoNormal" align=3D"left" style=3D"text-align:left"><b><span la= ng=3D"EN-US" style=3D"font-size:11.0pt">From:</span></b><span lang=3D"EN-US= " style=3D"font-size:11.0pt"> vdsm-devel-bounces@lists.fedorahosted.org [ma= ilto:vdsm-devel-bounces@lists.fedorahosted.org] <b>On Behalf Of </b>Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)<br> <b>Sent:</b> 2014</span><span style=3D"font-size:11.0pt;font-family:SimSun"= style=3D"font-size:11.0pt;font-family:SimSun">=D4=C2</span><span lang=3D"E= N-US" style=3D"font-size:11.0pt">11</span><span style=3D"font-size:11.0pt;f= ont-family:SimSun">=C8=D5</span><span lang=3D"EN-US" style=3D"font-size:11.= 0pt"> 14:02<br> <b>To:</b> vdsm-devel; engine-devel@ovirt.org<br> <b>Cc:</b> Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Vinod, C= hegu; Gilad Chaplik<br> <b>Subject:</b> [vdsm] Consider iowait add into usage CPU percentage<o:p></= o:p></span></p> </div> </div> <p class=3D"MsoNormal" align=3D"left" style=3D"text-align:left"><span lang= =3D"EN-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">Hi All,<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">On engine core, The usage CPU perce= ntage is calculated by %sys + %usr<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class VdsBrokerObjectsBuilder <o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function updateVDSStatisticsData<o:= p></o:p></span></p> <p class=3D"MsoNormal" style=3D"margin-left:21.0pt;text-indent:21.0pt"><spa= n lang=3D"EN-US" style=3D"font-family:"HP Simplified","sans-= serif"">vds.setCpuSys(AssignDoubleValue(xmlRpcStruct, VdsProperties.cp= u_sys));<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; vds.setCpuUser(AssignDoubleValue(xmlRpcStruct, VdsProperties.cpu_us= er));<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; if (vds.getCpuSys() !=3D null && vds.getCpuUser() !=3D null= ) {<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; vds.setUsageCpuPercent((int) (vds.getCpuSys= () + vds.getCpuUser()));<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; }<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">On vdsm, The %sys, %usr and %idle i= s calculated like below workflow,<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class API<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function getStats<o:p></o:p></span>= </p> <p class=3D"MsoNormal" style=3D"margin-left:21.0pt;text-indent:21.0pt"><spa= n lang=3D"EN-US" style=3D"font-family:"HP Simplified","sans-= serif"">decStats =3D self._cif._hostStats.get()<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class clientIF<o:p></o:p></span></p=
<p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function __init__<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; s= elf._hostStats =3D sampling.HostStatsThread(log=3Dlog)<o:p></o:p></span></p=
</p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; stats['cpuUser'] =3D jiffies / interval / self._ncpus<o:p></o:p></s=
<p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; self._hostStats.start()<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class HostStatsThread<o:p></o:p></s= pan></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function get<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; h= s0, hs1 =3D self._samples[0], self._samples[-1]<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; = =A1=AD<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; j= iffies =3D (hs1.totcpu.user - hs0.totcpu.user) % (2 ** 32)<o:p></o:p></span= pan></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; jiffies =3D (hs1.totcpu.sys - hs0.totcpu.sys) % (2 ** 32)<o:p></o:p=
</span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; stats['cpuSys'] =3D jiffies / interval / self._ncpus<o:p></o:p></sp= an></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; stats['cpuIdle'] =3D max(0.0, 100.0 - stats['cpuUser'] - stats['cpu= Sys'])<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class HostSample<o:p></o:p></span><= /p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function __init__<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; s= elf.totcpu =3D TotalCpuSample()<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">class TotalCpuSample<o:p></o:p></sp= an></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">function __init__<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; self.user, userNice, self.sys, self.idle =3D \<o:p></o:p></sp= an></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; map(int, file('/proc/stat').readline().spli= t()[1:5])<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""> = ; self.user +=3D userNice<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">Question1: Why stats[=A1=AEcpuIdle= =A1=AF] do not use the sampling data totcpu.idle for calculating?<o:p></o:p= </span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif"">Question2: There is another data na= med iowait in /proc/stat, do we need to consider add this into usage CPU pe= rcentage for calculating?<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"font-family:"HP S= implified","sans-serif""><o:p> </o:p></span></p> <p class=3D"MsoNormal"><b><span lang=3D"EN-US" style=3D"font-size:9.0pt;fon= t-family:"HP Simplified","sans-serif";color:black">Best= Regards,<br> </span></b><span lang=3D"EN-US" style=3D"font-size:9.0pt;font-family:"= HP Simplified","sans-serif";color:#717172">Jason Liao</span>= <span lang=3D"EN-US"><o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p> </o:p></span></p> </div> </body> </html>
--_000_B63C858E777679458338A30A991BB524015D1CBEG1W3780americas_--
----- Original Message -----
From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao@hp.com> To: "vdsm-devel" <vdsm-devel@lists.fedorahosted.org>, engine-devel@ovirt.org Cc: "Chegu Vinod" <chegu_vinod@hp.com>, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang@hp.com> Sent: Wednesday, March 12, 2014 4:09:59 AM Subject: Re: [Engine-devel] Consider iowait add into usage CPU percentage
Hi All,
Any feedback for this topic?
Add Doron and Martin in the mail list.
Best Regards, Jason Liao
From: vdsm-devel-bounces@lists.fedorahosted.org [mailto:vdsm-devel-bounces@lists.fedorahosted.org] On Behalf Of Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC) Sent: 2014 年 3 月 11 日 14:02 To: vdsm-devel; engine-devel@ovirt.org Cc: Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Vinod, Chegu; Gilad Chaplik Subject: [vdsm] Consider iowait add into usage CPU percentage
Hi All,
On engine core, The usage CPU percentage is calculated by %sys + %usr
class VdsBrokerObjectsBuilder
function updateVDSStatisticsData
vds.setCpuSys(AssignDoubleValue(xmlRpcStruct, VdsProperties.cpu_sys));
vds.setCpuUser(AssignDoubleValue(xmlRpcStruct, VdsProperties.cpu_user));
if (vds.getCpuSys() != null && vds.getCpuUser() != null) {
vds.setUsageCpuPercent((int) (vds.getCpuSys() + vds.getCpuUser()));
}
On vdsm, The %sys, %usr and %idle is calculated like below workflow,
class API
function getStats
decStats = self._cif._hostStats.get()
class clientIF
function __init__
self._hostStats = sampling.HostStatsThread(log=log)
self._hostStats.start()
class HostStatsThread
function get
hs0, hs1 = self._samples[0], self._samples[-1]
…
jiffies = (hs1.totcpu.user - hs0.totcpu.user) % (2 ** 32)
stats['cpuUser'] = jiffies / interval / self._ncpus
jiffies = (hs1.totcpu.sys - hs0.totcpu.sys) % (2 ** 32)
stats['cpuSys'] = jiffies / interval / self._ncpus
stats['cpuIdle'] = max(0.0, 100.0 - stats['cpuUser'] - stats['cpuSys'])
class HostSample
function __init__
self.totcpu = TotalCpuSample()
class TotalCpuSample
function __init__
self.user, userNice, self.sys, self.idle = \
map(int, file('/proc/stat').readline().split()[1:5])
self.user += userNice
Question1: Why stats[‘cpuIdle’] do not use the sampling data totcpu.idle for calculating?
I have a vague memory of this calculation which tries to level the numbers. ie- the assumption is that user and sys adds up to something which is less than 100. If this is not the case (multiple core / SMT) idle will be set to 0. But possibly Dan remembers something else?
Question2: There is another data named iowait in /proc/stat, do we need to consider add this into usage CPU percentage for calculating?
Since the above excludes iowait, I wouldn't add it here. Otherwise we may have inconsistency with the numbers.
Best Regards, Jason Liao
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (2)
-
Doron Fediuck -
Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)