1:11 a.m.
Hello all,
The 'Import VM/Template More Than Once' feature description can be found under the
following link:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
Please review, and feel free to share your comments and thoughts.
Thanks,
Gilad.
1:27 a.m.
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
Hello all,
The 'Import VM/Template More Than Once' feature description can be found under
the following link:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
Please review, and feel free to share your comments and thoughts.
Thanks,
Gilad.
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
1. Missing high level (user level) summary. For example, what does it
mean that a VM already exist in the setup? If I had a VM with 10GB disk,
without an OS installed, then exported it, then installed an OS into it
(so now the disk is a bit full, as opposed to the emptied exported one).
Does it means that an identical entity already exist in the setup or
not? (think of overwriting files).
The design should (ALWAYS?) start with the user flow.
2. 'clone' doesn't strike me as a great parameter name in the API. Not
in the UI either (but I don't have a better suggestion - yet).
3. What is the equivalent to 'suffix' in the API? Or do we expect to
provide a name when we import? I'm not sure how the API works in the
case of an existing VM, really. Only after we fetch via the API the fact
it has an existing VM, we give it a new suffix?
4. Small typos (I'll fix them later directly in the wiki, except for the
mockups, which I can't fix).
Y.
2:03 a.m.
On 02/21/2012 05:27 PM, Yaniv Kaul wrote:
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
> Hello all,
>
> The 'Import VM/Template More Than Once' feature description can be
> found under the following link:
>
> http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
>
> Please review, and feel free to share your comments and thoughts.
>
> Thanks,
> Gilad.
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
1. Missing high level (user level) summary. For example, what does it
mean that a VM already exist in the setup? If I had a VM with 10GB disk,
without an OS installed, then exported it, then installed an OS into it
(so now the disk is a bit full, as opposed to the emptied exported one).
Does it means that an identical entity already exist in the setup or
not? (think of overwriting files).
The design should (ALWAYS?) start with the user flow.
2. 'clone' doesn't strike me as a great parameter name in the API. Not
in the UI either (but I don't have a better suggestion - yet).
3. What is the equivalent to 'suffix' in the API? Or do we expect to
provide a name when we import? I'm not sure how the API works in the
case of an existing VM, really. Only after we fetch via the API the fact
This reminds me that I was in a dilemma of suffix/prefix issue myself,
in Clone VM from snapshot feature.
I think this issue may be problematic , and for simplicity we should
simply provide a new name.
it has an existing VM, we give it a new suffix?
4. Small typos (I'll fix them later directly in the wiki, except for the
mockups, which I can't fix).
Y.
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
2:30 a.m.
----- Original Message -----
From: "Yaniv Kaul" <ykaul(a)redhat.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>
Cc: engine-devel(a)ovirt.org
Sent: Tuesday, February 21, 2012 5:27:19 PM
Subject: Re: [Engine-devel] 'Import VM/Template More Than Once' feature
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
> Hello all,
>
> The 'Import VM/Template More Than Once' feature description can be
> found under the following link:
>
> http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
>
> Please review, and feel free to share your comments and thoughts.
>
> Thanks,
> Gilad.
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
1. Missing high level (user level) summary. For example, what does it
mean that a VM already exist in the setup? If I had a VM with 10GB
disk,
without an OS installed, then exported it, then installed an OS into
it
(so now the disk is a bit full, as opposed to the emptied exported
one).
Does it means that an identical entity already exist in the setup or
not? (think of overwriting files).
The design should (ALWAYS?) start with the user flow.
2. 'clone' doesn't strike me as a great parameter name in the API.
Not
in the UI either (but I don't have a better suggestion - yet).
i would say: importAsNewEntity - because what it really does is create a new entity,
in terms of ids, disks, nics...
also, the copyCollapse flag should be on as well.
3. What is the equivalent to 'suffix' in the API? Or do we
expect to
provide a name when we import? I'm not sure how the API works in the
case of an existing VM, really. Only after we fetch via the API the
fact
it has an existing VM, we give it a new suffix?
4. Small typos (I'll fix them later directly in the wiki, except for
the
mockups, which I can't fix).
Y.
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
2:49 a.m.
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs(a)redhat.com>
Sent: Tuesday, February 21, 2012 6:03:46 PM
On 02/21/2012 05:27 PM, Yaniv Kaul wrote:
> On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
>> Hello all,
>>
>> The 'Import VM/Template More Than Once' feature description can be
>> found under the following link:
>>
>> http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
>>
>> Please review, and feel free to share your comments and thoughts.
>>
>> Thanks,
>> Gilad.
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
> 1. Missing high level (user level) summary. For example, what does
> it
> mean that a VM already exist in the setup? If I had a VM with 10GB
> disk,
> without an OS installed, then exported it, then installed an OS
> into it
> (so now the disk is a bit full, as opposed to the emptied exported
> one).
> Does it means that an identical entity already exist in the setup
> or
> not? (think of overwriting files).
> The design should (ALWAYS?) start with the user flow.
> 2. 'clone' doesn't strike me as a great parameter name in the API.
> Not
> in the UI either (but I don't have a better suggestion - yet).
> 3. What is the equivalent to 'suffix' in the API? Or do we expect
> to
> provide a name when we import? I'm not sure how the API works in
> the
> case of an existing VM, really. Only after we fetch via the API the
> fact
This reminds me that I was in a dilemma of suffix/prefix issue
myself,
in Clone VM from snapshot feature.
I think this issue may be problematic , and for simplicity we should
simply provide a new name.
* just to clarify: the suffix feature is a pure GUI feature, and it shouldn't involve
the backend/api; the api should require a new name for every imported VM; the suffix
text-box is just to allow the user to provide a new name for several imported VMs at
once.
* in case of "clone VM from snapshot", I think that providing a new name is
enough (maybe provide a default name in the new name text-box, but again - it is GUI
only), mainly because I don't think that we will allow cloning from several
VMs/snapshots at once.
[we might want to clone several VMs from the same snapshot, not sure how we will provide
multiple names in such case]
> it has an existing VM, we give it a new suffix?
> 4. Small typos (I'll fix them later directly in the wiki, except
> for the
> mockups, which I can't fix).
> Y.
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
7:08 p.m.
----- Original Message -----
From: "Yaniv Kaul" <ykaul(a)redhat.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>
Cc: engine-devel(a)ovirt.org
Sent: Tuesday, February 21, 2012 5:27:19 PM
Subject: Re: [Engine-devel] 'Import VM/Template More Than Once' feature
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
> Hello all,
>
> The 'Import VM/Template More Than Once' feature description can be
> found under the following link:
>
> http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
>
> Please review, and feel free to share your comments and thoughts.
>
> Thanks,
> Gilad.
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
1. Missing high level (user level) summary. For example, what does it
mean that a VM already exist in the setup? If I had a VM with 10GB
disk,
without an OS installed, then exported it, then installed an OS into
it
(so now the disk is a bit full, as opposed to the emptied exported
one).
Does it means that an identical entity already exist in the setup or
not? (think of overwriting files).
not.
We need to think how to portray it to the user, it a bit tricky.
The design should (ALWAYS?) start with the user flow.
I'll change it.
2. 'clone' doesn't strike me as a great parameter name in
the API.
Not
in the UI either (but I don't have a better suggestion - yet).
Other suggestions are welcomed, Omer has one.
3. What is the equivalent to 'suffix' in the API? Or do we
expect to
provide a name when we import? I'm not sure how the API works in the
case of an existing VM, really. Only after we fetch via the API the
fact
it has an existing VM, we give it a new suffix?
In fact it's the same (just need to clarify that), the suffix is GUI only, and the
client passes the vm name in the vm's vm_name field (old_name + suffix). In REST the
vm name will be passed a part of the action parameters:
<action>
<cluster id="afsdasdf"/>
<storage_domain id="5@#$^234634^"/>
<clone>true</clone> //This is the new value
<vm>
<name>new_name</name>
</vm>
</action>
note: in case the clone flag is true the vm.name is mandatory. (will update the wiki for
all the above)
4. Small typos (I'll fix them later directly in the wiki, except
for
the
mockups, which I can't fix).
Y.
5:58 a.m.
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
Hello all,
The 'Import VM/Template More Than Once' feature description can be found under
the following link:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
Please review, and feel free to share your comments and thoughts.
1. " Add 'Already Exists in Setup' column to import entity dialog:
Run multiple queries for get_entity_by_id to check whether the
imported entities exist in the setup. "
what if there are 1000 VMs to import?
2. "Add 'clone only existing entities' check box to Import Entity Dialog:
"
I'd keep simple for first round to get feedback from users and assume
users want to either clone or not during import, rather than mixed
(i.e., i'd drop this option to clone some of the imported images - i
think it is confusing)
which means maybe user should choose between importing already existing
images or new ones.
for existing ones, user should choose if to clone or overwrite.
6:56 p.m.
On 21/02/12 17:11, Gilad Chaplik wrote:
Hello all,
The 'Import VM/Template More Than Once' feature description can be found under
the following link:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
Please review, and feel free to share your comments and thoughts.
Thanks,
Gilad.
I am missing the most obvious limitation of this feature in the summary
of the feature.
This feature is limited to mode of collapsing the imported VM images
AFAIR, if you import a VM based on a template, for each import, a
collapsed image is created in the setup (It is like importing the
template with each VM you have based on this template).
I think this limitation makes the feature unworthy, we should be able to
support changing the ID's and importing only the needed storage layer.
Livnat
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
5:14 a.m.
see inline
Thanks,
Gilad.
----- Original Message -----
From: "Itamar Heim" <iheim(a)redhat.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>
Cc: engine-devel(a)ovirt.org
Sent: Wednesday, March 28, 2012 9:58:57 PM
Subject: Re: [Engine-devel] 'Import VM/Template More Than Once' feature
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
> Hello all,
>
> The 'Import VM/Template More Than Once' feature description can be
> found under the following link:
>
> http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
>
> Please review, and feel free to share your comments and thoughts.
1. " Add 'Already Exists in Setup' column to import entity dialog:
Run multiple queries for get_entity_by_id to check whether the
imported entities exist in the setup. "
what if there are 1000 VMs to import?
My mistake, meant it to be run search query on VMs with concating 'OR' between all
vms ids (if search by vm ids is not supported I will add it).
but if you prefer it I can remove the column.
2. "Add 'clone only existing entities' check box to Import Entity
Dialog: "
I'd keep simple for first round to get feedback from users and assume
users want to either clone or not during import, rather than mixed
(i.e., i'd drop this option to clone some of the imported images - i
think it is confusing)
which means maybe user should choose between importing already
existing
images or new ones.
for existing ones, user should choose if to clone or overwrite.
Not sure what is override? delete the VM that is currently in setup and then import?
Anyhow, I think it's quite important, especially if we remove the 'exist in
setup' column, we want the user to avoid getting can-do-action.
I agree that it is slightly confusing, I can rerun it through Eldan again, even though
it's his design.
5:49 a.m.
I think that the necessity of this feature is a from UX point of view:
Avoiding the nasty can-do-action if the VM is in the system, and adding an important flow
to the user.
Anyhow I think it's a light feature with minimum changes to the backend, most of the
work is in the ui.
Thanks,
Gilad.
----- Original Message -----
From: "Livnat Peer" <lpeer(a)redhat.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>
Cc: engine-devel(a)ovirt.org
Sent: Thursday, March 29, 2012 10:56:17 AM
Subject: Re: [Engine-devel] 'Import VM/Template More Than Once' feature
On 21/02/12 17:11, Gilad Chaplik wrote:
> Hello all,
>
> The 'Import VM/Template More Than Once' feature description can be
> found under the following link:
>
> http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
>
> Please review, and feel free to share your comments and thoughts.
>
> Thanks,
> Gilad.
I am missing the most obvious limitation of this feature in the
summary
of the feature.
This feature is limited to mode of collapsing the imported VM images
AFAIR, if you import a VM based on a template, for each import, a
collapsed image is created in the setup (It is like importing the
template with each VM you have based on this template).
I think this limitation makes the feature unworthy, we should be able
to
support changing the ID's and importing only the needed storage
layer.
Livnat
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
7:24 a.m.
On 03/29/2012 09:14 PM, Gilad Chaplik wrote:
see inline
Thanks,
Gilad.
----- Original Message -----
> From: "Itamar Heim"<iheim(a)redhat.com>
> To: "Gilad Chaplik"<gchaplik(a)redhat.com>
> Cc: engine-devel(a)ovirt.org
> Sent: Wednesday, March 28, 2012 9:58:57 PM
> Subject: Re: [Engine-devel] 'Import VM/Template More Than Once' feature
>
> On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
>> Hello all,
>>
>> The 'Import VM/Template More Than Once' feature description can be
>> found under the following link:
>>
>> http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
>>
>> Please review, and feel free to share your comments and thoughts.
>
> 1. " Add 'Already Exists in Setup' column to import entity dialog:
> Run multiple queries for get_entity_by_id to check whether the
> imported entities exist in the setup. "
>
> what if there are 1000 VMs to import?
My mistake, meant it to be run search query on VMs with concating 'OR' between
all vms ids (if search by vm ids is not supported I will add it).
but if you prefer it I can remove the column.
>
> 2. "Add 'clone only existing entities' check box to Import Entity
> Dialog: "
>
> I'd keep simple for first round to get feedback from users and assume
> users want to either clone or not during import, rather than mixed
> (i.e., i'd drop this option to clone some of the imported images - i
> think it is confusing)
>
> which means maybe user should choose between importing already
> existing
> images or new ones.
>
> for existing ones, user should choose if to clone or overwrite.
>
Not sure what is override? delete the VM that is currently in setup and then import?
Anyhow, I think it's quite important, especially if we remove the 'exist in
setup' column, we want the user to avoid getting can-do-action.
I agree that it is slightly confusing, I can rerun it through Eldan again, even though
it's his design.
override wouldn't delete the VM, just override the disks iirc (will not
touch configuration i guess. no idea what happens if configuration is
different, or number of disks is different, etc.)
4410
days inactive
4448
days old
10 comments
7 participants
participants (7)
-
Einav Cohen -
Gilad Chaplik -
Itamar Heim -
Livnat Peer -
Omer Frenkel -
Yair Zaslavsky -
Yaniv Kaul