Re: [Engine-devel] [vdsm] Adding vdsm_api support for gluster vdsm verbs
[Adding engine-devel] On 04/16/2013 02:10 PM, Aravinda wrote:
vdsm/gluster is vdsm plugin for gluster related functionality. These functionalities are available only when vdsm-gluster package is installed. So the schema JSON of vdsm-gluster cannot be added to the same file(vdsm_api/vdsmapi-schema.json)
Looks like vdsm_api is not providing plugin support. This patch adds functionality to vdsm_api to read vdsmapi-gluster-schema.json if available. But with this approach we need to edit the core vdsmapi.py file.
http://gerrit.ovirt.org/#/c/13921/
Alternate approach: We can have "vdsm_api/plugins" or "vdsm_api/schema" directory inside vdsm_api, so that we can modify vdsmapi.py to read all schema files from that dir. When vdsm-gluster package installed, it copies vdsmapi-gluster-schema.json into schema directory.
-- regards Aravinda
On 04/15/2013 04:14 PM, Aravinda wrote:
Hi,
We are trying to add json rpc support for vdsm gluster verbs. I submitted a patch to read gluster verbs schema from vdsm/gluster directory. http://gerrit.ovirt.org/#/c/13921/
Let me know if the approach is fine.
-- regards Aravinda _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
_______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
[Adding Saggi, Adam, Dan, Sahina] On 04/16/2013 02:13 PM, Aravinda wrote:
[Adding engine-devel]
On 04/16/2013 02:10 PM, Aravinda wrote:
vdsm/gluster is vdsm plugin for gluster related functionality. These functionalities are available only when vdsm-gluster package is installed. So the schema JSON of vdsm-gluster cannot be added to the same file(vdsm_api/vdsmapi-schema.json)
Looks like vdsm_api is not providing plugin support. This patch adds functionality to vdsm_api to read vdsmapi-gluster-schema.json if available. But with this approach we need to edit the core vdsmapi.py file.
http://gerrit.ovirt.org/#/c/13921/
Alternate approach: We can have "vdsm_api/plugins" or "vdsm_api/schema" directory inside vdsm_api, so that we can modify vdsmapi.py to read all schema files from that dir. When vdsm-gluster package installed, it copies vdsmapi-gluster-schema.json into schema directory.
-- regards Aravinda
On 04/15/2013 04:14 PM, Aravinda wrote:
Hi,
We are trying to add json rpc support for vdsm gluster verbs. I submitted a patch to read gluster verbs schema from vdsm/gluster directory. http://gerrit.ovirt.org/#/c/13921/
Let me know if the approach is fine.
-- regards Aravinda _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
_______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
This is very Gluster specific but I guess it's OK until I get some time to make things a bit more generic over there. ----- Original Message -----
From: "Aravinda" <avishwan@redhat.com> To: vdsm-devel@lists.fedorahosted.org, engine-devel@ovirt.org, "Saggi Mizrahi" <smizrahi@redhat.com>, agl@us.ibm.com Cc: "Dan Kenigsberg" <danken@redhat.com>, "Sahina Bose" <sabose@redhat.com> Sent: Wednesday, April 17, 2013 3:49:13 PM Subject: Re: [Engine-devel] [vdsm] Adding vdsm_api support for gluster vdsm verbs
[Adding Saggi, Adam, Dan, Sahina]
On 04/16/2013 02:13 PM, Aravinda wrote:
[Adding engine-devel]
On 04/16/2013 02:10 PM, Aravinda wrote:
vdsm/gluster is vdsm plugin for gluster related functionality. These functionalities are available only when vdsm-gluster package is installed. So the schema JSON of vdsm-gluster cannot be added to the same file(vdsm_api/vdsmapi-schema.json)
Looks like vdsm_api is not providing plugin support. This patch adds functionality to vdsm_api to read vdsmapi-gluster-schema.json if available. But with this approach we need to edit the core vdsmapi.py file.
http://gerrit.ovirt.org/#/c/13921/
Alternate approach: We can have "vdsm_api/plugins" or "vdsm_api/schema" directory inside vdsm_api, so that we can modify vdsmapi.py to read all schema files from that dir. When vdsm-gluster package installed, it copies vdsmapi-gluster-schema.json into schema directory.
-- regards Aravinda
On 04/15/2013 04:14 PM, Aravinda wrote:
Hi,
We are trying to add json rpc support for vdsm gluster verbs. I submitted a patch to read gluster verbs schema from vdsm/gluster directory. http://gerrit.ovirt.org/#/c/13921/
Let me know if the approach is fine.
-- regards Aravinda _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
_______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (2)
-
Aravinda -
Saggi Mizrahi