packaging: setup: start ovn services on restore - broke make install-dev on fc30?
Hi all, Running on fc30 with engine, suddenly when rebasing or being on master branch the command: $ make install-dev SKIP_CHECKS=1 PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari" -j8 Didn't pass, it showed to me no errors, after build success, I got: touch "tmp.built" make[2]: Leaving directory '/home/lrotenbe/git/ovirt-engine' make[1]: Leaving directory '/home/lrotenbe/git/ovirt-engine' make: *** [Makefile:584: all-dev] Error 2 $ make test Did pass. Burning time to figure out the situation, I found out that this[1] patch caused it. Any idea why did it happen? Or what possibly we can do? [1] https://gerrit.ovirt.org/c/107847/ Regards, Liran.
On Thu, Mar 26, 2020 at 5:23 PM Liran Rotenberg <lrotenbe@redhat.com> wrote:
Hi all, Running on fc30 with engine, suddenly when rebasing or being on master branch the command: $ make install-dev SKIP_CHECKS=1 PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari" -j8
Didn't pass, it showed to me no errors, after build success, I got: touch "tmp.built" make[2]: Leaving directory '/home/lrotenbe/git/ovirt-engine' make[1]: Leaving directory '/home/lrotenbe/git/ovirt-engine' make: *** [Makefile:584: all-dev] Error 2
$ make test Did pass.
Burning time to figure out the situation, I found out that this[1] patch caused it. Any idea why did it happen? Or what possibly we can do?
Does https://gerrit.ovirt.org/#/c/107995/ fix the issue for you?
[1] https://gerrit.ovirt.org/c/107847/
Regards, Liran.
On Thu, Mar 26, 2020 at 7:04 PM Dominik Holler <dholler@redhat.com> wrote:
On Thu, Mar 26, 2020 at 5:23 PM Liran Rotenberg <lrotenbe@redhat.com> wrote:
Hi all, Running on fc30 with engine, suddenly when rebasing or being on master branch the command: $ make install-dev SKIP_CHECKS=1 PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari" -j8
Didn't pass, it showed to me no errors, after build success, I got: touch "tmp.built" make[2]: Leaving directory '/home/lrotenbe/git/ovirt-engine' make[1]: Leaving directory '/home/lrotenbe/git/ovirt-engine' make: *** [Makefile:584: all-dev] Error 2
$ make test Did pass.
Burning time to figure out the situation, I found out that this[1] patch caused it. Any idea why did it happen? Or what possibly we can do?
Does https://gerrit.ovirt.org/#/c/107995/ fix the issue for you?
Yes it works, +1 on the patch. Thanks!
[1] https://gerrit.ovirt.org/c/107847/
Regards, Liran.
participants (2)
-
Dominik Holler -
Liran Rotenberg