On Mon, Sep 5, 2016 at 9:04 AM, Yedidyah Bar David <didi@redhat.com> wrote:

On Sun, Sep 4, 2016 at 6:55 PM, Eyal Edri <eedri@redhat.com> wrote:

...

Any reason to keep running db upgrade jobs? [1] while we already have engine setup+upgrade jobs running per patch? [2]

IMO [2] is enough. In the not-very-common event that engine-setup breaks not due to dbscripts, we should fix it quickly anyway.

I agree, I'll send a patch to remove it from Jenkins, If at any point ovirt-engine maintainer will want it, it should be added as a script under check-patch.sh.

Downside of [1] is mainly extra maintenance on your (CI) side. If you keep it, you might soon need to patch it again to support [3].

I'm not too much concerned on the extra maintanance, it more dev side that is affected by it: 1. One more job to wait for when sending patches, increasing queue size 2. Another job which is separated from standard CI increase the chance of wrong review values from CI.

[3] https://bugzilla.redhat.com/show_bug.cgi?id=1366900

...

[1] http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-

db-from-master_el7_created/

...

[2] http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade- from-4.0_el7_created/

-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel

phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

-- Didi

-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)