[Engine-devel] Is there a preferred workflow when adding additional error messages to VDSM _and_ Engine?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello all, I'm currently working on a patch to correct the logic used by vdsm when reviewing the logical and physical block size of physical volumes [1]. Once/If this is approved I'd like to look into making the exceptions thrown from vdsm and the errors displayed within engine more descriptive. Before I start throwing patches into gerrit I was wondering *if* there is a preferred workflow when adding additional exceptions and error messages across both projects. For example, committing changes to vdsm before engine, engine before vdsm or both at the same time. I'm also wondering if there is a way to say that vdsm gerrit changeid x relies on engine gerrit changeid y etc? Thanks in advance, Lee - -- Lee Yarwood Software Maintenance Engineer Red Hat UK Ltd 200 Fowler Avenue IQ Farnborough, Farnborough, Hants GU14 7JP Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson(USA), Charlie Peters (USA) GPG fingerprint : A5D1 9385 88CB 7E5F BE64 6618 BCA6 6E33 F672 2D76 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPgFjGAAoJELymbjP2ci12MScIANRBXgWPSjeSZvSM2+bZmDrD FefJfxMcCQFtTqWYePXIxFgqeeRcFc57+6alExBRU2g9nKZJEIPn2vj640XSTGlt n5T4ItED1IVydzuEXFOAvgaTmZfKzTQkxQWp8QgL6pC7cYgnp2nL7gkbkedx1JyI gCgCGomrHeWP2++vUS8UjtCccZdTJiOiWqoH2sBCKgEVcmFMgvYREK6hTou4DHU4 DcpureWuLvM4HWUlyfl37eXQOmy66A7uHGp3xF5sykQZ9aozaiMFjSoCqQOEVqO6 jHRnsQB6FfF/xU+F/UQK5PKZOm7e+KvrMjhIDfR+/DX3t0rkrtc69gg2O6duy4o= =vdud -----END PGP SIGNATURE-----
----- Original Message -----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hello all,
I'm currently working on a patch to correct the logic used by vdsm when reviewing the logical and physical block size of physical volumes [1]. Once/If this is approved I'd like to look into making the exceptions thrown from vdsm and the errors displayed within engine more descriptive.
Before I start throwing patches into gerrit I was wondering *if* there is a preferred workflow when adding additional exceptions and error messages across both projects. For example, committing changes to vdsm before engine, engine before vdsm or both at the same time.
I'm also wondering if there is a way to say that vdsm gerrit changeid x relies on engine gerrit changeid y etc?
Adding in engine does not rely on vdsm actually throwing the exception. Adding in vdsm without corresponding code in engine would just mean that a generic message is displayed to user, so either way is ok as long as you make sure to submit both. There is no need for a dependency between gerrits (and I'm not sure how that would work either, but I'm not aware of any such mechanism at the moment).
Thanks in advance,
Lee - --
Lee Yarwood Software Maintenance Engineer Red Hat UK Ltd 200 Fowler Avenue IQ Farnborough, Farnborough, Hants GU14 7JP
Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson(USA), Charlie Peters (USA)
GPG fingerprint : A5D1 9385 88CB 7E5F BE64 6618 BCA6 6E33 F672 2D76 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPgFjGAAoJELymbjP2ci12MScIANRBXgWPSjeSZvSM2+bZmDrD FefJfxMcCQFtTqWYePXIxFgqeeRcFc57+6alExBRU2g9nKZJEIPn2vj640XSTGlt n5T4ItED1IVydzuEXFOAvgaTmZfKzTQkxQWp8QgL6pC7cYgnp2nL7gkbkedx1JyI gCgCGomrHeWP2++vUS8UjtCccZdTJiOiWqoH2sBCKgEVcmFMgvYREK6hTou4DHU4 DcpureWuLvM4HWUlyfl37eXQOmy66A7uHGp3xF5sykQZ9aozaiMFjSoCqQOEVqO6 jHRnsQB6FfF/xU+F/UQK5PKZOm7e+KvrMjhIDfR+/DX3t0rkrtc69gg2O6duy4o= =vdud -----END PGP SIGNATURE----- _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
On 07/04/12 18:10, Lee Yarwood wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hello all,
I'm currently working on a patch to correct the logic used by vdsm when reviewing the logical and physical block size of physical volumes [1]. Once/If this is approved I'd like to look into making the exceptions thrown from vdsm and the errors displayed within engine more descriptive.
Before I start throwing patches into gerrit I was wondering *if* there is a preferred workflow when adding additional exceptions and error messages across both projects. For example, committing changes to vdsm before engine, engine before vdsm or both at the same time.
Hi Lee, We had a Jenkins Job to give warning if there is a new error code in VDSM that is not covered in the backend. I see this job is disabled in ovirt Jenkins, http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Eyal, any specific reason this is disabled? Livnat
I'm also wondering if there is a way to say that vdsm gerrit changeid x relies on engine gerrit changeid y etc?
Thanks in advance,
Lee - --
Lee Yarwood Software Maintenance Engineer Red Hat UK Ltd 200 Fowler Avenue IQ Farnborough, Farnborough, Hants GU14 7JP
Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson(USA), Charlie Peters (USA)
GPG fingerprint : A5D1 9385 88CB 7E5F BE64 6618 BCA6 6E33 F672 2D76 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPgFjGAAoJELymbjP2ci12MScIANRBXgWPSjeSZvSM2+bZmDrD FefJfxMcCQFtTqWYePXIxFgqeeRcFc57+6alExBRU2g9nKZJEIPn2vj640XSTGlt n5T4ItED1IVydzuEXFOAvgaTmZfKzTQkxQWp8QgL6pC7cYgnp2nL7gkbkedx1JyI gCgCGomrHeWP2++vUS8UjtCccZdTJiOiWqoH2sBCKgEVcmFMgvYREK6hTou4DHU4 DcpureWuLvM4HWUlyfl37eXQOmy66A7uHGp3xF5sykQZ9aozaiMFjSoCqQOEVqO6 jHRnsQB6FfF/xU+F/UQK5PKZOm7e+KvrMjhIDfR+/DX3t0rkrtc69gg2O6duy4o= =vdud -----END PGP SIGNATURE----- _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 07/04/12 18:10, Lee Yarwood wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hello all,
I'm currently working on a patch to correct the logic used by vdsm when reviewing the logical and physical block size of physical volumes [1]. Once/If this is approved I'd like to look into making the exceptions thrown from vdsm and the errors displayed within engine more descriptive.
Before I start throwing patches into gerrit I was wondering *if* there is a preferred workflow when adding additional exceptions and error messages across both projects. For example, committing changes to vdsm before engine, engine before vdsm or both at the same time.
Hi, There is a wiki describing how to add errors & their descriptions to the engine: http://www.ovirt.org/wiki/Engine_Adding_Messages The relevant parts there are the VdsmErrors related (the other type of error is the one you get for illegal actions/states/etc before any call to VDSM is made). Hope you find it helpful. Regards, Mike
Hi Lee, We had a Jenkins Job to give warning if there is a new error code in VDSM that is not covered in the backend.
I see this job is disabled in ovirt Jenkins,
http://jenkins.ovirt.org/job/vdsm_verify_error_codes/
Eyal, any specific reason this is disabled?
Livnat
I'm also wondering if there is a way to say that vdsm gerrit changeid x relies on engine gerrit changeid y etc?
Thanks in advance,
Lee - --
Lee Yarwood Software Maintenance Engineer Red Hat UK Ltd 200 Fowler Avenue IQ Farnborough, Farnborough, Hants GU14 7JP
Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson(USA), Charlie Peters (USA)
GPG fingerprint : A5D1 9385 88CB 7E5F BE64 6618 BCA6 6E33 F672 2D76 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPgFjGAAoJELymbjP2ci12MScIANRBXgWPSjeSZvSM2+bZmDrD FefJfxMcCQFtTqWYePXIxFgqeeRcFc57+6alExBRU2g9nKZJEIPn2vj640XSTGlt n5T4ItED1IVydzuEXFOAvgaTmZfKzTQkxQWp8QgL6pC7cYgnp2nL7gkbkedx1JyI gCgCGomrHeWP2++vUS8UjtCccZdTJiOiWqoH2sBCKgEVcmFMgvYREK6hTou4DHU4 DcpureWuLvM4HWUlyfl37eXQOmy66A7uHGp3xF5sykQZ9aozaiMFjSoCqQOEVqO6 jHRnsQB6FfF/xU+F/UQK5PKZOm7e+KvrMjhIDfR+/DX3t0rkrtc69gg2O6duy4o= =vdud -----END PGP SIGNATURE-----
participants (4)
-
Ayal Baron -
Lee Yarwood -
Livnat Peer -
Mike Kolesnik