From: "Eyal Edri" <eedri(a)redhat.com&gt; To: "Laszlo Hornyak" <lhornyak(a)redhat.com&gt; Cc: "engine-devel" <engine-devel(a)ovirt.org&gt;, "infra" <infra(a)ovirt.org&gt; Sent: Monday, June 24, 2013 4:28:44 PM Subject: Re: [Engine-devel] checkstyle and tools project Can we add a gerrit hook to run checkstyle on the code? rather than waiting it to be merged and fail on jenkins? ----- Original Message ----- > From: "Laszlo Hornyak" <lhornyak(a)redhat.com&gt; > To: "engine-devel" <engine-devel(a)ovirt.org&gt; > Sent: Monday, June 24, 2013 11:15:38 AM > Subject: [Engine-devel] checkstyle and tools project > > Hi, > > Checkstyle is not executed on tools project. I have sent a patch to gerrit > to > fix this, could you guys review? > > http://gerrit.ovirt.org/15719 > > And there are some more cleanup patches for tools: > http://gerrit.ovirt.org/15720 > http://gerrit.ovirt.org/15721 > http://gerrit.ovirt.org/15722 > > > Thank you, > Laszlo > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >

From: "Itamar Heim" <iheim(a)redhat.com&gt; To: "Eyal Edri" <eedri(a)redhat.com&gt; Cc: "Laszlo Hornyak" <lhornyak(a)redhat.com&gt;, "engine-devel" <engine-devel(a)ovirt.org&gt;, "infra" <infra(a)ovirt.org&gt; Sent: Monday, June 24, 2013 9:57:02 PM Subject: Re: [Engine-devel] checkstyle and tools project On 06/24/2013 05:28 PM, Eyal Edri wrote: > Can we add a gerrit hook to run checkstyle on the code? i wouldn't want gerrit to build, but can we add this to jenkins job? > rather than waiting it to be merged and fail on jenkins? > > ----- Original Message ----- >> From: "Laszlo Hornyak" <lhornyak(a)redhat.com&gt; >> To: "engine-devel" <engine-devel(a)ovirt.org&gt; >> Sent: Monday, June 24, 2013 11:15:38 AM >> Subject: [Engine-devel] checkstyle and tools project >> >> Hi, >> >> Checkstyle is not executed on tools project. I have sent a patch to gerrit >> to >> fix this, could you guys review? >> >> http://gerrit.ovirt.org/15719 >> >> And there are some more cleanup patches for tools: >> http://gerrit.ovirt.org/15720 >> http://gerrit.ovirt.org/15721 >> http://gerrit.ovirt.org/15722 >> >> >> Thank you, >> Laszlo >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >