vdsm_master_unit-tests_merged is failing

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/1155/consoleFull is failing. Looks like python3-nose is not installed inside the mock chroot. *23:51:01* if [ -x "/usr/bin/python3" ]; then \*23:51:01* PYTHON_EXE="/usr/bin/python3" ../tests/run_tests_local.sh \*23:51:01* apiData.py cmdutilsTests.py cpuProfileTests.py ; \*23:51:01* fi*23:51:01* Traceback (most recent call last):*23:51:01* File "../tests/testrunner.py", line 42, in <module>*23:51:01* import testlib*23:51:01* File "/tmp/run/vdsm/tests/testlib.py", line 38, in <module>*23:51:01* from nose import config*23:51:01* ImportError: No module named 'nose'*23:51:01* Makefile:1162: recipe for target 'check-local' failed*23:51:01* make[3]: *** [check-local] Error 1*23:51:01* make[3]: Leaving directory '/tmp/run/vdsm/tests' Please fix ASAP -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

This looks like an ancient job, not YAMLized and not using any of our more recent tools (mock_runner.sh) for example. Wasn't this already superseded by the Standard-CI jobs? On 18 December 2015 at 09:25, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/1155/consoleFull is failing. Looks like python3-nose is not installed inside the mock chroot.
23:51:01 if [ -x "/usr/bin/python3" ]; then \ 23:51:01 PYTHON_EXE="/usr/bin/python3" ../tests/run_tests_local.sh \ 23:51:01 apiData.py cmdutilsTests.py cpuProfileTests.py ; \ 23:51:01 fi 23:51:01 Traceback (most recent call last): 23:51:01 File "../tests/testrunner.py", line 42, in <module> 23:51:01 import testlib 23:51:01 File "/tmp/run/vdsm/tests/testlib.py", line 38, in <module> 23:51:01 from nose import config 23:51:01 ImportError: No module named 'nose' 23:51:01 Makefile:1162: recipe for target 'check-local' failed 23:51:01 make[3]: *** [check-local] Error 1 23:51:01 make[3]: Leaving directory '/tmp/run/vdsm/tests'
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Barak Korren bkorren@redhat.com RHEV-CI Team

On Fri, Dec 18, 2015 at 10:26 AM, Barak Korren <bkorren@redhat.com> wrote:
This looks like an ancient job, not YAMLized and not using any of our more recent tools (mock_runner.sh) for example. Wasn't this already superseded by the Standard-CI jobs?
Not checked, but if it's obsoleted please drop it.
On 18 December 2015 at 09:25, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/1155/consoleFull
is failing. Looks like python3-nose is not installed inside the mock chroot.
23:51:01 if [ -x "/usr/bin/python3" ]; then \ 23:51:01 PYTHON_EXE="/usr/bin/python3" ../tests/run_tests_local.sh \ 23:51:01 apiData.py cmdutilsTests.py cpuProfileTests.py ; \ 23:51:01 fi 23:51:01 Traceback (most recent call last): 23:51:01 File "../tests/testrunner.py", line 42, in <module> 23:51:01 import testlib 23:51:01 File "/tmp/run/vdsm/tests/testlib.py", line 38, in <module> 23:51:01 from nose import config 23:51:01 ImportError: No module named 'nose' 23:51:01 Makefile:1162: recipe for target 'check-local' failed 23:51:01 make[3]: *** [check-local] Error 1 23:51:01 make[3]: Leaving directory '/tmp/run/vdsm/tests'
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Barak Korren bkorren@redhat.com RHEV-CI Team
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com

for some runs it is installed - we added it to the requirements for check-patch - https://gerrit.ovirt.org/#/c/48051/29/automation/check-patch.packages

On 19 December 2015 at 13:05, Yaniv Bronheim <ybronhei@redhat.com> wrote:
for some runs it is installed - we added it to the requirements for check-patch - https://gerrit.ovirt.org/#/c/48051/29/automation/check-patch.packages
check_patch runs are done by the "vdsm_master_check-patch" job, not this one. If this job's functionality is indeed already covered by check_patch, then I vote for it to be removed. VDSM maintainers, please confirm. -- Barak Korren bkorren@redhat.com RHEV-CI Team

On Sun, Dec 20, 2015 at 8:49 AM, Barak Korren <bkorren@redhat.com> wrote:
On 19 December 2015 at 13:05, Yaniv Bronheim <ybronhei@redhat.com> wrote:
for some runs it is installed - we added it to the requirements for check-patch - https://gerrit.ovirt.org/#/c/48051/29/automation/check-patch.packages
check_patch runs are done by the "vdsm_master_check-patch" job, not this one. If this job's functionality is indeed already covered by check_patch, then I vote for it to be removed. VDSM maintainers, please confirm.
I think check-patch.sh and check-merge are enough. I don't know what are the other jobs and what they are doing. Better remove them since nobody care about them anyway. If they do something valuable, they should be integrated with the standard automation scripts. Nir

On Sun, Dec 20, 2015 at 9:46 AM, Nir Soffer <nsoffer@redhat.com> wrote:
On Sun, Dec 20, 2015 at 8:49 AM, Barak Korren <bkorren@redhat.com> wrote:
On 19 December 2015 at 13:05, Yaniv Bronheim <ybronhei@redhat.com> wrote:
for some runs it is installed - we added it to the requirements for check-patch - https://gerrit.ovirt.org/#/c/48051/29/automation/check-patch.packages
check_patch runs are done by the "vdsm_master_check-patch" job, not this one. If this job's functionality is indeed already covered by check_patch, then I vote for it to be removed. VDSM maintainers, please confirm.
I think check-patch.sh and check-merge are enough.
I don't know what are the other jobs and what they are doing. Better remove them since nobody care about them anyway.
If they do something valuable, they should be integrated with the standard automation scripts.
ack
Nir
-- *Yaniv Bronhaim.*

On Mon, Dec 21, 2015 at 02:22:16PM +0200, Barak Korren wrote:
I don't know what are the other jobs and what they are doing. Better remove them since nobody care about them anyway.
ack
...
Nir
Yaniv Bronhaim.
Job disabled for now.
Please remove it - unless you have plans to revert the automation/*-based approach.

Please remove it - unless you have plans to revert the automation/*-based approach.
Since I don't know who wrote it, and what useful bits of code may be hiding inside, I rather not make any irreversible changes while almost everyone is on PTO. -- Barak Korren bkorren@redhat.com RHEV-CI Team

Nothing hiding there.. the automation CI method is the only thing we need to keep to avoid leaving garbage that nobody looks at On Tue, Dec 22, 2015 at 9:59 AM, Barak Korren <bkorren@redhat.com> wrote:
Please remove it - unless you have plans to revert the automation/*-based approach.
Since I don't know who wrote it, and what useful bits of code may be hiding inside, I rather not make any irreversible changes while almost everyone is on PTO.
-- Barak Korren bkorren@redhat.com RHEV-CI Team
-- *Yaniv Bronhaim.*

On Tue, Dec 22, 2015 at 09:59:20AM +0200, Barak Korren wrote:
Please remove it - unless you have plans to revert the automation/*-based approach.
Since I don't know who wrote it, and what useful bits of code may be hiding inside, I rather not make any irreversible changes while almost everyone is on PTO.
The job cherry-picks the now-abandoned https://gerrit.ovirt.org/#/c/34888/ and runs https://gerrit.ovirt.org/#/c/34888/15/jobs/confs/shell-scripts/vdsm_unit-tes... This code is now placed under vdsm's automation dir, and there's no reason to look back.

On Tue, Dec 22, 2015 at 12:04 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Tue, Dec 22, 2015 at 09:59:20AM +0200, Barak Korren wrote:
Please remove it - unless you have plans to revert the automation/*-based approach.
Since I don't know who wrote it, and what useful bits of code may be hiding inside, I rather not make any irreversible changes while almost everyone is on PTO.
The job cherry-picks the now-abandoned https://gerrit.ovirt.org/#/c/34888/ and runs
https://gerrit.ovirt.org/#/c/34888/15/jobs/confs/shell-scripts/vdsm_unit-tes...
This code is now placed under vdsm's automation dir, and there's no reason to look back.
ok, so have the job been deleted?
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
participants (5)
-
Barak Korren
-
Dan Kenigsberg
-
Nir Soffer
-
Sandro Bonazzola
-
Yaniv Bronheim