Thank you. I found the issue. Will push a fix now. -- SHIRLY RADCO BI SeNIOR SOFTWARE ENGINEER Red Hat Israel <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> On Tue, Feb 20, 2018 at 12:00 PM, Dafna Ron <dron(a)redhat.com&gt; wrote: > Hi, > > We have a failed test for project ovirt-engine-metrics. > It seems that CQ is reporting that the root cause of the failure was a > patch from 6 days ago. > > Shirly, can you please check the changes? > > *Link and headline of suspected patches: change reported as failed: * > > replace vdsm stats with collectd virt plugin - > https://gerrit.ovirt.org/#/c/87310/ > > > *change reported as root cause: * > ansible: add role to copy required files - https://gerrit.ovirt.org/#/c/8 > 7430/ > > > TASK [oVirt.ovirt-initial-validations/validate-config-yml : Validate viaq_metrics_store parameter] *** > fatal: [localhost]: FAILED! => {"msg": "The conditional check 'viaq_metrics_store != true' failed. The error was: error while evaluating conditional (viaq_metrics_store != true): 'viaq_metrics_store' is undefined\n\nThe error appears to have been in '/usr/share/ansible/roles/oVirt.metrics/roles/oVirt.ovirt-initial-validations/validate-config-yml/tasks/main.yml': line 49, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: \"Validate viaq_metrics_store parameter\"\n ^ here\n"} > > NO MORE HOSTS LEFT ************************************************************* > > PLAY RECAP ********************************************************************* > localhost : ok=4 changed=0 unreachable=0 failed=1 > > > lago.utils: ERROR: Error while running thread > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/lago/utils.py", line 58, in _ret_via_queue > queue.put({'return': func()}) > File "/home/jenkins/workspace/ovirt-4.2_change-queue-tester/ovirt-system-tests/basic-suite-4.2/test-scenarios/003_00_metrics_bootstrap.py", line 54, in configure_metrics > ' Exit code is %s' % result.code > File "/usr/lib/python2.7/site-packages/nose/tools/trivial.py", line 29, in eq_ > raise AssertionError(msg or "%r != %r" % (a, b)) > AssertionError: Configuring ovirt machines for metrics failed. Exit code is 2 > lago.ssh: DEBUG: Command 59b597f6 on lago-basic-suite-4-2-engine returned with 0 > lago.ssh: DEBUG: Command 59b597f6 on lago-basic-suite-4-2-engine output: > This command will collect system configuration and diagnostic > information from this system. > The generated archive may contain data considered sensitive and its > content should be reviewed by the originating organization before > being passed to any third party. > No changes will be made to system configuration. > INFO: /dev/shm/log does not exist. It will be created. > DEBUG: API Vendor(None) API Version(4.2.0) > WARNING: This ovirt-log-collector call will collect logs from all available hosts. This may take long time, depending on the size of your deployment > INFO: Gathering oVirt Engine information... > DEBUG: loading config '/usr/share/ovirt-engine/services/ovirt-engine/ovirt-engine.conf' > DEBUG: calling(['sosreport', '--list-plugins']) > DEBUG: returncode(0) > DEBUG: STDOUT( > sosreport (version 3.4) > > > > > > > > > > *Link to > Job:http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/ > <http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/>Link to > all > logs:http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/artif... > <http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/artifacts&... > error snippet from the log: <error></error>* >

2018-02-20 13:21 GMT+01:00 Dafna Ron <dron(a)redhat.com&gt;: > Thanks Shirly. > can you please send me a link to the fix? > I think Gal already fixed no? https://gerrit.ovirt.org/#/c/87842/ > > Thanks again! > Dafna > > > On Tue, Feb 20, 2018 at 12:18 PM, Shirly Radco <sradco(a)redhat.com&gt; wrote: > >> Thank you. >> I found the issue. >> Will push a fix now. >> >> -- >> >> SHIRLY RADCO >> >> BI SeNIOR SOFTWARE ENGINEER >> >> Red Hat Israel <https://www.redhat.com/> >> <https://red.ht/sig> >> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> >> >> On Tue, Feb 20, 2018 at 12:00 PM, Dafna Ron <dron(a)redhat.com&gt; wrote: >> >>> Hi, >>> >>> We have a failed test for project ovirt-engine-metrics. >>> It seems that CQ is reporting that the root cause of the failure was a >>> patch from 6 days ago. >>> >>> Shirly, can you please check the changes? >>> >>> *Link and headline of suspected patches: change reported as failed: * >>> >>> replace vdsm stats with collectd virt plugin - >>> https://gerrit.ovirt.org/#/c/87310/ >>> >>> >>> *change reported as root cause: * >>> ansible: add role to copy required files - >>> https://gerrit.ovirt.org/#/c/87430/ >>> >>> >>> TASK [oVirt.ovirt-initial-validations/validate-config-yml : Validate viaq_metrics_store parameter] *** >>> fatal: [localhost]: FAILED! => {"msg": "The conditional check 'viaq_metrics_store != true' failed. The error was: error while evaluating conditional (viaq_metrics_store != true): 'viaq_metrics_store' is undefined\n\nThe error appears to have been in '/usr/share/ansible/roles/oVirt.metrics/roles/oVirt.ovirt-initial-validations/validate-config-yml/tasks/main.yml': line 49, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: \"Validate viaq_metrics_store parameter\"\n ^ here\n"} >>> >>> NO MORE HOSTS LEFT ************************************************************* >>> >>> PLAY RECAP ********************************************************************* >>> localhost : ok=4 changed=0 unreachable=0 failed=1 >>> >>> >>> lago.utils: ERROR: Error while running thread >>> Traceback (most recent call last): >>> File "/usr/lib/python2.7/site-packages/lago/utils.py", line 58, in _ret_via_queue >>> queue.put({'return': func()}) >>> File "/home/jenkins/workspace/ovirt-4.2_change-queue-tester/ovirt-system-tests/basic-suite-4.2/test-scenarios/003_00_metrics_bootstrap.py", line 54, in configure_metrics >>> ' Exit code is %s' % result.code >>> File "/usr/lib/python2.7/site-packages/nose/tools/trivial.py", line 29, in eq_ >>> raise AssertionError(msg or "%r != %r" % (a, b)) >>> AssertionError: Configuring ovirt machines for metrics failed. Exit code is 2 >>> lago.ssh: DEBUG: Command 59b597f6 on lago-basic-suite-4-2-engine returned with 0 >>> lago.ssh: DEBUG: Command 59b597f6 on lago-basic-suite-4-2-engine output: >>> This command will collect system configuration and diagnostic >>> information from this system. >>> The generated archive may contain data considered sensitive and its >>> content should be reviewed by the originating organization before >>> being passed to any third party. >>> No changes will be made to system configuration. >>> INFO: /dev/shm/log does not exist. It will be created. >>> DEBUG: API Vendor(None) API Version(4.2.0) >>> WARNING: This ovirt-log-collector call will collect logs from all available hosts. This may take long time, depending on the size of your deployment >>> INFO: Gathering oVirt Engine information... >>> DEBUG: loading config '/usr/share/ovirt-engine/services/ovirt-engine/ovirt-engine.conf' >>> DEBUG: calling(['sosreport', '--list-plugins']) >>> DEBUG: returncode(0) >>> DEBUG: STDOUT( >>> sosreport (version 3.4) >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> *Link to >>> Job:http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/ >>> <http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/>Link to >>> all >>> logs:http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/artif... >>> <http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/864/artifacts&... >>> error snippet from the log: <error></error>* >>> >> >> > > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > > -- SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>