Hi Martin, I noticed that you are working on some patches to refactor the VM devices and deprecate self.conf['devices']. I am a big fan of this because my Live Merge code is far more complex than it should be since some information lives in self.conf['devices'] and some lives in self.devices. Are you planning on changing the recovery code save/recovery of vm.conf to work with the new device container you are creating? It would be nice to get my code working entirely independent of self.conf['devices'] if possible. Also, when are you aiming to have this work completed? Live Merge is needed for 3.5. Will this work be ready before then? Thanks! -- Adam Litke
----- Original Message -----
From: "Adam Litke" <alitke@redhat.com> To: "Martin Polednik" <mpoledni@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 20, 2014 6:20:33 PM Subject: [ovirt-devel] [vdsm] Unifying VM device representations
Hi Martin,
I noticed that you are working on some patches to refactor the VM devices and deprecate self.conf['devices']. I am a big fan of this because my Live Merge code is far more complex than it should be since some information lives in self.conf['devices'] and some lives in self.devices.
I'm very interested in those patches as well and I'd like to join the effort, but see below.
Are you planning on changing the recovery code save/recovery of vm.conf to work with the new device container you are creating?
This will be indeed a nice thing to have.
It would be nice to get my code working entirely independent of self.conf['devices'] if possible. Also, when are you aiming to have this work completed? Live Merge is needed for 3.5. Will this work be ready before then?
Unfortunately I don't think the VmContainer patch can make it for 3.5 since the merge window is closing quite fast. I think we have realistically something like 2-3 days left to have it merged and AFAIK there is still quite some work to do to achieve that, including a not-trivial rebase. I think we can have it merged for 3.6. Bests, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani
----- Original Message -----
From: "Francesco Romani" <fromani@redhat.com> To: "Adam Litke" <alitke@redhat.com> Cc: "Martin Polednik" <mpoledni@redhat.com>, devel@ovirt.org Sent: Friday, May 23, 2014 9:26:49 AM Subject: Re: [ovirt-devel] [vdsm] Unifying VM device representations
----- Original Message -----
From: "Adam Litke" <alitke@redhat.com> To: "Martin Polednik" <mpoledni@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 20, 2014 6:20:33 PM Subject: [ovirt-devel] [vdsm] Unifying VM device representations
Hi Martin,
I noticed that you are working on some patches to refactor the VM devices and deprecate self.conf['devices']. I am a big fan of this because my Live Merge code is far more complex than it should be since some information lives in self.conf['devices'] and some lives in self.devices.
I'm very interested in those patches as well and I'd like to join the effort, but see below.
I'll get in touch with you as soon as I'm in the office (exam period slowly coming to an end).
Are you planning on changing the recovery code save/recovery of vm.conf to work with the new device container you are creating?
This will be indeed a nice thing to have.
The new device handling is already built with recovery compatibility in mind and the format should not change (at least not in near future, migration to JSON-like format is planned but definitely not close to being ready)
It would be nice to get my code working entirely independent of self.conf['devices'] if possible. Also, when are you aiming to have this work completed? Live Merge is needed for 3.5. Will this work be ready before then?
Unfortunately I don't think the VmContainer patch can make it for 3.5 since the merge window is closing quite fast. I think we have realistically something like 2-3 days left to have it merged and AFAIK there is still quite some work to do to achieve that, including a not-trivial rebase.
Currently it seems that VmContainer will not be needed at all and would only add more code bloat.
I think we can have it merged for 3.6.
Bests,
-- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani
participants (3)
-
Adam Litke -
Francesco Romani -
Martin Polednik