8:57 p.m.
Hi,
I'm struggling with a check-patch failing. This is the error (I think):
[7;33m************* Module vdsm.tool.update_volume [0m
[1;31mE [0m: 87,16: [1;31mInstance of '_Client' has no 'Host' member [0m
(
[1;31mno-member [0m)
[1;31mE [0m:101,23: [1;31mInstance of '_Client' has no 'StoragePool'
member
[0m ( [1;31mno-member [0m)
The way I understand it, the error above from [1] means that the check
patch fails because the cli object does not contain Host or StoragePool.
However, from reading the code it seems the Host and StoragePool members
are created at runtime by parsing the API schema. So static checking for
[2] and [3] fails.
I see some other tools doing similar things (i,e. dump_volume_chains), but
I can't find anything specific done to prevent it. Or am I missing
something?
Any idea on how to solve this?
[1]
https://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/25017/ar...
[2]
https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume....
[3]
https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume....
Thanks!
Germano
9:53 p.m.
On Wed, Sep 19, 2018 at 1:57 PM Germano Veit Michel <germano(a)redhat.com>
wrote:
Hi,
I'm struggling with a check-patch failing. This is the error (I think):
[7;33m************* Module vdsm.tool.update_volume [0m
[1;31mE [0m: 87,16: [1;31mInstance of '_Client' has no 'Host' member [0m
(
[1;31mno-member [0m)
[1;31mE [0m:101,23: [1;31mInstance of '_Client' has no 'StoragePool'
member [0m ( [1;31mno-member [0m)
The way I understand it, the error above from [1] means that the check
patch fails because the cli object does not contain Host or StoragePool.
However, from reading the code it seems the Host and StoragePool members
are created at runtime by parsing the API schema. So static checking for
[2] and [3] fails.
I see some other tools doing similar things (i,e. dump_volume_chains), but
I can't find anything specific done to prevent it. Or am I missing
something?
Any idea on how to solve this?
[1]
https://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/25017/ar...
[2]
https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume....
[3]
https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume....
Thanks!
Germano
Update
I added "pylint: disable=no-member" as I found on some other vdsm files and
now those member errors are gone. But check_patch is apparently still
returning 2, can't figure out why.
Any ideas?
https://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/25088/
https://gerrit.ovirt.org/#/c/94105/
2041
days inactive
2047
days old
1 comments
1 participants
participants (Last-Modified: Sat, 27 Apr 2024 07:50:24 GMT
Expires: Sat, 27 Apr 2024 19:50:24 GMT
Content-Type: application/javascript
Cache-Control: max-age=43200
{"evolution": [{"date": "2024-03-27", "count": 0}, {"date": "2024-03-28", "count": 0}, {"date": "2024-03-29", "count": 0}, {"date": "2024-03-30", "count": 0}, {"date": "2024-03-31", "count": 0}, {"date": "2024-04-01", "count": 0}, {"date": "2024-04-02", "count": 0}, {"date": "2024-04-03", "count": 0}, {"date": "2024-04-04", "count": 0}, {"date": "2024-04-05", "count": 0}, {"date": "2024-04-06", "count": 0}, {"date": "2024-04-07", "count": 0}, {"date": "2024-04-08", "count": 0}, {"date": "2024-04-09", "count": 0}, {"date": "2024-04-10", "count": 0}, {"date": "2024-04-11", "count": 0}, {"date": "2024-04-12", "count": 0}, {"date": "2024-04-13", "count": 0}, {"date": "2024-04-14", "count": 0}, {"date": "2024-04-15", "count": 0}, {"date": "2024-04-16", "count": 0}, {"date": "2024-04-17", "count": 0}, {"date": "2024-04-18", "count": 0}, {"date": "2024-04-19", "count": 0}, {"date": "2024-04-20", "count": 0}, {"date": "2024-04-21", "count": 0}, {"date": "2024-04-22", "count": 0}, {"date": "2024-04-23", "count": 0}, {"date": "2024-04-24", "count": 0}, {"date": "2024-04-25", "count": 0}, {"date": "2024-04-26", "count": 0}, {"date": "2024-04-27", "count": 0}]})
-
Germano Veit Michel