2:30 a.m.
Vojtech[/others] - what do you think about Gilad's comment below?
would it be possible / more correct to activate column resizing within the
base grid class itself by default (or something similar), rather than enable
it separately for each grid?
[@Gilad - keep in mind that IIUC - each column in each grid still needs to have
its width explicitly set]
----
Thanks,
Einav
----- Original Message -----
From: gchaplik(a)redhat.com
To: "Daniel Erez" <derez(a)redhat.com>
Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>, "Alona Kaplan" <alkaplan(a)redhat.com>,
"Tal Nisan" <tnisan(a)redhat.com>
Sent: Thursday, April 25, 2013 3:23:56 AM
Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab: sub-tabs
resizable columns
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
......................................................................
Patch Set 4:
why we need to invoke getTable().enableColumnResizing() on each sub-tab?
don't we want all grid subtabs to have column resizing?
--
To view, visit http://gerrit.ovirt.org/14105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
2:41 a.m.
imo the preliminary patches (separated or not) should be only adding the missing columns
widths.
once done, a single patch should activate column re-sizing in a single shot -i.e removing
the method (enableColumn...) and enabling the feature.
btw, what is the time in Boston?
Thanks,
Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen(a)redhat.com>
To: "Vojtech Szocs" <vszocs(a)redhat.com>
Cc: "Daniel Erez" <derez(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>, "Tal Nisan" <tnisan(a)redhat.com>,
gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 10:30:48 AM
Subject: enable column resizing on all sub-tabs?
Vojtech[/others] - what do you think about Gilad's comment below?
would it be possible / more correct to activate column resizing within the
base grid class itself by default (or something similar), rather than enable
it separately for each grid?
[@Gilad - keep in mind that IIUC - each column in each grid still needs to
have
its width explicitly set]
----
Thanks,
Einav
----- Original Message -----
> From: gchaplik(a)redhat.com
> To: "Daniel Erez" <derez(a)redhat.com>
> Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>,
> "Alona Kaplan" <alkaplan(a)redhat.com>,
> "Tal Nisan" <tnisan(a)redhat.com>
> Sent: Thursday, April 25, 2013 3:23:56 AM
> Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab:
> sub-tabs resizable columns
>
> Gilad Chaplik has posted comments on this change.
>
> Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
> ......................................................................
>
>
> Patch Set 4:
>
> why we need to invoke getTable().enableColumnResizing() on each sub-tab?
> don't we want all grid subtabs to have column resizing?
>
> --
> To view, visit http://gerrit.ovirt.org/14105
> To unsubscribe, visit http://gerrit.ovirt.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> Gerrit-PatchSet: 4
> Gerrit-Project: ovirt-engine
> Gerrit-Branch: master
> Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
>
5:22 a.m.
----- Original Message -----
From: "Einav Cohen" <ecohen(a)redhat.com>
To: "Vojtech Szocs" <vszocs(a)redhat.com>
Cc: "Daniel Erez" <derez(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>, "Tal Nisan" <tnisan(a)redhat.com>,
gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 10:30:48 AM
Subject: enable column resizing on all sub-tabs?
Vojtech[/others] - what do you think about Gilad's comment below?
would it be possible / more correct to activate column resizing within the
base grid class itself by default (or something similar), rather than enable
it separately for each grid?
[@Gilad - keep in mind that IIUC - each column in each grid still needs to
have
its width explicitly set]
We probably should just replace enableColumnResizing() with disbaleColumnResizing()
in favor of the problematic sub-tabs. But I think it can wait till we're done
adding the support (i.e. set width explicitly for each column).
What do you think?
----
Thanks,
Einav
----- Original Message -----
> From: gchaplik(a)redhat.com
> To: "Daniel Erez" <derez(a)redhat.com>
> Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>,
> "Alona Kaplan" <alkaplan(a)redhat.com>,
> "Tal Nisan" <tnisan(a)redhat.com>
> Sent: Thursday, April 25, 2013 3:23:56 AM
> Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab:
> sub-tabs resizable columns
>
> Gilad Chaplik has posted comments on this change.
>
> Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
> ......................................................................
>
>
> Patch Set 4:
>
> why we need to invoke getTable().enableColumnResizing() on each sub-tab?
> don't we want all grid subtabs to have column resizing?
>
> --
> To view, visit http://gerrit.ovirt.org/14105
> To unsubscribe, visit http://gerrit.ovirt.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> Gerrit-PatchSet: 4
> Gerrit-Project: ovirt-engine
> Gerrit-Branch: master
> Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
>
5:33 a.m.
----- Original Message -----
From: "Daniel Erez" <derez(a)redhat.com>
Sent: Thursday, April 25, 2013 6:22:02 AM
----- Original Message -----
> From: "Einav Cohen" <ecohen(a)redhat.com>
> To: "Vojtech Szocs" <vszocs(a)redhat.com>
> Cc: "Daniel Erez" <derez(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>,
> "Tal Nisan" <tnisan(a)redhat.com>,
> gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
> Sent: Thursday, April 25, 2013 10:30:48 AM
> Subject: enable column resizing on all sub-tabs?
>
> Vojtech[/others] - what do you think about Gilad's comment below?
> would it be possible / more correct to activate column resizing within the
> base grid class itself by default (or something similar), rather than
> enable
> it separately for each grid?
>
> [@Gilad - keep in mind that IIUC - each column in each grid still needs to
> have
> its width explicitly set]
We probably should just replace enableColumnResizing() with
disbaleColumnResizing()
in favor of the problematic sub-tabs. But I think it can wait till we're done
adding the support (i.e. set width explicitly for each column).
What do you think?
indeed - no matter how we decide to exactly approach this: if the general approach is to
enable
column resizing by default in the base widget class, we need to take care of preparing the
widget
instances first, i.e., set their columns' widths.
I suggest that we will proceed with the patches that were already written as they are, and
also write the upcoming patches in the same manner (i.e. explicitly
"enableColumnResizing()"
each one of the widget instances + set the widths), verify that everything is
working/looking OK,
and only then - create the patch that replaces the "enableColumnResizing()"
method with the
"disbaleColumnResizing()" method (and removes all calls to
"enableColumnResizing()"), which will
actually be only a code-change/refactoring patch (i.e. will have no affect on the
application behavior).
acks/nacks/comments?
>
> ----
> Thanks,
> Einav
>
> ----- Original Message -----
> > From: gchaplik(a)redhat.com
> > To: "Daniel Erez" <derez(a)redhat.com>
> > Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech
Szocs"
> > <vszocs(a)redhat.com>,
> > "Alona Kaplan" <alkaplan(a)redhat.com>,
> > "Tal Nisan" <tnisan(a)redhat.com>
> > Sent: Thursday, April 25, 2013 3:23:56 AM
> > Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab:
> > sub-tabs resizable columns
> >
> > Gilad Chaplik has posted comments on this change.
> >
> > Change subject: webadmin: DataCenters main-tab: sub-tabs resizable
> > columns
> > ......................................................................
> >
> >
> > Patch Set 4:
> >
> > why we need to invoke getTable().enableColumnResizing() on each sub-tab?
> > don't we want all grid subtabs to have column resizing?
> >
> > --
> > To view, visit http://gerrit.ovirt.org/14105
> > To unsubscribe, visit http://gerrit.ovirt.org/settings
> >
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> > Gerrit-PatchSet: 4
> > Gerrit-Project: ovirt-engine
> > Gerrit-Branch: master
> > Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
> > Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
> > Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> > Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> > Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
> > Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
> > Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
> >
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
9:47 a.m.
Hi guys,
the reason why we need to call enableColumnResizing() explicitly is because currently,
action tables which don't use enableColumnResizing() yet have at least one column
*without* explicit width in PX units. After calling enableColumnResizing(), you *must*
specify (absolute) column width in PX units when calling addColumn(). If you don't do
this, column resize behavior will be messed up -- all columns simply need to have
(absolute) explicit widths in order for resize behavior to work correctly.
So we cannot simply call enableColumnResizing() on higher level (i.e.
AbstractSubTabTableView), just because specific implementations are not always calling
addColumn() using explicit width..
imo the preliminary patches (separated or not) should be only adding
the missing columns widths.
once done, a single patch should activate column re-sizing in a single shot -i.e removing
the method (enableColumn...) and enabling the feature.
I'm not against this, but it requires us to fix all (specific) tables before we enable
resizing on higher level (i.e. AbstractSubTabTableView).
Vojtech
----- Original Message -----
From: "Gilad Chaplik" <gchaplik(a)redhat.com>
To: "Einav Cohen" <ecohen(a)redhat.com>
Cc: "Vojtech Szocs" <vszocs(a)redhat.com>, "Daniel Erez"
<derez(a)redhat.com>, "Alona Kaplan" <alkaplan(a)redhat.com>, "Tal
Nisan" <tnisan(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 9:41:53 AM
Subject: Re: enable column resizing on all sub-tabs?
imo the preliminary patches (separated or not) should be only adding the missing columns
widths.
once done, a single patch should activate column re-sizing in a single shot -i.e removing
the method (enableColumn...) and enabling the feature.
btw, what is the time in Boston?
Thanks,
Gilad.
----- Original Message -----
From: "Einav Cohen" <ecohen(a)redhat.com>
To: "Vojtech Szocs" <vszocs(a)redhat.com>
Cc: "Daniel Erez" <derez(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>, "Tal Nisan" <tnisan(a)redhat.com>,
gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 10:30:48 AM
Subject: enable column resizing on all sub-tabs?
Vojtech[/others] - what do you think about Gilad's comment below?
would it be possible / more correct to activate column resizing within the
base grid class itself by default (or something similar), rather than enable
it separately for each grid?
[@Gilad - keep in mind that IIUC - each column in each grid still needs to
have
its width explicitly set]
----
Thanks,
Einav
----- Original Message -----
> From: gchaplik(a)redhat.com
> To: "Daniel Erez" <derez(a)redhat.com>
> Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>,
> "Alona Kaplan" <alkaplan(a)redhat.com>,
> "Tal Nisan" <tnisan(a)redhat.com>
> Sent: Thursday, April 25, 2013 3:23:56 AM
> Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab:
> sub-tabs resizable columns
>
> Gilad Chaplik has posted comments on this change.
>
> Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
> ......................................................................
>
>
> Patch Set 4:
>
> why we need to invoke getTable().enableColumnResizing() on each sub-tab?
> don't we want all grid subtabs to have column resizing?
>
> --
> To view, visit http://gerrit.ovirt.org/14105
> To unsubscribe, visit http://gerrit.ovirt.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> Gerrit-PatchSet: 4
> Gerrit-Project: ovirt-engine
> Gerrit-Branch: master
> Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
>
9:50 a.m.
Hi Daniel,
We probably should just replace enableColumnResizing() with
disbaleColumnResizing()
in favor of the problematic sub-tabs. But I think it can wait till we're done
adding the support (i.e. set width explicitly for each column).
I agree, it makes sense, but I'd prefer to do this kind of API/behavior inversion
later on (but I'm all for it).
Vojtech
----- Original Message -----
From: "Daniel Erez" <derez(a)redhat.com>
To: "Einav Cohen" <ecohen(a)redhat.com>
Cc: "Vojtech Szocs" <vszocs(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>, "Tal Nisan" <tnisan(a)redhat.com>,
gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 12:22:02 PM
Subject: Re: enable column resizing on all sub-tabs?
----- Original Message -----
From: "Einav Cohen" <ecohen(a)redhat.com>
To: "Vojtech Szocs" <vszocs(a)redhat.com>
Cc: "Daniel Erez" <derez(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>, "Tal Nisan" <tnisan(a)redhat.com>,
gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 10:30:48 AM
Subject: enable column resizing on all sub-tabs?
Vojtech[/others] - what do you think about Gilad's comment below?
would it be possible / more correct to activate column resizing within the
base grid class itself by default (or something similar), rather than enable
it separately for each grid?
[@Gilad - keep in mind that IIUC - each column in each grid still needs to
have
its width explicitly set]
We probably should just replace enableColumnResizing() with disbaleColumnResizing()
in favor of the problematic sub-tabs. But I think it can wait till we're done
adding the support (i.e. set width explicitly for each column).
What do you think?
----
Thanks,
Einav
----- Original Message -----
> From: gchaplik(a)redhat.com
> To: "Daniel Erez" <derez(a)redhat.com>
> Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>,
> "Alona Kaplan" <alkaplan(a)redhat.com>,
> "Tal Nisan" <tnisan(a)redhat.com>
> Sent: Thursday, April 25, 2013 3:23:56 AM
> Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab:
> sub-tabs resizable columns
>
> Gilad Chaplik has posted comments on this change.
>
> Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
> ......................................................................
>
>
> Patch Set 4:
>
> why we need to invoke getTable().enableColumnResizing() on each sub-tab?
> don't we want all grid subtabs to have column resizing?
>
> --
> To view, visit http://gerrit.ovirt.org/14105
> To unsubscribe, visit http://gerrit.ovirt.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> Gerrit-PatchSet: 4
> Gerrit-Project: ovirt-engine
> Gerrit-Branch: master
> Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
>
11:35 a.m.
Hi,
I suggest that we will proceed with the patches that were already
written as they are, and
also write the upcoming patches in the same manner (i.e. explicitly
"enableColumnResizing()"
each one of the widget instances + set the widths), verify that everything is
working/looking OK,
and only then - create the patch that replaces the "enableColumnResizing()"
method with the
"disbaleColumnResizing()" method (and removes all calls to
"enableColumnResizing()"), which will
actually be only a code-change/refactoring patch (i.e. will have no affect on the
application behavior).
ack
[I'd suggest to verify that addColumn() is always called with explicit width first,
before changing enable -> disable API]
Vojtech
----- Original Message -----
From: "Einav Cohen" <ecohen(a)redhat.com>
To: "Daniel Erez" <derez(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>, "Gilad Chaplik" <gchaplik(a)redhat.com>
Cc: "engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 12:33:06 PM
Subject: Re: [Engine-devel] enable column resizing on all sub-tabs?
----- Original Message -----
From: "Daniel Erez" <derez(a)redhat.com>
Sent: Thursday, April 25, 2013 6:22:02 AM
----- Original Message -----
> From: "Einav Cohen" <ecohen(a)redhat.com>
> To: "Vojtech Szocs" <vszocs(a)redhat.com>
> Cc: "Daniel Erez" <derez(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>,
> "Tal Nisan" <tnisan(a)redhat.com>,
> gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
> Sent: Thursday, April 25, 2013 10:30:48 AM
> Subject: enable column resizing on all sub-tabs?
>
> Vojtech[/others] - what do you think about Gilad's comment below?
> would it be possible / more correct to activate column resizing within the
> base grid class itself by default (or something similar), rather than
> enable
> it separately for each grid?
>
> [@Gilad - keep in mind that IIUC - each column in each grid still needs to
> have
> its width explicitly set]
We probably should just replace enableColumnResizing() with
disbaleColumnResizing()
in favor of the problematic sub-tabs. But I think it can wait till we're done
adding the support (i.e. set width explicitly for each column).
What do you think?
indeed - no matter how we decide to exactly approach this: if the general approach is to
enable
column resizing by default in the base widget class, we need to take care of preparing the
widget
instances first, i.e., set their columns' widths.
I suggest that we will proceed with the patches that were already written as they are, and
also write the upcoming patches in the same manner (i.e. explicitly
"enableColumnResizing()"
each one of the widget instances + set the widths), verify that everything is
working/looking OK,
and only then - create the patch that replaces the "enableColumnResizing()"
method with the
"disbaleColumnResizing()" method (and removes all calls to
"enableColumnResizing()"), which will
actually be only a code-change/refactoring patch (i.e. will have no affect on the
application behavior).
acks/nacks/comments?
>
> ----
> Thanks,
> Einav
>
> ----- Original Message -----
> > From: gchaplik(a)redhat.com
> > To: "Daniel Erez" <derez(a)redhat.com>
> > Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech
Szocs"
> > <vszocs(a)redhat.com>,
> > "Alona Kaplan" <alkaplan(a)redhat.com>,
> > "Tal Nisan" <tnisan(a)redhat.com>
> > Sent: Thursday, April 25, 2013 3:23:56 AM
> > Subject: Change in ovirt-engine[master]: webadmin: DataCenters main-tab:
> > sub-tabs resizable columns
> >
> > Gilad Chaplik has posted comments on this change.
> >
> > Change subject: webadmin: DataCenters main-tab: sub-tabs resizable
> > columns
> > ......................................................................
> >
> >
> > Patch Set 4:
> >
> > why we need to invoke getTable().enableColumnResizing() on each sub-tab?
> > don't we want all grid subtabs to have column resizing?
> >
> > --
> > To view, visit http://gerrit.ovirt.org/14105
> > To unsubscribe, visit http://gerrit.ovirt.org/settings
> >
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> > Gerrit-PatchSet: 4
> > Gerrit-Project: ovirt-engine
> > Gerrit-Branch: master
> > Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
> > Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
> > Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> > Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> > Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
> > Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
> > Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
> >
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
11:48 a.m.
----- Original Message -----
From: "Vojtech Szocs" <vszocs(a)redhat.com>
Sent: Thursday, April 25, 2013 12:35:39 PM
Hi,
> I suggest that we will proceed with the patches that were already written
> as they are, and
> also write the upcoming patches in the same manner (i.e. explicitly
> "enableColumnResizing()"
> each one of the widget instances + set the widths), verify that everything
> is working/looking OK,
> and only then - create the patch that replaces the
"enableColumnResizing()"
> method with the
> "disbaleColumnResizing()" method (and removes all calls to
> "enableColumnResizing()"), which will
> actually be only a code-change/refactoring patch (i.e. will have no affect
> on the application behavior).
ack
thanks, Vojtech.
[I'd suggest to verify that addColumn() is always called with explicit width
first, before changing enable -> disable API]
ack :)
Vojtech
----- Original Message -----
From: "Einav Cohen" <ecohen(a)redhat.com>
To: "Daniel Erez" <derez(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>,
"Gilad Chaplik" <gchaplik(a)redhat.com>
Cc: "engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, April 25, 2013 12:33:06 PM
Subject: Re: [Engine-devel] enable column resizing on all sub-tabs?
> ----- Original Message -----
> From: "Daniel Erez" <derez(a)redhat.com>
> Sent: Thursday, April 25, 2013 6:22:02 AM
>
>
> ----- Original Message -----
> > From: "Einav Cohen" <ecohen(a)redhat.com>
> > To: "Vojtech Szocs" <vszocs(a)redhat.com>
> > Cc: "Daniel Erez" <derez(a)redhat.com>, "Alona Kaplan"
> > <alkaplan(a)redhat.com>,
> > "Tal Nisan" <tnisan(a)redhat.com>,
> > gchaplik(a)redhat.com, "engine-devel" <engine-devel(a)ovirt.org>
> > Sent: Thursday, April 25, 2013 10:30:48 AM
> > Subject: enable column resizing on all sub-tabs?
> >
> > Vojtech[/others] - what do you think about Gilad's comment below?
> > would it be possible / more correct to activate column resizing within
> > the
> > base grid class itself by default (or something similar), rather than
> > enable
> > it separately for each grid?
> >
> > [@Gilad - keep in mind that IIUC - each column in each grid still needs
> > to
> > have
> > its width explicitly set]
>
> We probably should just replace enableColumnResizing() with
> disbaleColumnResizing()
> in favor of the problematic sub-tabs. But I think it can wait till we're
> done
> adding the support (i.e. set width explicitly for each column).
>
> What do you think?
indeed - no matter how we decide to exactly approach this: if the general
approach is to enable
column resizing by default in the base widget class, we need to take care of
preparing the widget
instances first, i.e., set their columns' widths.
I suggest that we will proceed with the patches that were already written as
they are, and
also write the upcoming patches in the same manner (i.e. explicitly
"enableColumnResizing()"
each one of the widget instances + set the widths), verify that everything is
working/looking OK,
and only then - create the patch that replaces the "enableColumnResizing()"
method with the
"disbaleColumnResizing()" method (and removes all calls to
"enableColumnResizing()"), which will
actually be only a code-change/refactoring patch (i.e. will have no affect on
the application behavior).
acks/nacks/comments?
>
> >
> > ----
> > Thanks,
> > Einav
> >
> > ----- Original Message -----
> > > From: gchaplik(a)redhat.com
> > > To: "Daniel Erez" <derez(a)redhat.com>
> > > Cc: "Einav Cohen" <ecohen(a)redhat.com>, "Vojtech
Szocs"
> > > <vszocs(a)redhat.com>,
> > > "Alona Kaplan" <alkaplan(a)redhat.com>,
> > > "Tal Nisan" <tnisan(a)redhat.com>
> > > Sent: Thursday, April 25, 2013 3:23:56 AM
> > > Subject: Change in ovirt-engine[master]: webadmin: DataCenters
> > > main-tab:
> > > sub-tabs resizable columns
> > >
> > > Gilad Chaplik has posted comments on this change.
> > >
> > > Change subject: webadmin: DataCenters main-tab: sub-tabs resizable
> > > columns
> > > ......................................................................
> > >
> > >
> > > Patch Set 4:
> > >
> > > why we need to invoke getTable().enableColumnResizing() on each
> > > sub-tab?
> > > don't we want all grid subtabs to have column resizing?
> > >
> > > --
> > > To view, visit http://gerrit.ovirt.org/14105
> > > To unsubscribe, visit http://gerrit.ovirt.org/settings
> > >
> > > Gerrit-MessageType: comment
> > > Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
> > > Gerrit-PatchSet: 4
> > > Gerrit-Project: ovirt-engine
> > > Gerrit-Branch: master
> > > Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
> > > Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
> > > Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> > > Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> > > Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
> > > Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
> > > Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
> > >
> >
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
>
>
4041
days inactive
4041
days old
7 comments
4 participants
participants (4)
-
Daniel Erez -
Einav Cohen -
Gilad Chaplik -
Vojtech Szocs