1:51 p.m.
Hi,
Can we agree to use the same .java file space standards in our gwt ui.xml files?
Specifically: spaces only, no tabs, 4 spaces indent, no trailing whitespace.
I have my Eclipse set to fix these things (with the anyedit plugin), and the ui.xml files
always have tabs and trailing space in them.
If we agree, I volunteer to fix them all and post a patch. I think we can also set gerrit
to point these out.
Thanks,
Greg
Greg Sheremeta
Red Hat, Inc.
Sr. Software Engineer, RHEV
Cell: 919-807-1086
gshereme(a)redhat.com
1:56 p.m.
Sounds good to me, I think the only reason they're not formatted is that
the Java formatter by default ignores them.
On 29/05/14 14:51, Greg Sheremeta wrote:
Hi,
Can we agree to use the same .java file space standards in our gwt ui.xml files?
Specifically: spaces only, no tabs, 4 spaces indent, no trailing whitespace.
I have my Eclipse set to fix these things (with the anyedit plugin), and the ui.xml files
always have tabs and trailing space in them.
If we agree, I volunteer to fix them all and post a patch. I think we can also set gerrit
to point these out.
Thanks,
Greg
Greg Sheremeta
Red Hat, Inc.
Sr. Software Engineer, RHEV
Cell: 919-807-1086
gshereme(a)redhat.com
2:28 p.m.
----- Original Message -----
From: "Lior Vernia" <lvernia(a)redhat.com>
To: "Greg Sheremeta" <gshereme(a)redhat.com>
Cc: devel(a)ovirt.org, "Alexander Wels" <awels(a)redhat.com>, "Vojtech
Szocs" <vszocs(a)redhat.com>, "Einav Cohen"
<ecohen(a)redhat.com>, "Alona Kaplan" <alkaplan(a)redhat.com>,
"Gilad Chaplik" <gchaplik(a)redhat.com>, "Tomas Jelinek"
<tjelinek(a)redhat.com>
Sent: Thursday, May 29, 2014 2:56:29 PM
Subject: Re: fixing whitespace in ui.xml files
Sounds good to me, I think the only reason they're not formatted is that
the Java formatter by default ignores them.
On 29/05/14 14:51, Greg Sheremeta wrote:
> Hi,
>
> Can we agree to use the same .java file space standards in our gwt ui.xml
> files? Specifically: spaces only, no tabs, 4 spaces indent, no trailing
> whitespace.
[adding Juan]
I agree on same formatting as api.xsd.
>
> I have my Eclipse set to fix these things (with the anyedit plugin), and
> the ui.xml files always have tabs and trailing space in them.
>
> If we agree, I volunteer to fix them all and post a patch. I think we can
> also set gerrit to point these out.
>
> Thanks,
> Greg
>
> Greg Sheremeta
> Red Hat, Inc.
> Sr. Software Engineer, RHEV
> Cell: 919-807-1086
> gshereme(a)redhat.com
>
12:13 p.m.
----- Original Message -----
From: "Gilad Chaplik" <gchaplik(a)redhat.com>
To: "Lior Vernia" <lvernia(a)redhat.com>
Cc: "Greg Sheremeta" <gshereme(a)redhat.com>, devel(a)ovirt.org,
"Alexander Wels" <awels(a)redhat.com>, "Vojtech Szocs"
<vszocs(a)redhat.com>, "Einav Cohen" <ecohen(a)redhat.com>, "Alona
Kaplan" <alkaplan(a)redhat.com>, "Tomas Jelinek"
<tjelinek(a)redhat.com>, "Juan Hernandez" <jhernand(a)redhat.com>
Sent: Thursday, May 29, 2014 2:28:59 PM
Subject: Re: fixing whitespace in ui.xml files
----- Original Message -----
> From: "Lior Vernia" <lvernia(a)redhat.com>
> To: "Greg Sheremeta" <gshereme(a)redhat.com>
> Cc: devel(a)ovirt.org, "Alexander Wels" <awels(a)redhat.com>,
"Vojtech Szocs"
> <vszocs(a)redhat.com>, "Einav Cohen"
> <ecohen(a)redhat.com>, "Alona Kaplan" <alkaplan(a)redhat.com>,
"Gilad Chaplik"
> <gchaplik(a)redhat.com>, "Tomas Jelinek"
> <tjelinek(a)redhat.com>
> Sent: Thursday, May 29, 2014 2:56:29 PM
> Subject: Re: fixing whitespace in ui.xml files
>
> Sounds good to me, I think the only reason they're not formatted is that
> the Java formatter by default ignores them.
>
> On 29/05/14 14:51, Greg Sheremeta wrote:
> > Hi,
> >
> > Can we agree to use the same .java file space standards in our gwt ui.xml
> > files? Specifically: spaces only, no tabs, 4 spaces indent, no trailing
> > whitespace.
[adding Juan]
I agree on same formatting as api.xsd.
Hm, api.xsd seems to use 2 spaces per "tab", without a space before
"/>" part.
While none of these are that big of a deal, we should stay consistent with
accompanying (Java) code, i.e. have single whitespace policy for both source
and XML files. (The space before "/>" part is a courtesy to older XML/XHTML
parsers and is not really important IMHO.)
> >
> > I have my Eclipse set to fix these things (with the anyedit plugin), and
> > the ui.xml files always have tabs and trailing space in them.
> >
> > If we agree, I volunteer to fix them all and post a patch. I think we can
> > also set gerrit to point these out.
> >
> > Thanks,
> > Greg
> >
> > Greg Sheremeta
> > Red Hat, Inc.
> > Sr. Software Engineer, RHEV
> > Cell: 919-807-1086
> > gshereme(a)redhat.com
> >
>
1:35 p.m.
I agree, 4 spaces for consistency.
Anyone else have an opinion?
----- Original Message -----
From: "Vojtech Szocs" <vszocs(a)redhat.com>
To: "Gilad Chaplik" <gchaplik(a)redhat.com>
Cc: "Lior Vernia" <lvernia(a)redhat.com>, "Greg Sheremeta"
<gshereme(a)redhat.com>, devel(a)ovirt.org, "Alexander Wels"
<awels(a)redhat.com>, "Einav Cohen" <ecohen(a)redhat.com>, "Alona
Kaplan" <alkaplan(a)redhat.com>, "Tomas Jelinek"
<tjelinek(a)redhat.com>, "Juan Hernandez" <jhernand(a)redhat.com>
Sent: Monday, June 2, 2014 6:13:10 AM
Subject: Re: fixing whitespace in ui.xml files
----- Original Message -----
> From: "Gilad Chaplik" <gchaplik(a)redhat.com>
> To: "Lior Vernia" <lvernia(a)redhat.com>
> Cc: "Greg Sheremeta" <gshereme(a)redhat.com>, devel(a)ovirt.org,
"Alexander
> Wels" <awels(a)redhat.com>, "Vojtech Szocs"
> <vszocs(a)redhat.com>, "Einav Cohen" <ecohen(a)redhat.com>,
"Alona Kaplan"
> <alkaplan(a)redhat.com>, "Tomas Jelinek"
> <tjelinek(a)redhat.com>, "Juan Hernandez" <jhernand(a)redhat.com>
> Sent: Thursday, May 29, 2014 2:28:59 PM
> Subject: Re: fixing whitespace in ui.xml files
>
> ----- Original Message -----
> > From: "Lior Vernia" <lvernia(a)redhat.com>
> > To: "Greg Sheremeta" <gshereme(a)redhat.com>
> > Cc: devel(a)ovirt.org, "Alexander Wels" <awels(a)redhat.com>,
"Vojtech Szocs"
> > <vszocs(a)redhat.com>, "Einav Cohen"
> > <ecohen(a)redhat.com>, "Alona Kaplan"
<alkaplan(a)redhat.com>, "Gilad
> > Chaplik"
> > <gchaplik(a)redhat.com>, "Tomas Jelinek"
> > <tjelinek(a)redhat.com>
> > Sent: Thursday, May 29, 2014 2:56:29 PM
> > Subject: Re: fixing whitespace in ui.xml files
> >
> > Sounds good to me, I think the only reason they're not formatted is that
> > the Java formatter by default ignores them.
> >
> > On 29/05/14 14:51, Greg Sheremeta wrote:
> > > Hi,
> > >
> > > Can we agree to use the same .java file space standards in our gwt
> > > ui.xml
> > > files? Specifically: spaces only, no tabs, 4 spaces indent, no trailing
> > > whitespace.
>
> [adding Juan]
> I agree on same formatting as api.xsd.
Hm, api.xsd seems to use 2 spaces per "tab", without a space before
"/>"
part.
While none of these are that big of a deal, we should stay consistent with
accompanying (Java) code, i.e. have single whitespace policy for both source
and XML files. (The space before "/>" part is a courtesy to older XML/XHTML
parsers and is not really important IMHO.)
>
> > >
> > > I have my Eclipse set to fix these things (with the anyedit plugin),
> > > and
> > > the ui.xml files always have tabs and trailing space in them.
> > >
> > > If we agree, I volunteer to fix them all and post a patch. I think we
> > > can
> > > also set gerrit to point these out.
> > >
> > > Thanks,
> > > Greg
> > >
> > > Greg Sheremeta
> > > Red Hat, Inc.
> > > Sr. Software Engineer, RHEV
> > > Cell: 919-807-1086
> > > gshereme(a)redhat.com
> > >
> >
>
3619
days inactive
3623
days old
4 comments
4 participants
participants (4)
-
Gilad Chaplik -
Greg Sheremeta -
Lior Vernia -
Vojtech Szocs