why we need "postZero" and discard the block device in deleteVolumes(class Image) in vdsm?
------=_Part_53573_1186128017.1514946785593 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 aGVsbG8sIGV2ZXJ5b25lIQogICAgd2hlbiBJbWFnZS5kZWxldGUgY2FsbGVkIGluIHZkc20sIHdl IG5lZWQgYSBwYXJhbSAiZGlzY2FydCIgaW4gWzFdLCB0aGVuIEkgZmluZCBpcyBqdXN0IHN1cHBv cnRlZCBieSBibG9jayBhbmQgIi9zYmluL2Jsa2Rpc2NhcmQiIGNhbGxlZCBpbiBsYXN0IGluIFsy XSwgYnV0IApJIGRvbid0IGtub3cgd2h5IHdlIG5lZWQgdG8gZGlzY2FyZCB0aGUgYmxvY2sgZGV2 aWNlcyByYXRoZXIgdGhhbiBkaXJlY3RseSB1c2UgInJtIC1mIiA/IGFuZCB3aGF0IHRpbWUgd2Ug bmVlZCBzZXQgImRpc2NhcnQgPSBUUlVFIiA/CiAgICBBbmQgd2hhdCB0aW1lIHdlIHNob3VsZCBz ZXQgInBvc3RaZXJvPVRSVUUiID8KCgoKClsxXSAgaHR0cHM6Ly9naXRodWIuY29tL29WaXJ0L3Zk c20vYmxvYi8yYjk4ZGFmZmIyYzJkZWMxYmJiZDM0MjdkM2QzMjg2MWQ3N2YwMWE3L2xpYi92ZHNt L0FQSS5weSNMODQxClsyXWh0dHBzOi8vZ2l0aHViLmNvbS9vVmlydC92ZHNtL2Jsb2IvMmI5OGRh ZmZiMmMyZGVjMWJiYmQzNDI3ZDNkMzI4NjFkNzdmMDFhNy9saWIvdmRzbS9zdG9yYWdlL2Jsb2Nr U0QucHkjTDcxNA== ------=_Part_53573_1186128017.1514946785593 Content-Type: text/html; charset=GBK Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6MS43O2NvbG9yOiMwMDAwMDA7Zm9udC1zaXplOjE0cHg7 Zm9udC1mYW1pbHk6QXJpYWwiPjxkaXY+aGVsbG8sIGV2ZXJ5b25lITwvZGl2PjxkaXY+Jm5ic3A7 ICZuYnNwOyB3aGVuIEltYWdlLmRlbGV0ZSBjYWxsZWQgaW4gdmRzbSwgd2UgbmVlZCBhIHBhcmFt ICJkaXNjYXJ0IiBpbiBbMV0sIHRoZW4gSSBmaW5kIGlzIGp1c3Qgc3VwcG9ydGVkIGJ5IGJsb2Nr IGFuZCZuYnNwOzxzcGFuIHN0eWxlPSJjb2xvcjogcmdiKDAsIDEyOCwgMCk7IGZvbnQtd2VpZ2h0 OiBib2xkOyBmb250LWZhbWlseTogJnF1b3Q7RGVqYVZ1IFNhbnMgTW9ubyZxdW90OzsgZm9udC1z aXplOiAxMS4zcHQ7IHdoaXRlLXNwYWNlOiBwcmUtd3JhcDsiPiIvc2Jpbi9ibGtkaXNjYXJkIiA8 L3NwYW4+Y2FsbGVkIGluIGxhc3QgaW4gWzJdLCBidXQmbmJzcDs8L2Rpdj48ZGl2PkkgZG9uJ3Qg a25vdyB3aHkgd2UgbmVlZCB0byBkaXNjYXJkIHRoZSBibG9jayBkZXZpY2VzIHJhdGhlciB0aGFu IGRpcmVjdGx5IHVzZSAiPHNwYW4gc3R5bGU9ImNvbG9yOiByZ2IoMCwgMTI4LCAwKTsgZm9udC13 ZWlnaHQ6IGJvbGQ7IGZvbnQtZmFtaWx5OiAmcXVvdDtEZWphVnUgU2FucyBNb25vJnF1b3Q7OyBm b250LXNpemU6IDExLjNwdDsgd2hpdGUtc3BhY2U6IHByZS13cmFwOyIgY2xhc3M9IiI+cm0gLWY8 L3NwYW4+IiA/IGFuZCB3aGF0IHRpbWUgd2UgbmVlZCBzZXQgIjxzcGFuIHN0eWxlPSJjb2xvcjog cmdiKDAsIDEyOCwgMCk7IGZvbnQtd2VpZ2h0OiBib2xkOyBmb250LWZhbWlseTogJnF1b3Q7RGVq YVZ1IFNhbnMgTW9ubyZxdW90OzsgZm9udC1zaXplOiAxMS4zcHQ7IHdoaXRlLXNwYWNlOiBwcmUt d3JhcDsiIGNsYXNzPSIiPmRpc2NhcnQgPSBUUlVFIiA8L3NwYW4+PzwvZGl2PjxkaXY+Jm5ic3A7 ICZuYnNwOyBBbmQgd2hhdCB0aW1lIHdlIHNob3VsZCBzZXQgIjxzcGFuIHN0eWxlPSJjb2xvcjog cmdiKDAsIDEyOCwgMCk7IGZvbnQtd2VpZ2h0OiBib2xkOyBmb250LWZhbWlseTogJnF1b3Q7RGVq YVZ1IFNhbnMgTW9ubyZxdW90OzsgZm9udC1zaXplOiAxMS4zcHQ7IHdoaXRlLXNwYWNlOiBwcmUt d3JhcDsiIGNsYXNzPSIiPnBvc3RaZXJvPVRSVUU8L3NwYW4+IiA/PC9kaXY+PGRpdj48YnI+PC9k aXY+PGRpdj48YnI+PC9kaXY+PGRpdj5bMV0mbmJzcDsmbmJzcDs8c3BhbiBzdHlsZT0iY29sb3I6 IHJnYigzNiwgNDEsIDQ2KTsgZm9udC1mYW1pbHk6IFNGTW9uby1SZWd1bGFyLCBDb25zb2xhcywg JnF1b3Q7TGliZXJhdGlvbiBNb25vJnF1b3Q7LCBNZW5sbywgQ291cmllciwgbW9ub3NwYWNlOyBm b250LXNpemU6IDEycHg7IHdoaXRlLXNwYWNlOiBwcmUtd3JhcDsiPjxhIGhyZWY9Imh0dHBzOi8v Z2l0aHViLmNvbS9vVmlydC92ZHNtL2Jsb2IvMmI5OGRhZmZiMmMyZGVjMWJiYmQzNDI3ZDNkMzI4 NjFkNzdmMDFhNy9saWIvdmRzbS9BUEkucHkjTDg0MSIgX3NyYz0iaHR0cHM6Ly9naXRodWIuY29t L29WaXJ0L3Zkc20vYmxvYi8yYjk4ZGFmZmIyYzJkZWMxYmJiZDM0MjdkM2QzMjg2MWQ3N2YwMWE3 L2xpYi92ZHNtL0FQSS5weSNMODQxIj5odHRwczovL2dpdGh1Yi5jb20vb1ZpcnQvdmRzbS9ibG9i LzJiOThkYWZmYjJjMmRlYzFiYmJkMzQyN2QzZDMyODYxZDc3ZjAxYTcvbGliL3Zkc20vQVBJLnB5 I0w4NDE8L2E+PC9zcGFuPjwvZGl2PjxkaXY+PHNwYW4gc3R5bGU9ImNvbG9yOiByZ2IoMzYsIDQx LCA0Nik7IGZvbnQtZmFtaWx5OiBTRk1vbm8tUmVndWxhciwgQ29uc29sYXMsICZxdW90O0xpYmVy YXRpb24gTW9ubyZxdW90OywgTWVubG8sIENvdXJpZXIsIG1vbm9zcGFjZTsgZm9udC1zaXplOiAx MnB4OyB3aGl0ZS1zcGFjZTogcHJlLXdyYXA7Ij5bMl08L3NwYW4+PHNwYW4gc3R5bGU9ImNvbG9y OiByZ2IoMzYsIDQxLCA0Nik7IGZvbnQtZmFtaWx5OiBTRk1vbm8tUmVndWxhciwgQ29uc29sYXMs ICZxdW90O0xpYmVyYXRpb24gTW9ubyZxdW90OywgTWVubG8sIENvdXJpZXIsIG1vbm9zcGFjZTsg Zm9udC1zaXplOiAxMnB4OyB3aGl0ZS1zcGFjZTogcHJlLXdyYXA7Ij5odHRwczovL2dpdGh1Yi5j b20vb1ZpcnQvdmRzbS9ibG9iLzJiOThkYWZmYjJjMmRlYzFiYmJkMzQyN2QzZDMyODYxZDc3ZjAx YTcvbGliL3Zkc20vc3RvcmFnZS9ibG9ja1NELnB5I0w3MTQ8L3NwYW4+PHNwYW4gc3R5bGU9ImNv bG9yOiByZ2IoMzYsIDQxLCA0Nik7IGZvbnQtZmFtaWx5OiBTRk1vbm8tUmVndWxhciwgQ29uc29s YXMsICZxdW90O0xpYmVyYXRpb24gTW9ubyZxdW90OywgTWVubG8sIENvdXJpZXIsIG1vbm9zcGFj ZTsgZm9udC1zaXplOiAxMnB4OyB3aGl0ZS1zcGFjZTogcHJlLXdyYXA7Ij4gPC9zcGFuPjwvZGl2 PjwvZGl2Pjxicj48YnI+PHNwYW4gdGl0bGU9Im5ldGVhc2Vmb290ZXIiPjxwPiZuYnNwOzwvcD48 L3NwYW4+ ------=_Part_53573_1186128017.1514946785593--
Hi, The fields "discard" and "postZero" are sent to vdsm by the engine in order to implement the "Discard After Delete" and "Wipe After Delete" features. When a storage domain is marked with Discard After Delete, a disk that is removed from that storage domain is discarded before it's removed. This way, the disk's blocks are freed from the storage array and can be used by other LUNs in the array. For more information about Discard After Delete, please refer to the feature page [1]. When a disk (on a block storage domain) is marked with Wipe After Delete, it is wiped right before it's removed. The idea behind this is that when the disk contains sensitive data, the administrator doesn't want it to be read after it is removed. However, when we don't wipe a disk's blocks before it is removed, the data can be read by a new VM user with a disk that is created on some/all the blocks of the old disk. For more information about Wipe After Delete, please refer to the administrator guide [2]. If you have any further questions, please don't hesitate to ask. Regards, Idan [1] https://www.ovirt.org/develop/release-management/features/storage/discard-af... [2] https://www.ovirt.org/documentation/admin-guide/chap-Virtual_Machine_Disks/#... On Wed, Jan 3, 2018 at 4:33 AM, pengyixiang <yxpengi386@163.com> wrote:
hello, everyone! when Image.delete called in vdsm, we need a param "discart" in [1], then I find is just supported by block and "/sbin/blkdiscard" called in last in [2], but I don't know why we need to discard the block devices rather than directly use "rm -f" ? and what time we need set "discart = TRUE" ? And what time we should set "postZero=TRUE" ?
[1] https://github.com/oVirt/vdsm/blob/2b98daffb2c2dec1bbbd3427d3d328 61d77f01a7/lib/vdsm/API.py#L841 [2]https://github.com/oVirt/vdsm/blob/2b98daffb2c2dec1bbbd3427d3d328 61d77f01a7/lib/vdsm/storage/blockSD.py#L714
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
------=_Part_147535_614774795.1514979706393 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 SGVsbG8hCiAgIFRoYWtzIGZvciB5b3VyIHJlcGx5ICwgIEkgcmVhZCB0aGVzZSBndWlkZXMgYW5k IG1ha2UgY2xlYXIgc29tZSwgYnV0IHRoZXJlJ3Mgb25lIHBvaW50IEkgZG9uJ3QgdW5kZXJzdGFu ZC4gSW4gWzFdLCBwdXJnZUltYWdlIGNhbGwgImJsa2Rpc2NhcmQiIAphbmQgImRlbGV0ZVZvbHVt ZXMiLCBJIHNlZSAiVGhpcyBmZWF0dXJlIGlzIGFib3V0IGZyZWVpbmcgKGRpc2NhcmRpbmcpIHRo ZSB3aG9sZSBkaXNrIHNwYWNlIHJpZ2h0IGJlZm9yZSByZW1vdmluZyBpdC4iIGluIFsyXSwgSSBk b24ndCBrbm93IAp3aGF0IHRoZSBkaWZmZXJlbnQgYmV0d2VlbiBmcmVlaW5nIGFuZCByZW1vdmlu Zz8gTWF5IGNhbGwgZGVsZXRlVm9sdW1lcy0+bHZtLnJlbW92ZUxWcyB0aGF0cyBlbm91Z2ggdG8g ZGVsZXRlIHRoZSBsdnMgb2Ygdm0gYW5kIG90aGVycyB2bSAKY2FuIHJldXNlIGl0J3Mgc3BhY2U/ CgoKCgpbMV0gaHR0cHM6Ly9naXRodWIuY29tL29WaXJ0L3Zkc20vYmxvYi8yYjk4ZGFmZmIyYzJk ZWMxYmJiZDM0MjdkM2QzMjg2MWQ3N2YwMWE3L2xpYi92ZHNtL3N0b3JhZ2UvYmxvY2tTRC5weSNM NzA1ClsyXSBodHRwczovL3d3dy5vdmlydC5vcmcvZGV2ZWxvcC9yZWxlYXNlLW1hbmFnZW1lbnQv ZmVhdHVyZXMvc3RvcmFnZS9kaXNjYXJkLWFmdGVyLWRlbGV0ZS8jd2hhdC1jb3VsZC1iZS1pbXBy b3ZlZAoKCgoKCkF0IDIwMTgtMDEtMDMgMTQ6Mjk6MjksICJJZGFuIFNoYWJ5IiA8aXNoYWJ5QHJl ZGhhdC5jb20+IHdyb3RlOgoKSGksCgoKVGhlIGZpZWxkcyAiZGlzY2FyZCIgYW5kICJwb3N0WmVy byIgYXJlIHNlbnQgdG8gdmRzbSBieSB0aGUgZW5naW5lIGluIG9yZGVyIHRvIGltcGxlbWVudCB0 aGUgIkRpc2NhcmQgQWZ0ZXIgRGVsZXRlIiBhbmQgIldpcGUgQWZ0ZXIgRGVsZXRlIiBmZWF0dXJl cy4KCgpXaGVuIGEgc3RvcmFnZSBkb21haW4gaXMgbWFya2VkIHdpdGggRGlzY2FyZCBBZnRlciBE ZWxldGUsIGEgZGlzayB0aGF0IGlzIHJlbW92ZWQgZnJvbSB0aGF0IHN0b3JhZ2UgZG9tYWluIGlz IGRpc2NhcmRlZCBiZWZvcmUgaXQncyByZW1vdmVkLiBUaGlzIHdheSwgdGhlIGRpc2sncyBibG9j a3MgYXJlIGZyZWVkIGZyb20gdGhlIHN0b3JhZ2UgYXJyYXkgYW5kIGNhbiBiZSB1c2VkIGJ5IG90 aGVyIExVTnMgaW4gdGhlIGFycmF5LgpGb3IgbW9yZSBpbmZvcm1hdGlvbiBhYm91dCBEaXNjYXJk IEFmdGVyIERlbGV0ZSwgcGxlYXNlIHJlZmVyIHRvIHRoZSBmZWF0dXJlIHBhZ2UgWzFdLgoKCldo ZW4gYSBkaXNrIChvbiBhIGJsb2NrIHN0b3JhZ2UgZG9tYWluKSBpcyBtYXJrZWQgd2l0aCBXaXBl IEFmdGVyIERlbGV0ZSwgaXQgaXMgd2lwZWQgcmlnaHQgYmVmb3JlIGl0J3MgcmVtb3ZlZC4gVGhl IGlkZWEgYmVoaW5kIHRoaXMgaXMgdGhhdCB3aGVuIHRoZSBkaXNrIGNvbnRhaW5zIHNlbnNpdGl2 ZSBkYXRhLCB0aGUgYWRtaW5pc3RyYXRvciBkb2Vzbid0IHdhbnQgaXQgdG8gYmUgcmVhZCBhZnRl ciBpdCBpcyByZW1vdmVkLiBIb3dldmVyLCB3aGVuIHdlIGRvbid0IHdpcGUgYSBkaXNrJ3MgYmxv Y2tzIGJlZm9yZSBpdCBpcyByZW1vdmVkLCB0aGUgZGF0YSBjYW4gYmUgcmVhZCBieSBhIG5ldyBW TSB1c2VyIHdpdGggYSBkaXNrIHRoYXQgaXMgY3JlYXRlZCBvbiBzb21lL2FsbCB0aGUgYmxvY2tz IG9mIHRoZSBvbGQgZGlzay4KRm9yIG1vcmUgaW5mb3JtYXRpb24gYWJvdXQgV2lwZSBBZnRlciBE ZWxldGUsIHBsZWFzZSByZWZlciB0byB0aGUgYWRtaW5pc3RyYXRvciBndWlkZSBbMl0uCgoKSWYg eW91IGhhdmUgYW55IGZ1cnRoZXIgcXVlc3Rpb25zLCBwbGVhc2UgZG9uJ3QgaGVzaXRhdGUgdG8g YXNrLgoKCgpSZWdhcmRzLAoKSWRhbgoKClsxXSBodHRwczovL3d3dy5vdmlydC5vcmcvZGV2ZWxv cC9yZWxlYXNlLW1hbmFnZW1lbnQvZmVhdHVyZXMvc3RvcmFnZS9kaXNjYXJkLWFmdGVyLWRlbGV0 ZS8KWzJdIGh0dHBzOi8vd3d3Lm92aXJ0Lm9yZy9kb2N1bWVudGF0aW9uL2FkbWluLWd1aWRlL2No YXAtVmlydHVhbF9NYWNoaW5lX0Rpc2tzLyNzZXR0aW5ncy10by13aXBlLXZpcnR1YWwtZGlza3Mt YWZ0ZXItZGVsZXRpb24KCgoKT24gV2VkLCBKYW4gMywgMjAxOCBhdCA0OjMzIEFNLCBwZW5neWl4 aWFuZyA8eXhwZW5naTM4NkAxNjMuY29tPiB3cm90ZToKCmhlbGxvLCBldmVyeW9uZSEKICAgIHdo ZW4gSW1hZ2UuZGVsZXRlIGNhbGxlZCBpbiB2ZHNtLCB3ZSBuZWVkIGEgcGFyYW0gImRpc2NhcnQi IGluIFsxXSwgdGhlbiBJIGZpbmQgaXMganVzdCBzdXBwb3J0ZWQgYnkgYmxvY2sgYW5kICIvc2Jp bi9ibGtkaXNjYXJkIiBjYWxsZWQgaW4gbGFzdCBpbiBbMl0sIGJ1dCAKSSBkb24ndCBrbm93IHdo eSB3ZSBuZWVkIHRvIGRpc2NhcmQgdGhlIGJsb2NrIGRldmljZXMgcmF0aGVyIHRoYW4gZGlyZWN0 bHkgdXNlICJybSAtZiIgPyBhbmQgd2hhdCB0aW1lIHdlIG5lZWQgc2V0ICJkaXNjYXJ0ID0gVFJV RSIgPwogICAgQW5kIHdoYXQgdGltZSB3ZSBzaG91bGQgc2V0ICJwb3N0WmVybz1UUlVFIiA/CgoK CgpbMV0gIGh0dHBzOi8vZ2l0aHViLmNvbS9vVmlydC92ZHNtL2Jsb2IvMmI5OGRhZmZiMmMyZGVj MWJiYmQzNDI3ZDNkMzI4NjFkNzdmMDFhNy9saWIvdmRzbS9BUEkucHkjTDg0MQpbMl1odHRwczov L2dpdGh1Yi5jb20vb1ZpcnQvdmRzbS9ibG9iLzJiOThkYWZmYjJjMmRlYzFiYmJkMzQyN2QzZDMy ODYxZDc3ZjAxYTcvbGliL3Zkc20vc3RvcmFnZS9ibG9ja1NELnB5I0w3MTQKCgoKCiAKCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpEZXZlbCBtYWlsaW5n IGxpc3QKRGV2ZWxAb3ZpcnQub3JnCmh0dHA6Ly9saXN0cy5vdmlydC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kZXZlbAoKCg== ------=_Part_147535_614774795.1514979706393 Content-Type: text/html; charset=GBK Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6MS43O2NvbG9yOiMwMDAwMDA7Zm9udC1zaXplOjE0cHg7 Zm9udC1mYW1pbHk6QXJpYWwiPjxkaXY+SGVsbG8hPC9kaXY+PGRpdj4mbmJzcDsgJm5ic3A7VGhh a3MgZm9yIHlvdXIgcmVwbHkgLCZuYnNwOyBJIHJlYWQgdGhlc2UgZ3VpZGVzIGFuZCBtYWtlIGNs ZWFyIHNvbWUsIGJ1dCB0aGVyZSdzIG9uZSBwb2ludCBJIGRvbid0IHVuZGVyc3RhbmQuIEluIFsx XSwgcHVyZ2VJbWFnZSBjYWxsICJibGtkaXNjYXJkIiZuYnNwOzwvZGl2PjxkaXY+YW5kICJkZWxl dGVWb2x1bWVzIiwgSSBzZWUgIjxzcGFuIHN0eWxlPSJjb2xvcjogcmdiKDUxLCA1MSwgNTEpOyBm b250LWZhbWlseTogJnF1b3Q7U291cmNlIFNhbnMgUHJvJnF1b3Q7LCAmcXVvdDtPcGVuIFNhbnMm cXVvdDssICZxdW90O0hlbHZldGljYSBOZXVlJnF1b3Q7LCBIZWx2ZXRpY2EsIEFyaWFsLCBzYW5z LXNlcmlmOyBmb250LXNpemU6IDE2cHg7Ij5UaGlzIGZlYXR1cmUgaXMgYWJvdXQgZnJlZWluZyAo ZGlzY2FyZGluZykgdGhlIHdob2xlIGRpc2sgc3BhY2UgcmlnaHQgYmVmb3JlIHJlbW92aW5nIGl0 Ljwvc3Bhbj4iIGluIFsyXSwgSSBkb24ndCBrbm93Jm5ic3A7PC9kaXY+PGRpdj53aGF0IHRoZSBk aWZmZXJlbnQgYmV0d2VlbiBmcmVlaW5nIGFuZCByZW1vdmluZz8gTWF5IGNhbGwgZGVsZXRlVm9s dW1lcy0mZ3Q7PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OiAmcXVvdDtEZWphVnUgU2FucyBNb25v JnF1b3Q7OyBmb250LXNpemU6IDExLjNwdDsgd2hpdGUtc3BhY2U6IHByZS13cmFwOyBiYWNrZ3Jv dW5kLWNvbG9yOiByZ2IoMjI4LCAyMjgsIDI1NSk7Ij5sdm08L3NwYW4+PHNwYW4gc3R5bGU9ImZv bnQtZmFtaWx5OiAmcXVvdDtEZWphVnUgU2FucyBNb25vJnF1b3Q7OyBmb250LXNpemU6IDExLjNw dDsgd2hpdGUtc3BhY2U6IHByZS13cmFwOyI+LnJlbW92ZUxWcyA8L3NwYW4+dGhhdHMgZW5vdWdo IHRvIGRlbGV0ZSB0aGUgbHZzIG9mIHZtIGFuZCBvdGhlcnMgdm0mbmJzcDs8L2Rpdj48ZGl2PmNh biByZXVzZSBpdCdzIHNwYWNlPzwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2Pjxk aXY+WzFdJm5ic3A7PHNwYW4gc3R5bGU9ImNvbG9yOiByZ2IoMzYsIDQxLCA0Nik7IGZvbnQtZmFt aWx5OiBTRk1vbm8tUmVndWxhciwgQ29uc29sYXMsICZxdW90O0xpYmVyYXRpb24gTW9ubyZxdW90 OywgTWVubG8sIENvdXJpZXIsIG1vbm9zcGFjZTsgZm9udC1zaXplOiAxMnB4OyB3aGl0ZS1zcGFj ZTogcHJlLXdyYXA7Ij48YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20vb1ZpcnQvdmRzbS9ibG9i LzJiOThkYWZmYjJjMmRlYzFiYmJkMzQyN2QzZDMyODYxZDc3ZjAxYTcvbGliL3Zkc20vc3RvcmFn ZS9ibG9ja1NELnB5I0w3MDUiIF9zcmM9Imh0dHBzOi8vZ2l0aHViLmNvbS9vVmlydC92ZHNtL2Js b2IvMmI5OGRhZmZiMmMyZGVjMWJiYmQzNDI3ZDNkMzI4NjFkNzdmMDFhNy9saWIvdmRzbS9zdG9y YWdlL2Jsb2NrU0QucHkjTDcwNSI+aHR0cHM6Ly9naXRodWIuY29tL29WaXJ0L3Zkc20vYmxvYi8y Yjk4ZGFmZmIyYzJkZWMxYmJiZDM0MjdkM2QzMjg2MWQ3N2YwMWE3L2xpYi92ZHNtL3N0b3JhZ2Uv YmxvY2tTRC5weSNMNzA1PC9hPjwvc3Bhbj48L2Rpdj5bMl0mbmJzcDtodHRwczovL3d3dy5vdmly dC5vcmcvZGV2ZWxvcC9yZWxlYXNlLW1hbmFnZW1lbnQvZmVhdHVyZXMvc3RvcmFnZS9kaXNjYXJk LWFmdGVyLWRlbGV0ZS8jd2hhdC1jb3VsZC1iZS1pbXByb3ZlZDxicj48YnI+PGJyPjxicj48ZGl2 IHN0eWxlPSJwb3NpdGlvbjpyZWxhdGl2ZTt6b29tOjEiPjwvZGl2PjxkaXYgaWQ9ImRpdk5ldGVh c2VNYWlsQ2FyZCI+PC9kaXY+PGJyPkF0IDIwMTgtMDEtMDMgMTQ6Mjk6MjksICJJZGFuIFNoYWJ5 IiAmbHQ7aXNoYWJ5QHJlZGhhdC5jb20mZ3Q7IHdyb3RlOjxicj4gPGJsb2NrcXVvdGUgaWQ9Imlz UmVwbHlDb250ZW50IiBzdHlsZT0iUEFERElORy1MRUZUOiAxZXg7IE1BUkdJTjogMHB4IDBweCAw cHggMC44ZXg7IEJPUkRFUi1MRUZUOiAjY2NjIDFweCBzb2xpZCI+PGRpdiBkaXI9Imx0ciI+PGRp dj48ZGl2PkhpLDxicj48YnI+PC9kaXY+VGhlIGZpZWxkcyAiZGlzY2FyZCIgYW5kICJwb3N0WmVy byIgYXJlIHNlbnQgdG8gdmRzbSBieSB0aGUgZW5naW5lIGluIG9yZGVyIHRvIGltcGxlbWVudCB0 aGUgIkRpc2NhcmQgQWZ0ZXIgRGVsZXRlIiBhbmQgIldpcGUgQWZ0ZXIgRGVsZXRlIiBmZWF0dXJl cy48L2Rpdj48ZGl2Pjxicj48L2Rpdj5XaGVuIGEgc3RvcmFnZSBkb21haW4gaXMgbWFya2VkIHdp dGggRGlzY2FyZCBBZnRlciBEZWxldGUsIGEgZGlzayB0aGF0IGlzIHJlbW92ZWQgZnJvbSB0aGF0 IHN0b3JhZ2UgZG9tYWluIGlzIGRpc2NhcmRlZCBiZWZvcmUgaXQncyByZW1vdmVkLiBUaGlzIHdh eSwgdGhlIGRpc2sncyBibG9ja3MgYXJlIGZyZWVkIGZyb20gdGhlIHN0b3JhZ2UgYXJyYXkgYW5k IGNhbiBiZSB1c2VkIGJ5IG90aGVyIExVTnMgaW4gdGhlIGFycmF5Ljxicj5Gb3IgbW9yZSBpbmZv cm1hdGlvbiBhYm91dCBEaXNjYXJkIEFmdGVyIERlbGV0ZSwgcGxlYXNlIHJlZmVyIHRvIHRoZSBm ZWF0dXJlIHBhZ2UgWzFdLjxicj48YnI+PGRpdj5XaGVuIGEgZGlzayAob24gYSBibG9jayBzdG9y YWdlIGRvbWFpbikgaXMgbWFya2VkIHdpdGggV2lwZSBBZnRlciBEZWxldGUsIGl0IGlzIHdpcGVk IHJpZ2h0IGJlZm9yZSBpdCdzIHJlbW92ZWQuIFRoZSBpZGVhIGJlaGluZCB0aGlzIGlzIHRoYXQg d2hlbiB0aGUgZGlzayBjb250YWlucyBzZW5zaXRpdmUgZGF0YSwgdGhlIGFkbWluaXN0cmF0b3Ig ZG9lc24ndCB3YW50IGl0IHRvIGJlIHJlYWQgYWZ0ZXIgaXQgaXMgcmVtb3ZlZC4gSG93ZXZlciwg d2hlbiB3ZSBkb24ndCB3aXBlIGEgZGlzaydzIGJsb2NrcyBiZWZvcmUgaXQgaXMgcmVtb3ZlZCwg dGhlIGRhdGEgY2FuIGJlIHJlYWQgYnkgYSBuZXcgVk0gdXNlciB3aXRoIGEgZGlzayB0aGF0IGlz IGNyZWF0ZWQgb24gc29tZS9hbGwgdGhlICBibG9ja3Mgb2YgdGhlIG9sZCBkaXNrLjwvZGl2Pjxk aXY+Rm9yIG1vcmUgaW5mb3JtYXRpb24gYWJvdXQgV2lwZSBBZnRlciBEZWxldGUsIHBsZWFzZSBy ZWZlciB0byB0aGUgYWRtaW5pc3RyYXRvciBndWlkZSBbMl0uPC9kaXY+PGRpdj48YnI+PC9kaXY+ PGRpdj5JZiB5b3UgaGF2ZSBhbnkgZnVydGhlciBxdWVzdGlvbnMsIHBsZWFzZSBkb24ndCBoZXNp dGF0ZSB0byBhc2suPGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+UmVnYXJkcyw8YnI+PC9k aXY+PGRpdiBjbGFzcz0iZ21haWxfZXh0cmEiPjxkaXY+PGRpdiBjbGFzcz0iZ21haWxfc2lnbmF0 dXJlIj48ZGl2IGRpcj0ibHRyIj48ZGl2PjxkaXYgZGlyPSJsdHIiPjxkaXY+PGRpdiBkaXI9Imx0 ciI+SWRhbjwvZGl2PjxkaXYgZGlyPSJsdHIiPjxicj48L2Rpdj48ZGl2PlsxXSA8YSBocmVmPSJo dHRwczovL3d3dy5vdmlydC5vcmcvZGV2ZWxvcC9yZWxlYXNlLW1hbmFnZW1lbnQvZmVhdHVyZXMv c3RvcmFnZS9kaXNjYXJkLWFmdGVyLWRlbGV0ZS8iPmh0dHBzOi8vd3d3Lm92aXJ0Lm9yZy9kZXZl bG9wL3JlbGVhc2UtbWFuYWdlbWVudC9mZWF0dXJlcy9zdG9yYWdlL2Rpc2NhcmQtYWZ0ZXItZGVs ZXRlLzwvYT48L2Rpdj48ZGl2PlsyXSA8YSBocmVmPSJodHRwczovL3d3dy5vdmlydC5vcmcvZG9j dW1lbnRhdGlvbi9hZG1pbi1ndWlkZS9jaGFwLVZpcnR1YWxfTWFjaGluZV9EaXNrcy8jc2V0dGlu Z3MtdG8td2lwZS12aXJ0dWFsLWRpc2tzLWFmdGVyLWRlbGV0aW9uIj5odHRwczovL3d3dy5vdmly dC5vcmcvZG9jdW1lbnRhdGlvbi9hZG1pbi1ndWlkZS9jaGFwLVZpcnR1YWxfTWFjaGluZV9EaXNr cy8jc2V0dGluZ3MtdG8td2lwZS12aXJ0dWFsLWRpc2tzLWFmdGVyLWRlbGV0aW9uPC9hPjxicj48 L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj48L2Rpdj4KPGJyPjxkaXYgY2xhc3M9 ImdtYWlsX3F1b3RlIj5PbiBXZWQsIEphbiAzLCAyMDE4IGF0IDQ6MzMgQU0sIHBlbmd5aXhpYW5n IDxzcGFuIGRpcj0ibHRyIj4mbHQ7PGEgaHJlZj0ibWFpbHRvOnl4cGVuZ2kzODZAMTYzLmNvbSIg dGFyZ2V0PSJfYmxhbmsiPnl4cGVuZ2kzODZAMTYzLmNvbTwvYT4mZ3Q7PC9zcGFuPiB3cm90ZTo8 YnI+PGJsb2NrcXVvdGUgY2xhc3M9ImdtYWlsX3F1b3RlIiBzdHlsZT0ibWFyZ2luOjBweCAwcHgg MHB4IDAuOGV4O2JvcmRlci1sZWZ0OjFweCBzb2xpZCByZ2IoMjA0LDIwNCwyMDQpO3BhZGRpbmct bGVmdDoxZXgiPjxkaXYgc3R5bGU9ImxpbmUtaGVpZ2h0OjEuNztjb2xvcjpyZ2IoMCwwLDApO2Zv bnQtc2l6ZToxNHB4O2ZvbnQtZmFtaWx5OkFyaWFsIj48ZGl2PmhlbGxvLCBldmVyeW9uZSE8L2Rp dj48ZGl2PiZuYnNwOyAmbmJzcDsgd2hlbiBJbWFnZS5kZWxldGUgY2FsbGVkIGluIHZkc20sIHdl IG5lZWQgYSBwYXJhbSAiZGlzY2FydCIgaW4gWzFdLCB0aGVuIEkgZmluZCBpcyBqdXN0IHN1cHBv cnRlZCBieSBibG9jayBhbmQmbmJzcDs8c3BhbiBzdHlsZT0iY29sb3I6cmdiKDAsMTI4LDApO2Zv bnQtd2VpZ2h0OmJvbGQ7Zm9udC1mYW1pbHk6JnF1b3Q7RGVqYVZ1IFNhbnMgTW9ubyZxdW90Oztm b250LXNpemU6MTEuM3B0O3doaXRlLXNwYWNlOnByZS13cmFwIj4iL3NiaW4vYmxrZGlzY2FyZCIg PC9zcGFuPmNhbGxlZCBpbiBsYXN0IGluIFsyXSwgYnV0Jm5ic3A7PC9kaXY+PGRpdj5JIGRvbid0 IGtub3cgd2h5IHdlIG5lZWQgdG8gZGlzY2FyZCB0aGUgYmxvY2sgZGV2aWNlcyByYXRoZXIgdGhh biBkaXJlY3RseSB1c2UgIjxzcGFuIHN0eWxlPSJjb2xvcjpyZ2IoMCwxMjgsMCk7Zm9udC13ZWln aHQ6Ym9sZDtmb250LWZhbWlseTomcXVvdDtEZWphVnUgU2FucyBNb25vJnF1b3Q7O2ZvbnQtc2l6 ZToxMS4zcHQ7d2hpdGUtc3BhY2U6cHJlLXdyYXAiPnJtIC1mPC9zcGFuPiIgPyBhbmQgd2hhdCB0 aW1lIHdlIG5lZWQgc2V0ICI8c3BhbiBzdHlsZT0iY29sb3I6cmdiKDAsMTI4LDApO2ZvbnQtd2Vp Z2h0OmJvbGQ7Zm9udC1mYW1pbHk6JnF1b3Q7RGVqYVZ1IFNhbnMgTW9ubyZxdW90Oztmb250LXNp emU6MTEuM3B0O3doaXRlLXNwYWNlOnByZS13cmFwIj5kaXNjYXJ0ID0gVFJVRSIgPC9zcGFuPj88 L2Rpdj48ZGl2PiZuYnNwOyAmbmJzcDsgQW5kIHdoYXQgdGltZSB3ZSBzaG91bGQgc2V0ICI8c3Bh biBzdHlsZT0iY29sb3I6cmdiKDAsMTI4LDApO2ZvbnQtd2VpZ2h0OmJvbGQ7Zm9udC1mYW1pbHk6 JnF1b3Q7RGVqYVZ1IFNhbnMgTW9ubyZxdW90Oztmb250LXNpemU6MTEuM3B0O3doaXRlLXNwYWNl OnByZS13cmFwIj5wb3N0WmVybz1UUlVFPC9zcGFuPiIgPzwvZGl2PjxkaXY+PGJyPjwvZGl2Pjxk aXY+PGJyPjwvZGl2PjxkaXY+WzFdJm5ic3A7Jm5ic3A7PHNwYW4gc3R5bGU9ImNvbG9yOnJnYigz Niw0MSw0Nik7Zm9udC1mYW1pbHk6U0ZNb25vLVJlZ3VsYXIsQ29uc29sYXMsJnF1b3Q7TGliZXJh dGlvbiBNb25vJnF1b3Q7LE1lbmxvLENvdXJpZXIsbW9ub3NwYWNlO2ZvbnQtc2l6ZToxMnB4O3do aXRlLXNwYWNlOnByZS13cmFwIj48YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20vb1ZpcnQvdmRz bS9ibG9iLzJiOThkYWZmYjJjMmRlYzFiYmJkMzQyN2QzZDMyODYxZDc3ZjAxYTcvbGliL3Zkc20v QVBJLnB5I0w4NDEiIHRhcmdldD0iX2JsYW5rIj5odHRwczovL2dpdGh1Yi5jb20vb1ZpcnQvPHdi cj48L3dicj52ZHNtL2Jsb2IvPHdicj48L3dicj4yYjk4ZGFmZmIyYzJkZWMxYmJiZDM0MjdkM2Qz Mjg8d2JyPjwvd2JyPjYxZDc3ZjAxYTcvbGliL3Zkc20vQVBJLnB5Izx3YnI+PC93YnI+TDg0MTwv YT48L3NwYW4+PC9kaXY+PGRpdj48c3BhbiBzdHlsZT0iY29sb3I6cmdiKDM2LDQxLDQ2KTtmb250 LWZhbWlseTpTRk1vbm8tUmVndWxhcixDb25zb2xhcywmcXVvdDtMaWJlcmF0aW9uIE1vbm8mcXVv dDssTWVubG8sQ291cmllcixtb25vc3BhY2U7Zm9udC1zaXplOjEycHg7d2hpdGUtc3BhY2U6cHJl LXdyYXAiPlsyXTwvc3Bhbj48c3BhbiBzdHlsZT0iY29sb3I6cmdiKDM2LDQxLDQ2KTtmb250LWZh bWlseTpTRk1vbm8tUmVndWxhcixDb25zb2xhcywmcXVvdDtMaWJlcmF0aW9uIE1vbm8mcXVvdDss TWVubG8sQ291cmllcixtb25vc3BhY2U7Zm9udC1zaXplOjEycHg7d2hpdGUtc3BhY2U6cHJlLXdy YXAiPjxhIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9vVmlydC92ZHNtL2Jsb2IvMmI5OGRhZmZi MmMyZGVjMWJiYmQzNDI3ZDNkMzI4NjFkNzdmMDFhNy9saWIvdmRzbS9zdG9yYWdlL2Jsb2NrU0Qu cHkjTDcxNCIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vZ2l0aHViLmNvbS9vVmlydC88d2JyPjwv d2JyPnZkc20vYmxvYi88d2JyPjwvd2JyPjJiOThkYWZmYjJjMmRlYzFiYmJkMzQyN2QzZDMyODx3 YnI+PC93YnI+NjFkNzdmMDFhNy9saWIvdmRzbS9zdG9yYWdlLzx3YnI+PC93YnI+YmxvY2tTRC5w eSNMNzE0PC9hPjwvc3Bhbj48c3BhbiBzdHlsZT0iY29sb3I6cmdiKDM2LDQxLDQ2KTtmb250LWZh bWlseTpTRk1vbm8tUmVndWxhcixDb25zb2xhcywmcXVvdDtMaWJlcmF0aW9uIE1vbm8mcXVvdDss TWVubG8sQ291cmllcixtb25vc3BhY2U7Zm9udC1zaXplOjEycHg7d2hpdGUtc3BhY2U6cHJlLXdy YXAiPiA8L3NwYW4+PC9kaXY+PC9kaXY+PGJyPjxicj48c3BhbiB0aXRsZT0ibmV0ZWFzZWZvb3Rl ciI+PHA+Jm5ic3A7PC9wPjwvc3Bhbj48YnI+X19fX19fX19fX19fX19fX19fX19fX19fX19fX19f PHdicj48L3dicj5fX19fX19fX19fX19fX19fXzxicj4KRGV2ZWwgbWFpbGluZyBsaXN0PGJyPgo8 YSBocmVmPSJtYWlsdG86RGV2ZWxAb3ZpcnQub3JnIj5EZXZlbEBvdmlydC5vcmc8L2E+PGJyPgo8 YSBocmVmPSJodHRwOi8vbGlzdHMub3ZpcnQub3JnL21haWxtYW4vbGlzdGluZm8vZGV2ZWwiIHJl bD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHA6Ly9saXN0cy5vdmlydC5vcmcvPHdi cj48L3dicj5tYWlsbWFuL2xpc3RpbmZvL2RldmVsPC9hPjxicj48L2Jsb2NrcXVvdGU+PC9kaXY+ PGJyPjwvZGl2PjwvZGl2Pgo8L2Jsb2NrcXVvdGU+PC9kaXY+PGJyPjxicj48c3BhbiB0aXRsZT0i bmV0ZWFzZWZvb3RlciI+PHA+Jm5ic3A7PC9wPjwvc3Bhbj4= ------=_Part_147535_614774795.1514979706393--
Hi, Removing a logical volume (LV) doesn't free the space from the underlying storage, i.e the underlying thinly provisioned LUN is not shrunk. When you remove a LV from your virtual group (VG), your VG still uses the same blocks from the underlying storage perspective. The only thing that is changed when you remove a LV is that from lvm's perspective, your VG has some more free space now so you can create more LVs on it. When you call to blkdiscard before removing the LV, you "tell" the storage array that you don't need these blocks anymore, and therefore it can use them to provision new LUNs or extend existing ones. Regards, Idan On Wed, Jan 3, 2018 at 1:41 PM, pengyixiang <yxpengi386@163.com> wrote:
Hello! Thaks for your reply , I read these guides and make clear some, but there's one point I don't understand. In [1], purgeImage call "blkdiscard" and "deleteVolumes", I see "This feature is about freeing (discarding) the whole disk space right before removing it." in [2], I don't know what the different between freeing and removing? May call deleteVolumes-> lvm.removeLVs thats enough to delete the lvs of vm and others vm can reuse it's space?
[1] https://github.com/oVirt/vdsm/blob/2b98daffb2c2dec1bbbd3427d3d328 61d77f01a7/lib/vdsm/storage/blockSD.py#L705 [2] https://www.ovirt.org/develop/release-management/ features/storage/discard-after-delete/#what-could-be-improved
At 2018-01-03 14:29:29, "Idan Shaby" <ishaby@redhat.com> wrote:
Hi,
The fields "discard" and "postZero" are sent to vdsm by the engine in order to implement the "Discard After Delete" and "Wipe After Delete" features.
When a storage domain is marked with Discard After Delete, a disk that is removed from that storage domain is discarded before it's removed. This way, the disk's blocks are freed from the storage array and can be used by other LUNs in the array. For more information about Discard After Delete, please refer to the feature page [1].
When a disk (on a block storage domain) is marked with Wipe After Delete, it is wiped right before it's removed. The idea behind this is that when the disk contains sensitive data, the administrator doesn't want it to be read after it is removed. However, when we don't wipe a disk's blocks before it is removed, the data can be read by a new VM user with a disk that is created on some/all the blocks of the old disk. For more information about Wipe After Delete, please refer to the administrator guide [2].
If you have any further questions, please don't hesitate to ask.
Regards, Idan
[1] https://www.ovirt.org/develop/release-management/features/ storage/discard-after-delete/ [2] https://www.ovirt.org/documentation/admin-guide/ chap-Virtual_Machine_Disks/#settings-to-wipe-virtual-disks-after-deletion
On Wed, Jan 3, 2018 at 4:33 AM, pengyixiang <yxpengi386@163.com> wrote:
hello, everyone! when Image.delete called in vdsm, we need a param "discart" in [1], then I find is just supported by block and "/sbin/blkdiscard" called in last in [2], but I don't know why we need to discard the block devices rather than directly use "rm -f" ? and what time we need set "discart = TRUE" ? And what time we should set "postZero=TRUE" ?
[1] https://github.com/oVirt/vdsm/blob/2b98daffb2c2dec1bbbd 3427d3d32861d77f01a7/lib/vdsm/API.py#L841 [2]https://github.com/oVirt/vdsm/blob/2b98daffb2c2dec1bbbd34 27d3d32861d77f01a7/lib/vdsm/storage/blockSD.py#L714
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (2)
-
Idan Shaby -
pengyixiang