On Sun, Dec 9, 2018 at 6:21 PM Nir Soffer <nsoffer@redhat.com> wrote:

I posted patches for vdsm new NBD APIs: https://gerrit.ovirt.org/q/topic:nbd+project:vdsm

For the big picture, see the feature page:

https://ovirt.org/develop/release-management/features/storage/incremental-ba...

Changes: - Adding option to run a service as user:group https://gerrit.ovirt.org/c/96077 - Adding back support for systemd-run and systemctl_stop to supervdsm. https://gerrit.ovirt.org/c/96078 - Introducing the NBD APIs https://gerrit.ovirt.org/c/96079 - Starting nbd module tests https://gerrit.ovirt.org/c/96080 - Allow running tests that need supervdsm on your laptop https://gerrit.ovirt.org/c/96081

Thanks for the reviews so far! I sent a new version, adding 2 new pathces: - Fix qemuimg test class names https://gerrit.ovirt.org/c/96141/ - Support qemuimg.convert to NBD (needed for the tests) https://gerrit.ovirt.org/c/96142 Other changes: - Add discard option to server configuration. Previously volume.isSparse() was used which is wrong. Engine must set the discard option based on the policy for the storage domain. - Add missing tests and improve test coverage for the new module (97%). Please review. Nir