On Thu, 1 Feb 2018 15:57:46 +0000 Dafna Ron <dron@redhat.com> wrote:

Hi,

We are failing initialize engine on both basic and upgrade suites.

Can you please check?

*Link and headline of suspected patches: https://gerrit.ovirt.org/#/c/86679/ <https://gerrit.ovirt.org/#/c/86679/> - *

*core: Check Sequence before/afterLink to Job:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/5187/ <http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/5187/>Link to all logs:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/5187/artifact/ <http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/5187/artifact/>(Relevant) error snippet from the log: <error>2018-02-01 10:38:27,057-0500 DEBUG otopi.plugins.otopi.dialog.human dialog.__logString:204 DIALOG:SEND Version: otopi-1.7.7_master (otopi-1.7.7-0.0.master.20180201063428.git81ce9b7.el7.centos)2018-02-01 10:38:27,058-0500 ERROR otopi.context context.check:833 "before" parameter of method otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin._misc_configure_provider is a string, should probably be a tuple. Perhaps a missing comma?2018-02-01 10:38:27,058-0500 DEBUG otopi.plugins.otopi.dialog.human dialog.__logString:204 DIALOG:SEND methodinfo: {'priority': 5000, 'name': None, 'before': 'osetup.ovn.provider.service.restart', 'after': ('osetup.pki.ca <http://osetup.pki.ca>.available', 'osetup.ovn.services.restart'), 'method': <bound method ?._misc_configure_provider of <otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin object at 0x2edf6d0>>, 'condition': <bound method ?.<lambda> of <otopi.plugins.ovirt_engine_setup.ovirt_engine.network.ovirtproviderovn.Plugin object at 0x2edf6d0>>, 'stage': 11}2018-02-01 10:38:27,059-0500 DEBUG otopi.context context._executeMethod:143 method exceptionTraceback (most recent call last): File "/usr/lib/python2.7/site-packages/otopi/context.py", line 133, in _executeMethod method['method']() File "/usr/share/otopi/plugins/otopi/core/misc.py", line 61, in _setup self.context.checkSequence() File "/usr/lib/python2.7/site-packages/otopi/context.py", line 844, in checkSequence raise RuntimeError(_('Found bad "before" or "after" parameters'))RuntimeError: Found bad "before" or "after" parameters2018-02-01 10:38:27,059-0500 ERROR otopi.context context._executeMethod:152 Failed to execute stage 'Environment setup': Found bad "before" or "after" parameters</error>*

Seems like the new introduced check of https://gerrit.ovirt.org/#/c/86679/ works. I posted https://gerrit.ovirt.org/#/c/87045/ to fix this. Locally it works for me, but I still have test this change in OST on jenkins.