From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; To: "engine-devel" <engine-devel(a)ovirt.org&gt; Sent: Thursday, April 18, 2013 4:55:46 PM Subject: [Engine-devel] Location of findbugs filter.xml file Hi all, I sent a patch upstream to add findbugs filter that will filter out bug reports that we decided that are not bugs. We have a debate on whether to have the findbugs filter definition in the root pom.xml or to put it in the jenkins jobs repo and treat it as an external tool. I would like to hear opinions about what you think should be the proper location

Thanks, Yair _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

From: "Mike Kolesnik" <mkolesni(a)redhat.com&gt; To: "engine-devel" <engine-devel(a)ovirt.org&gt; Cc: "Oved Ourfalli" <ovedo(a)redhat.com&gt; Sent: Thursday, April 18, 2013 5:10:39 PM Subject: Re: [Engine-devel] Location of findbugs filter.xml file ----- Original Message ----- > > > ----- Original Message ----- > > From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > > To: "engine-devel" <engine-devel(a)ovirt.org&gt; > > Sent: Thursday, April 18, 2013 4:55:46 PM > > Subject: [Engine-devel] Location of findbugs filter.xml file > > > > Hi all, > > I sent a patch upstream to add findbugs filter that will filter out bug > > reports that we decided that are not bugs. > > We have a debate on whether to have the findbugs filter definition in the > > root pom.xml or to put it in the jenkins jobs repo and treat it as an > > external tool. > > I would like to hear opinions about what you think should be the proper > > location > > > Putting it in the root pom.xml file will allow running filtered findbugs > using maven, without the need to use jenkins, so I'd go with that approach. +1

> > > Thanks, > > Yair > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

From: "Michael Pasternak" <mpastern(a)redhat.com&gt; To: "Oved Ourfalli" <ovedo(a)redhat.com&gt; Cc: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt;, "engine-devel" <engine-devel(a)ovirt.org&gt; Sent: Thursday, April 18, 2013 9:33:34 PM Subject: Re: [Engine-devel] Location of findbugs filter.xml file On 04/18/2013 04:58 PM, Oved Ourfalli wrote: > > > ----- Original Message ----- >> From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; >> To: "engine-devel" <engine-devel(a)ovirt.org&gt; >> Sent: Thursday, April 18, 2013 4:55:46 PM >> Subject: [Engine-devel] Location of findbugs filter.xml file >> >> Hi all, >> I sent a patch upstream to add findbugs filter that will filter out bug >> reports that we decided that are not bugs. >> We have a debate on whether to have the findbugs filter definition in the >> root pom.xml or to put it in the jenkins jobs repo and treat it as an >> external tool. >> I would like to hear opinions about what you think should be the proper >> location >> > Putting it in the root pom.xml file will allow running filtered findbugs > using maven, without the need to use jenkins, so I'd go with that > approach. +1 > >> Thanks, >> Yair >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel -- Michael Pasternak RedHat, ENG-Virtualization R&D