On Wed, Jun 15, 2016 at 5:35 AM, Yuko Katabami <ykatabam(a)redhat.com&gt; wrote: > Hi Ravi and all, > > I am reporting the following as this may cause potential issues: > > *File:* backend/manager/modules/enginesso/src/main/resources/messages > *Resource ID:* UNSUPPORTED_PARAMETER_IN_REQUEST > *String:​​ *The request contains unsupported parameter value '%s' for > parameter '%s'. > ​I think we could change that to: ​ *​ *The request contains unsupported value ​​ '%s' for parameter '%s'.

Yuko, is it OK? If so, Ravi could you post a patch? *Question: *Using the same variables in a single sentence would cause > problem when it is translated as the order of words may be changed. It > should use different variables. > > Kind regards, > > Yuko > > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel >

On Wed, Jun 15, 2016 at 11:04 PM, Yuko Katabami <ykatabam(a)redhat.com&gt; wrote: > Hi Martin, > > Thank you very much for your reply. > Please see my comment inline: > > On Wed, Jun 15, 2016 at 11:50 PM, Martin Perina <mperina(a)redhat.com&gt; > wrote: > >> >> >> On Wed, Jun 15, 2016 at 5:35 AM, Yuko Katabami <ykatabam(a)redhat.com&gt; >> wrote: >> >>> Hi Ravi and all, >>> >>> I am reporting the following as this may cause potential issues: >>> >>> *File:* backend/manager/modules/enginesso/src/main/resources/messages >>> *Resource ID:* UNSUPPORTED_PARAMETER_IN_REQUEST >>> *String:​​ * >>> ​​ >>> The request contains unsupported parameter value '%s' for parameter >>> '%s'. >>> >> >> ​I think we could change that to: >> ​ >> >> *​ *The request contains unsupported value >> ​​ >> '%s' for parameter '%s'. >> > > ​My comment was probably not clear enough.​ > > ​What I meant is that ​ > ​ > '%s' is used twice in this string, one is used for "value" and the other > for "parameter". > > When we translate, for example into Japanese, the order of words will be > changed. > It will look like: > > | The request | contain | of the paramater > ​ > '%s (parameter)' | value > ​ > '%s (value)'| > but is the first > ​ > '%s' is defined to be value, and the second > ​ > '%s' is parameter, translation will be shown on UI as: > | The request | contain | of the paramater > ​ > '%s (value)' | value > ​ > '%s (parameter)'| > > So it would be better if you can use different variables, instead of 2 x > ​ > ​ > '%s'. > > Hope this clarifies the issue. > > Thanks, > > Yuko > ​Ahh, now I see you point :-) Ravi, please create a patch which will add indexes to all localization strings using String.format(), for example: ​ The request contains unsupported parameter value '%1$s' for parameter '%2$s'. Thanks Martin ​ > > > >> Yuko, is it OK? If so, Ravi could you post a patch? >> >> *Question: *Using the same variables in a single sentence would cause >>> problem when it is translated as the order of words may be changed. It >>> should use different variables. >>> >>> Kind regards, >>> >>> Yuko >>> >>> _______________________________________________ >>> Devel mailing list >>> Devel(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/devel >>> >> >> > > ​​ > >

Posted a patch to fix the issue https://gerrit.ovirt.org/#/c/59290/

Ravi On Wed, Jun 15, 2016 at 6:39 PM, Yuko Katabami <ykatabam(a)redhat.com&gt; wrote: > Thanks a lot, Martin and Ravi! > > On Thu, Jun 16, 2016 at 7:28 AM, Martin Perina <mperina(a)redhat.com&gt; > wrote: > >> >> >> On Wed, Jun 15, 2016 at 11:04 PM, Yuko Katabami <ykatabam(a)redhat.com&gt; >> wrote: >> >>> Hi Martin, >>> >>> Thank you very much for your reply. >>> Please see my comment inline: >>> >>> On Wed, Jun 15, 2016 at 11:50 PM, Martin Perina <mperina(a)redhat.com&gt; >>> wrote: >>> >>>> >>>> >>>> On Wed, Jun 15, 2016 at 5:35 AM, Yuko Katabami <ykatabam(a)redhat.com&gt; >>>> wrote: >>>> >>>>> Hi Ravi and all, >>>>> >>>>> I am reporting the following as this may cause potential issues: >>>>> >>>>> *File:* backend/manager/modules/enginesso/src/main/resources/messages >>>>> *Resource ID:* UNSUPPORTED_PARAMETER_IN_REQUEST >>>>> *String:​​ * >>>>> ​​ >>>>> The request contains unsupported parameter value '%s' for parameter >>>>> '%s'. >>>>> >>>> >>>> ​I think we could change that to: >>>> ​ >>>> >>>> *​ *The request contains unsupported value >>>> ​​ >>>> '%s' for parameter '%s'. >>>> >>> >>> ​My comment was probably not clear enough.​ >>> >>> ​What I meant is that ​ >>> ​ >>> '%s' is used twice in this string, one is used for "value" and the >>> other for "parameter". >>> >>> When we translate, for example into Japanese, the order of words will >>> be changed. >>> It will look like: >>> >>> | The request | contain | of the paramater >>> ​ >>> '%s (parameter)' | value >>> ​ >>> '%s (value)'| >>> but is the first >>> ​ >>> '%s' is defined to be value, and the second >>> ​ >>> '%s' is parameter, translation will be shown on UI as: >>> | The request | contain | of the paramater >>> ​ >>> '%s (value)' | value >>> ​ >>> '%s (parameter)'| >>> >>> So it would be better if you can use different variables, instead of 2 >>> x ​ >>> ​ >>> '%s'. >>> >>> Hope this clarifies the issue. >>> >>> Thanks, >>> >>> Yuko >>> >> >> ​Ahh, now I see you point :-) >> >> Ravi, please create a patch which will add indexes to all localization >> strings using String.format(), for example: >> >> ​ >> The request contains unsupported parameter value '%1$s' for parameter >> '%2$s'. >> >> Thanks >> >> Martin >> >> ​ >> >> >>> >>> >>> >>>> Yuko, is it OK? If so, Ravi could you post a patch? >>>> >>>> *Question: *Using the same variables in a single sentence would cause >>>>> problem when it is translated as the order of words may be changed. It >>>>> should use different variables. >>>>> >>>>> Kind regards, >>>>> >>>>> Yuko >>>>> >>>>> _______________________________________________ >>>>> Devel mailing list >>>>> Devel(a)ovirt.org >>>>> http://lists.ovirt.org/mailman/listinfo/devel >>>>> >>>> >>>> >>> >>> ​​ >>> >>> >> > > > >