On Wed, Jun 19, 2019 at 4:12 PM Marcin Sobczyk <msobczyk(a)redhat.com> wrote:
Hi,
it's probably the test's 'tearDown' trying to delete the
'SSLServerThred'...
Anyway, these tests don't actually test any of our production code base
and they're subject for removal:
https://gerrit.ovirt.org/#/c/95309/
Thanks, merged.
I hope that we have real ssl tests for the actual server code, similar to
these
tests in imageio:
https://github.com/oVirt/ovirt-imageio/blob/master/daemon/test/ssl_test.py
Regards, Marcin
On 6/18/19 9:09 PM, Nir Soffer wrote:
On Tue, Jun 18, 2019 at 8:10 PM Nir Soffer <nsoffer(a)redhat.com> wrote:
> We have new random failure in this test:
>
> [2019-06-18T16:05:56.576Z] =================================== FAILURES
> ===================================
> [2019-06-18T16:05:56.576Z] _________________
> SSLTests.testConnectWithoutCertificateFails __________________
> [2019-06-18T16:05:56.576Z]
> [2019-06-18T16:05:56.576Z] self = <ssl_test.SSLTests
> testMethod=testConnectWithoutCertificateFails>
> [2019-06-18T16:05:56.576Z]
> [2019-06-18T16:05:56.576Z] def
> testConnectWithoutCertificateFails(self):
> [2019-06-18T16:05:56.576Z] """
> [2019-06-18T16:05:56.576Z] Verify that the connection without a
> client certificate
> [2019-06-18T16:05:56.576Z] fails.
> [2019-06-18T16:05:56.576Z] """
> [2019-06-18T16:05:56.576Z]
> [2019-06-18T16:05:56.576Z] with self.assertRaises(cmdutils.Error):
> [2019-06-18T16:05:56.576Z] args = ["openssl",
"s_client",
> "-connect", "%s:%d" % self.address]
> [2019-06-18T16:05:56.576Z] > commands.run(args)
> [2019-06-18T16:05:56.576Z] E AssertionError: Error not raised
> [2019-06-18T16:05:56.576Z]
> [2019-06-18T16:05:56.576Z] ssl_test.py:173: AssertionError
>
> The build:
>
>
https://jenkins.ovirt.org/blue/organizations/jenkins/vdsm_standard-check-...
>
>
https://jenkins.ovirt.org/blue/rest/organizations/jenkins/pipelines/vdsm_...
>
Second failure today:
[2019-06-18T18:56:08.924Z] =================================== FAILURES
===================================
[2019-06-18T18:56:08.924Z] _________________ SSLTests.testConnectWithoutCertificateFails
__________________
[2019-06-18T18:56:08.924Z]
[2019-06-18T18:56:08.924Z] self = <ssl_test.SSLTests
testMethod=testConnectWithoutCertificateFails>
[2019-06-18T18:56:08.924Z]
[2019-06-18T18:56:08.924Z] def testConnectWithoutCertificateFails(self):
[2019-06-18T18:56:08.924Z] """
[2019-06-18T18:56:08.924Z] Verify that the connection without a client
certificate
[2019-06-18T18:56:08.924Z] fails.
[2019-06-18T18:56:08.924Z] """
[2019-06-18T18:56:08.924Z]
[2019-06-18T18:56:08.924Z] with self.assertRaises(cmdutils.Error):
[2019-06-18T18:56:08.924Z] args = ["openssl", "s_client",
"-connect", "%s:%d" % self.address]
[2019-06-18T18:56:08.924Z] > commands.run(args)
[2019-06-18T18:56:08.924Z] E AssertionError: Error not raised
[2019-06-18T18:56:08.924Z]
[2019-06-18T18:56:08.924Z] ssl_test.py:173: AssertionError
https://jenkins.ovirt.org/blue/organizations/jenkins/vdsm_standard-check-...
https://jenkins.ovirt.org/blue/rest/organizations/jenkins/pipelines/vdsm_...
>
>
> Marcin, can you look at it?
>