Gerrit, only infra can remove reviewers
--C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Effective now, only infra team members can remove reviewers from engine mas= ter and vdsm master. That means that you'll have to poke one of us each time you want to prevent jenkins (or anyone) from blocking any patches. Enjoy! --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVJVZKAAoJEEBxx+HSYmnDc2wH/0eAQ2ooLxcP9SlJf5UgsDka ODICflQ7MMR5u9J+lTcIC50mzRJiiKsh8Q69S0psyVVDQZEPvxi07OYixjC5LLlq 2A6S70YONNk5C9uJ8ncNZYs5TTrEx7ecYdGmDzavdZoLVLjN4lNQSr4eOMn7nMJK TZrlXFt/HxGWSn4A/+B5lXl9WQQX8zCEmdQyzhDeKv9wSNnWz30mFn4v8O/yho5+ oN54gZUCTrFdpS2jQMNg3VajYt9TOYOkJJFZEHA9IOp8KezJPsWg7vqwKnMqowi9 U4tIBruh6ygdGoAg7DJ1CmhKMMx9Q9TbVMFp5uwkz+250veYH3IdTXqAyNGcz8I= =ML7z -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--
On Apr 8, 2015, at 19:24 , David Caro <dcaroest@redhat.com> wrote:
Effective now, only infra team members can remove reviewers from engine master and vdsm master. That means that you'll have to poke one of us each time you want to prevent jenkins (or anyone) from blocking any patches.
we have people working in various time zones, how do we make sure an urgent thing is addressed in time? what's the full contact list? escalation list? Thanks, michal
Enjoy!
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
--x4pBfXISqBoDm8sr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/13, Michal Skrivanek wrote:
=20 On Apr 8, 2015, at 19:24 , David Caro <dcaroest@redhat.com> wrote: =20
=20 Effective now, only infra team members can remove reviewers from engine= master and vdsm master. That means that you'll have to poke one of us each tim= e you want to prevent jenkins (or anyone) from blocking any patches. =20 we have people working in various time zones, how do we make sure an urge= nt thing is addressed in time? =20 what's the full contact list? escalation list?
infra at ovirt dot org for any and all the issues. Prefferently if you open= ed a ticket at [1] 1 https://fedorahosted.org/ovirt/
=20 Thanks, michal =20
=20 =20 Enjoy! =20 =20 --=20 David Caro =20 Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D =20 Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel =20
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --x4pBfXISqBoDm8sr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVK5FUAAoJEEBxx+HSYmnDgaUH/RPa3w298dzOjRXqac1BfYBi 98aQUAmTBhuazuL3eyPE++yOIXci1xnOUvy1VH592Kj9b/HZLh1pemArgQ+eddO4 RkVO5aNC9dBfDsI1IJ5n35iZGrLQYK/5FS56P6FcA1R7BgtdoM9cKgZGBaLEC2tf N8mWhQ7rzv9jOz+3suS7J64rp7fAKoesOE1NsZn8GmaqPjru4S/dZ1mfKj3JNwwT +OCJmdnnN/6VGcBL3jPekzp/RrHt/m9NJlzc6cx7xuebub26PqyevweyISJLaIEw BE9/bVgkmhKKgnUjZrg4FwEvWRgtE7MB0nHYYGaqM/tElDxv9PaGDK/zLJVZ0cQ= =CYNg -----END PGP SIGNATURE----- --x4pBfXISqBoDm8sr--
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: devel@ovirt.org, infra@ovirt.org Sent: Wednesday, April 8, 2015 7:24:42 PM Subject: [ovirt-devel] Gerrit, only infra can remove reviewers
Effective now, only infra team members can remove reviewers from engine master and vdsm master.
Can't you limit the list of removed reviewers only for the relevant reviewer list ? specifically for "gerrit-hooks" and "oVirt Jenkins CI Server" ? I'd like to have the ability to remove unintended reviewer from a patch (i.e. if was mistakenly added ). Also, can a user remove himself from the reviewer list of a given patch ?
That means that you'll have to poke one of us each time you want to prevent jenkins (or anyone) from blocking any patches.
Enjoy!
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On 04/13/2015 10:41 AM, Moti Asayag wrote:
From: "David Caro" <dcaroest@redhat.com> To: devel@ovirt.org, infra@ovirt.org Sent: Wednesday, April 8, 2015 7:24:42 PM Subject: [ovirt-devel] Gerrit, only infra can remove reviewers
Effective now, only infra team members can remove reviewers from engine master and vdsm master. Can't you limit the list of removed reviewers only for the relevant reviewer
----- Original Message ----- list ? specifically for "gerrit-hooks" and "oVirt Jenkins CI Server" ?
I tend to agree with that, a false positive failed test can delay merging for days sometimes, can't you let specific people (maintainers for instance or a representative from each team) to remove reviewers?
I'd like to have the ability to remove unintended reviewer from a patch (i.e. if was mistakenly added ).
Also, can a user remove himself from the reviewer list of a given patch ?
That means that you'll have to poke one of us each time you want to prevent jenkins (or anyone) from blocking any patches.
Enjoy!
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
--yVhtmJPUSI46BTXb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/13, Moti Asayag wrote:
From: "David Caro" <dcaroest@redhat.com> To: devel@ovirt.org, infra@ovirt.org Sent: Wednesday, April 8, 2015 7:24:42 PM Subject: [ovirt-devel] Gerrit, only infra can remove reviewers =20 =20 Effective now, only infra team members can remove reviewers from engine master and vdsm master.=20 =20 Can't you limit the list of removed reviewers only for the relevant revie= wer
=20 =20 ----- Original Message ----- list ? specifically for "gerrit-hooks" and "oVirt Jenkins CI Server" ? =20 No, that's not an option right now (unsupported)
I'd like to have the ability to remove unintended reviewer from a patch (= i.e. if was mistakenly added ). =20 Also, can a user remove himself from the reviewer list of a given patch ?
Yes, you should, have you tried?
=20
That means that you'll have to poke one of us each time you want to prevent jenkins (or anyone) from blocking any patches. =20 =20 Enjoy! =20 =20 -- David Caro =20 Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D =20 Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 =20 _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --yVhtmJPUSI46BTXb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVK5CrAAoJEEBxx+HSYmnD38UH/AwnnydAo05edtvRU7V9K5sk aIuxNsBPwx32jlHSejcVZtKlvZBVYPIYRTNPgCjRjw/FR0dJLPjfr6eKy7SH3yf+ +/lvKwL47cQ54gqvc4rgE22mVz17GS+lqN6I/t+Vv5mkRj0fmPRtMzdDvK4CEKpz LE98pYLGtTOZdJsA2VtGgDMQ2XiCw19ejZAhPAEQylUU+oMcx6bOBprG2Zjry+yV GxLyVxJ2f7z4MeKCmRN1nZfOEXZppTjs+04BpgjjTONBKYgYwEgTdqcSzSmB4Xgr xiJpkWxLgL7ba6SW1Z/fNrv7eG4pyQAKhnHH1TAkUhLA8it1hq8KLFSYZHrWlnA= =EWQA -----END PGP SIGNATURE----- --yVhtmJPUSI46BTXb--
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Moti Asayag" <masayag@redhat.com> Cc: devel@ovirt.org, infra@ovirt.org Sent: Monday, April 13, 2015 12:47:23 PM Subject: Re: [ovirt-devel] Gerrit, only infra can remove reviewers
On 04/13, Moti Asayag wrote:
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: devel@ovirt.org, infra@ovirt.org Sent: Wednesday, April 8, 2015 7:24:42 PM Subject: [ovirt-devel] Gerrit, only infra can remove reviewers
Effective now, only infra team members can remove reviewers from engine master and vdsm master.
Can't you limit the list of removed reviewers only for the relevant reviewer list ? specifically for "gerrit-hooks" and "oVirt Jenkins CI Server" ?
No, that's not an option right now (unsupported)
I'd like to have the ability to remove unintended reviewer from a patch (i.e. if was mistakenly added ).
Also, can a user remove himself from the reviewer list of a given patch ?
Yes, you should, have you tried?
Just tried - it works well.
That means that you'll have to poke one of us each time you want to prevent jenkins (or anyone) from blocking any patches.
Enjoy!
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
participants (4)
-
David Caro -
Michal Skrivanek -
Moti Asayag -
Tal Nisan