Problem with vdsm 'make check'
Hi, I am having an issue running make check on vdsm master. ` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently? -- Thanks, Kaustav Majumder
Hi, On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
--
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
Yes i did but same issue. On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
--
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
-- Thanks, Kaustav Majumder
did you run autogen.sh? On Mon, Oct 14, 2019 at 7:12 PM Kaustav Majumder <kmajumde@redhat.com> wrote:
Yes i did but same issue.
On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
--
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
--
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WELA...
Thanks for pointing that out. Right now the only isssue is upgrading tox I guess. ``` [kmajumde:~/work/git/vdsm] master+* 2 ± make check Makefile:1029: warning: overriding recipe for target 'check-recursive' Makefile:548: warning: ignoring old recipe for target 'check-recursive' Checking that .in files are ignored... ! git --no-pager grep execCmd `git ls-files | grep -v -F -f execcmd-blacklist.txt` out=`tox --version`; \ if [ $? -ne 0 ]; then \ echo "Error: cannot run tox, please install tox \ 3.14 or later"; \ exit 1; \ fi; \ version=`echo $out | cut -d' ' -f1`; \ if python2.7 build-aux/vercmp $version 3.14; then \ echo "Error: tox is too old, please install tox \ 3.14 or later"; \ exit 1; \ fi Error: tox is too old, please install tox 3.14 or later make: *** [Makefile:1012: tox] Error 1 ``` On Mon, Oct 14, 2019 at 10:42 PM Benny Zlotnik <bzlotnik@redhat.com> wrote:
did you run autogen.sh?
On Mon, Oct 14, 2019 at 7:12 PM Kaustav Majumder <kmajumde@redhat.com> wrote:
Yes i did but same issue.
On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk <msobczyk@redhat.com>
wrote:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29,
in <module>
from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
--
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
--
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WELA...
-- Thanks, Kaustav Majumder
Thanks for pointing that out. Right now the only isssue is upgrading tox I guess.
yes. Fedora provides only 3.5, so you need to upgrade it via pip (and make sure you use one installed via pip and not from package if you previously installed it)
``` [kmajumde:~/work/git/vdsm] master+* 2 ± make check Makefile:1029: warning: overriding recipe for target 'check-recursive' Makefile:548: warning: ignoring old recipe for target 'check-recursive' Checking that .in files are ignored... ! git --no-pager grep execCmd `git ls-files | grep -v -F -f execcmd-blacklist.txt` out=`tox --version`; \ if [ $? -ne 0 ]; then \ echo "Error: cannot run tox, please install tox \ 3.14 or later"; \ exit 1; \ fi; \ version=`echo $out | cut -d' ' -f1`; \ if python2.7 build-aux/vercmp $version 3.14; then \ echo "Error: tox is too old, please install tox \ 3.14 or later"; \ exit 1; \ fi Error: tox is too old, please install tox 3.14 or later make: *** [Makefile:1012: tox] Error 1 ```
On Mon, Oct 14, 2019 at 10:42 PM Benny Zlotnik <bzlotnik@redhat.com> wrote:
did you run autogen.sh?
On Mon, Oct 14, 2019 at 7:12 PM Kaustav Majumder <kmajumde@redhat.com>
wrote:
Yes i did but same issue.
On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk <msobczyk@redhat.com>
wrote:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \
mv .coverage .coverage-nose-py27; \
fi
Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module>
from vdsm import constants
File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29,
in <module>
from vdsm.common.constants import * # NOQA: F401, F403
` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
--
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLD VOWHW6RZWBLMETZ3NYCM/> --
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WE LAQT5EHG6U72LWQFUGSK/
Marcin Sobczyk <msobczyk@redhat.com> writes:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often. Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q...
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of. Full log here : https://pastebin.com/fb77r7Hj On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com> wrote:
Marcin Sobczyk <msobczyk@redhat.com> writes:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
-- Thanks, Kaustav Majumder
On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of. Can you please pastebin the contents of your 'lib/vdsm/common/constants.py' file?
Full log here : https://pastebin.com/fb77r7Hj
On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com <mailto:mzamazal@redhat.com>> wrote:
Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> writes:
> Hi, > > On 10/14/19 3:06 PM, Kaustav Majumder wrote: >> >> Hi, >> I am having an issue running make check on vdsm master. >> >> ` >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \ >> mv .coverage .coverage-nose-py27; \ >> fi >> Traceback (most recent call last): >> File "../tests/testrunner.py", line 70, in <module> >> from vdsm import constants >> File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line >> 29, in <module> >> from vdsm.common.constants import * # NOQA: F401, F403 >> ` >> Am I missing something? Do I need to run tests differently? > did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
>> Thanks, >> >> Kaustav Majumder >> >> >> _______________________________________________ >> Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> >> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ >> List Archives: >> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO... > > _______________________________________________ > Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> > To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/ > oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
--
Thanks,
Kaustav Majumder
Hi, There is no constants.py file but constants.py.in -> https://pastebin.com/ATLrmTuh On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of.
Can you please pastebin the contents of your 'lib/vdsm/common/constants.py' file?
Full log here : https://pastebin.com/fb77r7Hj
On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com> wrote:
Marcin Sobczyk <msobczyk@redhat.com> writes:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
--
Thanks,
Kaustav Majumder
-- Thanks, Kaustav Majumder
On 10/15/19 2:12 PM, Kaustav Majumder wrote:
Hi, There is no constants.py file but constants.py.in <http://constants.py.in> -> https://pastebin.com/ATLrmTuh That would suggest that you didn't run 'make' - this is the step that generates files from '*.in' ones.
On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> wrote:
On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of.
Can you please pastebin the contents of your 'lib/vdsm/common/constants.py' file?
Full log here : https://pastebin.com/fb77r7Hj
On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com <mailto:mzamazal@redhat.com>> wrote:
Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> writes:
> Hi, > > On 10/14/19 3:06 PM, Kaustav Majumder wrote: >> >> Hi, >> I am having an issue running make check on vdsm master. >> >> ` >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \ >> mv .coverage .coverage-nose-py27; \ >> fi >> Traceback (most recent call last): >> File "../tests/testrunner.py", line 70, in <module> >> from vdsm import constants >> File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line >> 29, in <module> >> from vdsm.common.constants import * # NOQA: F401, F403 >> ` >> Am I missing something? Do I need to run tests differently? > did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
>> Thanks, >> >> Kaustav Majumder >> >> >> _______________________________________________ >> Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> >> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ >> List Archives: >> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO... > > _______________________________________________ > Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> > To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/ > oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
Yes, I didnot run make after I chnged my dev environment, It worked but I still see some commands failing namely ``` ERROR: tests-py27: commands failed ERROR: storage-py27: commands failed lib-py27: commands succeeded ERROR: network-py27: commands failed virt-py27: commands succeeded gluster-py27: commands succeeded ``` I am working on master. Full log here: https://pastebin.com/8RbBk97d On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
On 10/15/19 2:12 PM, Kaustav Majumder wrote:
Hi, There is no constants.py file but constants.py.in -> https://pastebin.com/ATLrmTuh
That would suggest that you didn't run 'make' - this is the step that generates files from '*.in' ones.
On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of.
Can you please pastebin the contents of your 'lib/vdsm/common/constants.py' file?
Full log here : https://pastebin.com/fb77r7Hj
On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com> wrote:
Marcin Sobczyk <msobczyk@redhat.com> writes:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
-- Thanks, Kaustav Majumder
On 10/15/19 3:07 PM, Kaustav Majumder wrote:
Yes, I didnot run make after I chnged my dev environment, It worked but I still see some commands failing namely ``` ERROR: tests-py27: commands failed ERROR: storage-py27: commands failed lib-py27: commands succeeded ERROR: network-py27: commands failed virt-py27: commands succeeded gluster-py27: commands succeeded ``` I am working on master. Full log here: https://pastebin.com/8RbBk97d
AFAICT there are no actual errors regarding storage and network tests - the reason a failure is reported is because you're missing minimal required coverage i.e. for storage: FAIL Required test coverage of 62% not reached. Total coverage: 56.81% The coverage is lower than expected because some tests work only in specific envs (like running as 'root'). You can lower the expected coverage by defining these vars: export NETWORK_COVERAGE=5 export STORAGE_COVERAGE=5 Unfortunately I can't the reason behind failure of 'tests-py27' it's trimmed.
On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> wrote:
On 10/15/19 2:12 PM, Kaustav Majumder wrote:
Hi, There is no constants.py file but constants.py.in <http://constants.py.in> -> https://pastebin.com/ATLrmTuh
That would suggest that you didn't run 'make' - this is the step that generates files from '*.in' ones.
On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> wrote:
On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of.
Can you please pastebin the contents of your 'lib/vdsm/common/constants.py' file?
Full log here : https://pastebin.com/fb77r7Hj
On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com <mailto:mzamazal@redhat.com>> wrote:
Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> writes:
> Hi, > > On 10/14/19 3:06 PM, Kaustav Majumder wrote: >> >> Hi, >> I am having an issue running make check on vdsm master. >> >> ` >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \ >> mv .coverage .coverage-nose-py27; \ >> fi >> Traceback (most recent call last): >> File "../tests/testrunner.py", line 70, in <module> >> from vdsm import constants >> File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line >> 29, in <module> >> from vdsm.common.constants import * # NOQA: F401, F403 >> ` >> Am I missing something? Do I need to run tests differently? > did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
>> Thanks, >> >> Kaustav Majumder >> >> >> _______________________________________________ >> Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> >> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ >> List Archives: >> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO... > > _______________________________________________ > Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> > To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/ > oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
Thanks a lot. BTW here is the full log : https://pastebin.com/6zDb9tB3 On Tue, Oct 15, 2019 at 6:48 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
On 10/15/19 3:07 PM, Kaustav Majumder wrote:
Yes, I didnot run make after I chnged my dev environment, It worked but I still see some commands failing namely ``` ERROR: tests-py27: commands failed ERROR: storage-py27: commands failed lib-py27: commands succeeded ERROR: network-py27: commands failed virt-py27: commands succeeded gluster-py27: commands succeeded ``` I am working on master. Full log here: https://pastebin.com/8RbBk97d
AFAICT there are no actual errors regarding storage and network tests - the reason a failure is reported is because you're missing minimal required coverage i.e. for storage:
FAIL Required test coverage of 62% not reached. Total coverage: 56.81%
The coverage is lower than expected because some tests work only in specific envs (like running as 'root'). You can lower the expected coverage by defining these vars:
export NETWORK_COVERAGE=5 export STORAGE_COVERAGE=5
Unfortunately I can't the reason behind failure of 'tests-py27' it's trimmed.
On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
On 10/15/19 2:12 PM, Kaustav Majumder wrote:
Hi, There is no constants.py file but constants.py.in -> https://pastebin.com/ATLrmTuh
That would suggest that you didn't run 'make' - this is the step that generates files from '*.in' ones.
On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:
On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of.
Can you please pastebin the contents of your 'lib/vdsm/common/constants.py' file?
Full log here : https://pastebin.com/fb77r7Hj
On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com> wrote:
Marcin Sobczyk <msobczyk@redhat.com> writes:
Hi,
On 10/14/19 3:06 PM, Kaustav Majumder wrote:
Hi, I am having an issue running make check on vdsm master.
` if [ -n "$NOSE_WITH_COVERAGE" ]; then \ mv .coverage .coverage-nose-py27; \ fi Traceback (most recent call last): File "../tests/testrunner.py", line 70, in <module> from vdsm import constants File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in <module> from vdsm.common.constants import * # NOQA: F401, F403 ` Am I missing something? Do I need to run tests differently?
did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
Thanks,
Kaustav Majumder
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
-- Thanks, Kaustav Majumder
On 10/15/19 3:49 PM, Kaustav Majumder wrote:
Thanks a lot. BTW here is the full log : https://pastebin.com/6zDb9tB3
So the only failure I can see is: JsonRpcNoResponseError: No response for JSON-RPC request: {'method': 'event'} and this one is on me - stomp-related tests can be unfortunately quite unstable... As soon as I dig myself out of py3-related tasks I will look into this.
On Tue, Oct 15, 2019 at 6:48 PM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> wrote:
On 10/15/19 3:07 PM, Kaustav Majumder wrote:
Yes, I didnot run make after I chnged my dev environment, It worked but I still see some commands failing namely ``` ERROR: tests-py27: commands failed ERROR: storage-py27: commands failed lib-py27: commands succeeded ERROR: network-py27: commands failed virt-py27: commands succeeded gluster-py27: commands succeeded ``` I am working on master. Full log here: https://pastebin.com/8RbBk97d
AFAICT there are no actual errors regarding storage and network tests - the reason a failure is reported is because you're missing minimal required coverage i.e. for storage:
FAIL Required test coverage of 62% not reached. Total coverage: 56.81%
The coverage is lower than expected because some tests work only in specific envs (like running as 'root'). You can lower the expected coverage by defining these vars:
export NETWORK_COVERAGE=5 export STORAGE_COVERAGE=5
Unfortunately I can't the reason behind failure of 'tests-py27' it's trimmed.
On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> wrote:
On 10/15/19 2:12 PM, Kaustav Majumder wrote:
Hi, There is no constants.py file but constants.py.in <http://constants.py.in> -> https://pastebin.com/ATLrmTuh
That would suggest that you didn't run 'make' - this is the step that generates files from '*.in' ones.
On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> wrote:
On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. Mostly with vdsm.constants.I have lines of ``` E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member) ************* Module vdsm.gluster.api E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member) ************* Module vdsm.gluster.gfapi E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member) ************* Module vdsm.supervdsm_api.udev ``` for all places wherever vdsm.constants is required. Any change I am unaware of.
Can you please pastebin the contents of your 'lib/vdsm/common/constants.py' file?
Full log here : https://pastebin.com/fb77r7Hj
On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal <mzamazal@redhat.com <mailto:mzamazal@redhat.com>> wrote:
Marcin Sobczyk <msobczyk@redhat.com <mailto:msobczyk@redhat.com>> writes:
> Hi, > > On 10/14/19 3:06 PM, Kaustav Majumder wrote: >> >> Hi, >> I am having an issue running make check on vdsm master. >> >> ` >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \ >> mv .coverage .coverage-nose-py27; \ >> fi >> Traceback (most recent call last): >> File "../tests/testrunner.py", line 70, in <module> >> from vdsm import constants >> File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line >> 29, in <module> >> from vdsm.common.constants import * # NOQA: F401, F403 >> ` >> Am I missing something? Do I need to run tests differently? > did you run plane 'make' before 'make check'?
Wouldn't it be worth to fix the missing dependency? We hit this issue often.
Even if we made `check' simply depend on `all', it would be fine IMO, since the running time of `all' is negligible to the running time of `check'.
>> Thanks, >> >> Kaustav Majumder >> >> >> _______________________________________________ >> Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> >> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ >> List Archives: >> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVO... > > _______________________________________________ > Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> > To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/ > oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6Q... _______________________________________________ Devel mailing list -- devel@ovirt.org <mailto:devel@ovirt.org> To unsubscribe send an email to devel-leave@ovirt.org <mailto:devel-leave@ovirt.org> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQF...
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
--
Thanks,
Kaustav Majumder
participants (5)
-
Benny Zlotnik -
Kaustav Majumder -
Marcin Sobczyk -
Milan Zamazal -
Vojtech Juranek