[Engine-devel] Adding support for OpenLDAP to oVirt
Hello together, regarding support for OpenLDAP as domain provider I found this mail from last year on ovirt-users list :http://lists.ovirt.org/pipermail/users/2012-July/002791.html I would like to add support for OpenLDAP to oVirt. As a start I had a look at ovirt-engine/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDS* which seems to be very similar to the RHDS classes. I simply copied all ITDS*.java files to OpenLdap*.java and changed class names and so forth from ITDS/itds to OpenLdap/openLdap. I also changed user and group attributes to make sense for OpenLDAP. Additionally I enhanced the LdapQueryMetadataFactoryImpl class, again copying mostly from ITDS and others. To the very last I enhanced the enum at ovirt-engine/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java with an OpenLDAP entry. Right now I do not oversee the whole LDAPBroker code. Especially I do not know how enum at LdapProviderType.java is related the code found at bll/adbroker/*. Could you please give me some guidance and advise, if I am on the right track? I could also send a diff of all changes to the list, if that is helpful. Thanks very much.
Hi Uwe, Bare in mind we have some plans for refactoring/changing the authentication module. However, for the meanwhile - we will be very happy if you can assist in adding this support. I would like to introduce you to a Wiki that Oved Ourfali has written about the subject - http://www.ovirt.org/DomainInfrastructure Please let us know if this helps you with your questions. kind regards, Yair ----- Original Message -----
From: "Uwe Grawert" <grawert@b1-systems.de> To: engine-devel@ovirt.org Sent: Tuesday, March 19, 2013 7:44:17 PM Subject: [Engine-devel] Adding support for OpenLDAP to oVirt
Hello together,
regarding support for OpenLDAP as domain provider I found this mail from last year on ovirt-users list :http://lists.ovirt.org/pipermail/users/2012-July/002791.html
I would like to add support for OpenLDAP to oVirt. As a start I had a look at ovirt-engine/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDS* which seems to be very similar to the RHDS classes.
I simply copied all ITDS*.java files to OpenLdap*.java and changed class names and so forth from ITDS/itds to OpenLdap/openLdap. I also changed user and group attributes to make sense for OpenLDAP. Additionally I enhanced the LdapQueryMetadataFactoryImpl class, again copying mostly from ITDS and others.
To the very last I enhanced the enum at ovirt-engine/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java with an OpenLDAP entry.
Right now I do not oversee the whole LDAPBroker code. Especially I do not know how enum at LdapProviderType.java is related the code found at bll/adbroker/*.
Could you please give me some guidance and advise, if I am on the right track? I could also send a diff of all changes to the list, if that is helpful. Thanks very much. _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Hello Yair, Am 20.03.2013 um 08:24 schrieb Yair Zaslavsky:
Hi Uwe, Bare in mind we have some plans for refactoring/changing the authentication module. However, for the meanwhile - we will be very happy if you can assist in adding this support. I would like to introduce you to a Wiki that Oved Ourfali has written about the subject -
good to know. Refactoring will probably take some time, so I hope it's still worth the effort.
http://www.ovirt.org/DomainInfrastructure Please let us know if this helps you with your questions.
So far I am simply copying what has been done for ITDS and adopting things to OpenLdap. I am using the git tag "ovirt-engine-3.2.1", since I am getting the following error when using HEAD: [root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291) I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
----- Original Message -----
From: "Uwe Grawert" <grawert@b1-systems.de> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: engine-devel@ovirt.org Sent: Thursday, March 21, 2013 4:49:03 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
Hello Yair,
Am 20.03.2013 um 08:24 schrieb Yair Zaslavsky:
Hi Uwe, Bare in mind we have some plans for refactoring/changing the authentication module. However, for the meanwhile - we will be very happy if you can assist in adding this support. I would like to introduce you to a Wiki that Oved Ourfali has written about the subject -
good to know. Refactoring will probably take some time, so I hope it's still worth the effort.
http://www.ovirt.org/DomainInfrastructure Please let us know if this helps you with your questions.
So far I am simply copying what has been done for ITDS and adopting things to OpenLdap. I am using the git tag "ovirt-engine-3.2.1", since I am getting the following error when using HEAD:
Do you still have by any chance backup of the db + environment that caused this exception? There is something I would like you to examine on the db of the "faulty installation" if possible.
[root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291)
I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
Hello Yair, Am 21.03.2013 um 17:31 schrieb Yair Zaslavsky:
Do you still have by any chance backup of the db + environment that caused this exception? There is something I would like you to examine on the db of the "faulty installation" if possible.
yes I have. What would you like to have?
[root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291)
I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
----- Original Message -----
From: "Uwe Grawert" <grawert@b1-systems.de> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: engine-devel@ovirt.org Sent: Thursday, March 21, 2013 6:36:59 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
Hello Yair,
Am 21.03.2013 um 17:31 schrieb Yair Zaslavsky:
Do you still have by any chance backup of the db + environment that caused this exception? There is something I would like you to examine on the db of the "faulty installation" if possible.
yes I have. What would you like to have?
Cool! Please provide output for - select * from vdc_options where option_name in ('AdUserName','AdUserPassword','DomainName','LdapServers','LDAPProviderTypes');
[root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291)
I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
Am 21.03.2013 um 17:48 schrieb Yair Zaslavsky:
----- Original Message -----
From: "Uwe Grawert" <grawert@b1-systems.de> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: engine-devel@ovirt.org Sent: Thursday, March 21, 2013 6:36:59 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
Hello Yair,
Am 21.03.2013 um 17:31 schrieb Yair Zaslavsky:
Do you still have by any chance backup of the db + environment that caused this exception? There is something I would like you to examine on the db of the "faulty installation" if possible.
yes I have. What would you like to have?
Cool!
Please provide output for -
select * from vdc_options where option_name in ('AdUserName','AdUserPassword','DomainName','LdapServers','LDAPProviderTypes');
engine=# select * from vdc_options where option_name in ('AdUserName','AdUserPassword','DomainName','LdapServers','LDAPProviderTypes'); option_id | option_name | option_value | version -----------+-------------------+--------------+--------- 10 | AdUserName | | general 11 | AdUserPassword | | general 56 | DomainName | | general 126 | LdapServers | | general 127 | LDAPProviderTypes | | general (5 rows) I haven't added any domains, yet.
Hmm... Well, there is nothing in your db in the values of these fields, but it should not have failed engine-manage-domains. Can you send me the commit hash you built against , so I will be able to reproduce exactly you issue? Many thanks, Yair ----- Original Message -----
From: "Uwe Grawert" <grawert@b1-systems.de> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: engine-devel@ovirt.org Sent: Thursday, March 21, 2013 6:53:42 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
Am 21.03.2013 um 17:48 schrieb Yair Zaslavsky:
----- Original Message -----
From: "Uwe Grawert" <grawert@b1-systems.de> To: "Yair Zaslavsky" <yzaslavs@redhat.com> Cc: engine-devel@ovirt.org Sent: Thursday, March 21, 2013 6:36:59 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
Hello Yair,
Am 21.03.2013 um 17:31 schrieb Yair Zaslavsky:
Do you still have by any chance backup of the db + environment that caused this exception? There is something I would like you to examine on the db of the "faulty installation" if possible.
yes I have. What would you like to have?
Cool!
Please provide output for -
select * from vdc_options where option_name in ('AdUserName','AdUserPassword','DomainName','LdapServers','LDAPProviderTypes');
engine=# select * from vdc_options where option_name in ('AdUserName','AdUserPassword','DomainName','LdapServers','LDAPProviderTypes'); option_id | option_name | option_value | version -----------+-------------------+--------------+--------- 10 | AdUserName | | general 11 | AdUserPassword | | general 56 | DomainName | | general 126 | LdapServers | | general 127 | LDAPProviderTypes | | general (5 rows)
I haven't added any domains, yet.
Am 21.03.2013 um 17:59 schrieb Yair Zaslavsky:
Hmm... Well, there is nothing in your db in the values of these fields, but it should not have failed engine-manage-domains.
Can you send me the commit hash you built against , so I will be able to reproduce exactly you issue?
[root@ovirt-nightly ovirt-engine]# git log -1 commit 7546d98680d50a103bd01c04756cfe72e6e14a1b Author: Lior Vernia <lvernia@redhat.com> Date: Wed Feb 27 17:25:06 2013 +0200 core: Changed Bond constructor for backwards compatibility Before the Bond subclass was implemented, the old way to check whether a VdsNetworkInterface was to check the value of its "bonded" field. This is now preserved, so that any Bond object would still comply with older code. Change-Id: I93d970df3fe1e22e8116d0b5683e82851037f6c8 Signed-off-by: Lior Vernia <lvernia@redhat.com>
On 03/21/2013 03:49 PM, Uwe Grawert wrote:
Hello Yair,
Am 20.03.2013 um 08:24 schrieb Yair Zaslavsky:
Hi Uwe, Bare in mind we have some plans for refactoring/changing the authentication module. However, for the meanwhile - we will be very happy if you can assist in adding this support. I would like to introduce you to a Wiki that Oved Ourfali has written about the subject -
good to know. Refactoring will probably take some time, so I hope it's still worth the effort.
http://www.ovirt.org/DomainInfrastructure Please let us know if this helps you with your questions.
So far I am simply copying what has been done for ITDS and adopting things to OpenLdap. I am using the git tag "ovirt-engine-3.2.1", since I am getting the following error when using HEAD:
[root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291)
I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
Note that we recently fixed an issue with how engine-config uses the log and the standard output which had this same symptom. You may want to apply this patch (already merged in the master branch) and then try again: http://gerrit.ovirt.org/12987 -- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Uwe Grawert" <grawert@b1-systems.de> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, engine-devel@ovirt.org Sent: Thursday, March 21, 2013 6:59:40 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
On 03/21/2013 03:49 PM, Uwe Grawert wrote:
Hello Yair,
Am 20.03.2013 um 08:24 schrieb Yair Zaslavsky:
Hi Uwe, Bare in mind we have some plans for refactoring/changing the authentication module. However, for the meanwhile - we will be very happy if you can assist in adding this support. I would like to introduce you to a Wiki that Oved Ourfali has written about the subject -
good to know. Refactoring will probably take some time, so I hope it's still worth the effort.
http://www.ovirt.org/DomainInfrastructure Please let us know if this helps you with your questions.
So far I am simply copying what has been done for ITDS and adopting things to OpenLdap. I am using the git tag "ovirt-engine-3.2.1", since I am getting the following error when using HEAD:
[root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291)
I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
Note that we recently fixed an issue with how engine-config uses the log and the standard output which had this same symptom. You may want to apply this patch (already merged in the master branch) and then try again:
Actually, I think Juan is right, and I saw this error myself when the patch he mentioned was not applied.
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: engine-devel@ovirt.org Sent: Thursday, March 21, 2013 7:03:06 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Uwe Grawert" <grawert@b1-systems.de> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, engine-devel@ovirt.org Sent: Thursday, March 21, 2013 6:59:40 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
On 03/21/2013 03:49 PM, Uwe Grawert wrote:
Hello Yair,
Am 20.03.2013 um 08:24 schrieb Yair Zaslavsky:
Hi Uwe, Bare in mind we have some plans for refactoring/changing the authentication module. However, for the meanwhile - we will be very happy if you can assist in adding this support. I would like to introduce you to a Wiki that Oved Ourfali has written about the subject -
good to know. Refactoring will probably take some time, so I hope it's still worth the effort.
http://www.ovirt.org/DomainInfrastructure Please let us know if this helps you with your questions.
So far I am simply copying what has been done for ITDS and adopting things to OpenLdap. I am using the git tag "ovirt-engine-3.2.1", since I am getting the following error when using HEAD:
[root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291)
I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
Note that we recently fixed an issue with how engine-config uses the log and the standard output which had this same symptom. You may want to apply this patch (already merged in the master branch) and then try again:
Actually, I think Juan is right, and I saw this error myself when the patch he mentioned was not applied.
Juan's patch was introduced *after* the commit hash you mentioned was introduced. Please rebase again or at least apply his patch.
-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Am 21.03.2013 um 18:06 schrieb Yair Zaslavsky:
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: "Juan Hernandez" <jhernand@redhat.com> Cc: engine-devel@ovirt.org Sent: Thursday, March 21, 2013 7:03:06 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
----- Original Message -----
From: "Juan Hernandez" <jhernand@redhat.com> To: "Uwe Grawert" <grawert@b1-systems.de> Cc: "Yair Zaslavsky" <yzaslavs@redhat.com>, engine-devel@ovirt.org Sent: Thursday, March 21, 2013 6:59:40 PM Subject: Re: [Engine-devel] Adding support for OpenLDAP to oVirt
On 03/21/2013 03:49 PM, Uwe Grawert wrote:
Hello Yair,
Am 20.03.2013 um 08:24 schrieb Yair Zaslavsky:
Hi Uwe, Bare in mind we have some plans for refactoring/changing the authentication module. However, for the meanwhile - we will be very happy if you can assist in adding this support. I would like to introduce you to a Wiki that Oved Ourfali has written about the subject -
good to know. Refactoring will probably take some time, so I hope it's still worth the effort.
http://www.ovirt.org/DomainInfrastructure Please let us know if this helps you with your questions.
So far I am simply copying what has been done for ITDS and adopting things to OpenLdap. I am using the git tag "ovirt-engine-3.2.1", since I am getting the following error when using HEAD:
[root@ovirt-nightly ~]# engine-manage-domains -action=list Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1 at org.ovirt.engine.core.domains.DomainsConfigurationEntry.<init>(DomainsConfigurationEntry.java:23) at org.ovirt.engine.core.domains.ManageDomains.getConfiguration(ManageDomains.java:423) at org.ovirt.engine.core.domains.ManageDomains.runCommand(ManageDomains.java:293) at org.ovirt.engine.core.domains.ManageDomains.main(ManageDomains.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.modules.Module.run(Module.java:260) at org.jboss.modules.Main.main(Main.java:291)
I created only ovirt-engine RPMs and installed them with --nodeps. Might be that I am missing some dependency here. Anyways, ovirt-engine-3.2.1 release tag is working, and diffs will very likely apply to HEAD as well.
Note that we recently fixed an issue with how engine-config uses the log and the standard output which had this same symptom. You may want to apply this patch (already merged in the master branch) and then try again:
Actually, I think Juan is right, and I saw this error myself when the patch he mentioned was not applied.
Juan's patch was introduced *after* the commit hash you mentioned was introduced. Please rebase again or at least apply his patch.
Right. I was quite old. Now I'm current and it works well. [root@ovirt-nightly ovirt-engine]# git log -1 commit c743bf9f0e7a20b8c69423aef80079c6e7ffbf80 Author: Libor Spevak <lspevak@redhat.com> Date: Thu Mar 21 12:35:33 2013 +0100 [root@ovirt-nightly ovirt-engine]# engine-manage-domains -action=list Manage Domains completed successfully
Hallo together, adding support for OpenLDAP has been working fine so far, but before bringing it to the review process, I would like to discuss the following issue. When querying the RootDSE most of the attributes are defined as operational attributes, and standard says, those must be requested explicitly. Among them is namingContexts, which for OpenLDAP, has to be requested. Therefore I had to change the searchControl and define the attributes to return. This could be affecting other directory servers. So far the test classes have run fine, and I could successfully test adding and authenticating against ActiveDirectory and IPA. RHDS and ITDS have not been tested. So the question is, could the following patch break something? diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEQueryInfo.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEQueryInfo.java index 01294c6..60033ff 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEQueryInfo.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEQueryInfo.java @@ -21,8 +21,10 @@ public class RootDSEQueryInfo { * @return */ public static SearchControls createSearchControls() { + String[] returnAttributes = {NAMING_CONTEXTS_RESULT_ATTRIBUTE, DEFAULT_NAMING_CONTEXT_RESULT_ATTRIBUTE}; SearchControls searchControls = new SearchControls(); searchControls.setSearchScope(SearchControls.OBJECT_SCOPE); + searchControls.setReturningAttributes(returnAttributes); // Added this in order to prevent a warning saying: "the returning obj flag wasn't set, setting it to true" searchControls.setReturningObjFlag(true); return searchControls;
participants (3)
-
Juan Hernandez -
Uwe Grawert -
Yair Zaslavsky