[Engine-devel] +1 in gerrit
Hi, Just an idea for the gerrit reviews: if you review a patch and give "+1 Looks good to me, but someone else must approve", then please add someone as reviewer, who might be the right person. And then after a while the patch will get to someone who knows if the patch is good or not. Laszlo
----- Original Message -----
From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, April 29, 2012 3:03:35 PM Subject: [Engine-devel] +1 in gerrit
Hi,
Just an idea for the gerrit reviews: if you review a patch and give "+1 Looks good to me, but someone else must approve", then please add someone as reviewer, who might be the right person. And then after a while the patch will get to someone who knows if the patch is good or not.
+1 (but someone else must approve ;-))
Laszlo _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 29/04/12 15:22, Eli Mesika wrote:
----- Original Message -----
From: "Laszlo Hornyak" <lhornyak@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, April 29, 2012 3:03:35 PM Subject: [Engine-devel] +1 in gerrit
Hi,
Just an idea for the gerrit reviews: if you review a patch and give "+1 Looks good to me, but someone else must approve", then please add someone as reviewer, who might be the right person. And then after a while the patch will get to someone who knows if the patch is good or not.
+1 (but someone else must approve ;-))
+1, if you give +1 it would be nice to add who you think should be able to +2.
Laszlo _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (3)
-
Eli Mesika -
Laszlo Hornyak -
Livnat Peer