Verify Grade (-1) for check_product and check_target_milestone hooks
Hi Tal, I'm going to apply today the verify grade (-1) for the following hooks: 1. *check_product* - if the patch project is not the same as the bug product will return a verify grade (-1). 2. *check_target_milestone* - if the patch branch major version is not the same as the bug target milestone major version will return a verify grade (-1). Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCVA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1
Hi All, I'm going to apply today the verify grade (-1) for the following hooks: 1. *check_product* - It will return a verify grade (-1) if the patch project is not the same as the bug product. 2. *check_target_milestone* - It will return a verify grade (-1) if the patch branch major version is not the same as the bug target milestone major version. Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCVA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1
Great, thanks! I will let you know if something doesn't work as it should On Sun, Feb 5, 2017 at 12:09 PM, Shlomo Ben David <sbendavi@redhat.com> wrote:
Hi Tal,
I'm going to apply today the verify grade (-1) for the following hooks:
1. *check_product* - if the patch project is not the same as the bug product will return a verify grade (-1). 2. *check_target_milestone* - if the patch branch major version is not the same as the bug target milestone major version will return a verify grade (-1).
Best Regards,
Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCVA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
OPEN SOURCE - 1 4 011 && 011 4 1
This is a multi-part message in MIME format. --------------A37248C6363D1E76C59F013F Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/05/2017 12:39 PM, Tal Nisan wrote:
Great, thanks! I will let you know if something doesn't work as it should
On Sun, Feb 5, 2017 at 12:09 PM, Shlomo Ben David <sbendavi@redhat.com <mailto:sbendavi@redhat.com>> wrote:
Hi Tal,
I'm going to apply today the verify grade (-1) for the following hooks:
1. *check_product* - if the patch project is not the same as the bug product will return a verify grade (-1). 2. *check_target_milestone* - if the patch branch major version is not the same as the bug target milestone major version will return a verify grade (-1).
Best Regards,
Let's consider this scenario: we just begin developing the 4.2 version on the master branch; we just released the 4.1.0 version, so we have the 4.1.z branch, and we are still supporting the 4.0.z branch. Let's consider a bug which needs to be backported in the 4.0.z branch, from master, of course passing throgh 4.1.z 0. bug target milestone is 4.0.N+1 (last release is 4.0.N) 1. patch on master -> OK 2. patch backported first time on branch 4.1.z -> check_target_milestone fails! branch major 4.1, bug target 4.0 It seems that this flow doesn't cover the case on which we need a double backport. Bests, -- Francesco Romani Red Hat Engineering Virtualization R & D IRC: fromani --------------A37248C6363D1E76C59F013F Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit <html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <br> <div class="moz-cite-prefix">On 02/05/2017 12:39 PM, Tal Nisan wrote:<br> </div> <blockquote cite="mid:CA+c-=xPz3NjGK7N_oKtMfju3y8n3ak759hMfpXBDhg-ePck5AA@mail.gmail.com" type="cite"> <div dir="ltr">Great, thanks! <div>I will let you know if something doesn't work as it should</div> </div> <div class="gmail_extra"><br> <div class="gmail_quote">On Sun, Feb 5, 2017 at 12:09 PM, Shlomo Ben David <span dir="ltr"><<a moz-do-not-send="true" href="mailto:sbendavi@redhat.com" target="_blank">sbendavi@redhat.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"> <div>Hi Tal,</div> <div><br> </div> <div>I'm going to apply today the verify grade (-1) for the following hooks:</div> <div><br> </div> <div> <ol> <li><b>check_product</b> - if the patch project is not the same as the bug product will return a verify grade (-1).<br> </li> <li><b>check_target_milestone</b> - if the patch branch major version is not the same as the bug target milestone major version will return a verify grade (-1).</li> </ol> </div> <div> <div class="m_-4133077015336823918gmail_signature"> <div dir="ltr"> <div class="m_-4133077015336823918gmail_signature"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div>Best Regards,</div> <br> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </blockquote> </div> </div> </blockquote> <br> Let's consider this scenario: we just begin developing the 4.2 version on the master branch; we just released the 4.1.0 version, so we have the 4.1.z branch, and we are still supporting the 4.0.z branch.<br> Let's consider a bug which needs to be backported in the 4.0.z branch, from master, of course passing throgh 4.1.z<br> <br> 0. bug target milestone is 4.0.N+1 (last release is 4.0.N)<br> 1. patch on master -> OK<br> 2. patch backported first time on branch 4.1.z<br> -> check_target_milestone fails! branch major 4.1, bug target 4.0<br> <br> It seems that this flow doesn't cover the case on which we need a double backport.<br> <br> Bests,<br> <pre class="moz-signature" cols="72">-- Francesco Romani Red Hat Engineering Virtualization R & D IRC: fromani</pre> </body> </html> --------------A37248C6363D1E76C59F013F--
On Tue, Feb 7, 2017 at 10:18 AM, Francesco Romani <fromani@redhat.com> wrote:
On 02/05/2017 12:39 PM, Tal Nisan wrote:
Great, thanks! I will let you know if something doesn't work as it should
On Sun, Feb 5, 2017 at 12:09 PM, Shlomo Ben David <sbendavi@redhat.com> wrote:
Hi Tal,
I'm going to apply today the verify grade (-1) for the following hooks:
1. *check_product* - if the patch project is not the same as the bug product will return a verify grade (-1). 2. *check_target_milestone* - if the patch branch major version is not the same as the bug target milestone major version will return a verify grade (-1).
Best Regards,
Let's consider this scenario: we just begin developing the 4.2 version on the master branch; we just released the 4.1.0 version, so we have the 4.1.z branch, and we are still supporting the 4.0.z branch. Let's consider a bug which needs to be backported in the 4.0.z branch, from master, of course passing throgh 4.1.z
0. bug target milestone is 4.0.N+1 (last release is 4.0.N) 1. patch on master -> OK 2. patch backported first time on branch 4.1.z -> check_target_milestone fails! branch major 4.1, bug target 4.0
It seems that this flow doesn't cover the case on which we need a double backport.
We are aware of that option, i.e "clone candidate" bugs, and if we see that the bug has 2 version flags ( e.g ovirt-4.1 + ovirt-4.0 ) then it shouldn't give -1. If it still fails on bugs that are 'clone candidate' then its a bug and we should fix it.
Bests,
-- Francesco Romani Red Hat Engineering Virtualization R & D IRC: fromani
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
participants (4)
-
Eyal Edri -
Francesco Romani -
Shlomo Ben David -
Tal Nisan