As part of the multiple storage domains feature there will be new functionality added to allow users to move individual disks. What are the prerequisites for moving a disk? 1) the disk must exist 2) the associated VM must be down 3) the associated VM must not be locked 4) the source storage domain must exist 5) the source storage domain must be available 6) the target domain must exist 7) the target domain must be available 8) the target domain must have adequate disk space 9) the target domain cannot be an ISO or export domain 10) the source domain cannot be an ISO or export domain

What am I missing? Also, should we allow the moving of a template disk that has VM disks based on it? Unless I'm wrong this would require all of the disks based on the template to be moved as well. thoughts? _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

On 01/16/2012 05:26 PM, Jon Choate wrote: > As part of the multiple storage domains feature there will be new > functionality added to allow users to move individual disks. > > What are the prerequisites for moving a disk? > > 1) the disk must exist > 2) the associated VM must be down this can't just be a CanDoAction check - the lock has to be real to prevent a race from starting the VM after the validation.

> 3) the associated VM must not be locked > 4) the source storage domain must exist > 5) the source storage domain must be available > 6) the target domain must exist > 7) the target domain must be available > 8) the target domain must have adequate disk space > 9) the target domain cannot be an ISO or export domain > 10) the source domain cannot be an ISO or export domain

user must provide same/other quota for the target domain which has enough quota left for the requested size. > > What am I missing? > > Also, should we allow the moving of a template disk that has VM > disks based on it? Unless I'm wrong this would require all of the > disks based on the template to be moved as well. I'd say no. you can only move a template disk if it is not used. I'd go further and say one should copy the template disk and delete, rather than support move for it at all (not relevant for VM disk, since we don't have the same concept of multiple copies for it).

> > thoughts? > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

From: "Jon Choate" <jchoate(a)redhat.com&gt; To: "Ayal Baron" <abaron(a)redhat.com&gt; Cc: engine-devel(a)ovirt.org Sent: Monday, January 16, 2012 9:39:55 PM Subject: Re: [Engine-devel] move disk command On 01/16/2012 02:26 PM, Ayal Baron wrote: > > ----- Original Message ----- >> On 01/16/2012 05:26 PM, Jon Choate wrote: >>> As part of the multiple storage domains feature there will be new >>> functionality added to allow users to move individual disks. >>> >>> What are the prerequisites for moving a disk? >>> >>> 1) the disk must exist >>> 2) the associated VM must be down >> this can't just be a CanDoAction check - the lock has to be real >> to >> prevent a race from starting the VM after the validation. >> > Either down or disk is unplugged. > >>> 3) the associated VM must not be locked >>> 4) the source storage domain must exist >>> 5) the source storage domain must be available >>> 6) the target domain must exist >>> 7) the target domain must be available >>> 8) the target domain must have adequate disk space >>> 9) the target domain cannot be an ISO or export domain >>> 10) the source domain cannot be an ISO or export domain > This may be unrelated, but user would be allowed to export and > import a floating disk, right? > I would like the ability to import *any* disk in the export domain > as a floating disk, but in the least, export and import disks not > associated with a VM.

This was not in scope for the work I am currently doing. If this is something desirable I think it needs to be prioritized and worked in at a later time. If it does need to happen now then we are going to need to be able to do full crud for a floating disk I would think. >> user must provide same/other quota for the target domain which has >> enough quota left for the requested size. >> >>> What am I missing? >>> >>> Also, should we allow the moving of a template disk that has VM >>> disks based on it? Unless I'm wrong this would require all of the >>> disks based on the template to be moved as well. >> I'd say no. you can only move a template disk if it is not used. >> I'd go further and say one should copy the template disk and >> delete, >> rather than support move for it at all (not relevant for VM disk, >> since >> we don't have the same concept of multiple copies for it). > As long as you can delete a copy of the disk from a domain where > there are no VM disks derived from it. > >>> thoughts? >>> _______________________________________________ >>> Engine-devel mailing list >>> Engine-devel(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/engine-devel >> _______________________________________________ >> Engine-devel mailing list >> Engine-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/engine-devel >> _______________________________________________ Engine-devel mailing list Engine-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

From: "Ayal Baron" <abaron(a)redhat.com&gt; To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; Cc: engine-devel(a)ovirt.org, "Jon Choate" <jchoate(a)redhat.com&gt; Sent: Tuesday, January 17, 2012 10:45:53 AM Subject: Shared disk / Floating disk import/export (was: Re: [Engine-devel] move disk command) [SNIP] > > > This may be unrelated, but user would be allowed to export and > > > import a floating disk, right? > > > I would like the ability to import *any* disk in the export > > > domain > > > as a floating disk, but in the least, export and import disks > > > not > > > associated with a VM. > > you are right, it is unrelated, this thread is about move disk of a > vm between SDs, > export and import is copy, and floating disks is part of the shared > disk feature, > this indeed need to be discussed in that scope. Ok, so I've changed the subject, now let's discuss it.

On 01/17/2012 11:57 AM, Omer Frenkel wrote: > > > ----- Original Message ----- >> From: "Ayal Baron" <abaron(a)redhat.com&gt; >> To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; >> Cc: engine-devel(a)ovirt.org, "Jon Choate" <jchoate(a)redhat.com&gt; >> Sent: Tuesday, January 17, 2012 10:45:53 AM >> Subject: Shared disk / Floating disk import/export (was: Re: >> [Engine-devel] move disk command) >> >> >> [SNIP] >> >>>>> This may be unrelated, but user would be allowed to export and >>>>> import a floating disk, right? >>>>> I would like the ability to import *any* disk in the export >>>>> domain >>>>> as a floating disk, but in the least, export and import disks >>>>> not >>>>> associated with a VM. >>> >>> you are right, it is unrelated, this thread is about move disk of >>> a >>> vm between SDs, >>> export and import is copy, and floating disks is part of the >>> shared >>> disk feature, >>> this indeed need to be discussed in that scope. >> >> Ok, so I've changed the subject, now let's discuss it. >> > > Adding Maor, > not sure if we have any plan regard export/import of floating disk, > or in general, exporting disk without it's vm (if I understood Ayal > correctly) > > Maor, any comments? I remember, we mentioned export/import issue in our last meeting with Andrew in the context of shared raw disk. It was decided then, that export/import will not be supported by shared raw disk, I'm not sure if we also decided that for floating disk, but I think its a PM decision. Support import/export domain might evolve to a big change, since if we want to export disk, we might also want to reflect all its configuration and functionality there, also reflect disks which are attached to VMs and templates as well.

----- Original Message ----- > From: "Ayal Baron" <abaron(a)redhat.com&gt; > To: "Maor" <mlipchuk(a)redhat.com&gt; > Cc: engine-devel(a)ovirt.org, "Jon Choate" <jchoate(a)redhat.com&gt;, > "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > Sent: Tuesday, January 17, 2012 10:21:29 PM > Subject: Re: Shared disk / Floating disk import/export (was: Re: > [Engine-devel] move disk command) > > > > ----- Original Message ----- > > On 01/17/2012 11:57 AM, Omer Frenkel wrote: > > > > > > > > > ----- Original Message ----- > > >> From: "Ayal Baron" <abaron(a)redhat.com&gt; > > >> To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > > >> Cc: engine-devel(a)ovirt.org, "Jon Choate" <jchoate(a)redhat.com&gt; > > >> Sent: Tuesday, January 17, 2012 10:45:53 AM > > >> Subject: Shared disk / Floating disk import/export (was: Re: > > >> [Engine-devel] move disk command) > > >> > > >> > > >> [SNIP] > > >> > > >>>>> This may be unrelated, but user would be allowed to export > > >>>>> and > > >>>>> import a floating disk, right? > > >>>>> I would like the ability to import *any* disk in the export > > >>>>> domain > > >>>>> as a floating disk, but in the least, export and import > > >>>>> disks > > >>>>> not > > >>>>> associated with a VM. > > >>> > > >>> you are right, it is unrelated, this thread is about move > > >>> disk > > >>> of > > >>> a > > >>> vm between SDs, > > >>> export and import is copy, and floating disks is part of the > > >>> shared > > >>> disk feature, > > >>> this indeed need to be discussed in that scope. > > >> > > >> Ok, so I've changed the subject, now let's discuss it. > > >> > > > > > > Adding Maor, > > > not sure if we have any plan regard export/import of floating > > > disk, > > > or in general, exporting disk without it's vm (if I understood > > > Ayal > > > correctly) > > > > > > Maor, any comments? > > I remember, we mentioned export/import issue in our last meeting > > with > > Andrew in the context of shared raw disk. > > It was decided then, that export/import will not be supported by > > shared > > raw disk, I'm not sure if we also decided that for floating disk, > > but I think its a PM decision. > > > > Support import/export domain might evolve to a big change, since > > if > > we > > want to export disk, we might also want to reflect all its > > configuration > > and functionality there, also reflect disks which are attached to > > VMs > > and templates as well. > > What properties does a disk have? > Interface is what type of connection is used when plugging the disk > in the computer (VM) so it's not really a disk property. > Address is also VM specific > Description is already stored in storage side. > What else do you have for disk? type (system/data..)

post-zero

name(?)

creation-date

last modify date

application-list

volume type and format

> > Note that being able to import floating disks means that we'd be > able > to take any data storage domain and import any disk(s) from it > (assuming user changes domain type to export domain, which users > already know how to do) > >

----- Original Message ----- > From: "Ayal Baron" <abaron(a)redhat.com&gt; > To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > Cc: engine-devel(a)ovirt.org, "Jon Choate" <jchoate(a)redhat.com&gt;, > "Maor" <mlipchuk(a)redhat.com&gt; > Sent: Wednesday, January 18, 2012 10:20:01 AM > Subject: Re: Shared disk / Floating disk import/export (was: Re: > [Engine-devel] move disk command) > > > > ----- Original Message ----- > > > > > > ----- Original Message ----- > > > From: "Ayal Baron" <abaron(a)redhat.com&gt; > > > To: "Maor" <mlipchuk(a)redhat.com&gt; > > > Cc: engine-devel(a)ovirt.org, "Jon Choate" <jchoate(a)redhat.com&gt;, > > > "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > > > Sent: Tuesday, January 17, 2012 10:21:29 PM > > > Subject: Re: Shared disk / Floating disk import/export (was: > > > Re: > > > [Engine-devel] move disk command) > > > > > > > > > > > > ----- Original Message ----- > > > > On 01/17/2012 11:57 AM, Omer Frenkel wrote: > > > > > > > > > > > > > > > ----- Original Message ----- > > > > >> From: "Ayal Baron" <abaron(a)redhat.com&gt; > > > > >> To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > > > > >> Cc: engine-devel(a)ovirt.org, "Jon Choate" > > > > >> <jchoate(a)redhat.com&gt; > > > > >> Sent: Tuesday, January 17, 2012 10:45:53 AM > > > > >> Subject: Shared disk / Floating disk import/export (was: > > > > >> Re: > > > > >> [Engine-devel] move disk command) > > > > >> > > > > >> > > > > >> [SNIP] > > > > >> > > > > >>>>> This may be unrelated, but user would be allowed to > > > > >>>>> export > > > > >>>>> and > > > > >>>>> import a floating disk, right? > > > > >>>>> I would like the ability to import *any* disk in the > > > > >>>>> export > > > > >>>>> domain > > > > >>>>> as a floating disk, but in the least, export and import > > > > >>>>> disks > > > > >>>>> not > > > > >>>>> associated with a VM. > > > > >>> > > > > >>> you are right, it is unrelated, this thread is about move > > > > >>> disk > > > > >>> of > > > > >>> a > > > > >>> vm between SDs, > > > > >>> export and import is copy, and floating disks is part of > > > > >>> the > > > > >>> shared > > > > >>> disk feature, > > > > >>> this indeed need to be discussed in that scope. > > > > >> > > > > >> Ok, so I've changed the subject, now let's discuss it. > > > > >> > > > > > > > > > > Adding Maor, > > > > > not sure if we have any plan regard export/import of > > > > > floating > > > > > disk, > > > > > or in general, exporting disk without it's vm (if I > > > > > understood > > > > > Ayal > > > > > correctly) > > > > > > > > > > Maor, any comments? > > > > I remember, we mentioned export/import issue in our last > > > > meeting > > > > with > > > > Andrew in the context of shared raw disk. > > > > It was decided then, that export/import will not be supported > > > > by > > > > shared > > > > raw disk, I'm not sure if we also decided that for floating > > > > disk, > > > > but I think its a PM decision. > > > > > > > > Support import/export domain might evolve to a big change, > > > > since > > > > if > > > > we > > > > want to export disk, we might also want to reflect all its > > > > configuration > > > > and functionality there, also reflect disks which are > > > > attached > > > > to > > > > VMs > > > > and templates as well. > > > > > > What properties does a disk have? > > > Interface is what type of connection is used when plugging the > > > disk > > > in the computer (VM) so it's not really a disk property. > > > Address is also VM specific > > > Description is already stored in storage side. > > > What else do you have for disk? > > > > type (system/data..) > > Didn't we recently have a discussion about this being irrelevant? as long it is visible to the user, no.

> > > post-zero > > Can assume always true i disagree

> > > name(?) > > This exists on storage side in addition to description?

> > > creation-date > > When imported no!

> > > last modify date > > This exists on storage side > > > application-list > > Has nothing to do with disk, it's a VM property no!

> > > volume type and format > > This exists on storage side > > > > > > > > > Note that being able to import floating disks means that we'd > > > be > > > able > > > to take any data storage domain and import any disk(s) from it > > > (assuming user changes domain type to export domain, which > > > users > > > already know how to do) > > > > > > > > >

----- Original Message ----- > > > ----- Original Message ----- > > > > > > ----- Original Message ----- > > > From: "Ayal Baron" <abaron(a)redhat.com&gt; > > > To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > > > Cc: engine-devel(a)ovirt.org, "Jon Choate" <jchoate(a)redhat.com&gt;, > > > "Maor" <mlipchuk(a)redhat.com&gt; > > > Sent: Wednesday, January 18, 2012 10:20:01 AM > > > Subject: Re: Shared disk / Floating disk import/export (was: > > > Re: > > > [Engine-devel] move disk command) > > > > > > > > > > > > ----- Original Message ----- > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Ayal Baron" <abaron(a)redhat.com&gt; > > > > > To: "Maor" <mlipchuk(a)redhat.com&gt; > > > > > Cc: engine-devel(a)ovirt.org, "Jon Choate" > > > > > <jchoate(a)redhat.com&gt;, > > > > > "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > > > > > Sent: Tuesday, January 17, 2012 10:21:29 PM > > > > > Subject: Re: Shared disk / Floating disk import/export > > > > > (was: > > > > > Re: > > > > > [Engine-devel] move disk command) > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > On 01/17/2012 11:57 AM, Omer Frenkel wrote: > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > >> From: "Ayal Baron" <abaron(a)redhat.com&gt; > > > > > > >> To: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > > > > > > >> Cc: engine-devel(a)ovirt.org, "Jon Choate" > > > > > > >> <jchoate(a)redhat.com&gt; > > > > > > >> Sent: Tuesday, January 17, 2012 10:45:53 AM > > > > > > >> Subject: Shared disk / Floating disk import/export > > > > > > >> (was: > > > > > > >> Re: > > > > > > >> [Engine-devel] move disk command) > > > > > > >> > > > > > > >> > > > > > > >> [SNIP] > > > > > > >> > > > > > > >>>>> This may be unrelated, but user would be allowed to > > > > > > >>>>> export > > > > > > >>>>> and > > > > > > >>>>> import a floating disk, right? > > > > > > >>>>> I would like the ability to import *any* disk in > > > > > > >>>>> the > > > > > > >>>>> export > > > > > > >>>>> domain > > > > > > >>>>> as a floating disk, but in the least, export and > > > > > > >>>>> import > > > > > > >>>>> disks > > > > > > >>>>> not > > > > > > >>>>> associated with a VM. > > > > > > >>> > > > > > > >>> you are right, it is unrelated, this thread is about > > > > > > >>> move > > > > > > >>> disk > > > > > > >>> of > > > > > > >>> a > > > > > > >>> vm between SDs, > > > > > > >>> export and import is copy, and floating disks is part > > > > > > >>> of > > > > > > >>> the > > > > > > >>> shared > > > > > > >>> disk feature, > > > > > > >>> this indeed need to be discussed in that scope. > > > > > > >> > > > > > > >> Ok, so I've changed the subject, now let's discuss it. > > > > > > >> > > > > > > > > > > > > > > Adding Maor, > > > > > > > not sure if we have any plan regard export/import of > > > > > > > floating > > > > > > > disk, > > > > > > > or in general, exporting disk without it's vm (if I > > > > > > > understood > > > > > > > Ayal > > > > > > > correctly) > > > > > > > > > > > > > > Maor, any comments? > > > > > > I remember, we mentioned export/import issue in our last > > > > > > meeting > > > > > > with > > > > > > Andrew in the context of shared raw disk. > > > > > > It was decided then, that export/import will not be > > > > > > supported > > > > > > by > > > > > > shared > > > > > > raw disk, I'm not sure if we also decided that for > > > > > > floating > > > > > > disk, > > > > > > but I think its a PM decision. > > > > > > > > > > > > Support import/export domain might evolve to a big > > > > > > change, > > > > > > since > > > > > > if > > > > > > we > > > > > > want to export disk, we might also want to reflect all > > > > > > its > > > > > > configuration > > > > > > and functionality there, also reflect disks which are > > > > > > attached > > > > > > to > > > > > > VMs > > > > > > and templates as well. > > > > > > > > > > What properties does a disk have? > > > > > Interface is what type of connection is used when plugging > > > > > the > > > > > disk > > > > > in the computer (VM) so it's not really a disk property. > > > > > Address is also VM specific > > > > > Description is already stored in storage side. > > > > > What else do you have for disk? > > > > > > > > type (system/data..) > > > > > > Didn't we recently have a discussion about this being > > > irrelevant? > > > > as long it is visible to the user, no. > > It's meaningless. > > > > > > > > > > post-zero > > > > > > Can assume always true > > > > i disagree > > It's the default behaviour for files, no reason to not allow users > to > import disk because of this. > > > > > > > > > > name(?) > > > > > > This exists on storage side > > > > in addition to description? > > there is uuid and description, do you store in addition another > name? > > > > > > > > > > creation-date > > > > > > When imported > > > > no! > > Hmmm, I love how elaborate your explanations are. > It's common with files, no reason to treat differently. > > > > > > > > > > last modify date > > > > > > This exists on storage side > > > > > > > application-list > > > > > > Has nothing to do with disk, it's a VM property > > > > no! > > Again, very elaborate... > VM has 3 disks, guest reports app-list for the VM, how do you > determine which disk has which apps? > If this is currently a disk property in engine then it's a bug. I think this is a snapshot's property.

> > > > > > > > > > volume type and format > > > > > > This exists on storage side > > > > > > > > > > > > > > > > > Note that being able to import floating disks means that > > > > > we'd > > > > > be > > > > > able > > > > > to take any data storage domain and import any disk(s) from > > > > > it > > > > > (assuming user changes domain type to export domain, which > > > > > users > > > > > already know how to do) > > > > > > > > > > > > > > > > > > > > _______________________________________________ > Engine-devel mailing list > Engine-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel >

----- Original Message ----- > From: "Omer Frenkel" <ofrenkel(a)redhat.com&gt; > To: "Jon Choate" <jchoate(a)redhat.com&gt; > Cc: engine-devel(a)ovirt.org > Sent: Tuesday, January 17, 2012 10:41:43 AM > Subject: Re: [Engine-devel] move disk command > > > > ----- Original Message ----- >> From: "Jon Choate" <jchoate(a)redhat.com&gt; >> To: "Ayal Baron" <abaron(a)redhat.com&gt; >> Cc: engine-devel(a)ovirt.org >> Sent: Monday, January 16, 2012 9:39:55 PM >> Subject: Re: [Engine-devel] move disk command >> >> On 01/16/2012 02:26 PM, Ayal Baron wrote: >>> >>> ----- Original Message ----- >>>> On 01/16/2012 05:26 PM, Jon Choate wrote: >>>>> As part of the multiple storage domains feature there will be >>>>> new >>>>> functionality added to allow users to move individual disks. >>>>> >>>>> What are the prerequisites for moving a disk? >>>>> >>>>> 1) the disk must exist >>>>> 2) the associated VM must be down >>>> this can't just be a CanDoAction check - the lock has to be real >>>> to >>>> prevent a race from starting the VM after the validation. >>>> >>> Either down or disk is unplugged. >>> >>>>> 3) the associated VM must not be locked >>>>> 4) the source storage domain must exist >>>>> 5) the source storage domain must be available >>>>> 6) the target domain must exist >>>>> 7) the target domain must be available >>>>> 8) the target domain must have adequate disk space >>>>> 9) the target domain cannot be an ISO or export domain >>>>> 10) the source domain cannot be an ISO or export domain >>> This may be unrelated, but user would be allowed to export and >>> import a floating disk, right? >>> I would like the ability to import *any* disk in the export >>> domain >>> as a floating disk, but in the least, export and import disks not >>> associated with a VM. > > you are right, it is unrelated, this thread is about move disk of a > vm between SDs, > export and import is copy, and floating disks is part of the shared > disk feature, > this indeed need to be discussed in that scope. So what is the behavior of a move of a floating disk? can I move any type of disk? (shared?) between SDs?