11:08 p.m.
with gerrit 2.8, there is a new change screen.
its not enabled by default (yet), please use and see what you think.
to enable, go to settings (click the top-right arrow next to your name,
and choose settings).
select preferences and set "Change View:" to "New Screen".
Thanks,
Itamar
10:38 a.m.
On 01/15/2014 11:08 PM, Itamar Heim wrote:
with gerrit 2.8, there is a new change screen.
its not enabled by default (yet), please use and see what you think.
to enable, go to settings (click the top-right arrow next to your
name, and choose settings).
select preferences and set "Change View:" to "New Screen".
Well
I had this enabled for some time today but I had to switch back,
since I don't see how I am able to apply code review +/- or anything
like this.
On the other hand, it is way faster on the diff view even for vdsm's
vm.py which has a whopping 5k lines. I like that :-)
This new change screen is something one really needs to get used to.
Thanks,
Itamar
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
--
Regards,
Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: +420 532 294 625
IRC: vfeenstr or evilissimo
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
10:40 a.m.
On 01/16/2014 10:38 AM, Vinzenz Feenstra wrote:
On 01/15/2014 11:08 PM, Itamar Heim wrote:
> with gerrit 2.8, there is a new change screen.
> its not enabled by default (yet), please use and see what you think.
>
> to enable, go to settings (click the top-right arrow next to your
> name, and choose settings).
> select preferences and set "Change View:" to "New Screen".
Well I had this enabled for some time today but I had to switch back,
since I don't see how I am able to apply code review +/- or anything
like this.
Correction, I just found it. It's hidden under the
"Reply..." button
On the other hand, it is way faster on the diff view even for vdsm's
vm.py which has a whopping 5k lines. I like that :-)
This new change screen is something one really needs to get used to.
>
> Thanks,
> Itamar
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
--
Regards,
Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: +420 532 294 625
IRC: vfeenstr or evilissimo
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
10:52 a.m.
----- Original Message -----
From: "Vinzenz Feenstra" <vfeenstr(a)redhat.com>
To: "Itamar Heim" <iheim(a)redhat.com>, vdsm-devel(a)lists.fedorahosted.org,
"engine-devel" <engine-devel(a)ovirt.org>
Sent: Thursday, January 16, 2014 11:40:01 AM
Subject: Re: [Engine-devel] Gerrit NEW Change Screen
On 01/16/2014 10:38 AM, Vinzenz Feenstra wrote:
> On 01/15/2014 11:08 PM, Itamar Heim wrote:
>> with gerrit 2.8, there is a new change screen.
>> its not enabled by default (yet), please use and see what you think.
>>
>> to enable, go to settings (click the top-right arrow next to your
>> name, and choose settings).
>> select preferences and set "Change View:" to "New Screen".
> Well I had this enabled for some time today but I had to switch back,
> since I don't see how I am able to apply code review +/- or anything
> like this.
Correction, I just found it. It's hidden under the "Reply..." button
And if you hover on it you see that you can also press 'a'. In 2.6 'r'
did this, not sure why they had to change that. And if you press 'r'
inside a diff you get to the old review/reply page...
>
> On the other hand, it is way faster on the diff view even for vdsm's
> vm.py which has a whopping 5k lines. I like that :-)
>
> This new change screen is something one really needs to get used to.
Indeed.
One thing I like in it is that in "History" it shows also all the inline
comments.
And one thing I miss is a solution to [1] - am I the only one bugged by it?
[1] http://code.google.com/p/gerrit/issues/detail?id=217
--
Didi
10:58 a.m.
On 01/16/2014 10:52 AM, Yedidyah Bar David wrote:
----- Original Message -----
> From: "Vinzenz Feenstra" <vfeenstr(a)redhat.com>
> To: "Itamar Heim" <iheim(a)redhat.com>,
vdsm-devel(a)lists.fedorahosted.org, "engine-devel"
<engine-devel(a)ovirt.org>
> Sent: Thursday, January 16, 2014 11:40:01 AM
> Subject: Re: [Engine-devel] Gerrit NEW Change Screen
>
> On 01/16/2014 10:38 AM, Vinzenz Feenstra wrote:
>> On 01/15/2014 11:08 PM, Itamar Heim wrote:
>>> with gerrit 2.8, there is a new change screen.
>>> its not enabled by default (yet), please use and see what you think.
>>>
>>> to enable, go to settings (click the top-right arrow next to your
>>> name, and choose settings).
>>> select preferences and set "Change View:" to "New
Screen".
>> Well I had this enabled for some time today but I had to switch back,
>> since I don't see how I am able to apply code review +/- or anything
>> like this.
> Correction, I just found it. It's hidden under the "Reply..." button
And if you hover on it you see that you can also press 'a'. In 2.6 'r'
did this, not sure why they had to change that. And if you press 'r'
inside a diff you get to the old review/reply page...
>> On the other hand, it is way faster on the diff view even for vdsm's
>> vm.py which has a whopping 5k lines. I like that :-)
>>
>> This new change screen is something one really needs to get used to.
Indeed.
One thing I like in it is that in "History" it shows also all the inline
comments.
And one thing I miss is a solution to [1] - am I the only one bugged by it?
No, I
am also not a big fan about it, but this is not a regression to
the previous version, thanks for the link :-)
--
Regards,
Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: +420 532 294 625
IRC: vfeenstr or evilissimo
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
2:16 p.m.
On 16/01/14 00:08 +0200, Itamar Heim wrote:
with gerrit 2.8, there is a new change screen.
its not enabled by default (yet), please use and see what you think.
to enable, go to settings (click the top-right arrow next to your
name, and choose settings).
select preferences and set "Change View:" to "New Screen".
Thanks Itamar. For me, this new screen is much better. Things are
more compact and for most patches all of the important information
fits easily on one screen. I also like the easy to find gitweb link
and the ability to edit the commit message right from the interface.
3:31 p.m.
New subject: [Engine-devel] [vdsm] Gerrit NEW Change Screen
On Thu, Jan 16, 2014 at 08:16:17AM -0500, Adam Litke wrote:
On 16/01/14 00:08 +0200, Itamar Heim wrote:
>with gerrit 2.8, there is a new change screen.
>its not enabled by default (yet), please use and see what you think.
>
>to enable, go to settings (click the top-right arrow next to your
>name, and choose settings).
>select preferences and set "Change View:" to "New Screen".
Thanks Itamar. For me, this new screen is much better. Things are
more compact and for most patches all of the important information
fits easily on one screen. I also like the easy to find gitweb link
and the ability to edit the commit message right from the interface.
On my narrow lcd, though, the new look makes comments in diff to be seen
only partially. I failed to find a configurable to make the comment
windows narrower, so my only solution is to reduce the font (which is
bad for my poor old eyes).
7:58 p.m.
On 01/16/2014 12:08 AM, Itamar Heim wrote:
with gerrit 2.8, there is a new change screen.
its not enabled by default (yet), please use and see what you think.
to enable, go to settings (click the top-right arrow next to your name,
and choose settings).
select preferences and set "Change View:" to "New Screen".
Thanks,
Itamar
more details on the new change screen:
https://gerrit-review.googlesource.com/Documentation/intro-change-screen....
The main highlights are under the hood:
Old style RPC calls are replaced by the REST API
The prettify syntax highlighting library was replaced by Codemirror
Automatic refresh of open changes
Support to download a patch direct in browser: no local repo is needed
JS API integration: it was never so easy to add change/revision actions to the UI
from a plugin.
and:
Included in
To see the branches a specific change was merged into and the list of the tags a change
was tagged with, use the Included In drop down on the change header, to the left of the
Revisions drop down.
Note that this list is only visible on merged changes.
and
"Related changes
Conflicts With Changes
Changes that are conflicting with the current change are listed on this tab. Only the
changes that are mergeable are currently shown. Non mergeable changes are filtered out.
This tab is only visible if there are conflicting changes with the current change.
8:12 a.m.
On 01/16/2014 12:08 AM, Itamar Heim wrote:
with gerrit 2.8, there is a new change screen.
its not enabled by default (yet), please use and see what you think.
to enable, go to settings (click the top-right arrow next to your
name, and choose settings).
select preferences and set "Change View:" to "New Screen".
Thanks,
Itamar
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
+1 needs some time to get used
to the new layout but overall its way
better to have the patch dependency ("Related")
and better without the cluttered patch-sets view.
reminds me of gitk somewhat...
11:38 a.m.
----- Original Message -----
From: "Roy Golan" <rgolan(a)redhat.com>
To: "Itamar Heim" <iheim(a)redhat.com>, vdsm-devel(a)lists.fedorahosted.org,
"engine-devel" <engine-devel(a)ovirt.org>
Sent: Sunday, January 26, 2014 9:12:38 AM
Subject: Re: [Engine-devel] Gerrit NEW Change Screen
On 01/16/2014 12:08 AM, Itamar Heim wrote:
> with gerrit 2.8, there is a new change screen.
> its not enabled by default (yet), please use and see what you think.
>
> to enable, go to settings (click the top-right arrow next to your
> name, and choose settings).
> select preferences and set "Change View:" to "New Screen".
I had found that the new window truncates the code
See for example line 115 in
http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/...
Switching to the old view will show all the line while in the new one it is truncated
>
> Thanks,
> Itamar
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
+1 needs some time to get used to the new layout but overall its way
better to have the patch dependency ("Related")
and better without the cluttered patch-sets view.
reminds me of gitk somewhat...
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
11:39 a.m.
On 01/26/2014 12:38 PM, Eli Mesika wrote:
----- Original Message -----
> From: "Roy Golan" <rgolan(a)redhat.com>
> To: "Itamar Heim" <iheim(a)redhat.com>,
vdsm-devel(a)lists.fedorahosted.org, "engine-devel"
<engine-devel(a)ovirt.org>
> Sent: Sunday, January 26, 2014 9:12:38 AM
> Subject: Re: [Engine-devel] Gerrit NEW Change Screen
>
> On 01/16/2014 12:08 AM, Itamar Heim wrote:
>> with gerrit 2.8, there is a new change screen.
>> its not enabled by default (yet), please use and see what you think.
>>
>> to enable, go to settings (click the top-right arrow next to your
>> name, and choose settings).
>> select preferences and set "Change View:" to "New Screen".
I had found that the new window truncates the code
See for example line 115 in
http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/...
Switching to the old view will show all the line while in the new one it is truncated
open a bug on gerrit upstream?
>>
>> Thanks,
>> Itamar
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> +1 needs some time to get used to the new layout but overall its way
> better to have the patch dependency ("Related")
> and better without the cluttered patch-sets view.
> reminds me of gitk somewhat...
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
12:02 p.m.
----- Original Message -----
From: "Itamar Heim" <iheim(a)redhat.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: vdsm-devel(a)lists.fedorahosted.org, "engine-devel"
<engine-devel(a)ovirt.org>
Sent: Sunday, January 26, 2014 12:39:19 PM
Subject: Re: [Engine-devel] Gerrit NEW Change Screen
On 01/26/2014 12:38 PM, Eli Mesika wrote:
>
>
> ----- Original Message -----
>> From: "Roy Golan" <rgolan(a)redhat.com>
>> To: "Itamar Heim" <iheim(a)redhat.com>,
vdsm-devel(a)lists.fedorahosted.org,
>> "engine-devel" <engine-devel(a)ovirt.org>
>> Sent: Sunday, January 26, 2014 9:12:38 AM
>> Subject: Re: [Engine-devel] Gerrit NEW Change Screen
>>
>> On 01/16/2014 12:08 AM, Itamar Heim wrote:
>>> with gerrit 2.8, there is a new change screen.
>>> its not enabled by default (yet), please use and see what you think.
>>>
>>> to enable, go to settings (click the top-right arrow next to your
>>> name, and choose settings).
>>> select preferences and set "Change View:" to "New
Screen".
>
> I had found that the new window truncates the code
> See for example line 115 in
>
http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/...
> Switching to the old view will show all the line while in the new one it is
> truncated
open a bug on gerrit upstream?
done
>
>>>
>>> Thanks,
>>> Itamar
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel(a)ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>> +1 needs some time to get used to the new layout but overall its way
>> better to have the patch dependency ("Related")
>> and better without the cluttered patch-sets view.
>> reminds me of gitk somewhat...
>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
12:06 p.m.
On 01/26/2014 01:02 PM, Eli Mesika wrote:
----- Original Message -----
> From: "Itamar Heim" <iheim(a)redhat.com>
> To: "Eli Mesika" <emesika(a)redhat.com>
> Cc: vdsm-devel(a)lists.fedorahosted.org, "engine-devel"
<engine-devel(a)ovirt.org>
> Sent: Sunday, January 26, 2014 12:39:19 PM
> Subject: Re: [Engine-devel] Gerrit NEW Change Screen
>
> On 01/26/2014 12:38 PM, Eli Mesika wrote:
>>
>>
>> ----- Original Message -----
>>> From: "Roy Golan" <rgolan(a)redhat.com>
>>> To: "Itamar Heim" <iheim(a)redhat.com>,
vdsm-devel(a)lists.fedorahosted.org,
>>> "engine-devel" <engine-devel(a)ovirt.org>
>>> Sent: Sunday, January 26, 2014 9:12:38 AM
>>> Subject: Re: [Engine-devel] Gerrit NEW Change Screen
>>>
>>> On 01/16/2014 12:08 AM, Itamar Heim wrote:
>>>> with gerrit 2.8, there is a new change screen.
>>>> its not enabled by default (yet), please use and see what you think.
>>>>
>>>> to enable, go to settings (click the top-right arrow next to your
>>>> name, and choose settings).
>>>> select preferences and set "Change View:" to "New
Screen".
>>
>> I had found that the new window truncates the code
>> See for example line 115 in
>>
http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/...
>> Switching to the old view will show all the line while in the new one it is
>> truncated
>
> open a bug on gerrit upstream?
done
btw, i really like the new feature on this screen of the
right-lower-corner notification that someone else updated this change
since i opened it on my screen.
8:05 a.m.
----- Original Message -----
----- Original Message -----
> From: "Roy Golan" <rgolan(a)redhat.com>
> To: "Itamar Heim" <iheim(a)redhat.com>,
vdsm-devel(a)lists.fedorahosted.org,
> "engine-devel" <engine-devel(a)ovirt.org>
> Sent: Sunday, January 26, 2014 9:12:38 AM
> Subject: Re: [Engine-devel] Gerrit NEW Change Screen
>
> On 01/16/2014 12:08 AM, Itamar Heim wrote:
> > with gerrit 2.8, there is a new change screen.
> > its not enabled by default (yet), please use and see what you think.
> >
> > to enable, go to settings (click the top-right arrow next to your
> > name, and choose settings).
> > select preferences and set "Change View:" to "New Screen".
I had found that the new window truncates the code
See for example line 115 in
http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/...
Switching to the old view will show all the line while in the new one it is
truncated
It's just enforcing a certain line length (which this code obviously violates) ;)
I found that if you change the zoom on the page you'll get a scrollbar at the bottom
so the line can be fully viewed..
> >
> > Thanks,
> > Itamar
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel(a)ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> +1 needs some time to get used to the new layout but overall its way
> better to have the patch dependency ("Related")
> and better without the cluttered patch-sets view.
> reminds me of gitk somewhat...
>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
8:58 a.m.
----- Original Message -----
From: "Mike Kolesnik" <mkolesni(a)redhat.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
Sent: Tuesday, January 28, 2014 9:05:21 AM
Subject: Re: [Engine-devel] Gerrit NEW Change Screen
----- Original Message -----
>
>
> ----- Original Message -----
> > From: "Roy Golan" <rgolan(a)redhat.com>
> > To: "Itamar Heim" <iheim(a)redhat.com>,
vdsm-devel(a)lists.fedorahosted.org,
> > "engine-devel" <engine-devel(a)ovirt.org>
> > Sent: Sunday, January 26, 2014 9:12:38 AM
> > Subject: Re: [Engine-devel] Gerrit NEW Change Screen
> >
> > On 01/16/2014 12:08 AM, Itamar Heim wrote:
> > > with gerrit 2.8, there is a new change screen.
> > > its not enabled by default (yet), please use and see what you think.
> > >
> > > to enable, go to settings (click the top-right arrow next to your
> > > name, and choose settings).
> > > select preferences and set "Change View:" to "New
Screen".
>
> I had found that the new window truncates the code
> See for example line 115 in
>
http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/...
> Switching to the old view will show all the line while in the new one it is
> truncated
It's just enforcing a certain line length (which this code obviously
violates) ;)
I found that if you change the zoom on the page you'll get a scrollbar at the
bottom so the line can be fully viewed..
Thanks for the workaround , it is still a bug not showing the full line...
>
> > >
> > > Thanks,
> > > Itamar
> > > _______________________________________________
> > > Engine-devel mailing list
> > > Engine-devel(a)ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > +1 needs some time to get used to the new layout but overall its way
> > better to have the patch dependency ("Related")
> > and better without the cluttered patch-sets view.
> > reminds me of gitk somewhat...
> >
> >
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel(a)ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
3761
days inactive
3775
days old
14 comments
8 participants
participants (8)
-
Adam Litke -
Dan Kenigsberg -
Eli Mesika -
Itamar Heim -
Mike Kolesnik -
Roy Golan -
Vinzenz Feenstra -
Yedidyah Bar David