[Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch

Hi Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!! We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of 1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise. Thanks for your cooperation Eli

We should add a gerrit hook to enforce the right naming/version of db upgrade scripts. Thanks Barak Azulay ----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, October 24, 2013 6:49:21 PM Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Hi
Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!!
We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of
1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix
I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise.
Thanks for your cooperation
Eli _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

there are already in place gerrit jobs for all flows, only this was introduced before they were added: ovirt_engine_3.2_update_db_to_3.3_gerrit ovirt_engine_3.3.0_update_db_to_3.3_gerrit ovirt_engine_3.3.1_update_db_to_3.3_gerrit ovirt_engine_3.3_update_db_to_master_gerrit ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit ovirt_engine_master_update_db_to_master_gerrit ovirt_engine_3.3_update_db_to_3.3_latest_gerrit ----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org, "Eyal Edri" <eedri@redhat.com> Sent: Thursday, October 24, 2013 7:13:04 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
We should add a gerrit hook to enforce the right naming/version of db upgrade scripts.
Thanks Barak Azulay
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, October 24, 2013 6:49:21 PM Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Hi
Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!!
We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of
1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix
I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise.
Thanks for your cooperation
Eli _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

Even better, When will these hooks be effective on engine master & ovirt-3.3 ? Barak ----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 7:20:11 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
there are already in place gerrit jobs for all flows, only this was introduced before they were added:
ovirt_engine_3.2_update_db_to_3.3_gerrit ovirt_engine_3.3.0_update_db_to_3.3_gerrit ovirt_engine_3.3.1_update_db_to_3.3_gerrit ovirt_engine_3.3_update_db_to_master_gerrit ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit ovirt_engine_master_update_db_to_master_gerrit ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org, "Eyal Edri" <eedri@redhat.com> Sent: Thursday, October 24, 2013 7:13:04 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
We should add a gerrit hook to enforce the right naming/version of db upgrade scripts.
Thanks Barak Azulay
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, October 24, 2013 6:49:21 PM Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Hi
Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!!
We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of
1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix
I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise.
Thanks for your cooperation
Eli _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

already active. ----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 8:12:27 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Even better,
When will these hooks be effective on engine master & ovirt-3.3 ?
Barak
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 7:20:11 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
there are already in place gerrit jobs for all flows, only this was introduced before they were added:
ovirt_engine_3.2_update_db_to_3.3_gerrit ovirt_engine_3.3.0_update_db_to_3.3_gerrit ovirt_engine_3.3.1_update_db_to_3.3_gerrit ovirt_engine_3.3_update_db_to_master_gerrit ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit ovirt_engine_master_update_db_to_master_gerrit ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org, "Eyal Edri" <eedri@redhat.com> Sent: Thursday, October 24, 2013 7:13:04 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
We should add a gerrit hook to enforce the right naming/version of db upgrade scripts.
Thanks Barak Azulay
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, October 24, 2013 6:49:21 PM Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Hi
Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!!
We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of
1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix
I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise.
Thanks for your cooperation
Eli _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 8:42:46 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
already active.
I may be missing something, so how wasn't it caught by those hooks ?
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 8:12:27 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Even better,
When will these hooks be effective on engine master & ovirt-3.3 ?
Barak
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 7:20:11 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
there are already in place gerrit jobs for all flows, only this was introduced before they were added:
ovirt_engine_3.2_update_db_to_3.3_gerrit ovirt_engine_3.3.0_update_db_to_3.3_gerrit ovirt_engine_3.3.1_update_db_to_3.3_gerrit ovirt_engine_3.3_update_db_to_master_gerrit ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit ovirt_engine_master_update_db_to_master_gerrit ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org, "Eyal Edri" <eedri@redhat.com> Sent: Thursday, October 24, 2013 7:13:04 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
We should add a gerrit hook to enforce the right naming/version of db upgrade scripts.
Thanks Barak Azulay
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, October 24, 2013 6:49:21 PM Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Hi
Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!!
We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of
1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix
I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise.
Thanks for your cooperation
Eli _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Sunday, October 27, 2013 12:49:33 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 8:42:46 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
already active.
I may be missing something, so how wasn't it caught by those hooks ?
1. job was added AFTER failure was introduced (flow from 3.3 -> master). 2. job will now fail on every patch until issue is fixed.
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 8:12:27 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Even better,
When will these hooks be effective on engine master & ovirt-3.3 ?
Barak
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 7:20:11 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
there are already in place gerrit jobs for all flows, only this was introduced before they were added:
ovirt_engine_3.2_update_db_to_3.3_gerrit ovirt_engine_3.3.0_update_db_to_3.3_gerrit ovirt_engine_3.3.1_update_db_to_3.3_gerrit ovirt_engine_3.3_update_db_to_master_gerrit ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit ovirt_engine_master_update_db_to_master_gerrit ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org, "Eyal Edri" <eedri@redhat.com> Sent: Thursday, October 24, 2013 7:13:04 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
We should add a gerrit hook to enforce the right naming/version of db upgrade scripts.
Thanks Barak Azulay
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "engine-devel" <engine-devel@ovirt.org> Sent: Thursday, October 24, 2013 6:49:21 PM Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Hi
Please note that any upgrade script introduced to the master branch should have the 03_04 prefix. If this script is resolving a blocker/exception BZ it should be ported to the ovirt-engine-3.3 branch with a 03_03 prefix !!!
We have encountered some patches that broke the upgrade from ovirt-engine-3.3 to master as a result of
1) naming new upgrade scripts in master branch with 03_03 prefix 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04 prefix
I am available for any question and asking you to add me to any DB related script as a reviewer even if I +2 the master patch and you just back-port it to ovirt-engine-3.3. It may save us a lot of noise.
Thanks for your cooperation
Eli _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Sunday, October 27, 2013 12:57:23 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Sunday, October 27, 2013 12:49:33 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 8:42:46 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
already active.
I may be missing something, so how wasn't it caught by those hooks ?
1. job was added AFTER failure was introduced (flow from 3.3 -> master). 2. job will now fail on every patch until issue is fixed.
Great, Thanks
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 8:12:27 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
Even better,
When will these hooks be effective on engine master & ovirt-3.3 ?
Barak
----- Original Message -----
From: "Eyal Edri" <eedri@redhat.com> To: "Barak Azulay" <bazulay@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org Sent: Thursday, October 24, 2013 7:20:11 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
there are already in place gerrit jobs for all flows, only this was introduced before they were added:
ovirt_engine_3.2_update_db_to_3.3_gerrit ovirt_engine_3.3.0_update_db_to_3.3_gerrit ovirt_engine_3.3.1_update_db_to_3.3_gerrit ovirt_engine_3.3_update_db_to_master_gerrit ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit ovirt_engine_master_update_db_to_master_gerrit ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
----- Original Message -----
From: "Barak Azulay" <bazulay@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, infra@ovirt.org, "Eyal Edri" <eedri@redhat.com> Sent: Thursday, October 24, 2013 7:13:04 PM Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch
We should add a gerrit hook to enforce the right naming/version of db upgrade scripts.
Thanks Barak Azulay
----- Original Message ----- > From: "Eli Mesika" <emesika@redhat.com> > To: "engine-devel" <engine-devel@ovirt.org> > Sent: Thursday, October 24, 2013 6:49:21 PM > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master > and > for > stable branch > > Hi > > Please note that any upgrade script introduced to the master > branch > should > have the 03_04 prefix. > If this script is resolving a blocker/exception BZ it should be > ported > to > the > ovirt-engine-3.3 branch with a 03_03 prefix !!! > > We have encountered some patches that broke the upgrade from > ovirt-engine-3.3 > to master as a result of > > 1) naming new upgrade scripts in master branch with 03_03 prefix > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch > with > 03_04 > prefix > > I am available for any question and asking you to add me to any > DB > related > script as a reviewer even if I +2 the master patch and you just > back-port > it > to ovirt-engine-3.3. > It may save us a lot of noise. > > Thanks for your cooperation > > Eli > _______________________________________________ > Engine-devel mailing list > Engine-devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > >
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

On 10/27/2013 12:57 PM, Eyal Edri wrote:
1. job was added AFTER failure was introduced (flow from 3.3 -> master). 2. job will now fail on every patch until issue is fixed.
already proven itself today...
participants (4)
-
Barak Azulay
-
Eli Mesika
-
Eyal Edri
-
Itamar Heim