Adjust engine to support arbitrary vlan device name
Hi all, This refactoring is targeted to 3.5. Please review the feature page and share your thoughts: http://www.ovirt.org/Feature/ArbitraryVlanDeviceName Thanks, Alona
Am 30.04.2014 09:54, schrieb Alona Kaplan:
Hi all,
This refactoring is targeted to 3.5.
Please review the feature page and share your thoughts:
Does this have any drawbacks when you use REST to work with vlans ? I guess not? -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH & Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
----- Original Message -----
From: "Sven Kieske" <S.Kieske@mittwald.de> To: devel@ovirt.org Sent: Wednesday, April 30, 2014 12:19:23 PM Subject: Re: [ovirt-devel] Adjust engine to support arbitrary vlan device name
Am 30.04.2014 09:54, schrieb Alona Kaplan:
Hi all,
This refactoring is targeted to 3.5.
Please review the feature page and share your thoughts:
Does this have any drawbacks when you use REST to work with vlans ? I guess not?
Hi Sven, Thanks for the comment! I"ve added REST api section to the feature page. REST Api base_interface property will be received on GET VdsNetworkInterface. Changes in "setupnetworks" ACTION- 1. If the base_interface is specified, it will be used instead of determining it from the device name. (The device name will be ignored). 2. If not, the base_interface name will be determined from the device name as before. (This should be done to keep backward compatibility).
-- Mit freundlichen Grüßen / Regards
Sven Kieske
Systemadministrator Mittwald CM Service GmbH & Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Very nice feature page. I think in UX you can add the VLAN tag in the VLAN column in the Network Interfaces sub tab under Host. Also from REST perspective you should allow to send the base interface for Setup Networks action, to explicitly specify which interface you're adding the network on, istead of relying on the interface name to implicitly state it. Regards, Mike ----- Original Message -----
Hi all,
This refactoring is targeted to 3.5.
Please review the feature page and share your thoughts:
http://www.ovirt.org/Feature/ArbitraryVlanDeviceName
Thanks, Alona _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Mike Kolesnik" <mkolesni@redhat.com> To: "Alona Kaplan" <alkaplan@redhat.com> Cc: devel@ovirt.org Sent: Wednesday, April 30, 2014 4:00:08 PM Subject: Re: [ovirt-devel] Adjust engine to support arbitrary vlan device name
Very nice feature page.
I think in UX you can add the VLAN tag in the VLAN column in the Network Interfaces sub tab under Host.
Also from REST perspective you should allow to send the base interface for Setup Networks action, to explicitly specify which interface you're adding the network on, istead of relying on the interface name to implicitly state it.
Regards, Mike
Thanks Mike! I"ve edited the feature page according to your comments.
----- Original Message -----
Hi all,
This refactoring is targeted to 3.5.
Please review the feature page and share your thoughts:
http://www.ovirt.org/Feature/ArbitraryVlanDeviceName
Thanks, Alona _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Hello, I'm just curious as to the restriction mentioned at the bottom of the feature page; it basically means that users who use customized VLAN device name can't perform networking operations from the engine involving those VLAN tags. Can't VDSM locate the proper device according to the VLAN tag and modify it instead of trying to create one with the "default" name? I'm no expert in VDSM, but it sounds like a relatively easy win. Yours, Lior. On 30/04/14 10:54, Alona Kaplan wrote:
Hi all,
This refactoring is targeted to 3.5.
Please review the feature page and share your thoughts:
http://www.ovirt.org/Feature/ArbitraryVlanDeviceName
Thanks, Alona _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (4)
-
Alona Kaplan -
Lior Vernia -
Mike Kolesnik -
Sven Kieske