[action required] vdsm build job failing on Fedora 20
Hi, VDSM build job is currently failing on Fedora 20 for all branches: 3.4: pep8 issues http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo... 3.5: infra issues http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo... master: infra issues http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1654/label=fedor... -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
----- Original Message -----
From: "Sandro Bonazzola" <sbonazzo@redhat.com> To: devel@ovirt.org, "infra" <infra@ovirt.org> Sent: Wednesday, July 23, 2014 10:19:43 AM Subject: [action required] vdsm build job failing on Fedora 20
Hi, VDSM build job is currently failing on Fedora 20 for all branches:
3.4: pep8 issues http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
07:51:15 /usr/bin/pep8 --version 07:51:15 1.5.6 This test is wrong in two ways: 1. There is no reason to check current source with pep8, only new changes. We should not change working code because new pep8 version changed the rules 2. This should not be part of the build. pep8 is a tool for checking new source before we add it. It does not validate the application in any way. To workaround this, either downgrade pep8 or disable this job.
3.5: infra issues http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
master: infra issues http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1654/label=fedor...
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
On Wed, Jul 23, 2014 at 06:04:06AM -0400, Nir Soffer wrote:
----- Original Message -----
From: "Sandro Bonazzola" <sbonazzo@redhat.com> To: devel@ovirt.org, "infra" <infra@ovirt.org> Sent: Wednesday, July 23, 2014 10:19:43 AM Subject: [action required] vdsm build job failing on Fedora 20
Hi, VDSM build job is currently failing on Fedora 20 for all branches:
3.4: pep8 issues http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
07:51:15 /usr/bin/pep8 --version 07:51:15 1.5.6
This test is wrong in two ways:
1. There is no reason to check current source with pep8, only new changes. We should not change working code because new pep8 version changed the rules 2. This should not be part of the build. pep8 is a tool for checking new source before we add it. It does not validate the application in any way.
To workaround this, either downgrade pep8 or disable this job.
... or disable pep8 in this specific job, by setting PEP8=true on the `make rpm` line.
participants (3)
-
Dan Kenigsberg -
Nir Soffer -
Sandro Bonazzola