pep8 & checkstyle are here again to bring an end to humanity

I can't compile the engine. Not sure should I laugh or cry. But you shouldn't be able to compile too. https://github.com/oVirt/ovirt-engine/commit/3d9d3b0aee17ff20d3303fd9f632975... is to blame, once I cut the line compilation is able to proceed. Not sure how it will go with ansible-runner-service yet... :) Fedor

Eitan, please fix ASAP On Tue, Mar 31, 2020 at 4:01 PM Fedor Gavrilov <fgavrilo@redhat.com> wrote:
I can't compile the engine. Not sure should I laugh or cry. But you shouldn't be able to compile too.
https://github.com/oVirt/ovirt-engine/commit/3d9d3b0aee17ff20d3303fd9f632975... is to blame, once I cut the line compilation is able to proceed. Not sure how it will go with ansible-runner-service yet... :)
Fedor _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QAA7QP4SY6Y42J...

On Tue, Mar 31, 2020 at 4:30 PM Tal Nisan <tnisan@redhat.com> wrote:
Eitan, please fix ASAP
Done: https://gerrit.ovirt.org/108126 https://gerrit.ovirt.org/108124 Apparently we didn't run pep8 at all since stopping building on el7...
On Tue, Mar 31, 2020 at 4:01 PM Fedor Gavrilov <fgavrilo@redhat.com> wrote:
I can't compile the engine. Not sure should I laugh or cry. But you shouldn't be able to compile too. https://github.com/oVirt/ovirt-engine/commit/3d9d3b0aee17ff20d3303fd9f632975... is to blame, once I cut the line compilation is able to proceed. Not sure how it will go with ansible-runner-service yet... :)
Fedor _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QAA7QP4SY6Y42J...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QXTCU3XZNV6QS2...
-- Didi

Fedor +1 for subject. On Wed, Apr 1, 2020 at 12:29 PM Yedidyah Bar David <didi@redhat.com> wrote:
On Tue, Mar 31, 2020 at 4:30 PM Tal Nisan <tnisan@redhat.com> wrote:
Eitan, please fix ASAP
Done:
https://gerrit.ovirt.org/108126
https://gerrit.ovirt.org/108124
Apparently we didn't run pep8 at all since stopping building on el7...
On Tue, Mar 31, 2020 at 4:01 PM Fedor Gavrilov <fgavrilo@redhat.com>
wrote:
I can't compile the engine. Not sure should I laugh or cry. But you
shouldn't be able to compile too.
https://github.com/oVirt/ovirt-engine/commit/3d9d3b0aee17ff20d3303fd9f632975... is to blame, once I cut the line compilation is able to proceed. Not sure how it will go with ansible-runner-service yet... :)
Fedor _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QAA7QP4SY6Y42J...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QXTCU3XZNV6QS2...
-- Didi _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/XJXZB25MWUVLWF...
-- Thanks, Kaustav Majumder
participants (4)
-
Fedor Gavrilov
-
Kaustav Majumder
-
Tal Nisan
-
Yedidyah Bar David