On Fri, Jul 31, 2015 at 1:53 PM, Dan Kenigsberg <danken(a)redhat.com> wrote:
On Fri, Jul 31, 2015 at 09:13:45AM +0200, Sandro Bonazzola wrote:
> On Fri, Jul 31, 2015 at 9:06 AM, Michal Skrivanek <
> michal.skrivanek(a)redhat.com> wrote:
> > On Jul 31, 2015, at 08:08 , Sandro Bonazzola <sbonazzo(a)redhat.com>
> > > Hi,
> > > vdsm from 3.5 branch is currently failing to build on Fedora, failing
> > pep8.
> > > Please fix ASAP.
> > >
> > > Fedora 20:
> > > Fedora 21:
> > looks like  merged 3 weeks ago
> > hm..running CI on merged patches doesn't alert on failure?
> Looks like no email is triggered on failure since jenkins already comment
> on gerrit and gerrit send an email to all people reviewing the patch.
> So all of them have been warned that the patch was failing on merge.
> I think vdsm is also missing a pep8 / pyflakes validation on patch sent,
> would help avoiding to discover the issue after having merged the patch.
We have pep8 job like that on master, but apparently - not on ovirt-3.5.
Anyway, I have just posted https://gerrit.ovirt.org/#/c/44239/
unbreak the long line of  and other damage done for stock el7 pep8.
I'll merge it asap.
Better technology. Faster innovation. Powered by community collaboration.
See how it works at