[oVirt 4.2 Localization Question #6] Misplaced double quotes?
Hello oVirt developers. My next question is as follows; *File: *UIConstants *Resource IDs: *highPerformancePopupRecommendationMsgForKsmPart1 highPerformancePopupRecommendationMsgForKsmPart2 *Strings: * KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: " ". This can be done by editing the Cluster and disabling the "Enable KSM" field. *Question:* There is something wrong with the usage of double quotes in those two strings. Could I remove it from the end of the first string, and the beginning of the second string (as well as the period)? Thank you, Yuko
As I thought from the context of the sentence, it's being used as a (parameterized) Message, like this: if (isKsmEnabled) { recommendationsList.add(constants.highPerformancePopupRecommenda tionMsgForKsmPart1() + clusterName + constants.highPerformancePopupRecommenda tionMsgForKsmPart2()); } So the cluster name is set between those two quotes. The programmer is supposed to use "Messages"[1] for this, not Constants. The message should be: highPerformancePopupRecommendationMsgForKsm=KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "{0}". This can be done by editing the Cluster and disabling the "Enable KSM" field. ^ although I'm not sure why the cluster name would be in quotes. It doesn't need to be. It can just say Cluster X (no colon either) Greg [1] ./frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages.properties Example: geoRepSlaveVolumeToolTip=Volume data from {0} of cluster {1} is replicated to this volume. On Thu, Oct 26, 2017 at 7:24 PM, Yuko Katabami <ykatabam@redhat.com> wrote:
Hello oVirt developers. My next question is as follows;
*File: *UIConstants
*Resource IDs: *highPerformancePopupRecommendationMsgForKsmPart1
highPerformancePopupRecommendationMsgForKsmPart2 *Strings: * KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "
". This can be done by editing the Cluster and disabling the "Enable KSM" field. *Question:* There is something wrong with the usage of double quotes in those two strings. Could I remove it from the end of the first string, and the beginning of the second string (as well as the period)?
Thank you,
Yuko
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Thank you very much Greg for looking into this. Your suggested message makes perfect sense. I leave my translation as-is for now (I cannot edit the source text) but when it is fixed and repushed to Zanata, I will retranslate it. Yuko On Fri, Oct 27, 2017 at 9:44 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
As I thought from the context of the sentence, it's being used as a (parameterized) Message, like this:
if (isKsmEnabled) { recommendationsList.add(constants.highPerformancePopupRecomm endationMsgForKsmPart1() + clusterName + constants.highPerformancePopup RecommendationMsgForKsmPart2()); }
So the cluster name is set between those two quotes.
The programmer is supposed to use "Messages"[1] for this, not Constants. The message should be:
highPerformancePopupRecommendationMsgForKsm=KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "{0}". This can be done by editing the Cluster and disabling the "Enable KSM" field.
^ although I'm not sure why the cluster name would be in quotes. It doesn't need to be. It can just say Cluster X (no colon either)
Greg
[1] ./frontend/webadmin/modules/webadmin/src/main/resources/ org/ovirt/engine/ui/webadmin/ApplicationMessages.properties Example: geoRepSlaveVolumeToolTip=Volume data from {0} of cluster {1} is replicated to this volume.
On Thu, Oct 26, 2017 at 7:24 PM, Yuko Katabami <ykatabam@redhat.com> wrote:
Hello oVirt developers. My next question is as follows;
*File: *UIConstants
*Resource IDs: *highPerformancePopupRecommendationMsgForKsmPart1
highPerformancePopupRecommendationMsgForKsmPart2 *Strings: * KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "
". This can be done by editing the Cluster and disabling the "Enable KSM" field. *Question:* There is something wrong with the usage of double quotes in those two strings. Could I remove it from the end of the first string, and the beginning of the second string (as well as the period)?
Thank you,
Yuko
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Hi, I believe the output with quotes is going to be: Please disable KSM by disabling it for the Cluster: "CLUSTER_NAME". This can be done by editing the Cluster and disabling the "Enable KSM" field. The colon or the quotes can probably be removed. But I am not a typography expert. Martin On Fri, Oct 27, 2017 at 1:24 AM, Yuko Katabami <ykatabam@redhat.com> wrote:
Hello oVirt developers. My next question is as follows;
File: UIConstants
Resource IDs: highPerformancePopupRecommendationMsgForKsmPart1
highPerformancePopupRecommendationMsgForKsmPart2
Strings: KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "
". This can be done by editing the Cluster and disabling the "Enable KSM" field. Question: There is something wrong with the usage of double quotes in those two strings. Could I remove it from the end of the first string, and the beginning of the second string (as well as the period)?
Thank you,
Yuko
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On Fri, Oct 27, 2017 at 10:00 PM, Martin Sivak <msivak@redhat.com> wrote:
Hi,
I believe the output with quotes is going to be:
Please disable KSM by disabling it for the Cluster: "CLUSTER_NAME". This can be done by editing the Cluster and disabling the "Enable KSM" field.
The colon or the quotes can probably be removed. But I am not a typography expert.
Thank you Martin. When this edit with a variable included is pushed to our translation system, I will re-translate it. Yuko
Martin
Hello oVirt developers. My next question is as follows;
File: UIConstants
Resource IDs: highPerformancePopupRecommendationMsgForKsmPart1
highPerformancePopupRecommendationMsgForKsmPart2
Strings: KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "
". This can be done by editing the Cluster and disabling the "Enable KSM" field. Question: There is something wrong with the usage of double quotes in
On Fri, Oct 27, 2017 at 1:24 AM, Yuko Katabami <ykatabam@redhat.com> wrote: those
two strings. Could I remove it from the end of the first string, and the beginning of the second string (as well as the period)?
Thank you,
Yuko
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Hi, A patch with this fix was merged: https://gerrit.ovirt.org/#/c/83390/ Regards, Sharon On Fri, Oct 27, 2017 at 7:41 PM, Yuko Katabami <ykatabam@redhat.com> wrote:
On Fri, Oct 27, 2017 at 10:00 PM, Martin Sivak <msivak@redhat.com> wrote:
Hi,
I believe the output with quotes is going to be:
Please disable KSM by disabling it for the Cluster: "CLUSTER_NAME". This can be done by editing the Cluster and disabling the "Enable KSM" field.
The colon or the quotes can probably be removed. But I am not a typography expert.
Thank you Martin. When this edit with a variable included is pushed to our translation system, I will re-translate it.
Yuko
Martin
Hello oVirt developers. My next question is as follows;
File: UIConstants
Resource IDs: highPerformancePopupRecommendationMsgForKsmPart1
highPerformancePopupRecommendationMsgForKsmPart2
Strings: KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "
". This can be done by editing the Cluster and disabling the "Enable KSM" field. Question: There is something wrong with the usage of double quotes in
On Fri, Oct 27, 2017 at 1:24 AM, Yuko Katabami <ykatabam@redhat.com> wrote: those
two strings. Could I remove it from the end of the first string, and the beginning of the second string (as well as the period)?
Thank you,
Yuko
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Thanks Sharon -- looks perfect :) Best wishes, Greg On Tue, Oct 31, 2017 at 10:53 AM, Sharon Gratch <sgratch@redhat.com> wrote:
Hi,
A patch with this fix was merged: https://gerrit.ovirt.org/#/c/83390/
Regards, Sharon
On Fri, Oct 27, 2017 at 7:41 PM, Yuko Katabami <ykatabam@redhat.com> wrote:
On Fri, Oct 27, 2017 at 10:00 PM, Martin Sivak <msivak@redhat.com> wrote:
Hi,
I believe the output with quotes is going to be:
Please disable KSM by disabling it for the Cluster: "CLUSTER_NAME". This can be done by editing the Cluster and disabling the "Enable KSM" field.
The colon or the quotes can probably be removed. But I am not a typography expert.
Thank you Martin. When this edit with a variable included is pushed to our translation system, I will re-translate it.
Yuko
Martin
Hello oVirt developers. My next question is as follows;
File: UIConstants
Resource IDs: highPerformancePopupRecommendationMsgForKsmPart1
highPerformancePopupRecommendationMsgForKsmPart2
Strings: KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "
". This can be done by editing the Cluster and disabling the "Enable KSM" field. Question: There is something wrong with the usage of double quotes in
two strings. Could I remove it from the end of the first string, and
On Fri, Oct 27, 2017 at 1:24 AM, Yuko Katabami <ykatabam@redhat.com> wrote: those the
beginning of the second string (as well as the period)?
Thank you,
Yuko
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Thank you very much Sharon and Greg! On Wed, Nov 1, 2017 at 12:57 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
Thanks Sharon -- looks perfect :)
Best wishes, Greg
On Tue, Oct 31, 2017 at 10:53 AM, Sharon Gratch <sgratch@redhat.com> wrote:
Hi,
A patch with this fix was merged: https://gerrit.ovirt.org/#/c/83390/
Regards, Sharon
On Fri, Oct 27, 2017 at 7:41 PM, Yuko Katabami <ykatabam@redhat.com> wrote:
On Fri, Oct 27, 2017 at 10:00 PM, Martin Sivak <msivak@redhat.com> wrote:
Hi,
I believe the output with quotes is going to be:
Please disable KSM by disabling it for the Cluster: "CLUSTER_NAME". This can be done by editing the Cluster and disabling the "Enable KSM" field.
The colon or the quotes can probably be removed. But I am not a typography expert.
Thank you Martin. When this edit with a variable included is pushed to our translation system, I will re-translate it.
Yuko
Martin
Hello oVirt developers. My next question is as follows;
File: UIConstants
Resource IDs: highPerformancePopupRecommendationMsgForKsmPart1
highPerformancePopupRecommendationMsgForKsmPart2
Strings: KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "
". This can be done by editing the Cluster and disabling the "Enable KSM" field. Question: There is something wrong with the usage of double quotes in
two strings. Could I remove it from the end of the first string, and
On Fri, Oct 27, 2017 at 1:24 AM, Yuko Katabami <ykatabam@redhat.com> wrote: those the
beginning of the second string (as well as the period)?
Thank you,
Yuko
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (4)
-
Greg Sheremeta -
Martin Sivak -
Sharon Gratch -
Yuko Katabami