[Engine-devel] Do we need genericApi project?
Hi, I found that we have a ovirt-engine/frontend/api/genericapi project, which is for my opinion is not at use any more. If there are any reason that we want to keep it , maybe someone using it and I missed these? Thanks Michael
On 06/10/2012 11:23 AM, Michael Kublin wrote:
Hi,
I found that we have a ovirt-engine/frontend/api/genericapi project, which is for my opinion is not at use any more. If there are any reason that we want to keep it , maybe someone using it and I missed these?
Thanks Michael _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
iirc, it's intended to allow to add queries needed for the UI without adding them into the core. and looking at GetUserActionGroups, I see it is used for example by uicommon. (GWT still uses the generic api)
we don't use GetUserActionGroups (it's an unreachable code - can be deleted), IMHO we can remove the project. Thanks, Gilad. ----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Michael Kublin" <mkublin@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, June 10, 2012 11:48:53 AM Subject: Re: [Engine-devel] Do we need genericApi project?
On 06/10/2012 11:23 AM, Michael Kublin wrote:
Hi,
I found that we have a ovirt-engine/frontend/api/genericapi project, which is for my opinion is not at use any more. If there are any reason that we want to keep it , maybe someone using it and I missed these?
Thanks Michael _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
iirc, it's intended to allow to add queries needed for the UI without adding them into the core. and looking at GetUserActionGroups, I see it is used for example by uicommon.
(GWT still uses the generic api) _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
We may want to wait for the removal of the deprecated uicommon project (which is in use by the old UserPortal). uicommonweb doesn't use UiQueries any more (it's not depended on the genericapi project) - so I think it can be removed. ----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Michael Kublin" <mkublin@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, June 10, 2012 11:48:53 AM Subject: Re: [Engine-devel] Do we need genericApi project?
On 06/10/2012 11:23 AM, Michael Kublin wrote:
Hi,
I found that we have a ovirt-engine/frontend/api/genericapi project, which is for my opinion is not at use any more. If there are any reason that we want to keep it , maybe someone using it and I missed these?
Thanks Michael _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
iirc, it's intended to allow to add queries needed for the UI without adding them into the core. and looking at GetUserActionGroups, I see it is used for example by uicommon.
(GWT still uses the generic api) _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 06/10/2012 12:33 PM, Daniel Erez wrote:
We may want to wait for the removal of the deprecated uicommon project (which is in use by the old UserPortal). uicommonweb doesn't use UiQueries any more (it's not depended on the genericapi project) - so I think it can be removed.
I'd wait to see it really isn't needed any more. it was added to cover a gap in which the UI is using logic which exists in methods in the business entities (IsLinux/IsWindows/Is64bit, etc.) which is something we wanted to decouple, and the UI queries expose these as queries for the UI rather than use the entities directly. so i'd say this still isn't fully utilized, rather than deprecated.
----- Original Message -----
From: "Itamar Heim"<iheim@redhat.com> To: "Michael Kublin"<mkublin@redhat.com> Cc: "engine-devel"<engine-devel@ovirt.org> Sent: Sunday, June 10, 2012 11:48:53 AM Subject: Re: [Engine-devel] Do we need genericApi project?
On 06/10/2012 11:23 AM, Michael Kublin wrote:
Hi,
I found that we have a ovirt-engine/frontend/api/genericapi project, which is for my opinion is not at use any more. If there are any reason that we want to keep it , maybe someone using it and I missed these?
Thanks Michael _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
iirc, it's intended to allow to add queries needed for the UI without adding them into the core. and looking at GetUserActionGroups, I see it is used for example by uicommon.
(GWT still uses the generic api) _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
At least meanwhile, can I disable loading of GenericApiService bean during start up of jboss? ----- Original Message ----- From: "Itamar Heim" <iheim@redhat.com> To: "Daniel Erez" <derez@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, "Michael Kublin" <mkublin@redhat.com> Sent: Sunday, June 10, 2012 12:44:08 PM Subject: Re: [Engine-devel] Do we need genericApi project? On 06/10/2012 12:33 PM, Daniel Erez wrote:
We may want to wait for the removal of the deprecated uicommon project (which is in use by the old UserPortal). uicommonweb doesn't use UiQueries any more (it's not depended on the genericapi project) - so I think it can be removed.
I'd wait to see it really isn't needed any more. it was added to cover a gap in which the UI is using logic which exists in methods in the business entities (IsLinux/IsWindows/Is64bit, etc.) which is something we wanted to decouple, and the UI queries expose these as queries for the UI rather than use the entities directly. so i'd say this still isn't fully utilized, rather than deprecated.
----- Original Message -----
From: "Itamar Heim"<iheim@redhat.com> To: "Michael Kublin"<mkublin@redhat.com> Cc: "engine-devel"<engine-devel@ovirt.org> Sent: Sunday, June 10, 2012 11:48:53 AM Subject: Re: [Engine-devel] Do we need genericApi project?
On 06/10/2012 11:23 AM, Michael Kublin wrote:
Hi,
I found that we have a ovirt-engine/frontend/api/genericapi project, which is for my opinion is not at use any more. If there are any reason that we want to keep it , maybe someone using it and I missed these?
Thanks Michael _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
iirc, it's intended to allow to add queries needed for the UI without adding them into the core. and looking at GetUserActionGroups, I see it is used for example by uicommon.
(GWT still uses the generic api) _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
On 06/10/2012 11:23 AM, Michael Kublin wrote:
Hi,
I found that we have a ovirt-engine/frontend/api/genericapi project, which is for my opinion is not at use any more. If there are any reason that we want to keep it , maybe someone using it and I missed these?
IIUC, this was served in order to create a SOAP web service to server our clients. I also don't see a reason why we should continue and use this - All GWT based code does not use this (it uses GenericApiGWTServiceImpl to communicate with engine, which injects the EJB bean of Backend). This class as an obselete field of genericAPIService, which is no longer being injected (so a fix should be done at GWT side as well). Yair
Thanks Michael _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (5)
-
Daniel Erez -
Gilad Chaplik -
Itamar Heim -
Michael Kublin -
Yair Zaslavsky