ovirt-engine-nodejs failing build on fc26
Hi, just an heads up that ovirt-engine-nodejs fails to build on fc26: http://jenkins.ovirt.org/job/ovirt-engine-nodejs_master_build-artifacts-fc26... -- SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
I'll take care of it. Thanks for letting us know :) On Mon, May 29, 2017 at 9:33 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, just an heads up that ovirt-engine-nodejs fails to build on fc26: http://jenkins.ovirt.org/job/ovirt-engine-nodejs_master_ build-artifacts-fc26-x86_64/1/consoleFull
--
SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com
Root cause is a node bug: https://github.com/nodejs/node/issues/11118 patch is https://gerrit.ovirt.org/#/c/77568 which simply bumps us to node 8, which coincidentally was released today. Looks like the fix isn't going into the node 6 line. Greg On Tue, May 30, 2017 at 8:12 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
I'll take care of it. Thanks for letting us know :)
On Mon, May 29, 2017 at 9:33 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, just an heads up that ovirt-engine-nodejs fails to build on fc26: http://jenkins.ovirt.org/job/ovirt-engine-nodejs_master_buil d-artifacts-fc26-x86_64/1/consoleFull
--
SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com
On Wed, May 31, 2017 at 2:45 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
Root cause is a node bug: https://github.com/nodejs/node/issues/11118
patch is https://gerrit.ovirt.org/#/c/77568
+1
which simply bumps us to node 8, which coincidentally was released today. Looks like the fix isn't going into the node 6 line.
Greg
On Tue, May 30, 2017 at 8:12 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
I'll take care of it. Thanks for letting us know :)
On Mon, May 29, 2017 at 9:33 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, just an heads up that ovirt-engine-nodejs fails to build on fc26: http://jenkins.ovirt.org/job/ovirt-engine-nodejs_master_buil d-artifacts-fc26-x86_64/1/consoleFull
--
SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com
-- SANDRO BONAZZOLA ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
+1 on bumping to NodeJS v8. According to [1] the build should pass with gcc v6, but seems that fc26 ships gcc v7 only. [1] https://github.com/nodejs/node/issues/10388#issuecomment-283056552 The root cause is indeed an ill-formed NodeJS source code. Using older gcc to build it isn't a proper solution. According to [2] the NodeJS v6 "active LTS" period ends at April 2018, however this is a build-related bug, and the GitHub issue is closed with resolution "fixed in next v7 release" (note that v7 is not LTS). [2] https://github.com/nodejs/LTS Even though NodeJS v8 "active LTS" period starts at October 2017 (in ~4 months), I'm OK with us bumping to v8 now. (If we face any problems with v8, we can "downgrade" to v7 if necessary.) Regards, Vojtech On Wed, May 31, 2017 at 8:54 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
On Wed, May 31, 2017 at 2:45 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
Root cause is a node bug: https://github.com/nodejs/node/issues/11118
patch is https://gerrit.ovirt.org/#/c/77568
+1
which simply bumps us to node 8, which coincidentally was released today. Looks like the fix isn't going into the node 6 line.
Greg
On Tue, May 30, 2017 at 8:12 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
I'll take care of it. Thanks for letting us know :)
On Mon, May 29, 2017 at 9:33 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, just an heads up that ovirt-engine-nodejs fails to build on fc26: http://jenkins.ovirt.org/job/ovirt-engine-nodejs_master_buil d-artifacts-fc26-x86_64/1/consoleFull
--
SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com
--
SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
participants (3)
-
Greg Sheremeta -
Sandro Bonazzola -
Vojtech Szocs