Re: [Engine-devel] Change in ovirt-engine[master]: webadmin: Adding confirmation for replicate gluster volumes

----boundary_0_ca8416cd-fda9-4595-a4c8-50bad361243c content-type: text/plain; charset=us-ascii content-transfer-encoding: 7bit Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding confirmation for replicate gluster volumes ..................................................................... webadmin: Adding confirmation for replicate gluster volumes While creating a Replicate or Distributed Replicate volume, if more than one brick is added from the same server, a confirmation popup will be shown. The same warning will be shown while adding bricks after creating volume. In the Add Bricks dialog, a NOTE will be shown in the bottom explaining the Replicate/Stripe groups will be created based on the order of the bricks. Change-Id: Id783c1404eb79b32981bbf137d4228675f3e960f Bug-Url: https://bugzilla.redhat.com/871261 Signed-off-by: Kanagaraj M <kmayilsa@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/VolumePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml 8 files changed, 218 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id783c1404eb79b32981bbf137d4228675f3e960f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal@redhat.com> _______________________________________________ Engine-commits mailing list Engine-commits@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-commits ----boundary_0_ca8416cd-fda9-4595-a4c8-50bad361243c content-type: application/octet-stream; name="originalBody.txt" content-transfer-encoding: base64 content-disposition: attachment; filename=originalBody.txt R2lsYWQgQ2hhcGxpayBoYXMgc3VibWl0dGVkIHRoaXMgY2hhbmdlIGFuZCBpdCB3YXMgbWVyZ2Vk Lg0KDQpDaGFuZ2Ugc3ViamVjdDogd2ViYWRtaW46IEFkZGluZyBjb25maXJtYXRpb24gZm9yIHJl cGxpY2F0ZSBnbHVzdGVyIHZvbHVtZXMNCi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLg0KDQoNCndlYmFkbWluOiBBZGRp bmcgY29uZmlybWF0aW9uIGZvciByZXBsaWNhdGUgZ2x1c3RlciB2b2x1bWVzDQoNCldoaWxlIGNy ZWF0aW5nIGEgUmVwbGljYXRlIG9yIERpc3RyaWJ1dGVkIFJlcGxpY2F0ZSB2b2x1bWUsDQppZiBt b3JlIHRoYW4gb25lIGJyaWNrIGlzIGFkZGVkIGZyb20gdGhlIHNhbWUgc2VydmVyLA0KYSBjb25m aXJtYXRpb24gcG9wdXAgd2lsbCBiZSBzaG93bi4gVGhlIHNhbWUgd2FybmluZyB3aWxsDQpiZSBz aG93biB3aGlsZSBhZGRpbmcgYnJpY2tzIGFmdGVyIGNyZWF0aW5nIHZvbHVtZS4NCg0KSW4gdGhl IEFkZCBCcmlja3MgZGlhbG9nLCBhIE5PVEUgd2lsbCBiZSBzaG93biBpbiB0aGUNCmJvdHRvbSBl eHBsYWluaW5nIHRoZSBSZXBsaWNhdGUvU3RyaXBlIGdyb3VwcyB3aWxsIGJlDQpjcmVhdGVkIGJh c2VkIG9uIHRoZSBvcmRlciBvZiB0aGUgYnJpY2tzLg0KDQpDaGFuZ2UtSWQ6IElkNzgzYzE0MDRl Yjc5YjMyOTgxYmJmMTM3ZDQyMjg2NzVmM2U5NjBmDQpCdWctVXJsOiBodHRwczovL2J1Z3ppbGxh LnJlZGhhdC5jb20vODcxMjYxDQpTaWduZWQtb2ZmLWJ5OiBLYW5hZ2FyYWogTSA8a21heWlsc2FA cmVkaGF0LmNvbT4NCi0tLQ0KTSBmcm9udGVuZC93ZWJhZG1pbi9tb2R1bGVzL3VpY29tbW9ud2Vi L3NyYy9tYWluL2phdmEvb3JnL292aXJ0L2VuZ2luZS91aS91aWNvbW1vbndlYi9tb2RlbHMvZ2x1 c3Rlci9Wb2x1bWVCcmlja0xpc3RNb2RlbC5qYXZhDQpNIGZyb250ZW5kL3dlYmFkbWluL21vZHVs ZXMvdWljb21tb253ZWIvc3JjL21haW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3VpY29tbW9u d2ViL21vZGVscy9nbHVzdGVyL1ZvbHVtZUJyaWNrTW9kZWwuamF2YQ0KTSBmcm9udGVuZC93ZWJh ZG1pbi9tb2R1bGVzL3VpY29tbW9ud2ViL3NyYy9tYWluL2phdmEvb3JnL292aXJ0L2VuZ2luZS91 aS91aWNvbW1vbndlYi9tb2RlbHMvZ2x1c3Rlci9Wb2x1bWVNb2RlbC5qYXZhDQpNIGZyb250ZW5k L3dlYmFkbWluL21vZHVsZXMvdWljb21wYXQvc3JjL21haW4vamF2YS9vcmcvb3ZpcnQvZW5naW5l L3VpL3VpY29tcGF0L0NvbnN0YW50cy5qYXZhDQpNIGZyb250ZW5kL3dlYmFkbWluL21vZHVsZXMv d2ViYWRtaW4vc3JjL21haW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL0FwcGxp Y2F0aW9uQ29uc3RhbnRzLmphdmENCk0gZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1p bi9zcmMvbWFpbi9qYXZhL29yZy9vdmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vc2VjdGlvbi9tYWlu L3ByZXNlbnRlci9wb3B1cC9nbHVzdGVyL1ZvbHVtZVBvcHVwUHJlc2VudGVyV2lkZ2V0LmphdmEN Ck0gZnJvbnRlbmQvd2ViYWRtaW4vbW9kdWxlcy93ZWJhZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9v dmlydC9lbmdpbmUvdWkvd2ViYWRtaW4vc2VjdGlvbi9tYWluL3ZpZXcvcG9wdXAvZ2x1c3Rlci9B ZGRCcmlja1BvcHVwVmlldy5qYXZhDQpNIGZyb250ZW5kL3dlYmFkbWluL21vZHVsZXMvd2ViYWRt aW4vc3JjL21haW4vamF2YS9vcmcvb3ZpcnQvZW5naW5lL3VpL3dlYmFkbWluL3NlY3Rpb24vbWFp bi92aWV3L3BvcHVwL2dsdXN0ZXIvQWRkQnJpY2tQb3B1cFZpZXcudWkueG1sDQo4IGZpbGVzIGNo YW5nZWQsIDIxOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQ0KDQpBcHByb3ZhbHM6DQog IEdpbGFkIENoYXBsaWs6IFZlcmlmaWVkOyBMb29rcyBnb29kIHRvIG1lLCBhcHByb3ZlZA0KDQoN Ci0tDQpUbyB2aWV3LCB2aXNpdCBodHRwOi8vZ2Vycml0Lm92aXJ0Lm9yZy8xMDAxOA0KVG8gdW5z dWJzY3JpYmUsIHZpc2l0IGh0dHA6Ly9nZXJyaXQub3ZpcnQub3JnL3NldHRpbmdzDQoNCkdlcnJp dC1NZXNzYWdlVHlwZTogbWVyZ2VkDQpHZXJyaXQtQ2hhbmdlLUlkOiBJZDc4M2MxNDA0ZWI3OWIz Mjk4MWJiZjEzN2Q0MjI4Njc1ZjNlOTYwZg0KR2Vycml0LVBhdGNoU2V0OiA1DQpHZXJyaXQtUHJv amVjdDogb3ZpcnQtZW5naW5lDQpHZXJyaXQtQnJhbmNoOiBtYXN0ZXINCkdlcnJpdC1Pd25lcjog S2FuYWdhcmFqIE0gPGttYXlpbHNhQHJlZGhhdC5jb20+DQpHZXJyaXQtUmV2aWV3ZXI6IEdpbGFk IENoYXBsaWsgPGdjaGFwbGlrQHJlZGhhdC5jb20+DQpHZXJyaXQtUmV2aWV3ZXI6IEthbmFnYXJh aiBNIDxrbWF5aWxzYUByZWRoYXQuY29tPg0KR2Vycml0LVJldmlld2VyOiBTaGlyZWVzaCBBbmph bCA8c2FuamFsQHJlZGhhdC5jb20+DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXw0KRW5naW5lLWNvbW1pdHMgbWFpbGluZyBsaXN0DQpFbmdpbmUtY29tbWl0 c0BvdmlydC5vcmcNCmh0dHA6Ly9saXN0cy5vdmlydC5vcmcvbWFpbG1hbi9saXN0aW5mby9lbmdp bmUtY29tbWl0cw== ----boundary_0_ca8416cd-fda9-4595-a4c8-50bad361243c--
participants (1)
-
thomas@parker.iz34.com