Changing unit labels from GB, MB, KB to GiB, MiB, KiB

Hi, In the ovirt-engine UI, we use units KB, MB, GB with the meaning of powers of 1024 bytes, instead of powers of 1000. Some time ago, there was a bug[1] that has changed some of the GB labels to GiB, but not in all places. This causes inconsistent messages in the UI, where one part of a sentence uses GB and the other GiB. To make it consistent, I have posted patches[2] that change unit labels in other places as well. This change touches strings from different parts of the project, so I'm sending this email to let you know about it. Feel free to check the patches or comment if the change is correct. Andrej [1] - https://bugzilla.redhat.com/1535714 [2] - https://gerrit.ovirt.org/#/q/project:ovirt-engine+topic:unit-relabel

Related, in the dashboard: Bug 1492397 – consistent binary prefix units for sizes (MiB, GiB) https://bugzilla.redhat.com/show_bug.cgi?id=1492397 We probably only need one of the bugs. Best wishes, Greg On Thu, Apr 26, 2018 at 6:29 AM, Andrej Krejcir <akrejcir@redhat.com> wrote:
Hi,
In the ovirt-engine UI, we use units KB, MB, GB with the meaning of powers of 1024 bytes, instead of powers of 1000. Some time ago, there was a bug[1] that has changed some of the GB labels to GiB, but not in all places. This causes inconsistent messages in the UI, where one part of a sentence uses GB and the other GiB.
To make it consistent, I have posted patches[2] that change unit labels in other places as well.
This change touches strings from different parts of the project, so I'm sending this email to let you know about it. Feel free to check the patches or comment if the change is correct.
Andrej
[1] - https://bugzilla.redhat.com/1535714 [2] - https://gerrit.ovirt.org/#/q/project:ovirt-engine+topic:unit-relabel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- GREG SHEREMETA SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX Red Hat NA <https://www.redhat.com/> gshereme@redhat.com IRC: gshereme <https://red.ht/sig>
participants (2)
-
Andrej Krejcir
-
Greg Sheremeta