8:45 a.m.
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
- https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
- https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
Thanks,
Nir
8:48 a.m.
----- Original Message -----
From: "Nir Soffer" <nsoffer(a)redhat.com>
To: "devel" <devel(a)ovirt.org>
Cc: "Dan Kenigsberg" <danken(a)redhat.com>, "Francesco Romani"
<fromani(a)redhat.com>, "Piotr Kliczewski"
<pkliczew(a)redhat.com>, "Adam Litke" <alitke(a)redhat.com>,
"Allon Mureinik" <amureini(a)redhat.com>
Sent: Thursday, November 12, 2015 3:45:13 PM
Subject: Reported-By - giving credit to our testers
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this header.
Strongly agreed, let's do this!
Bests,
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
8:49 a.m.
--W/nzBZO5zC0uMSeA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 11/12, Francesco Romani wrote:
----- Original Message -----
> From: "Nir Soffer" <nsoffer(a)redhat.com>
> To: "devel" <devel(a)ovirt.org>
> Cc: "Dan Kenigsberg" <danken(a)redhat.com>, "Francesco
Romani" <fromani@r=
edhat.com>, "Piotr Kliczewski"
> <pkliczew(a)redhat.com>, "Adam Litke"
<alitke(a)redhat.com>, "Allon Mureini=
k" <amureini(a)redhat.com>
> Sent: Thursday, November 12, 2015 3:45:13 PM
> Subject: Reported-By - giving credit to our testers
>=20
> Hi all,
>=20
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
>=20
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this he=
ader.
=20
Strongly agreed, let's do this!
+1
=20
Bests,
=20
--=20
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--W/nzBZO5zC0uMSeA
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJWRKcGAAoJEEBxx+HSYmnDOj8H/2a2FFFdfL3FHauUrsuCwKok
7JdjZW7ABqIK5+xkHCFVcqqbg0soklmoJwQn65yD9hY+v3vqmny5LlWr05g2KW4y
Elv3d6Wk+naoTCLJ65Lb6nwHNvaeYL5MPZxLEGs4fUnx3Mp8LY26cGxPNatI7G8f
hrFGZLjNpX91t4UzScPw7KsvK33r2r3ynp/SEQfA9n/lkYzJ+UoUHTyCw0Nw0nUR
b16+KHtUpHjlIcN+S+XmW7MEg0Gl+5ULtgV04L0ZbeIi1uZHzCOPNry9fZi45PlK
E1w9dGenVaYelZQowTeccSSTDCUe2ZRQil88YW4JCJtaZ/kppulpqSrcHnLcVSY=
=IABj
-----END PGP SIGNATURE-----
--W/nzBZO5zC0uMSeA--
8:54 a.m.
On Thu, Nov 12, 2015 at 3:49 PM, David Caro <dcaro(a)redhat.com> wrote:
On 11/12, Francesco Romani wrote:
> ----- Original Message -----
> > From: "Nir Soffer" <nsoffer(a)redhat.com>
> > To: "devel" <devel(a)ovirt.org>
> > Cc: "Dan Kenigsberg" <danken(a)redhat.com>, "Francesco
Romani" <
fromani(a)redhat.com>, "Piotr Kliczewski"
> > <pkliczew(a)redhat.com>, "Adam Litke" <alitke(a)redhat.com>,
"Allon
Mureinik" <amureini(a)redhat.com>
> > Sent: Thursday, November 12, 2015 3:45:13 PM
> > Subject: Reported-By - giving credit to our testers
> >
> > Hi all,
> >
> > Our QE (and sometimes our users) are working hard testing and
> > reporting bugs, but
> > their effort is never mentioned in our code.
> >
> > Looking at kernel git history, I found that they are using the
> > Reported-By header for
> > giving credit to the person reporting a bug. I suggest we adapt this
header.
>
> Strongly agreed, let's do this!
+1
+1
>
> Bests,
>
> --
> Francesco Romani
> RedHat Engineering Virtualization R & D
> Phone: 8261328
> IRC: fromani
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
--
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
8:55 a.m.
On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this
header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
+1
In case they help with the verification of the change, I suggest adding
Tested-By which is just as important.
A Tested-by: tag indicates that the patch has been successfully tested (in
some environment) by the person named. This tag informs maintainers that
some testing has been performed, provides a means to locate testers for
future patches, and ensures credit for the testers.
Y.
9 a.m.
----- Original Message -----
From: "Yaniv Kaul" <ykaul(a)redhat.com>
To: "Nir Soffer" <nsoffer(a)redhat.com>
Cc: "Piotr Kliczewski" <pkliczew(a)redhat.com>, "devel"
<devel(a)ovirt.org>
Sent: Thursday, November 12, 2015 4:55:10 PM
Subject: Re: [ovirt-devel] Reported-By - giving credit to our testers
On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer < nsoffer(a)redhat.com > wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
+1
In case they help with the verification of the change, I suggest adding
Tested-By which is just as important.
From https://www.kernel.org/doc/Documentation/SubmittingPatches :
A Tested-by: tag indicates that the patch has been successfully tested (in
some environment) by the person named. This tag informs maintainers that
some testing has been performed, provides a means to locate testers for
future patches, and ensures credit for the testers.
This meant to give credit for whoever is doing that in his own time, not for cooperation
that pays for QA nor replace bugzilla.
If you go over the logs, you will see I provide Reported-By and Tested-By two who produce
significant effort in helping out a case.
Y.
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
10:45 a.m.
+1
----- Original Message -----
From: "Nir Soffer" <nsoffer(a)redhat.com>
To: "devel" <devel(a)ovirt.org>
Cc: "Piotr Kliczewski" <pkliczew(a)redhat.com>
Sent: Thursday, November 12, 2015 4:45:13 PM
Subject: [ovirt-devel] Reported-By - giving credit to our testers
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
1:55 a.m.
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this
header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
infra: looking at above commit messages, can we get automatically added the
following lines?
Reviewed-on: https://gerrit.ovirt.org/46540
on patch creation
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
on patch comment
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
8:02 a.m.
+1
----- Original Message -----
From: "Nir Soffer" <nsoffer(a)redhat.com>
To: "devel" <devel(a)ovirt.org>
Cc: "Piotr Kliczewski" <pkliczew(a)redhat.com>
Sent: Thursday, November 12, 2015 3:45:13 PM
Subject: [ovirt-devel] Reported-By - giving credit to our testers
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
4:26 a.m.
+1
Let's add this to the standard commit msg template, so it won't be
forgotten unintentionally.
Shmuel
On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this
header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
4:51 a.m.
+1
Thanks,
Tomer
----- Original Message -----
From: "Shmuel Melamud" <smelamud(a)redhat.com>
To: "Nir Soffer" <nsoffer(a)redhat.com>
Cc: "Piotr Kliczewski" <pkliczew(a)redhat.com>, "devel"
<devel(a)ovirt.org>
Sent: Sunday, November 15, 2015 12:26:26 PM
Subject: Re: [ovirt-devel] Reported-By - giving credit to our testers
+1
Let's add this to the standard commit msg template, so it won't be forgotten
unintentionally.
Shmuel
On Thu, Nov 12, 2015 at 4:45 PM, Nir Soffer < nsoffer(a)redhat.com > wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt this header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
- https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
- https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
Thanks,
Nir
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
1:35 p.m.
This is a multi-part message in MIME format.
--------------040300070603050101010308
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
On 13.11.2015 07:55, Sandro Bonazzola wrote:
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <nsoffer(a)redhat.com
<mailto:nsoffer@redhat.com>> wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and
reporting bugs, but
their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the
Reported-By header for
giving credit to the person reporting a bug. I suggest we adapt
this header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
-
https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
-
https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
infra: looking at above commit messages, can we get automatically
added the following lines?
Reviewed-on: https://gerrit.ovirt.org/46540
on patch creation
Reviewed-by: Francesco Romani <fromani(a)redhat.com
<mailto:fromani@redhat.com>>
on patch comment
+1 both to Nir's original idea and to Sandro's suggestions.
--------------040300070603050101010308
Content-Type: text/html; charset=windows-1252
Content-Transfer-Encoding: 7bit
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 13.11.2015 07:55, Sandro Bonazzola wrote:<br>
<blockquote
cite="mid:CAPQRNTnhfwmDz4qFxPPF5A8pNdtUY=aZJExYV6j7W1fO6OTHMA@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Nov 12, 2015 at 3:45 PM, Nir
Soffer <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:nsoffer@redhat.com"
target="_blank">nsoffer(a)redhat.com</a>&gt;</span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi
all,<br>
<br>
Our QE (and sometimes our users) are working hard testing
and<br>
reporting bugs, but<br>
their effort is never mentioned in our code.<br>
<br>
Looking at kernel git history, I found that they are using
the<br>
Reported-By header for<br>
giving credit to the person reporting a bug. I suggest we
adapt this header.<br>
<br>
Here are some examples how we can use it:<br>
<br>
- <a moz-do-not-send="true"
href="https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG"
rel="noreferrer"
target="_blank">https://gerrit.ovirt.org/#/c/48483/3//COMMIT...
- <a moz-do-not-send="true"
href="https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c748341...
rel="noreferrer"
target="_blank">https://github.com/oVirt/vdsm/commit/fb4c72a...
- <a moz-do-not-send="true"
href="https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030d...
rel="noreferrer"
target="_blank">https://github.com/oVirt/vdsm/commit/f8127d8...
<div><br>
</div>
<div>infra: looking at above commit messages, can we get
automatically added the following lines?</div>
<div class="gmail_quote"><br>
</div>
Reviewed-on: <a moz-do-not-send="true"
href="https://gerrit.ovirt.org/46540">https://gerrit.ovirt.o...
on patch creation<br>
<br>
Reviewed-by: Francesco Romani <<a moz-do-not-send="true"
href="mailto:fromani@redhat.com">fromani@redhat.com</a>>
<div>on patch comment</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
+1 both to Nir's original idea and to Sandro's suggestions.<br>
<br>
</body>
</html>
--------------040300070603050101010308--
4:11 a.m.
On Sun, Nov 15, 2015 at 9:35 PM, Ondřej Svoboda <ondrej(a)svobodasoft.cz> wrote:
On 13.11.2015 07:55, Sandro Bonazzola wrote:
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
>
> Hi all,
>
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
>
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this
> header.
>
> Here are some examples how we can use it:
>
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959...
> -
> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7...
infra: looking at above commit messages, can we get automatically added the
following lines?
Reviewed-on: https://gerrit.ovirt.org/46540
on patch creation
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
on patch comment
+1 both to Nir's original idea and to Sandro's suggestions.
Now encountered [1] my first such case since this thread, and not sure
I agree to automatically add people. Some people might not want that
at all, some would prefer to have control over their name, some might
prefer an email address different from the one used for posting or no
email address at all.
I usually ask people to open a bug or comment on an existing bug.
Isn't that enough? Are git logs so much more important than bugzilla
history?
Another option I can think of is:
Report-Url: http://lists.ovirt.org/pipermail/users/2015-November/035947.html
Adding Christian, the reporter of [1]. Christian, feel free to ignore
current thread, and/or voice up your opinion, and/or say if you want
to appear as "Reported-By:" in the git commit message [2]. Thanks :-)
[1] http://lists.ovirt.org/pipermail/users/2015-November/035947.html
[2] https://gerrit.ovirt.org/48596
Best,
--
Didi
5:27 a.m.
Hi,
I think it's nice to have some appreciation for helping (Beside a working Environment
*g*),
I don't have a problem with doing it automatically as my name also appears in the
mailing lists and bugzilla.
Till next time
Christian
-----Ursprüngliche Nachricht-----
Von: Yedidyah Bar David [mailto:didi@redhat.com]
Gesendet: Montag, 16. November 2015 11:12
An: Ondřej Svoboda <ondrej(a)svobodasoft.cz>
Cc: devel <devel(a)ovirt.org>; Grundmann, Christian
<Christian.Grundmann(a)fabasoft.com>
Betreff: Re: [ovirt-devel] Reported-By - giving credit to our testers
On Sun, Nov 15, 2015 at 9:35 PM, Ondřej Svoboda <ondrej(a)svobodasoft.cz> wrote:
On 13.11.2015 07:55, Sandro Bonazzola wrote:
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
>
> Hi all,
>
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but their effort is never mentioned in our code.
>
> Looking at kernel git history, I found that they are using the
> Reported-By header for giving credit to the person reporting a bug. I
> suggest we adapt this header.
>
> Here are some examples how we can use it:
>
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d9
> 2959ebbd
> -
> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde24331
> 25c7b598
infra: looking at above commit messages, can we get automatically
added the following lines?
Reviewed-on: https://gerrit.ovirt.org/46540 on patch creation
Reviewed-by: Francesco Romani <fromani(a)redhat.com> on patch comment
+1 both to Nir's original idea and to Sandro's suggestions.
Now encountered [1] my first such case since this thread, and not sure
I agree to automatically add people. Some people might not want that
at all, some would prefer to have control over their name, some might
prefer an email address different from the one used for posting or no
email address at all.
I usually ask people to open a bug or comment on an existing bug.
Isn't that enough? Are git logs so much more important than bugzilla
history?
Another option I can think of is:
Report-Url: http://lists.ovirt.org/pipermail/users/2015-November/035947.html
Adding Christian, the reporter of [1]. Christian, feel free to ignore
current thread, and/or voice up your opinion, and/or say if you want
to appear as "Reported-By:" in the git commit message [2]. Thanks :-)
[1] http://lists.ovirt.org/pipermail/users/2015-November/035947.html
[2] https://gerrit.ovirt.org/48596
Best,
--
Didi
6:51 a.m.
--ALfTUftag+2gvp1h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 11/13 08:55, Sandro Bonazzola wrote:
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer
<nsoffer(a)redhat.com> wrote:
=20
> Hi all,
>
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
>
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this
> header.
>
> Here are some examples how we can use it:
>
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d929=
59ebbd
c7b598
=20
=20
infra: looking at above commit messages, can we get automatically added t=
he
following lines?
=20
Reviewed-on: https://gerrit.ovirt.org/46540
on patch creation
=20
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
on patch comment
There's no easy way to plug in extra stuff, that is done on vdsm by gerrit
itself because the project is set to 'cherry-pick', but that has consequenc=
es,
for starters, when you submit a patch, the commit that gets in is not the s=
ame
that you where reviewing (as the commit message changed) and thus you will =
be
forced to rebase all the patches that depended on it.
There's no built-in way either to change the commit on push (when
updating/creating the patch) without creating a new patch. That means that =
to
have that added, each time you send a patch a new one will be created, and =
each
time you add a comment for the first time to the patch, another patch will =
be
created too. Forcing the devel to refetch the commit each time he/she pushe=
s.
Not sure that smoothes up the dev process...
I think that the less painful path will be to use a commit hook locally, so=
the
commit message is changed locally first, but that will require the dev to
install it (we can ease that with a script or similar though)
=20
=20
=20
>
>
> Thanks,
> Nir
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
=20
=20
=20
--=20
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--ALfTUftag+2gvp1h
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJWSyLmAAoJEEBxx+HSYmnD+E0H/ja833aqLEKyMrq0dsKyhQ1e
bBrnatZ6Jf6uBBCFJ9KU/Zc/TBXVvZ8D0Jk+28MQTt5SBHZ05aYjYikzEkPgNYCV
fcQQqtoiPkF8iF5nnZeLV3G/jdiBD7q/GNBSmNvKKgqDMUBDBnuIwTM9BUhO19dj
rqHOuupjkGWnPGeJFHkRqrqooDFAFJTKFPJPDfTVilJuL5w7iNJMnT8ns1mvUL2d
VzZW3ItbeqMxoScG8OcYMVbHD3Frld1XFADt52UP2F5nzW3lnYjpj9iA6JZLWNje
cjMgjHJzckp79UiDWuxqTpKs8metClXKf9N7sjuCcUD0E/VpBSqZfIvuz485b2k=
=GdED
-----END PGP SIGNATURE-----
--ALfTUftag+2gvp1h--
3077
days inactive
3082
days old
14 comments
14 participants
participants (14)
-
Alon Bar-Lev -
David Caro -
Eli Mesika -
Francesco Romani -
Grundmann, Christian -
Nir Soffer -
Ondřej Svoboda -
Piotr Kliczewski -
Sandro Bonazzola -
Shmuel Melamud -
Tomer Saban -
Vojtech Szocs -
Yaniv Kaul -
Yedidyah Bar David