From: "Gilad Chaplik" <gchaplik(a)redhat.com&gt; To: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; Cc: devel(a)ovirt.org Sent: Thursday, June 19, 2014 11:14:35 AM Subject: Re: [ovirt-devel] Correct way to run internal actions from commands We should enforce that in code level: getBackend() should be private in CommandBase, and won't need any convention.

Thanks, Gilad. ----- Original Message ----- > From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > To: devel(a)ovirt.org > Sent: Wednesday, June 18, 2014 8:44:41 AM > Subject: [ovirt-devel] Correct way to run internal actions from commands > > Hi all, > Thanks to the collaboration of some of the maintainers and others I have > managed to merge a patch which gives the ability to run internal commands > the following way: > > If you're writing a code in a class that extends CommandBase, please follow > the following instructions: > > Instead of Backend.getInstance().runInternalAction (or MultipleActions) you > should use > > runInternalAction > > More patches will be added for running internal queries , and probably > endAction as well. > > > Thanks, > Yair > > > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel >

From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; To: "Gilad Chaplik" <gchaplik(a)redhat.com&gt; Cc: devel(a)ovirt.org Sent: Thursday, June 19, 2014 11:22:49 AM Subject: Re: [ovirt-devel] Correct way to run internal actions from commands ----- Original Message ----- > From: "Gilad Chaplik" <gchaplik(a)redhat.com&gt; > To: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > Cc: devel(a)ovirt.org > Sent: Thursday, June 19, 2014 11:14:35 AM > Subject: Re: [ovirt-devel] Correct way to run internal actions from > commands > > We should enforce that in code level: getBackend() should be private in > CommandBase, and won't need any convention. Using getBackend() is also a "convention".

> > Thanks, > Gilad. > > > ----- Original Message ----- > > From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > > To: devel(a)ovirt.org > > Sent: Wednesday, June 18, 2014 8:44:41 AM > > Subject: [ovirt-devel] Correct way to run internal actions from commands > > > > Hi all, > > Thanks to the collaboration of some of the maintainers and others I have > > managed to merge a patch which gives the ability to run internal commands > > the following way: > > > > If you're writing a code in a class that extends CommandBase, please > > follow > > the following instructions: > > > > Instead of Backend.getInstance().runInternalAction (or MultipleActions) > > you > > should use > > > > runInternalAction > > > > More patches will be added for running internal queries , and probably > > endAction as well. > > > > > > Thanks, > > Yair > > > > > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > >

From: "Alon Bar-Lev" <alonbl(a)redhat.com&gt; To: "Gilad Chaplik" <gchaplik(a)redhat.com&gt; Cc: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt;, devel(a)ovirt.org Sent: Thursday, June 19, 2014 11:41:37 AM Subject: Re: [ovirt-devel] Correct way to run internal actions from commands ----- Original Message ----- > From: "Gilad Chaplik" <gchaplik(a)redhat.com&gt; > To: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > Cc: devel(a)ovirt.org > Sent: Thursday, June 19, 2014 11:33:19 AM > Subject: Re: [ovirt-devel] Correct way to run internal actions from > commands > > ----- Original Message ----- > > From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > > To: "Gilad Chaplik" <gchaplik(a)redhat.com&gt; > > Cc: devel(a)ovirt.org > > Sent: Thursday, June 19, 2014 11:22:49 AM > > Subject: Re: [ovirt-devel] Correct way to run internal actions from > > commands > > > > > > > > ----- Original Message ----- > > > From: "Gilad Chaplik" <gchaplik(a)redhat.com&gt; > > > To: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > > > Cc: devel(a)ovirt.org > > > Sent: Thursday, June 19, 2014 11:14:35 AM > > > Subject: Re: [ovirt-devel] Correct way to run internal actions from > > > commands > > > > > > We should enforce that in code level: getBackend() should be private in > > > CommandBase, and won't need any convention. > > > > Using getBackend() is also a "convention". > > so you're adding another one :-) > > how should I enforce not using getBackend().runXXX in reviews? I've > probably > need to remember your email... Soon you will probably different signature for the helper runXXX() and the getBackend().runXXX()[1], as we are adding command context inheritance, to enable proper security context, correlation id inheritance and remove the ThreadLocal usage. So it will be easier to remember... :)

[1] http://gerrit.ovirt.org/#/c/28829/ > > > > > > > > > > > Thanks, > > > Gilad. > > > > > > > > > ----- Original Message ----- > > > > From: "Yair Zaslavsky" <yzaslavs(a)redhat.com&gt; > > > > To: devel(a)ovirt.org > > > > Sent: Wednesday, June 18, 2014 8:44:41 AM > > > > Subject: [ovirt-devel] Correct way to run internal actions from > > > > commands > > > > > > > > Hi all, > > > > Thanks to the collaboration of some of the maintainers and others I > > > > have > > > > managed to merge a patch which gives the ability to run internal > > > > commands > > > > the following way: > > > > > > > > If you're writing a code in a class that extends CommandBase, please > > > > follow > > > > the following instructions: > > > > > > > > Instead of Backend.getInstance().runInternalAction (or > > > > MultipleActions) > > > > you > > > > should use > > > > > > > > runInternalAction > > > > > > > > More patches will be added for running internal queries , and > > > > probably > > > > endAction as well. > > > > > > > > > > > > Thanks, > > > > Yair > > > > > > > > > > > > _______________________________________________ > > > > Devel mailing list > > > > Devel(a)ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel >