[Engine-devel] find-bugs errors - please investigate/fix
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13831/ @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [again - not sure when introduced - seems old, hence I suspect it is a false positive] ---- Thanks, Einav
On 04/24/2013 07:47 AM, Einav Cohen wrote:
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below]
@Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks!
@Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13740/
@Michal Skrivanek:
the following seem strange - can you please investigate? could be false positives.
- find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [not sure when introduced - seems old, hence I suspect it is a false positive]
- Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar.
- another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [again - not sure when introduced - seems old, hence I suspect it is a false positive]
---- Thanks, Einav
On Apr 24, 2013, at 07:49 , Sahina Bose <sabose@redhat.com> wrote:
On 04/24/2013 07:47 AM, Einav Cohen wrote:
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below]
@Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks!
@Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13740/
@Michal Skrivanek:
the following seem strange - can you please investigate? could be false positives.
- find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [not sure when introduced - seems old, hence I suspect it is a false positive]
- Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar.
- another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [again - not sure when introduced - seems old, hence I suspect it is a false positive]
Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused
---- Thanks, Einav
I've seen it too, it's after a series of patches I pushed to solve some findbugs issue that we got this false positive, I've asked Eyal to clean the target, it seems that findbugs is referring to old code that doesn't exist anymore. On 04/24/2013 10:11 AM, Michal Skrivanek wrote:
On Apr 24, 2013, at 07:49 , Sahina Bose<sabose@redhat.com> wrote:
On 04/24/2013 07:47 AM, Einav Cohen wrote:
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below]
@Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13740/
@Michal Skrivanek:
the following seem strange - can you please investigate? could be false positives.
- find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [not sure when introduced - seems old, hence I suspect it is a false positive]
- Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar.
- another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [again - not sure when introduced - seems old, hence I suspect it is a false positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused
---- Thanks, Einav
Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Seems that the cleanup worked, now the actual results after the frontend cleanup pathces are shown without the false positives http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4069/ On 04/24/2013 10:11 AM, Michal Skrivanek wrote:
On Apr 24, 2013, at 07:49 , Sahina Bose<sabose@redhat.com> wrote:
On 04/24/2013 07:47 AM, Einav Cohen wrote:
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below]
@Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13740/
@Michal Skrivanek:
the following seem strange - can you please investigate? could be false positives.
- find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [not sure when introduced - seems old, hence I suspect it is a false positive]
- Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar.
- another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [again - not sure when introduced - seems old, hence I suspect it is a false positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused
---- Thanks, Einav
Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
it seems that after the fixes and clean-up, find-bugs is now back to normal: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/ all - many thanks for your prompt response! ---- Regards, Einav ----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Sahina Bose" <sabose@redhat.com>, "Michael Kublin" <mkublin@redhat.com>, "Michal Skrivanek" <michal.skrivanek@redhat.com>, "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, April 23, 2013 10:17:20 PM Subject: [Engine-devel] find-bugs errors - please investigate/fix
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below]
@Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13831/
@Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13740/
@Michal Skrivanek:
the following seem strange - can you please investigate? could be false positives.
- find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [not sure when introduced - seems old, hence I suspect it is a false positive]
- Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar.
- another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [again - not sure when introduced - seems old, hence I suspect it is a false positive]
---- Thanks, Einav _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
thanks for the fix. Also, finally we see some progress on the 'low' priority bugs, fixing 337, which now stands on ~1600 instead of ~1900... http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/findbugsResult/? Eyal. ----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Sahina Bose" <sabose@redhat.com>, "Michal Skrivanek" <michal.skrivanek@redhat.com>, "Tal Nisan" <tnisan@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org>, "Eyal Edri" <eedri@redhat.com> Sent: Wednesday, April 24, 2013 3:48:34 PM Subject: Re: [Engine-devel] find-bugs errors - please investigate/fix
it seems that after the fixes and clean-up, find-bugs is now back to normal: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/
all - many thanks for your prompt response!
---- Regards, Einav
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Sahina Bose" <sabose@redhat.com>, "Michael Kublin" <mkublin@redhat.com>, "Michal Skrivanek" <michal.skrivanek@redhat.com>, "Eyal Edri" <eedri@redhat.com> Cc: "engine-devel" <engine-devel@ovirt.org> Sent: Tuesday, April 23, 2013 10:17:20 PM Subject: [Engine-devel] find-bugs errors - please investigate/fix
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below]
@Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13831/
@Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... caused by: http://gerrit.ovirt.org/#/c/13740/
@Michal Skrivanek:
the following seem strange - can you please investigate? could be false positives.
- find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [not sure when introduced - seems old, hence I suspect it is a false positive]
- Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable OnSuccess method within an anonymous class" or something similar.
- another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORM... [again - not sure when introduced - seems old, hence I suspect it is a false positive]
---- Thanks, Einav _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
participants (5)
-
Einav Cohen -
Eyal Edri -
Michal Skrivanek -
Sahina Bose -
Tal Nisan