[vdsm] Standard patch check broken by Black formatter for network stuff

Hi, standard patch check tests for vdsm are broken due to Black formatter check failure (see e.g. [1]): Oh no! 10:16:24 6 files would be reformatted, 164 files would be left unchanged. 10:16:24 ERROR: InvocationError for command /home/jenkins/workspace/ vdsm_standard-check-patch/vdsm/.tox/black/bin/black -l 79 -S --check ./lib/ vdsm/network/ ./tests/network (exited with code 1) Can someone take a look and fix it? I did a quick check and wasn't able to find any recent commit which should cause this failure:-( Thanks Vojta [1] https://jenkins.ovirt.org/job/vdsm_standard-check-patch/13396

+Edward Haas <edwardh@redhat.com> +Dominik Holler <dholler@redhat.com> On Tue, Oct 29, 2019 at 12:52 PM Vojtech Juranek <vjuranek@redhat.com> wrote:
Hi, standard patch check tests for vdsm are broken due to Black formatter check failure (see e.g. [1]):
Oh no! 10:16:24 6 files would be reformatted, 164 files would be left unchanged. 10:16:24 ERROR: InvocationError for command /home/jenkins/workspace/ vdsm_standard-check-patch/vdsm/.tox/black/bin/black -l 79 -S --check ./lib/ vdsm/network/ ./tests/network (exited with code 1)
Can someone take a look and fix it? I did a quick check and wasn't able to find any recent commit which should cause this failure:-(
Thanks Vojta
[1] https://jenkins.ovirt.org/job/vdsm_standard-check-patch/13396 _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/VD6LJ5A7Q3MX6T...

https://gerrit.ovirt.org/#/c/104284/ just got merged. On Tue, Oct 29, 2019 at 12:54 PM Tal Nisan <tnisan@redhat.com> wrote:
+Edward Haas <edwardh@redhat.com> +Dominik Holler <dholler@redhat.com>
On Tue, Oct 29, 2019 at 12:52 PM Vojtech Juranek <vjuranek@redhat.com> wrote:
Hi, standard patch check tests for vdsm are broken due to Black formatter check failure (see e.g. [1]):
Oh no! 10:16:24 6 files would be reformatted, 164 files would be left unchanged. 10:16:24 ERROR: InvocationError for command /home/jenkins/workspace/ vdsm_standard-check-patch/vdsm/.tox/black/bin/black -l 79 -S --check ./lib/ vdsm/network/ ./tests/network (exited with code 1)
Can someone take a look and fix it? I did a quick check and wasn't able to find any recent commit which should cause this failure:-(
Thanks Vojta
[1] https://jenkins.ovirt.org/job/vdsm_standard-check-patch/13396 _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/VD6LJ5A7Q3MX6T...
participants (3)
-
Edward Haas
-
Tal Nisan
-
Vojtech Juranek