[VDSM] Broken test - testV2VOutput

Hi all, The following test fails consistently, looks like bad test, running real v2v instead of the fake-v2v script. Last change in this area was commit 985cbe87077512adf1ff594841b7f79674d451fc Author: Tomáš Golembiovský <tgolembi@redhat.com> Date: Wed Jun 22 15:21:26 2016 +0200 v2v: Log detailed output of virt-v2v The detailed log of virt-v2v output is often necessary to debug conversion failures. We provide '-v -x' arguments to virt-v2v to get the detailed output and store the logs in the VDSM log directory. We cannot use execCmd() to store the log output. Therefore we use CPopen directly to redirect stderr to stdout and pipe it to tee to store everything in a log file. Logs older than 30 days are removed periodically on the daily basis. Please fix or disable this test. ====================================================================== ERROR: testV2VOutput (v2vTests.v2vTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/root/rpmbuild/BUILD/vdsm-4.18.999/tests/v2vTests.py", line 552, in testV2VOutput with open('fake-virt-v2v.err', 'r') as f: IOError: [Errno 2] No such file or directory: 'fake-virt-v2v.err' -------------------- >> begin captured logging << -------------------- 2016-09-04 23:06:55,217 DEBUG [root] (MainThread) /usr/bin/taskset --cpu-list 0-7 /root/rpmbuild/BUILD/vdsm-4.18.999/tests/fake-virt-v2v -v -x -ic 'vpx://adminr%40vsphere@0.0.0.0/ovirt/0.0.0.0?no_verify=1' -o vdsm -of raw -oa sparse --vdsm-image-uuid 00000000-0000-0000-0000-000000000001 --vdsm-vol-uuid 00000000-0000-0000-0000-000000000002 --vdsm-image-uuid 00000000-0000-0000-0000-000000000003 --vdsm-vol-uuid 00000000-0000-0000-0000-000000000004 --password-file /tmp/mypass --vdsm-vm-uuid 00000000-0000-0000-0000-000000000005 --vdsm-ovf-output /usr/local/var/run/vdsm/v2v --machine-readable -os /rhev/data-center/00000000-0000-0000-0000-000000000006/00000000-0000-0000-0000-000000000007 TEST (cwd None) 2016-09-04 23:06:55,292 DEBUG [root] (MainThread) SUCCESS: <err> = 'libguestfs: trace: internal_autosync = 0\nlibguestfs: sending SIGTERM to process 12345\nlibguestfs: trace: shutdown = 0\nlibguestfs: trace: close\nlibguestfs: closing guestfs handle 0x1e265f0 (state 0)\n'; <rc> = 0 --------------------- >> end captured logging << ---------------------

On Sun, Sep 04, 2016 at 11:39:07PM +0300, Nir Soffer wrote:
Hi all,
The following test fails consistently, looks like bad test, running real v2v instead of the fake-v2v script.
Last change in this area was
commit 985cbe87077512adf1ff594841b7f79674d451fc Author: Tomáš Golembiovský <tgolembi@redhat.com> Date: Wed Jun 22 15:21:26 2016 +0200
v2v: Log detailed output of virt-v2v
The detailed log of virt-v2v output is often necessary to debug conversion failures. We provide '-v -x' arguments to virt-v2v to get the detailed output and store the logs in the VDSM log directory.
We cannot use execCmd() to store the log output. Therefore we use CPopen directly to redirect stderr to stdout and pipe it to tee to store everything in a log file.
Logs older than 30 days are removed periodically on the daily basis.
Please fix or disable this test.
Tomas, I'm guessing that https://gerrit.ovirt.org/63273 tests: unbreake testV2VOutput would do the trick, but I did not test that. Could Jenkins run the unit test from the distributed tarball to catch such omissions?
====================================================================== ERROR: testV2VOutput (v2vTests.v2vTests) ----------------------------------------------------------------------
participants (2)
-
Dan Kenigsberg
-
Nir Soffer