[Engine-devel] Add traffic shaping parameters for a network interface.
Hi Guys, I've recently submitted a patch to support traffic shaping for a network interface (http://gerrit.ovirt.org/#/c/15445/). This work is needed in order to support http://www.ovirt.org/Features/Network_QoS . Given: 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': '1024'}, 'outbound': {'average': '128', 'burst': '256'}}} Generated xml is the following one: <bandwidth> <inbound average="1000" burst="1024" peak="5000"/> <outbound average="128" burst="256"/> </bandwidth> As you can see I tried to keep the data structure as flat as possible having the bandwidth element not carrying any useful information. Feedback is highly appreciated. Cheers, Giuseppe.
On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote:
Hi Guys, I've recently submitted a patch to support traffic shaping for a network interface (http://gerrit.ovirt.org/#/c/15445/). This work is needed in order to support http://www.ovirt.org/Features/Network_QoS . Given:
'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': '1024'}, 'outbound': {'average': '128', 'burst': '256'}}}
Generated xml is the following one:
<bandwidth> <inbound average="1000" burst="1024" peak="5000"/> <outbound average="128" burst="256"/> </bandwidth>
As you can see I tried to keep the data structure as flat as possible having the bandwidth element not carrying any useful information. Feedback is highly appreciated.
The issue has not been mentioned on the wiki page, but may need a means to report the currently-configured QoS of each vNIC from Vdsm to Engine. For example, when a VM is de-hibernated, we may want to tell whether its QoS needs to be set according to a recently-tweaked policy. I suggest that we use the "getVmList" verb of Vdsm, which is intended to report "static" properties of one Vm (or all of them). On the other hand, Engine would want to blindly set new values whenever in doubt. In such a case, I think that reporting of QoS can be avoided. Dan.
----- Original Message ----- | From: "Dan Kenigsberg" <danken@redhat.com> | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | Cc: engine-devel@ovirt.org | Sent: Monday, June 10, 2013 4:22:54 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface. | | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote: | > Hi Guys, I've recently submitted a patch to support traffic shaping for a | > network interface (http://gerrit.ovirt.org/#/c/15445/). | > This work is needed in order to support | > http://www.ovirt.org/Features/Network_QoS . | > Given: | > | > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': | > '1024'}, | > 'outbound': {'average': '128', 'burst': '256'}}} | > | > Generated xml is the following one: | > | > | > | > | > | > | > As you can see I tried to keep the data structure as flat as possible | > having the bandwidth element not carrying any useful information. | > Feedback is highly appreciated. | > | | The issue has not been mentioned on the wiki page, but may need a means | to report the currently-configured QoS of each vNIC from Vdsm to Engine. | For example, when a VM is de-hibernated, we may want to tell whether its | QoS needs to be set according to a recently-tweaked policy. | | I suggest that we use the "getVmList" verb of Vdsm, which is intended to | report "static" properties of one Vm (or all of them). | | On the other hand, Engine would want to blindly set new values whenever | in doubt. In such a case, I think that reporting of QoS can be avoided. | | Dan. | I'm not sure I've understood completely the issue in discussion, doesn't the engine knows already which are the QoS profile applied to each vNIC ? The last 'tweaked' profile is the one that should be applied after de-hibernation. This means that on the engine side we should keep track of profile change, if a change happens de-hibernating a vm triggers a QoS profile update on the host of the latest profile. I'm not aware of the implementation details so I might be wrong. Giuseppe.
----- Original Message -----
From: "Giuseppe Vallarelli" <gvallare@redhat.com> To: "Dan Kenigsberg" <danken@redhat.com> Cc: engine-devel@ovirt.org Sent: Monday, June 10, 2013 6:04:27 PM Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
----- Original Message ----- | From: "Dan Kenigsberg" <danken@redhat.com> | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | Cc: engine-devel@ovirt.org | Sent: Monday, June 10, 2013 4:22:54 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | interface. | | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote: | > Hi Guys, I've recently submitted a patch to support traffic shaping for a | > network interface (http://gerrit.ovirt.org/#/c/15445/). | > This work is needed in order to support | > http://www.ovirt.org/Features/Network_QoS . | > Given: | > | > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': | > '1024'}, | > 'outbound': {'average': '128', 'burst': '256'}}} | > | > Generated xml is the following one: | > | > | > | > | > | > | > As you can see I tried to keep the data structure as flat as possible | > having the bandwidth element not carrying any useful information. | > Feedback is highly appreciated. | > | | The issue has not been mentioned on the wiki page, but may need a means | to report the currently-configured QoS of each vNIC from Vdsm to Engine. | For example, when a VM is de-hibernated, we may want to tell whether its | QoS needs to be set according to a recently-tweaked policy. | | I suggest that we use the "getVmList" verb of Vdsm, which is intended to | report "static" properties of one Vm (or all of them). | | On the other hand, Engine would want to blindly set new values whenever | in doubt. In such a case, I think that reporting of QoS can be avoided. | | Dan. |
I'm not sure I've understood completely the issue in discussion, doesn't the engine knows already which are the QoS profile applied to each vNIC ? The last 'tweaked' profile is the one that should be applied after de-hibernation. This means that on the engine side we should keep track of profile change, if a change happens de-hibernating a vm triggers a QoS profile update on the host of the latest profile. I'm not aware of the implementation details so I might be wrong.
Giuseppe.
The idea is to handle scenarios where something went wrong; For example, VDSM crash while starting a new VM, engine crash, etc. So the engine should be able to ask for current QoS for reporting, and (re-)apply it if out of sync.
----- Original Message ----- | From: "Doron Fediuck" <dfediuck@redhat.com> | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | Cc: "Dan Kenigsberg" <danken@redhat.com>, engine-devel@ovirt.org | Sent: Monday, June 10, 2013 6:46:29 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface. | | | | ----- Original Message ----- | > From: "Giuseppe Vallarelli" <gvallare@redhat.com> | > To: "Dan Kenigsberg" <danken@redhat.com> | > Cc: engine-devel@ovirt.org | > Sent: Monday, June 10, 2013 6:04:27 PM | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | > interface. | > | > ----- Original Message ----- | > | From: "Dan Kenigsberg" <danken@redhat.com> | > | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | > | Cc: engine-devel@ovirt.org | > | Sent: Monday, June 10, 2013 4:22:54 PM | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | > | interface. | > | | > | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote: | > | > Hi Guys, I've recently submitted a patch to support traffic shaping for | > | > a | > | > network interface (http://gerrit.ovirt.org/#/c/15445/). | > | > This work is needed in order to support | > | > http://www.ovirt.org/Features/Network_QoS . | > | > Given: | > | > | > | > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': | > | > '1024'}, | > | > 'outbound': {'average': '128', 'burst': '256'}}} | > | > | > | > Generated xml is the following one: | > | > | > | > | > | > | > | > | > | > | > | > | > | > As you can see I tried to keep the data structure as flat as possible | > | > having the bandwidth element not carrying any useful information. | > | > Feedback is highly appreciated. | > | > | > | | > | The issue has not been mentioned on the wiki page, but may need a means | > | to report the currently-configured QoS of each vNIC from Vdsm to Engine. | > | For example, when a VM is de-hibernated, we may want to tell whether its | > | QoS needs to be set according to a recently-tweaked policy. | > | | > | I suggest that we use the "getVmList" verb of Vdsm, which is intended to | > | report "static" properties of one Vm (or all of them). | > | | > | On the other hand, Engine would want to blindly set new values whenever | > | in doubt. In such a case, I think that reporting of QoS can be avoided. | > | | > | Dan. | > | | > | > I'm not sure I've understood completely the issue in discussion, doesn't | > the | > engine knows already | > which are the QoS profile applied to each vNIC ? The last 'tweaked' profile | > is the one that should | > be applied after de-hibernation. This means that on the engine side we | > should | > keep track of profile | > change, if a change happens de-hibernating a vm triggers a QoS profile | > update | > on the host of the | > latest profile. I'm not aware of the implementation details so I might be | > wrong. | > | > Giuseppe. | | The idea is to handle scenarios where something went wrong; | For example, VDSM crash while starting a new VM, engine crash, etc. | So the engine should be able to ask for current QoS for reporting, | and (re-)apply it if out of sync. | Hi Doron, thanks for the feedback, makes sense to me. Giuseppe
On 06/10/2013 07:46 PM, Doron Fediuck wrote:
----- Original Message -----
From: "Giuseppe Vallarelli" <gvallare@redhat.com> To: "Dan Kenigsberg" <danken@redhat.com> Cc: engine-devel@ovirt.org Sent: Monday, June 10, 2013 6:04:27 PM Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
----- Original Message ----- | From: "Dan Kenigsberg" <danken@redhat.com> | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | Cc: engine-devel@ovirt.org | Sent: Monday, June 10, 2013 4:22:54 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | interface. | | On Mon, Jun 10, 2013 at 08:56:21AM -0400, Giuseppe Vallarelli wrote: | > Hi Guys, I've recently submitted a patch to support traffic shaping for a | > network interface (http://gerrit.ovirt.org/#/c/15445/). | > This work is needed in order to support | > http://www.ovirt.org/Features/Network_QoS . | > Given: | > | > 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst': | > '1024'}, | > 'outbound': {'average': '128', 'burst': '256'}}} | > | > Generated xml is the following one: | > | > | > | > | > | > | > As you can see I tried to keep the data structure as flat as possible | > having the bandwidth element not carrying any useful information. | > Feedback is highly appreciated. | > | | The issue has not been mentioned on the wiki page, but may need a means | to report the currently-configured QoS of each vNIC from Vdsm to Engine. | For example, when a VM is de-hibernated, we may want to tell whether its | QoS needs to be set according to a recently-tweaked policy. | | I suggest that we use the "getVmList" verb of Vdsm, which is intended to | report "static" properties of one Vm (or all of them). | | On the other hand, Engine would want to blindly set new values whenever | in doubt. In such a case, I think that reporting of QoS can be avoided. | | Dan. |
I'm not sure I've understood completely the issue in discussion, doesn't the engine knows already which are the QoS profile applied to each vNIC ? The last 'tweaked' profile is the one that should be applied after de-hibernation. This means that on the engine side we should keep track of profile change, if a change happens de-hibernating a vm triggers a QoS profile update on the host of the latest profile. I'm not aware of the implementation details so I might be wrong.
Giuseppe.
The idea is to handle scenarios where something went wrong; For example, VDSM crash while starting a new VM, engine crash, etc. So the engine should be able to ask for current QoS for reporting, and (re-)apply it if out of sync.
In addition, if we change the VNIC profile we do not require the VMs that are using this profile to be down. Now we can reach a state were the profile is configured for one thing and the VMs using this profile are running with another value. At least we would like the user to be aware of that. I'm not sure if we'd like to sync it automatically. I would start only with exposing this information to our administrator. Livnat
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Related to QoS parameters reporting to the engine. Looks like they're already available, I tried to use vdsClient with list verb and I've got the devices list where a 'specParams' is defined (it's empty because I didn't try it with my last patch). devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', 'network': 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'} ...] Perhaps I'm missing something, any ideas/hints ? Thanks Giuseppe
----- Original Message ----- | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | To: "Livnat Peer" <lpeer@redhat.com> | Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan Kenigsberg" <danken@redhat.com> | Sent: Tuesday, June 11, 2013 3:07:32 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface. | | Related to QoS parameters reporting to the engine. Looks like they're already | available, I tried to use vdsClient with list verb and I've got the devices | list where a 'specParams' is defined (it's empty because I didn't try it with | my last patch). | | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', 'network': | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': | '0x03', 'bus': '0x00', 'domain': '0x0000', | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'} | ...] | | Perhaps I'm missing something, any ideas/hints ? | Thanks Giuseppe A few pastes: creating the vm: http://paste.fedoraproject.org/17953/37096041/ dumping vm xml: http://paste.fedoraproject.org/17951/37096009/ I've tried this out thanks to Toni, losing sanity with vdsClient.. Giuseppe
----- Original Message -----
From: "Giuseppe Vallarelli" <gvallare@redhat.com> To: "Livnat Peer" <lpeer@redhat.com> Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan Kenigsberg" <danken@redhat.com> Sent: Tuesday, June 11, 2013 5:34:16 PM Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
----- Original Message ----- | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | To: "Livnat Peer" <lpeer@redhat.com> | Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan | Kenigsberg" <danken@redhat.com> | Sent: Tuesday, June 11, 2013 3:07:32 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | interface. | | Related to QoS parameters reporting to the engine. Looks like they're | already | available, I tried to use vdsClient with list verb and I've got the devices | list where a 'specParams' is defined (it's empty because I didn't try it | with | my last patch). | | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', | 'network': | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': | '0x03', 'bus': '0x00', 'domain': '0x0000', | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'} | ...] | | Perhaps I'm missing something, any ideas/hints ? | Thanks Giuseppe
A few pastes: creating the vm: http://paste.fedoraproject.org/17953/37096041/ dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
I've tried this out thanks to Toni, losing sanity with vdsClient..
Giuseppe
Thanks Giuseppe. Is this also reported by vdsm in getVmStats?
----- Original Message ----- | From: "Doron Fediuck" <dfediuck@redhat.com> | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | Cc: "Livnat Peer" <lpeer@redhat.com>, engine-devel@ovirt.org, "Dan Kenigsberg" <danken@redhat.com> | Sent: Wednesday, June 12, 2013 9:05:35 AM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface. | | | | ----- Original Message ----- | > From: "Giuseppe Vallarelli" <gvallare@redhat.com> | > To: "Livnat Peer" <lpeer@redhat.com> | > Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan | > Kenigsberg" <danken@redhat.com> | > Sent: Tuesday, June 11, 2013 5:34:16 PM | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | > interface. | > | > ----- Original Message ----- | > | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | > | To: "Livnat Peer" <lpeer@redhat.com> | > | Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan | > | Kenigsberg" <danken@redhat.com> | > | Sent: Tuesday, June 11, 2013 3:07:32 PM | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | > | interface. | > | | > | Related to QoS parameters reporting to the engine. Looks like they're | > | already | > | available, I tried to use vdsClient with list verb and I've got the | > | devices | > | list where a 'specParams' is defined (it's empty because I didn't try it | > | with | > | my last patch). | > | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', | > | 'network': | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': | > | '0x03', 'bus': '0x00', 'domain': '0x0000', | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': | > | 'interface'} | > | ...] | > | | > | Perhaps I'm missing something, any ideas/hints ? | > | Thanks Giuseppe | > | > A few pastes: | > creating the vm: http://paste.fedoraproject.org/17953/37096041/ | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/ | > | > I've tried this out thanks to Toni, losing sanity with vdsClient.. | > | > Giuseppe | > | | Thanks Giuseppe. | Is this also reported by vdsm in getVmStats? | Unfortunately is not reported using getVmStats, I'm looking into it. Giuseppe
----- Original Message ----- | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | To: "Doron Fediuck" <dfediuck@redhat.com> | Cc: engine-devel@ovirt.org | Sent: Wednesday, June 12, 2013 9:28:19 AM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface. | | | | ----- Original Message ----- | | From: "Doron Fediuck" <dfediuck@redhat.com> | | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | | Cc: "Livnat Peer" <lpeer@redhat.com>, engine-devel@ovirt.org, "Dan | | Kenigsberg" <danken@redhat.com> | | Sent: Wednesday, June 12, 2013 9:05:35 AM | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | | interface. | | | | | | | | ----- Original Message ----- | | > From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > To: "Livnat Peer" <lpeer@redhat.com> | | > Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan | | > Kenigsberg" <danken@redhat.com> | | > Sent: Tuesday, June 11, 2013 5:34:16 PM | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | | > interface. | | > | | > ----- Original Message ----- | | > | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > | To: "Livnat Peer" <lpeer@redhat.com> | | > | Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan | | > | Kenigsberg" <danken@redhat.com> | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | > | network | | > | interface. | | > | | | > | Related to QoS parameters reporting to the engine. Looks like they're | | > | already | | > | available, I tried to use vdsClient with list verb and I've got the | | > | devices | | > | list where a 'specParams' is defined (it's empty because I didn't try | | > | it | | > | with | | > | my last patch). | | > | | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', | | > | 'network': | | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': | | > | '0x03', 'bus': '0x00', 'domain': '0x0000', | | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': | | > | 'interface'} | | > | ...] | | > | | | > | Perhaps I'm missing something, any ideas/hints ? | | > | Thanks Giuseppe | | > | | > A few pastes: | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/ | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/ | | > | | > I've tried this out thanks to Toni, losing sanity with vdsClient.. | | > | | > Giuseppe | | > | | | | Thanks Giuseppe. | | Is this also reported by vdsm in getVmStats? | | | | Unfortunately is not reported using getVmStats, I'm looking into it. | Giuseppe New paste: http://paste.fedoraproject.org/18161/71033933/ Giuseppe
----- Original Message -----
From: "Giuseppe Vallarelli" <gvallare@redhat.com> To: "Doron Fediuck" <dfediuck@redhat.com> Cc: engine-devel@ovirt.org Sent: Wednesday, June 12, 2013 1:47:03 PM Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
----- Original Message ----- | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | To: "Doron Fediuck" <dfediuck@redhat.com> | Cc: engine-devel@ovirt.org | Sent: Wednesday, June 12, 2013 9:28:19 AM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | interface. | | | | ----- Original Message ----- | | From: "Doron Fediuck" <dfediuck@redhat.com> | | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | | Cc: "Livnat Peer" <lpeer@redhat.com>, engine-devel@ovirt.org, "Dan | | Kenigsberg" <danken@redhat.com> | | Sent: Wednesday, June 12, 2013 9:05:35 AM | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | | interface. | | | | | | | | ----- Original Message ----- | | > From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > To: "Livnat Peer" <lpeer@redhat.com> | | > Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan | | > Kenigsberg" <danken@redhat.com> | | > Sent: Tuesday, June 11, 2013 5:34:16 PM | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | > network | | > interface. | | > | | > ----- Original Message ----- | | > | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > | To: "Livnat Peer" <lpeer@redhat.com> | | > | Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, | | > | "Dan | | > | Kenigsberg" <danken@redhat.com> | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | > | network | | > | interface. | | > | | | > | Related to QoS parameters reporting to the engine. Looks like they're | | > | already | | > | available, I tried to use vdsClient with list verb and I've got the | | > | devices | | > | list where a 'specParams' is defined (it's empty because I didn't try | | > | it | | > | with | | > | my last patch). | | > | | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', | | > | 'network': | | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': | | > | {'slot': | | > | '0x03', 'bus': '0x00', 'domain': '0x0000', | | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': | | > | 'interface'} | | > | ...] | | > | | | > | Perhaps I'm missing something, any ideas/hints ? | | > | Thanks Giuseppe | | > | | > A few pastes: | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/ | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/ | | > | | > I've tried this out thanks to Toni, losing sanity with vdsClient.. | | > | | > Giuseppe | | > | | | | Thanks Giuseppe. | | Is this also reported by vdsm in getVmStats? | | | | Unfortunately is not reported using getVmStats, I'm looking into it. | Giuseppe
New paste: http://paste.fedoraproject.org/18161/71033933/
Giuseppe
Brilliant, thanks!
On Wed, Jun 12, 2013 at 06:54:52AM -0400, Doron Fediuck wrote:
----- Original Message -----
From: "Giuseppe Vallarelli" <gvallare@redhat.com> To: "Doron Fediuck" <dfediuck@redhat.com> Cc: engine-devel@ovirt.org Sent: Wednesday, June 12, 2013 1:47:03 PM Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
----- Original Message ----- | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | To: "Doron Fediuck" <dfediuck@redhat.com> | Cc: engine-devel@ovirt.org | Sent: Wednesday, June 12, 2013 9:28:19 AM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | interface. | | | | ----- Original Message ----- | | From: "Doron Fediuck" <dfediuck@redhat.com> | | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | | Cc: "Livnat Peer" <lpeer@redhat.com>, engine-devel@ovirt.org, "Dan | | Kenigsberg" <danken@redhat.com> | | Sent: Wednesday, June 12, 2013 9:05:35 AM | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network | | interface. | | | | | | | | ----- Original Message ----- | | > From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > To: "Livnat Peer" <lpeer@redhat.com> | | > Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan | | > Kenigsberg" <danken@redhat.com> | | > Sent: Tuesday, June 11, 2013 5:34:16 PM | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | > network | | > interface. | | > | | > ----- Original Message ----- | | > | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > | To: "Livnat Peer" <lpeer@redhat.com> | | > | Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, | | > | "Dan | | > | Kenigsberg" <danken@redhat.com> | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | > | network | | > | interface. | | > | | | > | Related to QoS parameters reporting to the engine. Looks like they're | | > | already | | > | available, I tried to use vdsClient with list verb and I've got the | | > | devices | | > | list where a 'specParams' is defined (it's empty because I didn't try | | > | it | | > | with | | > | my last patch). | | > | | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', | | > | 'network': | | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': | | > | {'slot': | | > | '0x03', 'bus': '0x00', 'domain': '0x0000', | | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': | | > | 'interface'} | | > | ...] | | > | | | > | Perhaps I'm missing something, any ideas/hints ? | | > | Thanks Giuseppe | | > | | > A few pastes: | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/ | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/ | | > | | > I've tried this out thanks to Toni, losing sanity with vdsClient.. | | > | | > Giuseppe | | > | | | | Thanks Giuseppe. | | Is this also reported by vdsm in getVmStats? | | | | Unfortunately is not reported using getVmStats, I'm looking into it. | Giuseppe
(using hyperlinks instead of inlining the suggested API is unfriendly to reviewers and to list archives) network = {'vnet0': {'macAddr': 'D0:67:E5:F0:75:B4', 'outbound': {'average': '1024'}, 'rxDropped': '0', 'txDropped': '0', 'inbound': {'average': '1024'}, 'rxErrors': '0', 'txRate': '0.0', 'rxRate': '0.0', 'txErrors': '0', 'state': 'unknown', 'speed': '1000', 'name': 'vnet0'}}
Giuseppe
Brilliant, thanks!
Why does it fit into getVmStats? getVmStats should report dynamically-changing properties. Bandwidth limitations are more static control entities, why should we report them every 10 seconds or so? Dan
----- Original Message -----
From: "Dan Kenigsberg" <danken@redhat.com> To: "Doron Fediuck" <dfediuck@redhat.com> Cc: "Giuseppe Vallarelli" <gvallare@redhat.com>, engine-devel@ovirt.org Sent: Wednesday, June 12, 2013 3:59:43 PM Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
On Wed, Jun 12, 2013 at 06:54:52AM -0400, Doron Fediuck wrote:
----- Original Message -----
From: "Giuseppe Vallarelli" <gvallare@redhat.com> To: "Doron Fediuck" <dfediuck@redhat.com> Cc: engine-devel@ovirt.org Sent: Wednesday, June 12, 2013 1:47:03 PM Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
----- Original Message ----- | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | To: "Doron Fediuck" <dfediuck@redhat.com> | Cc: engine-devel@ovirt.org | Sent: Wednesday, June 12, 2013 9:28:19 AM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a | network | interface. | | | | ----- Original Message ----- | | From: "Doron Fediuck" <dfediuck@redhat.com> | | To: "Giuseppe Vallarelli" <gvallare@redhat.com> | | Cc: "Livnat Peer" <lpeer@redhat.com>, engine-devel@ovirt.org, "Dan | | Kenigsberg" <danken@redhat.com> | | Sent: Wednesday, June 12, 2013 9:05:35 AM | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | network | | interface. | | | | | | | | ----- Original Message ----- | | > From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > To: "Livnat Peer" <lpeer@redhat.com> | | > Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, | | > "Dan | | > Kenigsberg" <danken@redhat.com> | | > Sent: Tuesday, June 11, 2013 5:34:16 PM | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | > network | | > interface. | | > | | > ----- Original Message ----- | | > | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | | > | To: "Livnat Peer" <lpeer@redhat.com> | | > | Cc: "Doron Fediuck" <dfediuck@redhat.com>, | | > | engine-devel@ovirt.org, | | > | "Dan | | > | Kenigsberg" <danken@redhat.com> | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a | | > | network | | > | interface. | | > | | | > | Related to QoS parameters reporting to the engine. Looks like | | > | they're | | > | already | | > | available, I tried to use vdsClient with list verb and I've got | | > | the | | > | devices | | > | list where a 'specParams' is defined (it's empty because I didn't | | > | try | | > | it | | > | with | | > | my last patch). | | > | | | > | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', | | > | 'network': | | > | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': | | > | {'slot': | | > | '0x03', 'bus': '0x00', 'domain': '0x0000', | | > | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': | | > | 'interface'} | | > | ...] | | > | | | > | Perhaps I'm missing something, any ideas/hints ? | | > | Thanks Giuseppe | | > | | > A few pastes: | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/ | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/ | | > | | > I've tried this out thanks to Toni, losing sanity with vdsClient.. | | > | | > Giuseppe | | > | | | | Thanks Giuseppe. | | Is this also reported by vdsm in getVmStats? | | | | Unfortunately is not reported using getVmStats, I'm looking into it. | Giuseppe
(using hyperlinks instead of inlining the suggested API is unfriendly to reviewers and to list archives)
network = {'vnet0': {'macAddr': 'D0:67:E5:F0:75:B4', 'outbound': {'average': '1024'}, 'rxDropped': '0', 'txDropped': '0', 'inbound': {'average': '1024'}, 'rxErrors': '0', 'txRate': '0.0', 'rxRate': '0.0', 'txErrors': '0', 'state': 'unknown', 'speed': '1000', 'name': 'vnet0'}}
Giuseppe
Brilliant, thanks!
Why does it fit into getVmStats? getVmStats should report dynamically-changing properties. Bandwidth limitations are more static control entities, why should we report them every 10 seconds or so?
Dan
I have no problems with having it in something which runs less frequently.
On Tue, Jun 11, 2013 at 10:34:16AM -0400, Giuseppe Vallarelli wrote:
----- Original Message ----- | From: "Giuseppe Vallarelli" <gvallare@redhat.com> | To: "Livnat Peer" <lpeer@redhat.com> | Cc: "Doron Fediuck" <dfediuck@redhat.com>, engine-devel@ovirt.org, "Dan Kenigsberg" <danken@redhat.com> | Sent: Tuesday, June 11, 2013 3:07:32 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface. | | Related to QoS parameters reporting to the engine. Looks like they're already | available, I tried to use vdsClient with list verb and I've got the devices | list where a 'specParams' is defined (it's empty because I didn't try it with | my last patch). | | devices = [... {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:04', 'network': | 'ovirtmgmt', 'alias': 'net0', 'specParams': {}, | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6', 'address': {'slot': | '0x03', 'bus': '0x00', 'domain': '0x0000', | 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface'} | ...] | | Perhaps I'm missing something, any ideas/hints ?
I believe this is enough.
participants (4)
-
Dan Kenigsberg -
Doron Fediuck -
Giuseppe Vallarelli -
Livnat Peer