Hi, I'm trying to reinstall a CentOS host (using master-snapshot) and I noticed otopi is trying to use python3 while the ovirt-host-deploy is not yet fully python3 compatible:

> 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info info._init:39 SYSTEM INFORMATION - BEGIN > 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info info._init:40 executable /bin/python3 > 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info info._init:41 python version 3.4.8 (default, Mar 23 2018, 10:04:27) > [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)] > 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info info._init:42 python /bin/python3 > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info info._init:43 platform linux > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info info._init:44 distribution ('CentOS Linux', '7.4.1708', 'Core') > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info info._init:45 host 'ovirt-host2' > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info info._init:51 uid 0 euid 0 gid 0 egid 0 > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info info._init:53 SYSTEM INFORMATION - END and then later: > 2018-05-03 21:35:56,912+0200 DEBUG otopi.context context._executeMethod:128 Stage init METHOD otopi.plugins.ovirt_host_ deploy.node.detect.Plugin._init > 2018-05-03 21:35:56,914+0200 DEBUG otopi.context context._executeMethod:143 method exception > Traceback (most recent call last): > File "/tmp/ovirt-a0GNITSwX9/pythonlib/otopi/context.py", line 133, in _executeMethod > method['method']() > File "/tmp/ovirt-a0GNITSwX9/otopi-plugins/ovirt-host-deploy/node/detect.py", line 131, in _init > odeploycons.FileLocations.OVIRT_NODE_VARIANT_VAL) > File "/tmp/ovirt-a0GNITSwX9/otopi-plugins/ovirt-host-deploy/node/detect.py", line 69, in hasconf > io.StringIO('[default]\n' + f.read().decode('utf-8')) > AttributeError: 'str' object has no attribute 'decode' > 2018-05-03 21:35:56,915+0200 ERROR otopi.context context._executeMethod:152 Failed to execute stage 'Initializing': 'str' object has no attribute 'decode' There is definitely a bug (or at least weirdness) in host-deploy -- why use .decode() on object returned by codecs.open()? But also, should host-deploy be already python3 compatible and is this otopi behaviour expected? Tomas -- Tomáš Golembiovský <tgolembi(a)redhat.com&gt; _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

On Fri, 4 May 2018 09:33:11 +0200 Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: > 2018-05-03 21:58 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: > > > Hi, > > > > I'm trying to reinstall a CentOS host (using master-snapshot) and I > > noticed otopi is trying to use python3 while the ovirt-host-deploy is > > not yet fully python3 compatible: > > > > How did you got python 3 on CentOS? > It's not in CentOS distribution. From EPEL. We have 'python34*' listed in our ovirt-*-epel repos.

Tomas > > > > > > > > 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:39 SYSTEM INFORMATION - BEGIN > > > 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:40 executable /bin/python3 > > > 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:41 python version 3.4.8 (default, Mar 23 2018, 10:04:27) > > > [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)] > > > 2018-05-03 21:35:56,855+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:42 python /bin/python3 > > > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:43 platform linux > > > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:44 distribution ('CentOS Linux', '7.4.1708', 'Core') > > > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:45 host 'ovirt-host2' > > > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:51 uid 0 euid 0 gid 0 egid 0 > > > 2018-05-03 21:35:56,856+0200 DEBUG otopi.plugins.otopi.system.info > > info._init:53 SYSTEM INFORMATION - END > > > > and then later: > > > > > 2018-05-03 21:35:56,912+0200 DEBUG otopi.context > > context._executeMethod:128 Stage init METHOD otopi.plugins.ovirt_host_ > > deploy.node.detect.Plugin._init > > > 2018-05-03 21:35:56,914+0200 DEBUG otopi.context > > context._executeMethod:143 method exception > > > Traceback (most recent call last): > > > File "/tmp/ovirt-a0GNITSwX9/pythonlib/otopi/context.py", line 133, in > > _executeMethod > > > method['method']() > > > File "/tmp/ovirt-a0GNITSwX9/otopi-plugins/ovirt-host-deploy/node/detect.py", > > line 131, in _init > > > odeploycons.FileLocations.OVIRT_NODE_VARIANT_VAL) > > > File "/tmp/ovirt-a0GNITSwX9/otopi-plugins/ovirt-host-deploy/node/detect.py", > > line 69, in hasconf > > > io.StringIO('[default]\n' + f.read().decode('utf-8')) > > > AttributeError: 'str' object has no attribute 'decode' > > > 2018-05-03 21:35:56,915+0200 ERROR otopi.context > > context._executeMethod:152 Failed to execute stage 'Initializing': 'str' > > object has no attribute 'decode' > > > > There is definitely a bug (or at least weirdness) in host-deploy -- why > > use .decode() on object returned by codecs.open()? > > > > But also, should host-deploy be already python3 compatible and is this > > otopi behaviour expected? > > > > Tomas > > > > > > -- > > Tomáš Golembiovský <tgolembi(a)redhat.com&gt; > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > -- > > SANDRO BONAZZOLA > > ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D > > Red Hat EMEA <https://www.redhat.com/> > > sbonazzo(a)redhat.com > <https://red.ht/sig> > <https://redhat.com/summit> -- Tomáš Golembiovský <tgolembi(a)redhat.com&gt;

On Fri, May 4, 2018 at 2:09 PM, Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: > > > 2018-05-04 11:07 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: > >> On Fri, 4 May 2018 09:33:11 +0200 >> Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: >> >> > 2018-05-03 21:58 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: >> > >> > > Hi, >> > > >> > > I'm trying to reinstall a CentOS host (using master-snapshot) and I >> > > noticed otopi is trying to use python3 while the ovirt-host-deploy is >> > > not yet fully python3 compatible: >> > > >> > >> > How did you got python 3 on CentOS? >> > It's not in CentOS distribution. >> >> From EPEL. We have 'python34*' listed in our ovirt-*-epel repos. >> > > > Dan, you asked for python34 packages from epel in > https://gerrit.ovirt.org/#/c/55415/ > Are they still needed? I don't see them required anywhere. > Can we drop them? > You are perfectly right, Sandro. My attempt to support Python 3 on el7 failed. https://gerrit.ovirt.org/90912 should clean its remainders. Can anybody remind me how I trigger check-merged job on it, for verification? _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

On 4 May 2018 at 16:01, Greg Sheremeta <gshereme(a)redhat.com&gt; wrote: > ci re-merge please > > Please note that you should never run this on pre-merged patches as it runs all the post-merge code including submission in change-queue. > On Fri, May 4, 2018 at 8:19 AM, Dan Kenigsberg <danken(a)redhat.com&gt; wrote: > >> >> >> On Fri, May 4, 2018 at 2:09 PM, Sandro Bonazzola <sbonazzo(a)redhat.com&gt; >> wrote: >> >>> >>> >>> 2018-05-04 11:07 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: >>> >>>> On Fri, 4 May 2018 09:33:11 +0200 >>>> Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: >>>> >>>> > 2018-05-03 21:58 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: >>>> > >>>> > > Hi, >>>> > > >>>> > > I'm trying to reinstall a CentOS host (using master-snapshot) and I >>>> > > noticed otopi is trying to use python3 while the ovirt-host-deploy >>>> is >>>> > > not yet fully python3 compatible: >>>> > > >>>> > >>>> > How did you got python 3 on CentOS? >>>> > It's not in CentOS distribution. >>>> >>>> From EPEL. We have 'python34*' listed in our ovirt-*-epel repos. >>>> >>> >>> >>> Dan, you asked for python34 packages from epel in >>> https://gerrit.ovirt.org/#/c/55415/ >>> Are they still needed? I don't see them required anywhere. >>> Can we drop them? >>> >> >> You are perfectly right, Sandro. My attempt to support Python 3 on el7 >> failed. >> https://gerrit.ovirt.org/90912 should clean its remainders. >> >> Can anybody remind me how I trigger check-merged job on it, for >> verification? >> >> >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> > > > > -- > > GREG SHEREMETA > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX > > Red Hat NA > > <https://www.redhat.com/> > > gshereme(a)redhat.com IRC: gshereme > <https://red.ht/sig> > > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > -- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted

On 4 May 2018 at 16:01, Greg Sheremeta <gshereme(a)redhat.com&gt; wrote: > ci re-merge please > > Please note that you should never run this on pre-merged patches as it runs all the post-merge code including submission in change-queue.

> On Fri, May 4, 2018 at 8:19 AM, Dan Kenigsberg <danken(a)redhat.com&gt; wrote: > >> >> >> On Fri, May 4, 2018 at 2:09 PM, Sandro Bonazzola <sbonazzo(a)redhat.com&gt; >> wrote: >> >>> >>> >>> 2018-05-04 11:07 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: >>> >>>> On Fri, 4 May 2018 09:33:11 +0200 >>>> Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: >>>> >>>> > 2018-05-03 21:58 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: >>>> > >>>> > > Hi, >>>> > > >>>> > > I'm trying to reinstall a CentOS host (using master-snapshot) and I >>>> > > noticed otopi is trying to use python3 while the ovirt-host-deploy >>>> is >>>> > > not yet fully python3 compatible: >>>> > > >>>> > >>>> > How did you got python 3 on CentOS? >>>> > It's not in CentOS distribution. >>>> >>>> From EPEL. We have 'python34*' listed in our ovirt-*-epel repos. >>>> >>> >>> >>> Dan, you asked for python34 packages from epel in >>> https://gerrit.ovirt.org/#/c/55415/ >>> Are they still needed? I don't see them required anywhere. >>> Can we drop them? >>> >> >> You are perfectly right, Sandro. My attempt to support Python 3 on el7 >> failed. >> https://gerrit.ovirt.org/90912 should clean its remainders. >> >> Can anybody remind me how I trigger check-merged job on it, for >> verification? >> >> >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> > > > > -- > > GREG SHEREMETA > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX > > Red Hat NA > > <https://www.redhat.com/> > > gshereme(a)redhat.com IRC: gshereme > <https://red.ht/sig> > > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > -- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

On 7 May 2018 at 10:15, Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: > > > 2018-05-06 7:53 GMT+02:00 Barak Korren <bkorren(a)redhat.com&gt;: > >> >> >> On 4 May 2018 at 16:01, Greg Sheremeta <gshereme(a)redhat.com&gt; wrote: >> >>> ci re-merge please >>> >>> >> Please note that you should never run this on pre-merged patches as it >> runs all the post-merge code including submission in change-queue. >> > > I hope the code handling "ci re-merge please" is smart enough to check > that the patch is merged before trying to re-merge it. > If not, please fix it. > As I wrote before, the V2 code is, the V1 code isn't, which is one more reason to switch...

> > > >> >> >> >>> On Fri, May 4, 2018 at 8:19 AM, Dan Kenigsberg <danken(a)redhat.com&gt; >>> wrote: >>> >>>> >>>> >>>> On Fri, May 4, 2018 at 2:09 PM, Sandro Bonazzola <sbonazzo(a)redhat.com&gt; >>>> wrote: >>>> >>>>> >>>>> >>>>> 2018-05-04 11:07 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com&gt;: >>>>> >>>>>> On Fri, 4 May 2018 09:33:11 +0200 >>>>>> Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: >>>>>> >>>>>> > 2018-05-03 21:58 GMT+02:00 Tomáš Golembiovský <tgolembi(a)redhat.com >>>>>> >: >>>>>> > >>>>>> > > Hi, >>>>>> > > >>>>>> > > I'm trying to reinstall a CentOS host (using master-snapshot) >>>>>> and I >>>>>> > > noticed otopi is trying to use python3 while the >>>>>> ovirt-host-deploy is >>>>>> > > not yet fully python3 compatible: >>>>>> > > >>>>>> > >>>>>> > How did you got python 3 on CentOS? >>>>>> > It's not in CentOS distribution. >>>>>> >>>>>> From EPEL. We have 'python34*' listed in our ovirt-*-epel repos. >>>>>> >>>>> >>>>> >>>>> Dan, you asked for python34 packages from epel in >>>>> https://gerrit.ovirt.org/#/c/55415/ >>>>> Are they still needed? I don't see them required anywhere. >>>>> Can we drop them? >>>>> >>>> >>>> You are perfectly right, Sandro. My attempt to support Python 3 on el7 >>>> failed. >>>> https://gerrit.ovirt.org/90912 should clean its remainders. >>>> >>>> Can anybody remind me how I trigger check-merged job on it, for >>>> verification? >>>> >>>> >>>> _______________________________________________ >>>> Devel mailing list >>>> Devel(a)ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/devel >>>> >>> >>> >>> >>> -- >>> >>> GREG SHEREMETA >>> >>> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX >>> >>> Red Hat NA >>> >>> <https://www.redhat.com/> >>> >>> gshereme(a)redhat.com IRC: gshereme >>> <https://red.ht/sig> >>> >>> _______________________________________________ >>> Devel mailing list >>> Devel(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/devel >>> >> >> >> >> -- >> Barak Korren >> RHV DevOps team , RHCE, RHCi >> Red Hat EMEA >> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted >> >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> > > > > -- > > SANDRO BONAZZOLA > > ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D > > Red Hat EMEA <https://www.redhat.com/> > > sbonazzo(a)redhat.com > <https://red.ht/sig> > <https://redhat.com/summit> > -- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted