OST: Warning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal

Hi all, I noticed this warning in OST's lago log, e.g. [1]: 2018-11-27 07:32:44,684::log_utils.py::start_log_task::655::nose::INFO:: # detach_vm_network_from_host_0: [0m [0m 2018-11-27 07:32:50,360::network_utils_v4.py::<genexpr>::119::py.warnings::WARNING:: * Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal 2018-11-27 07:32:50,360::log_utils.py::end_log_task::670::nose::INFO:: # detach_vm_network_from_host_0: [32mSuccess [0m (in 0:00:05) This seems to be a result of OST:basic-suite-master/test_utils/network_utils_v4.py:get_network_attachment , which does: network = next(net for net in dc.networks_service().list() if net.name == network_name) Apparently, dc.networks_service() returns a str, not unicode. Is this normal? Expected? Should the caller (OST) convert to unicode if needed, or the SDK? If so, [2] should fix (pushed just now, check-patch should finish in an hour or so, only then we can know for sure). Adding Ondra for considering the SDK side. For reference: to debug this on my own OST machine, I did this (after running the basic suite): python import ovirtsdk4 as sdk4 engine = sdk4.Connection(url='https://%s/ovirt-engine/api' % '192.168.201.4', username='admin@internal', password='123', insecure=True, debug=True).system_service() dc = engine.data_centers_service().data_center_service(engine.data_centers_service().list(search='name={}'.format('test-dc'))[0].id) [(net.name, type(net.name)) for net in dc.networks_service().list()] Which returned: [('ovirtmgmt', <type 'str'>), ('VM Network with a very long name and \xd7\xa2\xd7\x91\xd7\xa8\xd7\x99\xd7\xaa', <type 'str'>), ('Labeled_Network', <type 'str'>), ('Migration_Net', <type 'str'>)] Best regards, [1] https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11697/artifac... [2] https://gerrit.ovirt.org/95768 -- Didi
participants (1)
-
Yedidyah Bar David