2:47 a.m.
--_000_B63C858E777679458338A30A991BB52401612D47G1W3647americas_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hi Juan,
Please help us to review our restful API design with NUMA feature on ovirt
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interface_and_=
data_structure_in_restful_API
We are appreciate that you or some community members could give us some fee=
dback and comments, and sorry for the nag.
Best Regards,
Jason Liao
--_000_B63C858E777679458338A30A991BB52401612D47G1W3647americas_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml"
xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word"
=
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml"
xmlns=3D"http:=
//www.w3.org/TR/REC-html40" <head <meta http-equiv=3D"Content-Type"
content=3D"text/html; charset=3Dus-ascii"=
<meta name=3D"Generator" content=3D"Microsoft
Word 15 (filtered medium)" <style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"HP Simplified";
panose-1:2 11 6 4 2 2 4 2 2 4;}
@font-face
{font-family:"YaHei Consolas Hybrid";
panose-1:2 11 5 9 2 2 4 2 2 4;}
@font-face
{font-family:"\@YaHei Consolas Hybrid";
panose-1:2 11 5 9 2 2 4 2 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"HP Simplified","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" / </xml><![endif]--><!--[if gte mso
9]><xml <o:shapelayout
v:ext=3D"edit" <o:idmap v:ext=3D"edit"
data=3D"1" /
</o:shapelayout></xml><![endif]--
</head <body lang=3D"ZH-CN"
link=3D"#0563C1" vlink=3D"#954F72" style=3D"text-justi=
fy-trim:punctuation" <div
class=3D"WordSection1" <p
class=3D"MsoNormal"><span lang=3D"EN-US"
style=3D"font-family:"HP S=
implified","sans-serif"">Hi Juan,</span><span
lang=3D"EN-US"=
style=3D"font-family:"HP
Simplified","sans-serif""><o:=
p></o:p></span></p <p
class=3D"MsoNormal"><span lang=3D"EN-US"
style=3D"font-family:"HP S=
implified","sans-serif""><o:p> </o:p></span></p <p class=3D"MsoNormal"><span
lang=3D"EN-US" style=3D"font-family:"HP S=
implified","sans-serif"">Please help us to review our
restfu=
l API design with NUMA feature on ovirt<o:p></o:p></span></p <p class=3D"MsoNormal"><span
lang=3D"EN-US" style=3D"font-family:"HP S=
implified","sans-serif""><a
href=3D"http://www.ovirt.org/Fea=
tures/Detailed_NUMA_and_Virtual_NUMA#Interface_and_data_structure_in_restfu=
l_API">http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NU...
ce_and_data_structure_in_restful_API</a><o:p></o:p></span></p <p class=3D"MsoNormal"><span
lang=3D"EN-US" style=3D"font-family:"HP S=
implified","sans-serif""><o:p> </o:p></span></p <p class=3D"MsoNormal"><span
lang=3D"EN-US" style=3D"font-family:"HP S=
implified","sans-serif"">We are appreciate that you or
some =
community members could give us some feedback and comments, and sorry for t=
he nag.<o:p></o:p></span></p <p
class=3D"MsoNormal"><span lang=3D"EN-US"
style=3D"font-family:"HP S=
implified","sans-serif""><o:p> </o:p></span></p <p class=3D"MsoNormal"><b><span
lang=3D"EN-US" style=3D"font-size:9.0pt;fon=
t-family:"HP
Simplified","sans-serif";color:black">Best=
Regards,<br </span></b><span
lang=3D"EN-US" style=3D"font-size:9.0pt;font-family:"=
HP Simplified","sans-serif";color:#717172">Jason
Liao</span>=
<span lang=3D"EN-US"><o:p></o:p></span></p <p class=3D"MsoNormal"><span
lang=3D"EN-US"><o:p> </o:p></span></p </div
</body </html
--_000_B63C858E777679458338A30A991BB52401612D47G1W3647americas_--
4:24 a.m.
On 04/10/2014 09:47 AM, Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
wrote:
Hi Juan,
Please help us to review our restful API design with NUMA feature on ovirt
http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interface_an...
We are appreciate that you or some community members could give us some
feedback and comments, and sorry for the nag.
*Best Regards,
*Jason Liao
At the moment the RESTAPI design there is very light, so there is very
little to comment. Only thing I can recommend at the moment is to use
longer and clearer names for URL segments:
/hosts/{host:id}/numanodes
/vms/{vm:id}/numanodes
Do you have any additional information about how you plan to implement
the RESTAPI for NUMA?
--
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
3ºD, 28016 Madrid, Spain
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
12:58 a.m.
Hi Juan
Thanks for your feedback. I have already update the wiki page with the restful API calling
BLL layer.
In this week, we are forcing on the 'shell patch' which include the BLL query and
action for NUMA (with dummy data), and submit this as a draft in Gerrit.
After shell patch is done, I will submit another patch 'restful patch' which
include the restful API for NUMA.
I am very appreciate that you will join the reviewer of these patches.
Best Regards,
Jason Liao
-----Original Message-----
From: Juan Hernandez [mailto:jhernand@redhat.com]
Sent: 2014年4月10日 17:25
To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
Cc: devel(a)ovirt.org; Vinod, Chegu; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Subject: Re: Please help us to review our restful API design with NUMA feature on ovirt
On 04/10/2014 09:47 AM, Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
wrote:
> Hi Juan,
>
>
>
> Please help us to review our restful API design with NUMA feature on
> ovirt
>
> http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interface
> _and_data_structure_in_restful_API
>
>
>
> We are appreciate that you or some community members could give us
> some feedback and comments, and sorry for the nag.
>
>
>
> *Best Regards,
> *Jason Liao
>
>
>
At the moment the RESTAPI design there is very light, so there is very little to
comment. Only thing I can recommend at the moment is to use longer and clearer
names for URL segments:
/hosts/{host:id}/numanodes
/vms/{vm:id}/numanodes
Do you have any additional information about how you plan to implement the RESTAPI
for NUMA?
--
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016
Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
4:19 a.m.
Hi Juan,
Before coding the restful API for NUMA feature, I want to make sure the following change
list:
Module restapi-definition
rsdl_metadata.yaml - Add the NUMA definition.
org.ovirt.engine.api.resource - Add NUMA related interface
org.ovirt.engine.api.model - Add NUMA related model
Module restapi-jaxrs
Org.ovirt.engine.api.restapi.resource - Add NUMA related interface implement class
Module restapi-types
Org.ovirt.engine.api.restapi.types - Add NUMA related BE entities mappers
It is appreciate that you could tell me if anything I lost for coding.
Sorry for inconvenience.
Best Regards,
Jason Liao
-----Original Message-----
From: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
Sent: 2014年4月14日 13:58
To: 'Juan Hernandez'
Cc: devel(a)ovirt.org; Vinod, Chegu; Liang, Shang-Chun (David Liang,
HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
Subject: RE: Please help us to review our restful API design with NUMA feature on ovirt
Hi Juan
Thanks for your feedback. I have already update the wiki page with the restful API
calling BLL layer.
In this week, we are forcing on the 'shell patch' which include the BLL query and
action
for NUMA (with dummy data), and submit this as a draft in Gerrit.
After shell patch is done, I will submit another patch 'restful patch' which
include the
restful API for NUMA.
I am very appreciate that you will join the reviewer of these patches.
Best Regards,
Jason Liao
> -----Original Message-----
> From: Juan Hernandez [mailto:jhernand@redhat.com]
> Sent: 2014年4月10日 17:25
> To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> Cc: devel(a)ovirt.org; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Subject: Re: Please help us to review our restful API design with NUMA
> feature on ovirt
>
> On 04/10/2014 09:47 AM, Liao, Chuan (Jason Liao,
> HPservers-Core-OE-PSC)
> wrote:
> > Hi Juan,
> >
> >
> >
> > Please help us to review our restful API design with NUMA feature on
> > ovirt
> >
> > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interfa
> > ce
> > _and_data_structure_in_restful_API
> >
> >
> >
> > We are appreciate that you or some community members could give us
> > some feedback and comments, and sorry for the nag.
> >
> >
> >
> > *Best Regards,
> > *Jason Liao
> >
> >
> >
>
> At the moment the RESTAPI design there is very light, so there is very
> little to comment. Only thing I can recommend at the moment is to use
> longer and clearer names for URL segments:
>
> /hosts/{host:id}/numanodes
> /vms/{vm:id}/numanodes
>
> Do you have any additional information about how you plan to implement
> the RESTAPI for NUMA?
>
> --
> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F.
B82657941
- Red Hat S.L.
7:53 a.m.
On Thursday, April 17, 2014 09:19:00 AM Liao, Chuan wrote:
Hi Juan,
Before coding the restful API for NUMA feature, I want to make sure the
following change list:
Module restapi-definition
rsdl_metadata.yaml - Add the NUMA definition.
org.ovirt.engine.api.resource - Add NUMA related interface
org.ovirt.engine.api.model - Add NUMA related model
Module restapi-jaxrs
Org.ovirt.engine.api.restapi.resource - Add NUMA related interface implement
class
Module restapi-types
Org.ovirt.engine.api.restapi.types - Add NUMA related BE entities mappers
It is appreciate that you could tell me if anything I lost for coding.
Sorry for inconvenience.
Best Regards,
Jason Liao
Don't forget to add your resources to the LinkHelper class so it shows up when
you call /ovirt-engine/api. Also make sure to add it to the FeaturesHelper
class.
I also didn't see you mention the api.xsd. You will need to add the element
definitions in there as well.
> -----Original Message-----
> From: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> Sent: 2014年4月14日 13:58
> To: 'Juan Hernandez'
> Cc: devel(a)ovirt.org; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> Subject: RE: Please help us to review our restful API design with NUMA
> feature on ovirt
> Hi Juan
>
> Thanks for your feedback. I have already update the wiki page with the
> restful API
calling BLL layer.
>
> In this week, we are forcing on the 'shell patch' which include the BLL
> query and action
for NUMA (with dummy data), and submit this as a draft
> in Gerrit.
> After shell patch is done, I will submit another patch 'restful patch'
> which include the
restful API for NUMA.
>
> I am very appreciate that you will join the reviewer of these patches.
>
> Best Regards,
> Jason Liao
>
>
> > -----Original Message-----
> > From: Juan Hernandez [mailto:jhernand@redhat.com]
> > Sent: 2014年4月10日 17:25
> > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)
> > Cc: devel(a)ovirt.org; Vinod, Chegu; Liang, Shang-Chun (David Liang,
> > HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
> > Subject: Re: Please help us to review our restful API design with NUMA
> > feature on ovirt
> >
> >
> >
> > On 04/10/2014 09:47 AM, Liao, Chuan (Jason Liao,
> > HPservers-Core-OE-PSC)
> > wrote:
> >
> > > Hi Juan,
> > >
> > >
> > >
> > >
> > >
> > > Please help us to review our restful API design with NUMA feature on
> > > ovirt
> > >
> > >
> > >
> > > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interfa
> > > ce
> > > _and_data_structure_in_restful_API
> > >
> > >
> > >
> > >
> > >
> > > We are appreciate that you or some community members could give us
> > > some feedback and comments, and sorry for the nag.
> > >
> > >
> > >
> > >
> > >
> > > *Best Regards,
> > > *Jason Liao
> > >
> > >
> > >
> > >
> >
> >
> >
> > At the moment the RESTAPI design there is very light, so there is very
> > little to comment. Only thing I can recommend at the moment is to use
> > longer and clearer names for URL segments:
> >
> >
> >
> > /hosts/{host:id}/numanodes
> > /vms/{vm:id}/numanodes
> >
> >
> >
> > Do you have any additional information about how you plan to implement
> > the RESTAPI for NUMA?
> >
> >
> >
> > --
> > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> > 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid –
> > C.I.F. B82657941
> - Red Hat S.L.
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
3659
days inactive
3666
days old
4 comments
3 participants
participants (3)
-
Alexander Wels -
Juan Hernandez -
Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC)