Error pushing to gerrit

Hi All, when I try to push a patch I get: ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine' Although my patch is signed. Does someone have any clue how to solve this? 10x, Kobi

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I0XQAQVV2RPw6J2ig6kOlPUE7tUKUetQ1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue 27 May 2014 05:22:34 PM CEST, Kobi Ianko wrote:
Hi All, when I try to push a patch I get:
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/= committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Although my patch is signed.
Does someone have any clue how to solve this?
10x, Kobi
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
What does git log -1 show? Probably the Signed-off-by header or it's not well places, or it's not=20 signed by the committer/author/uploader. So you can try to amend the=20 author, or the committer, or the header. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --I0XQAQVV2RPw6J2ig6kOlPUE7tUKUetQ1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJThK5iAAoJEEBxx+HSYmnDnpAIAJlYlGr7eBWNDX91W3xDlHYM S7Ha4tJgUrpJJ6jZNvyFSHJ7evOSvkC1YRlotlkgE93KtK9gFfemFr+MvqDmxRA4 zzRAvXcwifvbUlJ7MKg8L1x74UI4eM4tm5QO1WTMZFFxI/a5r7Tj6zmckUnHWzkc fy2pyK6VZ+ygQu/LPW+3ukHgd9//NGsomsdBRrCb1is4T+RnqVDRdHFYdfugwYn3 KXcAqyI9QGsU+0YJysapmj4XKY7TzSpvtnSepi4hvUVETIiVUHDAHZpSExSZ7eog 2PGipJUv3WEPT/+uSzf5PxaseeLZxVXCDbKT0iFg9cwKBBAdfpQApEuTlpt/WPU= =W6+w -----END PGP SIGNATURE----- --I0XQAQVV2RPw6J2ig6kOlPUE7tUKUetQ1--

----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 6:25:22 PM Subject: Re: [ovirt-devel] Error pushing to gerrit
On Tue 27 May 2014 05:22:34 PM CEST, Kobi Ianko wrote:
Hi All, when I try to push a patch I get:
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Although my patch is signed.
Does someone have any clue how to solve this?
10x, Kobi
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
What does git log -1 show?
git log looks good: commit b5f56e86c64af232d3794a6f1534100a28615e77 Author: Kobi Ianko <kobi@redhat.com> Date: Tue May 13 19:00:08 2014 +0300 core: New internal command, VmSlaPolicyCommand Adding a new command to handle the SLA parameters. For now the new command only contains the CPU Limit parameter which limits the VM's CPU consumption. This Command will be called from the updateVmCommand, and updateMomPolicyCommand. later on it will be called from other parts of the system that configures SLA parameters. Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Kobi Ianko <kobi@redhat.com>
Probably the Signed-off-by header or it's not well places, or it's not signed by the committer/author/uploader. So you can try to amend the author, or the committer, or the header.
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Nv7AthddaWJfIFN6kv5VvRvxttFeV0d3j Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue 27 May 2014 05:39:28 PM CEST, Kobi Ianko wrote:
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 6:25:22 PM Subject: Re: [ovirt-devel] Error pushing to gerrit
On Tue 27 May 2014 05:22:34 PM CEST, Kobi Ianko wrote:
Hi All, when I try to push a patch I get:
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Although my patch is signed.
Does someone have any clue how to solve this?
10x, Kobi
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
What does git log -1 show?
git log looks good:
commit b5f56e86c64af232d3794a6f1534100a28615e77 Author: Kobi Ianko <kobi@redhat.com> Date: Tue May 13 19:00:08 2014 +0300
core: New internal command, VmSlaPolicyCommand
Adding a new command to handle the SLA parameters. For now the new command only contains the CPU Limit parameter which limits the VM's CPU consumption.
This Command will be called from the updateVmCommand, and updateMom=
PolicyCommand.
later on it will be called from other parts of the system that conf=
igures SLA parameters.
Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Kobi Ianko <kobi@redhat.com>
Probably the Signed-off-by header or it's not well places, or it's not=
signed by the committer/author/uploader. So you can try to amend the author, or the committer, or the header.
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Are you sure the are no extra spaces around the headers or extra=20 newlines? -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --Nv7AthddaWJfIFN6kv5VvRvxttFeV0d3j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJThMMZAAoJEEBxx+HSYmnDwhgH+gPQxV5rbUTTGSbCnEdRQTui nWsfnpr7sErUH/kP/P/ZiBWV/hHOEVZBaVAT5XthWiCU9MTN/RULUphNwnSmcLsC JP03pplBe+hZssEB8jDWK5urfyK2Nq2rnhwJKry7ts7P/7w2z44m4ilJbWxWLat0 vA6DQC9db9UbHNu0k4b1s644LqsGrO8HVkaqUgzoFTE6bhQ/aJ0j/sOHFfWduJZL v6hf2CC8R8qOhu8a0JjAPuiFKfiRzeCimvN+7ikIdxNSlNCbwxZVi3RQbBuhj9vR 9IK90e0LrUXqIqQv4uB/rxXal8HeYt+oAKuFhlXHEHwTOzf1V5jka0NxMwSsKeg= =fry8 -----END PGP SIGNATURE----- --Nv7AthddaWJfIFN6kv5VvRvxttFeV0d3j--

yeap, also deleting the sign-by line and executing git commit --amend -s did not solve it still same error... ----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 7:53:45 PM Subject: Re: [ovirt-devel] Error pushing to gerrit
On Tue 27 May 2014 05:39:28 PM CEST, Kobi Ianko wrote:
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: devel@ovirt.org Sent: Tuesday, May 27, 2014 6:25:22 PM Subject: Re: [ovirt-devel] Error pushing to gerrit
On Tue 27 May 2014 05:22:34 PM CEST, Kobi Ianko wrote:
Hi All, when I try to push a patch I get:
! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Although my patch is signed.
Does someone have any clue how to solve this?
10x, Kobi
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
What does git log -1 show?
git log looks good:
commit b5f56e86c64af232d3794a6f1534100a28615e77 Author: Kobi Ianko <kobi@redhat.com> Date: Tue May 13 19:00:08 2014 +0300
core: New internal command, VmSlaPolicyCommand
Adding a new command to handle the SLA parameters. For now the new command only contains the CPU Limit parameter which limits the VM's CPU consumption.
This Command will be called from the updateVmCommand, and updateMomPolicyCommand. later on it will be called from other parts of the system that configures SLA parameters.
Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Kobi Ianko <kobi@redhat.com>
Probably the Signed-off-by header or it's not well places, or it's not signed by the committer/author/uploader. So you can try to amend the author, or the committer, or the header.
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Are you sure the are no extra spaces around the headers or extra newlines?
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (2)
-
David Caro
-
Kobi Ianko