Hey everyone, OST project is now enabled for patch gating. What is the meaning of this? 1. The gating process will start when Code-Review +2, CI +1 and Verified +1 labels are turned on. 2. Every patch before merging will have to pass the following suites: - *oVirt-master* *oVirt-4.3* basic_suite basic_suite upgrade-from-release upgrade-from-release upgrade-from-prevrelease 3. Patches should no longer be manually merged in OST, they will be merged automatically when passing the gate. *NOTE: *Maintainers are still able to merge manually, but it is not recommended if the gate is not passing. *NOTE:* For additional information regarding the gating I've sent FAQ mail - 'Patch Gating summary + FAQ' Regards, Ehud.
On Wed, Sep 25, 2019 at 1:54 PM Ehud Yonasi <eyonasi@redhat.com> wrote:
Hey everyone, OST project is now enabled for patch gating.
What is the meaning of this?
1. The gating process will start when Code-Review +2, CI +1 and Verified +1 labels are turned on. 2. Every patch before merging will have to pass the following suites: -
*oVirt-master*
*oVirt-4.3*
basic_suite
basic_suite
upgrade-from-release
upgrade-from-release
upgrade-from-prevrelease 3. Patches should no longer be manually merged in OST, they will be merged automatically when passing the gate.
According to our discussion stable branch patches should not be merged automatically and will be merged upon the discretion of the maintainer
*NOTE: *Maintainers are still able to merge manually, but it is not recommended if the gate is not passing.
*NOTE:* For additional information regarding the gating I've sent FAQ mail - 'Patch Gating summary + FAQ'
Regards, Ehud. _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZES5BD3FXCKHDR...
On Wed, Sep 25, 2019 at 2:07 PM Tal Nisan <tnisan@redhat.com> wrote:
On Wed, Sep 25, 2019 at 1:54 PM Ehud Yonasi <eyonasi@redhat.com> wrote:
Hey everyone, OST project is now enabled for patch gating.
What is the meaning of this?
1. The gating process will start when Code-Review +2, CI +1 and Verified +1 labels are turned on. 2. Every patch before merging will have to pass the following suites: -
*oVirt-master*
*oVirt-4.3*
basic_suite
basic_suite
upgrade-from-release
upgrade-from-release
upgrade-from-prevrelease 3. Patches should no longer be manually merged in OST, they will be merged automatically when passing the gate.
According to our discussion stable branch patches should not be merged automatically and will be merged upon the discretion of the maintainer
This is for OST patches, not ovirt projects (for now), also, the maintainer can choose when to give +2 to patch, instead of merging it, to allow the system to verify it. So instead of merging, the maintainer can choose when to give +2 and let the system merge it automatically after it passed OST, otherwise you are risking merging something that is breaking OST.
*NOTE: *Maintainers are still able to merge manually, but it is not
recommended if the gate is not passing.
*NOTE:* For additional information regarding the gating I've sent FAQ mail - 'Patch Gating summary + FAQ'
Regards, Ehud. _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZES5BD3FXCKHDR...
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/XQI4SDZP5CUHBF...
-- Eyal edri He / Him / His MANAGER CONTINUOUS PRODUCTIZATION SYSTEM ENGINEERING Red Hat <https://www.redhat.com/> <https://red.ht/sig> phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ #cp-devel)
Ehud Yonasi <eyonasi@redhat.com> writes:
Hey everyone, OST project is now enabled for patch gating.
Hi, it's cool, but before enabling it for other projects, please make sure pending OST problems are fixed. AFAIK the random failures related to add_master_storage_domain in basic-suite-master and discussed here recently haven't been fixed yet (and I think this was the random failure I observed when running OST on my computer yesterday). While random failures may not look that urgent as regular failures, they are still incompatible with patch gating and will cause trouble in projects with more frequent merges and/or longer patch series. Thanks, Milan
What is the meaning of this?
1. The gating process will start when Code-Review +2, CI +1 and Verified +1 labels are turned on. 2. Every patch before merging will have to pass the following suites: -
*oVirt-master*
*oVirt-4.3*
basic_suite
basic_suite
upgrade-from-release
upgrade-from-release
upgrade-from-prevrelease 3. Patches should no longer be manually merged in OST, they will be merged automatically when passing the gate.
*NOTE: *Maintainers are still able to merge manually, but it is not recommended if the gate is not passing.
*NOTE:* For additional information regarding the gating I've sent FAQ mail - 'Patch Gating summary + FAQ'
Regards, Ehud. _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZES5BD3FXCKHDR...
The OST project is now gated. Any concerns you may encounter please let infra owner know by sending an email to infra-support@ovirt.org Thanks, Ehud On Wed, Sep 25, 2019 at 4:48 PM Milan Zamazal <mzamazal@redhat.com> wrote:
Ehud Yonasi <eyonasi@redhat.com> writes:
Hey everyone, OST project is now enabled for patch gating.
Hi,
it's cool, but before enabling it for other projects, please make sure pending OST problems are fixed. AFAIK the random failures related to add_master_storage_domain in basic-suite-master and discussed here recently haven't been fixed yet (and I think this was the random failure I observed when running OST on my computer yesterday). While random failures may not look that urgent as regular failures, they are still incompatible with patch gating and will cause trouble in projects with more frequent merges and/or longer patch series.
Thanks, Milan
What is the meaning of this?
1. The gating process will start when Code-Review +2, CI +1 and Verified +1 labels are turned on. 2. Every patch before merging will have to pass the following suites: -
*oVirt-master*
*oVirt-4.3*
basic_suite
basic_suite
upgrade-from-release
upgrade-from-release
upgrade-from-prevrelease 3. Patches should no longer be manually merged in OST, they will be merged automatically when passing the gate.
*NOTE: *Maintainers are still able to merge manually, but it is not recommended if the gate is not passing.
*NOTE:* For additional information regarding the gating I've sent FAQ mail - 'Patch Gating summary + FAQ'
Regards, Ehud. _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZES5BD3FXCKHDR...
participants (4)
-
Ehud Yonasi -
Eyal Edri -
Milan Zamazal -
Tal Nisan