remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes: To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine' All of the patches has "Signed-off-by" in the footer, and there are no conflicts in the message. Do you have any idea what might be the issue here when trying to push? 10x, Kobi
Is that a new development environment? Can it be that the "Signed-off-by" section contains another user, and not the one you use in gerrit? Oved ----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
All of the patches has "Signed-off-by" in the footer, and there are no conflicts in the message.
Do you have any idea what might be the issue here when trying to push?
10x, Kobi _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
nop, both are kobi@redhat.com ----- Original Message -----
From: "Oved Ourfali" <ovedo@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:40:22 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
Is that a new development environment? Can it be that the "Signed-off-by" section contains another user, and not the one you use in gerrit?
Oved
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
All of the patches has "Signed-off-by" in the footer, and there are no conflicts in the message.
Do you have any idea what might be the issue here when trying to push?
10x, Kobi _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Can you share the output of git show up to the contents of the patch? Nir
the git log: http://pastebin.com/RqbQAfa3 my patches (3 patches) are based on Gilad Chaplik patches which are not merged ----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:48:06 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Can you share the output of git show up to the contents of the patch?
Nir _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:53:30 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
the git log: http://pastebin.com/RqbQAfa3
commit bacb57540fba62b0a5a715280a4a17421bdd8660 Author: Gilad Chaplik <gchaplik@redhat.com> Date: Wed May 28 20:40:22 2014 +0300 db, core: aggregate qos and storage qos impl - DB and DAL changes: create qos table to accomodate qos objects and include storage qos and its limits. - added qos_sp.sql to add default sp. For more information see: http://www.ovirt.org/Features/aggregate_QoS, http://www.ovirt.org/Features/blkio-support Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Signed-off-by: Gilad Chaplik <gchaplik@redhat.com> This one does not have a footer - try to amend so you have a blank line before the Change-Id: line.
my patches (3 patches) are based on Gilad Chaplik patches which are not merged
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:48:06 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Can you share the output of git show up to the contents of the patch?
Nir _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
the git log: http://pastebin.com/RqbQAfa3 my patches (3 patches) are based on Gilad Chaplik patches which are not merged ----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:48:06 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Can you share the output of git show up to the contents of the patch?
Nir _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
You seem to be missing the "Signed-Off-By" line, see [1]. [1] http://www.ovirt.org/Working_with_oVirt_Gerrit#Install_the_change-ID_hook -- Didi ----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:53:53 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
the git log: http://pastebin.com/RqbQAfa3
my patches (3 patches) are based on Gilad Chaplik patches which are not merged
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:48:06 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Can you share the output of git show up to the contents of the patch?
Nir _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
I do have a sign off by in all my patches, do you see a patch that is missing it in the git log below ? ----- Original Message -----
From: "Yedidyah Bar David" <didi@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:59:14 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
You seem to be missing the "Signed-Off-By" line, see [1].
[1] http://www.ovirt.org/Working_with_oVirt_Gerrit#Install_the_change-ID_hook -- Didi
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:53:53 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
the git log: http://pastebin.com/RqbQAfa3
my patches (3 patches) are based on Gilad Chaplik patches which are not merged
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Kobi Ianko" <kobi@redhat.com> Cc: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 2:48:06 PM Subject: Re: [ovirt-devel] remote rejected - not Signed-off-by
----- Original Message -----
From: "Kobi Ianko" <kobi@redhat.com> To: "engine-devel@ovirt.org" <devel@ovirt.org> Sent: Sunday, July 20, 2014 1:17:36 PM Subject: [ovirt-devel] remote rejected - not Signed-off-by
Hi, Got this message when trying to push several changes:
To gerrit.ovirt.org:ovirt-engine ! [remote rejected] HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer) error: failed to push some refs to 'gerrit.ovirt.org:ovirt-engine'
Can you share the output of git show up to the contents of the patch?
Nir _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (4)
-
Kobi Ianko -
Nir Soffer -
Oved Ourfali -
Yedidyah Bar David