1:36 p.m.
we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60 days (to begin
with, I think the number should actually be lower).
they can always be re-opened by any interested party post their closure.
i.e., looking at gerrit, the patch list should actually get attention,
and not be a few worth looking at, with a "lot of old patches"
thoughts?
Thanks,
Itamar
1:46 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60 days (to
begin with, I think the number should actually be lower).
they can always be re-opened by any interested party post their closure.
i.e., looking at gerrit, the patch list should actually get attention,
and not be a few worth looking at, with a "lot of old patches"
thoughts?
Thanks,
Itamar
_______________________________________________
vdsm-devel mailing list
vdsm-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
It might helpful to have a cron-like script that checks the age of the
posts and first notifies the sender, the reviewers and the maintainer,
and if the patch is not updated in a certain period just abandons it.
--
David Caro
Red Hat Czech s.r.o.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno, Czech Republic
RHT Global #: 82-62605
1:47 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
On 09/23/2013 01:46 PM, David Caro wrote:
On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
> we have some very old gerrit patches.
> I'm for abandoning patches which were not touched over 60 days (to
> begin with, I think the number should actually be lower).
> they can always be re-opened by any interested party post their closure.
>
> i.e., looking at gerrit, the patch list should actually get attention,
> and not be a few worth looking at, with a "lot of old patches"
>
> thoughts?
>
> Thanks,
> Itamar
> _______________________________________________
> vdsm-devel mailing list
> vdsm-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
It might helpful to have a cron-like script that checks the age of the
posts and first notifies the sender, the reviewers and the maintainer,
and if the patch is not updated in a certain period just abandons it.
yep - warn after X days via email to just owner (or all subscribed to
the patch), and close if no activity for X+14 days or something like that.
1:49 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Itamar Heim" <iheim(a)redhat.com>
To: "David Caro" <dcaroest(a)redhat.com>
Cc: "engine-devel" <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:47:47 PM
Subject: Re: [vdsm] stale gerrit patches
On 09/23/2013 01:46 PM, David Caro wrote:
> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>> we have some very old gerrit patches.
>> I'm for abandoning patches which were not touched over 60 days (to
>> begin with, I think the number should actually be lower).
>> they can always be re-opened by any interested party post their closure.
>>
>> i.e., looking at gerrit, the patch list should actually get attention,
>> and not be a few worth looking at, with a "lot of old patches"
>>
>> thoughts?
>>
>> Thanks,
>> Itamar
>> _______________________________________________
>> vdsm-devel mailing list
>> vdsm-devel(a)lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>
> It might helpful to have a cron-like script that checks the age of the
> posts and first notifies the sender, the reviewers and the maintainer,
> and if the patch is not updated in a certain period just abandons it.
>
yep - warn after X days via email to just owner (or all subscribed to
the patch), and close if no activity for X+14 days or something like that.
This will be annoying.
And there are patches that pending with good reason.
Maintainers can close patches that are no interest nor progress.
Alon
1:50 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
----- Original Message -----
> From: "Itamar Heim" <iheim(a)redhat.com>
> To: "David Caro" <dcaroest(a)redhat.com>
> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> Sent: Monday, September 23, 2013 1:47:47 PM
> Subject: Re: [vdsm] stale gerrit patches
>
> On 09/23/2013 01:46 PM, David Caro wrote:
>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>>> we have some very old gerrit patches.
>>> I'm for abandoning patches which were not touched over 60 days (to
>>> begin with, I think the number should actually be lower).
>>> they can always be re-opened by any interested party post their closure.
>>>
>>> i.e., looking at gerrit, the patch list should actually get attention,
>>> and not be a few worth looking at, with a "lot of old patches"
>>>
>>> thoughts?
>>>
>>> Thanks,
>>> Itamar
>>> _______________________________________________
>>> vdsm-devel mailing list
>>> vdsm-devel(a)lists.fedorahosted.org
>>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>>
>> It might helpful to have a cron-like script that checks the age of the
>> posts and first notifies the sender, the reviewers and the maintainer,
>> and if the patch is not updated in a certain period just abandons it.
>>
>
> yep - warn after X days via email to just owner (or all subscribed to
> the patch), and close if no activity for X+14 days or something like that.
This will be annoying.
And there are patches that pending with good reason.
pending for 60 days with zero activity on them (no comment, no rebase,
nothing)?
Maintainers can close patches that are no interest nor progress.
Alon
1:52 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Itamar Heim" <iheim(a)redhat.com>
To: "Alon Bar-Lev" <alonbl(a)redhat.com>
Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:50:35 PM
Subject: Re: [vdsm] stale gerrit patches
On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
>
>
> ----- Original Message -----
>> From: "Itamar Heim" <iheim(a)redhat.com>
>> To: "David Caro" <dcaroest(a)redhat.com>
>> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
>> vdsm-devel(a)lists.fedorahosted.org
>> Sent: Monday, September 23, 2013 1:47:47 PM
>> Subject: Re: [vdsm] stale gerrit patches
>>
>> On 09/23/2013 01:46 PM, David Caro wrote:
>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>>>> we have some very old gerrit patches.
>>>> I'm for abandoning patches which were not touched over 60 days (to
>>>> begin with, I think the number should actually be lower).
>>>> they can always be re-opened by any interested party post their
closure.
>>>>
>>>> i.e., looking at gerrit, the patch list should actually get attention,
>>>> and not be a few worth looking at, with a "lot of old
patches"
>>>>
>>>> thoughts?
>>>>
>>>> Thanks,
>>>> Itamar
>>>> _______________________________________________
>>>> vdsm-devel mailing list
>>>> vdsm-devel(a)lists.fedorahosted.org
>>>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>>>
>>> It might helpful to have a cron-like script that checks the age of the
>>> posts and first notifies the sender, the reviewers and the maintainer,
>>> and if the patch is not updated in a certain period just abandons it.
>>>
>>
>> yep - warn after X days via email to just owner (or all subscribed to
>> the patch), and close if no activity for X+14 days or something like that.
>
> This will be annoying.
>
> And there are patches that pending with good reason.
pending for 60 days with zero activity on them (no comment, no rebase,
nothing)?
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
>
> Maintainers can close patches that are no interest nor progress.
>
> Alon
>
1:53 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Alon Bar-Lev" <alonbl(a)redhat.com>
To: "Itamar Heim" <iheim(a)redhat.com>
Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:52:56 PM
Subject: Re: [vdsm] stale gerrit patches
----- Original Message -----
> From: "Itamar Heim" <iheim(a)redhat.com>
> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> Sent: Monday, September 23, 2013 1:50:35 PM
> Subject: Re: [vdsm] stale gerrit patches
>
> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> >
> >
> > ----- Original Message -----
> >> From: "Itamar Heim" <iheim(a)redhat.com>
> >> To: "David Caro" <dcaroest(a)redhat.com>
> >> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
> >> vdsm-devel(a)lists.fedorahosted.org
> >> Sent: Monday, September 23, 2013 1:47:47 PM
> >> Subject: Re: [vdsm] stale gerrit patches
> >>
> >> On 09/23/2013 01:46 PM, David Caro wrote:
> >>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
> >>>> we have some very old gerrit patches.
> >>>> I'm for abandoning patches which were not touched over 60 days
(to
> >>>> begin with, I think the number should actually be lower).
> >>>> they can always be re-opened by any interested party post their
> >>>> closure.
> >>>>
> >>>> i.e., looking at gerrit, the patch list should actually get
attention,
> >>>> and not be a few worth looking at, with a "lot of old
patches"
> >>>>
> >>>> thoughts?
> >>>>
> >>>> Thanks,
> >>>> Itamar
> >>>> _______________________________________________
> >>>> vdsm-devel mailing list
> >>>> vdsm-devel(a)lists.fedorahosted.org
> >>>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> >>>
> >>> It might helpful to have a cron-like script that checks the age of the
> >>> posts and first notifies the sender, the reviewers and the maintainer,
> >>> and if the patch is not updated in a certain period just abandons it.
> >>>
> >>
> >> yep - warn after X days via email to just owner (or all subscribed to
> >> the patch), and close if no activity for X+14 days or something like
> >> that.
> >
> > This will be annoying.
> >
> > And there are patches that pending with good reason.
>
> pending for 60 days with zero activity on them (no comment, no rebase,
> nothing)?
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
>
> >
> > Maintainers can close patches that are no interest nor progress.
> >
> > Alon
> >
>
>
1:54 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
----- Original Message -----
> From: "Itamar Heim" <iheim(a)redhat.com>
> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> Sent: Monday, September 23, 2013 1:50:35 PM
> Subject: Re: [vdsm] stale gerrit patches
>
> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
>>
>>
>> ----- Original Message -----
>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>> To: "David Caro" <dcaroest(a)redhat.com>
>>> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
>>> vdsm-devel(a)lists.fedorahosted.org
>>> Sent: Monday, September 23, 2013 1:47:47 PM
>>> Subject: Re: [vdsm] stale gerrit patches
>>>
>>> On 09/23/2013 01:46 PM, David Caro wrote:
>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>>>>> we have some very old gerrit patches.
>>>>> I'm for abandoning patches which were not touched over 60 days
(to
>>>>> begin with, I think the number should actually be lower).
>>>>> they can always be re-opened by any interested party post their
closure.
>>>>>
>>>>> i.e., looking at gerrit, the patch list should actually get
attention,
>>>>> and not be a few worth looking at, with a "lot of old
patches"
>>>>>
>>>>> thoughts?
>>>>>
>>>>> Thanks,
>>>>> Itamar
>>>>> _______________________________________________
>>>>> vdsm-devel mailing list
>>>>> vdsm-devel(a)lists.fedorahosted.org
>>>>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>>>>
>>>> It might helpful to have a cron-like script that checks the age of the
>>>> posts and first notifies the sender, the reviewers and the maintainer,
>>>> and if the patch is not updated in a certain period just abandons it.
>>>>
>>>
>>> yep - warn after X days via email to just owner (or all subscribed to
>>> the patch), and close if no activity for X+14 days or something like that.
>>
>> This will be annoying.
>>
>> And there are patches that pending with good reason.
>
> pending for 60 days with zero activity on them (no comment, no rebase,
> nothing)?
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
so how does it help us to have these patches, some without any comment
from any reviewer.
lets get them reviewed and decide one way or the other, rather than let
them get old and stay forever
>
>>
>> Maintainers can close patches that are no interest nor progress.
>>
>> Alon
>>
>
>
1:59 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Itamar Heim" <iheim(a)redhat.com>
To: "Alon Bar-Lev" <alonbl(a)redhat.com>
Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
Sent: Monday, September 23, 2013 1:54:39 PM
Subject: Re: [vdsm] stale gerrit patches
On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
>
>
> ----- Original Message -----
>> From: "Itamar Heim" <iheim(a)redhat.com>
>> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
>> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
>> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
>> Sent: Monday, September 23, 2013 1:50:35 PM
>> Subject: Re: [vdsm] stale gerrit patches
>>
>> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>>> To: "David Caro" <dcaroest(a)redhat.com>
>>>> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
>>>> vdsm-devel(a)lists.fedorahosted.org
>>>> Sent: Monday, September 23, 2013 1:47:47 PM
>>>> Subject: Re: [vdsm] stale gerrit patches
>>>>
>>>> On 09/23/2013 01:46 PM, David Caro wrote:
>>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>>>>>> we have some very old gerrit patches.
>>>>>> I'm for abandoning patches which were not touched over 60
days (to
>>>>>> begin with, I think the number should actually be lower).
>>>>>> they can always be re-opened by any interested party post their
>>>>>> closure.
>>>>>>
>>>>>> i.e., looking at gerrit, the patch list should actually get
attention,
>>>>>> and not be a few worth looking at, with a "lot of old
patches"
>>>>>>
>>>>>> thoughts?
>>>>>>
>>>>>> Thanks,
>>>>>> Itamar
>>>>>> _______________________________________________
>>>>>> vdsm-devel mailing list
>>>>>> vdsm-devel(a)lists.fedorahosted.org
>>>>>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>>>>>
>>>>> It might helpful to have a cron-like script that checks the age of
the
>>>>> posts and first notifies the sender, the reviewers and the
maintainer,
>>>>> and if the patch is not updated in a certain period just abandons
it.
>>>>>
>>>>
>>>> yep - warn after X days via email to just owner (or all subscribed to
>>>> the patch), and close if no activity for X+14 days or something like
>>>> that.
>>>
>>> This will be annoying.
>>>
>>> And there are patches that pending with good reason.
>>
>> pending for 60 days with zero activity on them (no comment, no rebase,
>> nothing)?
>
>
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
so how does it help us to have these patches, some without any comment
from any reviewer.
lets get them reviewed and decide one way or the other, rather than let
them get old and stay forever
Again... maintainer can close these if he likes.
Owner can close these if he likes.
The problem is that maintainers avoid closing.
And that there are people who submitted patches without CC anyone and gone.
So a simple logic can be applied after we add metadata into tree:
1. If no maintainer is CCed on change, close that change within short cycle (can be even a
week).
2. Maintainer to close patches that have no interest in.
>
>>
>>>
>>> Maintainers can close patches that are no interest nor progress.
>>>
>>> Alon
>>>
>>
>>
12:21 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
----- Original Message -----
> From: "Itamar Heim" <iheim(a)redhat.com>
> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> Sent: Monday, September 23, 2013 1:54:39 PM
> Subject: Re: [vdsm] stale gerrit patches
>
> On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
> >
> >
> > ----- Original Message -----
> >> From: "Itamar Heim" <iheim(a)redhat.com>
> >> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> >> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> >> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> >> Sent: Monday, September 23, 2013 1:50:35 PM
> >> Subject: Re: [vdsm] stale gerrit patches
> >>
> >> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> >>>
> >>>
> >>> ----- Original Message -----
> >>>> From: "Itamar Heim" <iheim(a)redhat.com>
> >>>> To: "David Caro" <dcaroest(a)redhat.com>
> >>>> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
> >>>> vdsm-devel(a)lists.fedorahosted.org
> >>>> Sent: Monday, September 23, 2013 1:47:47 PM
> >>>> Subject: Re: [vdsm] stale gerrit patches
> >>>>
> >>>> On 09/23/2013 01:46 PM, David Caro wrote:
> >>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
> >>>>>> we have some very old gerrit patches.
> >>>>>> I'm for abandoning patches which were not touched over
60 days (to
> >>>>>> begin with, I think the number should actually be lower).
> >>>>>> they can always be re-opened by any interested party post
their
> >>>>>> closure.
> >>>>>>
> >>>>>> i.e., looking at gerrit, the patch list should actually
get
> >>>>>> attention,
> >>>>>> and not be a few worth looking at, with a "lot of old
patches"
> >>>>>>
> >>>>>> thoughts?
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Itamar
> >>>>>> _______________________________________________
> >>>>>> vdsm-devel mailing list
> >>>>>> vdsm-devel(a)lists.fedorahosted.org
> >>>>>> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> >>>>>
> >>>>> It might helpful to have a cron-like script that checks the age
of
> >>>>> the
> >>>>> posts and first notifies the sender, the reviewers and the
> >>>>> maintainer,
> >>>>> and if the patch is not updated in a certain period just
abandons it.
> >>>>>
> >>>>
> >>>> yep - warn after X days via email to just owner (or all subscribed
to
> >>>> the patch), and close if no activity for X+14 days or something
like
> >>>> that.
> >>>
> >>> This will be annoying.
> >>>
> >>> And there are patches that pending with good reason.
> >>
> >> pending for 60 days with zero activity on them (no comment, no rebase,
> >> nothing)?
> >
> >
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
>
> so how does it help us to have these patches, some without any comment
> from any reviewer.
> lets get them reviewed and decide one way or the other, rather than let
> them get old and stay forever
Again... maintainer can close these if he likes.
Owner can close these if he likes.
right, but why?
a patch without activity being abandoned might actually spur someone into motion (rebasing
and resubmitting, prodding maintainers etc).
I'm +1 for automatically abandoning old patches.
The problem is that maintainers avoid closing.
And that there are people who submitted patches without CC anyone and gone.
So a simple logic can be applied after we add metadata into tree:
1. If no maintainer is CCed on change, close that change within short cycle
(can be even a week).
2. Maintainer to close patches that have no interest in.
>
> >
> >>
> >>>
> >>> Maintainers can close patches that are no interest nor progress.
> >>>
> >>> Alon
> >>>
> >>
> >>
>
>
_______________________________________________
vdsm-devel mailing list
vdsm-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
9:17 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Ayal Baron" <abaron(a)redhat.com>
To: "Alon Bar-Lev" <alonbl(a)redhat.com>
Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
Sent: Tuesday, September 24, 2013 12:21:23 AM
Subject: Re: [vdsm] stale gerrit patches
----- Original Message -----
>
>
> ----- Original Message -----
> > From: "Itamar Heim" <iheim(a)redhat.com>
> > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > Sent: Monday, September 23, 2013 1:54:39 PM
> > Subject: Re: [vdsm] stale gerrit patches
> >
> > On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
> > >
> > >
> > > ----- Original Message -----
> > >> From: "Itamar Heim" <iheim(a)redhat.com>
> > >> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > >> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > >> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > >> Sent: Monday, September 23, 2013 1:50:35 PM
> > >> Subject: Re: [vdsm] stale gerrit patches
> > >>
> > >> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> > >>>
> > >>>
> > >>> ----- Original Message -----
> > >>>> From: "Itamar Heim" <iheim(a)redhat.com>
> > >>>> To: "David Caro" <dcaroest(a)redhat.com>
> > >>>> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
> > >>>> vdsm-devel(a)lists.fedorahosted.org
> > >>>> Sent: Monday, September 23, 2013 1:47:47 PM
> > >>>> Subject: Re: [vdsm] stale gerrit patches
> > >>>>
> > >>>> On 09/23/2013 01:46 PM, David Caro wrote:
> > >>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
> > >>>>>> we have some very old gerrit patches.
> > >>>>>> I'm for abandoning patches which were not touched
over 60 days (to
> > >>>>>> begin with, I think the number should actually be
lower).
> > >>>>>> they can always be re-opened by any interested party
post their
> > >>>>>> closure.
> > >>>>>>
> > >>>>>> i.e., looking at gerrit, the patch list should
actually get
> > >>>>>> attention,
> > >>>>>> and not be a few worth looking at, with a "lot of
old patches"
> > >>>>>>
> > >>>>>> thoughts?
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>> Itamar
> > >>>>>> _______________________________________________
> > >>>>>> vdsm-devel mailing list
> > >>>>>> vdsm-devel(a)lists.fedorahosted.org
> > >>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > >>>>>
> > >>>>> It might helpful to have a cron-like script that checks
the age of
> > >>>>> the
> > >>>>> posts and first notifies the sender, the reviewers and
the
> > >>>>> maintainer,
> > >>>>> and if the patch is not updated in a certain period just
abandons
> > >>>>> it.
> > >>>>>
> > >>>>
> > >>>> yep - warn after X days via email to just owner (or all
subscribed
> > >>>> to
> > >>>> the patch), and close if no activity for X+14 days or
something like
> > >>>> that.
> > >>>
> > >>> This will be annoying.
> > >>>
> > >>> And there are patches that pending with good reason.
> > >>
> > >> pending for 60 days with zero activity on them (no comment, no
rebase,
> > >> nothing)?
> > >
> > >
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
> >
> > so how does it help us to have these patches, some without any comment
> > from any reviewer.
> > lets get them reviewed and decide one way or the other, rather than let
> > them get old and stay forever
>
> Again... maintainer can close these if he likes.
> Owner can close these if he likes.
right, but why?
a patch without activity being abandoned might actually spur someone into
motion (rebasing and resubmitting, prodding maintainers etc).
I'm +1 for automatically abandoning old patches.
I do not understand why maintainer should not have human interaction with its
contributers.
>
> The problem is that maintainers avoid closing.
> And that there are people who submitted patches without CC anyone and gone.
>
> So a simple logic can be applied after we add metadata into tree:
>
> 1. If no maintainer is CCed on change, close that change within short cycle
> (can be even a week).
> 2. Maintainer to close patches that have no interest in.
>
> >
> > >
> > >>
> > >>>
> > >>> Maintainers can close patches that are no interest nor progress.
> > >>>
> > >>> Alon
> > >>>
> > >>
> > >>
> >
> >
> _______________________________________________
> vdsm-devel mailing list
> vdsm-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>
9:20 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
----- Original Message -----
> From: "Ayal Baron" <abaron(a)redhat.com>
> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> Sent: Tuesday, September 24, 2013 12:21:23 AM
> Subject: Re: [vdsm] stale gerrit patches
>
>
>
> ----- Original Message -----
> >
> >
> > ----- Original Message -----
> > > From: "Itamar Heim" <iheim(a)redhat.com>
> > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > > Sent: Monday, September 23, 2013 1:54:39 PM
> > > Subject: Re: [vdsm] stale gerrit patches
> > >
> > > On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
> > > >
> > > >
> > > > ----- Original Message -----
> > > >> From: "Itamar Heim" <iheim(a)redhat.com>
> > > >> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > >> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > > >> <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > >> Sent: Monday, September 23, 2013 1:50:35 PM
> > > >> Subject: Re: [vdsm] stale gerrit patches
> > > >>
> > > >> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> > > >>>
> > > >>>
> > > >>> ----- Original Message -----
> > > >>>> From: "Itamar Heim" <iheim(a)redhat.com>
> > > >>>> To: "David Caro" <dcaroest(a)redhat.com>
> > > >>>> Cc: "engine-devel"
<engine-devel(a)ovirt.org>,
> > > >>>> vdsm-devel(a)lists.fedorahosted.org
> > > >>>> Sent: Monday, September 23, 2013 1:47:47 PM
> > > >>>> Subject: Re: [vdsm] stale gerrit patches
> > > >>>>
> > > >>>> On 09/23/2013 01:46 PM, David Caro wrote:
> > > >>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim
wrote:
> > > >>>>>> we have some very old gerrit patches.
> > > >>>>>> I'm for abandoning patches which were not
touched over 60 days
> > > >>>>>> (to
> > > >>>>>> begin with, I think the number should actually be
lower).
> > > >>>>>> they can always be re-opened by any interested
party post their
> > > >>>>>> closure.
> > > >>>>>>
> > > >>>>>> i.e., looking at gerrit, the patch list should
actually get
> > > >>>>>> attention,
> > > >>>>>> and not be a few worth looking at, with a
"lot of old patches"
> > > >>>>>>
> > > >>>>>> thoughts?
> > > >>>>>>
> > > >>>>>> Thanks,
> > > >>>>>> Itamar
> > > >>>>>> _______________________________________________
> > > >>>>>> vdsm-devel mailing list
> > > >>>>>> vdsm-devel(a)lists.fedorahosted.org
> > > >>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > >>>>>
> > > >>>>> It might helpful to have a cron-like script that
checks the age
> > > >>>>> of
> > > >>>>> the
> > > >>>>> posts and first notifies the sender, the reviewers
and the
> > > >>>>> maintainer,
> > > >>>>> and if the patch is not updated in a certain period
just abandons
> > > >>>>> it.
> > > >>>>>
> > > >>>>
> > > >>>> yep - warn after X days via email to just owner (or all
subscribed
> > > >>>> to
> > > >>>> the patch), and close if no activity for X+14 days or
something
> > > >>>> like
> > > >>>> that.
> > > >>>
> > > >>> This will be annoying.
> > > >>>
> > > >>> And there are patches that pending with good reason.
> > > >>
> > > >> pending for 60 days with zero activity on them (no comment, no
> > > >> rebase,
> > > >> nothing)?
> > > >
> > > >
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
> > >
> > > so how does it help us to have these patches, some without any comment
> > > from any reviewer.
> > > lets get them reviewed and decide one way or the other, rather than let
> > > them get old and stay forever
> >
> > Again... maintainer can close these if he likes.
> > Owner can close these if he likes.
>
> right, but why?
> a patch without activity being abandoned might actually spur someone into
> motion (rebasing and resubmitting, prodding maintainers etc).
> I'm +1 for automatically abandoning old patches.
>
I do not understand why maintainer should not have human interaction with its
contributers.
I do not understand the relation between the subject and the things you're saying.
Right now these patches are stale and are rotting, abandoning them could actually spur
those interactions into motion.
> >
> > The problem is that maintainers avoid closing.
> > And that there are people who submitted patches without CC anyone and
> > gone.
> >
> > So a simple logic can be applied after we add metadata into tree:
> >
> > 1. If no maintainer is CCed on change, close that change within short
> > cycle
> > (can be even a week).
> > 2. Maintainer to close patches that have no interest in.
> >
> > >
> > > >
> > > >>
> > > >>>
> > > >>> Maintainers can close patches that are no interest nor
progress.
> > > >>>
> > > >>> Alon
> > > >>>
> > > >>
> > > >>
> > >
> > >
> > _______________________________________________
> > vdsm-devel mailing list
> > vdsm-devel(a)lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> >
>
9:30 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Ayal Baron" <abaron(a)redhat.com>
To: "Alon Bar-Lev" <alonbl(a)redhat.com>
Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
Sent: Tuesday, September 24, 2013 9:20:55 AM
Subject: Re: [vdsm] stale gerrit patches
----- Original Message -----
>
>
> ----- Original Message -----
> > From: "Ayal Baron" <abaron(a)redhat.com>
> > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
> > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > Sent: Tuesday, September 24, 2013 12:21:23 AM
> > Subject: Re: [vdsm] stale gerrit patches
> >
> >
> >
> > ----- Original Message -----
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Itamar Heim" <iheim(a)redhat.com>
> > > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > > Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > > > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > > > Sent: Monday, September 23, 2013 1:54:39 PM
> > > > Subject: Re: [vdsm] stale gerrit patches
> > > >
> > > > On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > >> From: "Itamar Heim" <iheim(a)redhat.com>
> > > > >> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > > >> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > > > >> <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > >> Sent: Monday, September 23, 2013 1:50:35 PM
> > > > >> Subject: Re: [vdsm] stale gerrit patches
> > > > >>
> > > > >> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> > > > >>>
> > > > >>>
> > > > >>> ----- Original Message -----
> > > > >>>> From: "Itamar Heim"
<iheim(a)redhat.com>
> > > > >>>> To: "David Caro"
<dcaroest(a)redhat.com>
> > > > >>>> Cc: "engine-devel"
<engine-devel(a)ovirt.org>,
> > > > >>>> vdsm-devel(a)lists.fedorahosted.org
> > > > >>>> Sent: Monday, September 23, 2013 1:47:47 PM
> > > > >>>> Subject: Re: [vdsm] stale gerrit patches
> > > > >>>>
> > > > >>>> On 09/23/2013 01:46 PM, David Caro wrote:
> > > > >>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim
wrote:
> > > > >>>>>> we have some very old gerrit patches.
> > > > >>>>>> I'm for abandoning patches which were
not touched over 60 days
> > > > >>>>>> (to
> > > > >>>>>> begin with, I think the number should
actually be lower).
> > > > >>>>>> they can always be re-opened by any
interested party post
> > > > >>>>>> their
> > > > >>>>>> closure.
> > > > >>>>>>
> > > > >>>>>> i.e., looking at gerrit, the patch list
should actually get
> > > > >>>>>> attention,
> > > > >>>>>> and not be a few worth looking at, with a
"lot of old patches"
> > > > >>>>>>
> > > > >>>>>> thoughts?
> > > > >>>>>>
> > > > >>>>>> Thanks,
> > > > >>>>>> Itamar
> > > > >>>>>>
_______________________________________________
> > > > >>>>>> vdsm-devel mailing list
> > > > >>>>>> vdsm-devel(a)lists.fedorahosted.org
> > > > >>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > > >>>>>
> > > > >>>>> It might helpful to have a cron-like script that
checks the age
> > > > >>>>> of
> > > > >>>>> the
> > > > >>>>> posts and first notifies the sender, the
reviewers and the
> > > > >>>>> maintainer,
> > > > >>>>> and if the patch is not updated in a certain
period just
> > > > >>>>> abandons
> > > > >>>>> it.
> > > > >>>>>
> > > > >>>>
> > > > >>>> yep - warn after X days via email to just owner (or
all
> > > > >>>> subscribed
> > > > >>>> to
> > > > >>>> the patch), and close if no activity for X+14 days
or something
> > > > >>>> like
> > > > >>>> that.
> > > > >>>
> > > > >>> This will be annoying.
> > > > >>>
> > > > >>> And there are patches that pending with good reason.
> > > > >>
> > > > >> pending for 60 days with zero activity on them (no comment,
no
> > > > >> rebase,
> > > > >> nothing)?
> > > > >
> > > > >
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
> > > >
> > > > so how does it help us to have these patches, some without any
> > > > comment
> > > > from any reviewer.
> > > > lets get them reviewed and decide one way or the other, rather than
> > > > let
> > > > them get old and stay forever
> > >
> > > Again... maintainer can close these if he likes.
> > > Owner can close these if he likes.
> >
> > right, but why?
> > a patch without activity being abandoned might actually spur someone into
> > motion (rebasing and resubmitting, prodding maintainers etc).
> > I'm +1 for automatically abandoning old patches.
> >
>
> I do not understand why maintainer should not have human interaction with
> its
> contributers.
I do not understand the relation between the subject and the things you're
saying.
Right now these patches are stale and are rotting, abandoning them could
actually spur those interactions into motion.
You prefer machines to interact with contributers to kick them in motion.
I believe that human interaction and discussion between maintainer and contributer is the
way to go.
It is much more polite and cooperative for maintainer that is not aware of anything
blocking a progress to kindly interact with contributer and finally close the change if
contributer is unresponsive and/or change has no value.
>
> > >
> > > The problem is that maintainers avoid closing.
> > > And that there are people who submitted patches without CC anyone and
> > > gone.
> > >
> > > So a simple logic can be applied after we add metadata into tree:
> > >
> > > 1. If no maintainer is CCed on change, close that change within short
> > > cycle
> > > (can be even a week).
> > > 2. Maintainer to close patches that have no interest in.
> > >
> > > >
> > > > >
> > > > >>
> > > > >>>
> > > > >>> Maintainers can close patches that are no interest nor
progress.
> > > > >>>
> > > > >>> Alon
> > > > >>>
> > > > >>
> > > > >>
> > > >
> > > >
> > > _______________________________________________
> > > vdsm-devel mailing list
> > > vdsm-devel(a)lists.fedorahosted.org
> > > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > >
> >
>
10:09 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
----- Original Message -----
> From: "Ayal Baron" <abaron(a)redhat.com>
> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> Sent: Tuesday, September 24, 2013 9:20:55 AM
> Subject: Re: [vdsm] stale gerrit patches
>
>
>
> ----- Original Message -----
> >
> >
> > ----- Original Message -----
> > > From: "Ayal Baron" <abaron(a)redhat.com>
> > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > Cc: "Itamar Heim" <iheim(a)redhat.com>,
"engine-devel"
> > > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > > Sent: Tuesday, September 24, 2013 12:21:23 AM
> > > Subject: Re: [vdsm] stale gerrit patches
> > >
> > >
> > >
> > > ----- Original Message -----
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Itamar Heim" <iheim(a)redhat.com>
> > > > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > > > Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > > > > <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > > Sent: Monday, September 23, 2013 1:54:39 PM
> > > > > Subject: Re: [vdsm] stale gerrit patches
> > > > >
> > > > > On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > >> From: "Itamar Heim" <iheim(a)redhat.com>
> > > > > >> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > > > >> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > > > > >> <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > > >> Sent: Monday, September 23, 2013 1:50:35 PM
> > > > > >> Subject: Re: [vdsm] stale gerrit patches
> > > > > >>
> > > > > >> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> > > > > >>>
> > > > > >>>
> > > > > >>> ----- Original Message -----
> > > > > >>>> From: "Itamar Heim"
<iheim(a)redhat.com>
> > > > > >>>> To: "David Caro"
<dcaroest(a)redhat.com>
> > > > > >>>> Cc: "engine-devel"
<engine-devel(a)ovirt.org>,
> > > > > >>>> vdsm-devel(a)lists.fedorahosted.org
> > > > > >>>> Sent: Monday, September 23, 2013 1:47:47 PM
> > > > > >>>> Subject: Re: [vdsm] stale gerrit patches
> > > > > >>>>
> > > > > >>>> On 09/23/2013 01:46 PM, David Caro wrote:
> > > > > >>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar
Heim wrote:
> > > > > >>>>>> we have some very old gerrit patches.
> > > > > >>>>>> I'm for abandoning patches which
were not touched over 60
> > > > > >>>>>> days
> > > > > >>>>>> (to
> > > > > >>>>>> begin with, I think the number should
actually be lower).
> > > > > >>>>>> they can always be re-opened by any
interested party post
> > > > > >>>>>> their
> > > > > >>>>>> closure.
> > > > > >>>>>>
> > > > > >>>>>> i.e., looking at gerrit, the patch list
should actually get
> > > > > >>>>>> attention,
> > > > > >>>>>> and not be a few worth looking at, with
a "lot of old
> > > > > >>>>>> patches"
> > > > > >>>>>>
> > > > > >>>>>> thoughts?
> > > > > >>>>>>
> > > > > >>>>>> Thanks,
> > > > > >>>>>> Itamar
> > > > > >>>>>>
_______________________________________________
> > > > > >>>>>> vdsm-devel mailing list
> > > > > >>>>>> vdsm-devel(a)lists.fedorahosted.org
> > > > > >>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > > > >>>>>
> > > > > >>>>> It might helpful to have a cron-like script
that checks the
> > > > > >>>>> age
> > > > > >>>>> of
> > > > > >>>>> the
> > > > > >>>>> posts and first notifies the sender, the
reviewers and the
> > > > > >>>>> maintainer,
> > > > > >>>>> and if the patch is not updated in a
certain period just
> > > > > >>>>> abandons
> > > > > >>>>> it.
> > > > > >>>>>
> > > > > >>>>
> > > > > >>>> yep - warn after X days via email to just owner
(or all
> > > > > >>>> subscribed
> > > > > >>>> to
> > > > > >>>> the patch), and close if no activity for X+14
days or
> > > > > >>>> something
> > > > > >>>> like
> > > > > >>>> that.
> > > > > >>>
> > > > > >>> This will be annoying.
> > > > > >>>
> > > > > >>> And there are patches that pending with good
reason.
> > > > > >>
> > > > > >> pending for 60 days with zero activity on them (no
comment, no
> > > > > >> rebase,
> > > > > >> nothing)?
> > > > > >
> > > > > >
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
> > > > >
> > > > > so how does it help us to have these patches, some without any
> > > > > comment
> > > > > from any reviewer.
> > > > > lets get them reviewed and decide one way or the other, rather
than
> > > > > let
> > > > > them get old and stay forever
> > > >
> > > > Again... maintainer can close these if he likes.
> > > > Owner can close these if he likes.
> > >
> > > right, but why?
> > > a patch without activity being abandoned might actually spur someone
> > > into
> > > motion (rebasing and resubmitting, prodding maintainers etc).
> > > I'm +1 for automatically abandoning old patches.
> > >
> >
> > I do not understand why maintainer should not have human interaction with
> > its
> > contributers.
>
> I do not understand the relation between the subject and the things you're
> saying.
> Right now these patches are stale and are rotting, abandoning them could
> actually spur those interactions into motion.
You prefer machines to interact with contributers to kick them in motion.
I believe that human interaction and discussion between maintainer and
contributer is the way to go.
It is much more polite and cooperative for maintainer that is not aware of
anything blocking a progress to kindly interact with contributer and finally
close the change if contributer is unresponsive and/or change has no value.
Personally I see nothing impolite about automatically abandoning patches if it is clear to
contributors that this the expected behaviour.
Other projects abandon automatically after a week and from what I've seen that is
working well to get things in motion and get those interactions that you (and I) want,
rolling.
>
> >
> > > >
> > > > The problem is that maintainers avoid closing.
> > > > And that there are people who submitted patches without CC anyone
and
> > > > gone.
> > > >
> > > > So a simple logic can be applied after we add metadata into tree:
> > > >
> > > > 1. If no maintainer is CCed on change, close that change within
short
> > > > cycle
> > > > (can be even a week).
> > > > 2. Maintainer to close patches that have no interest in.
> > > >
> > > > >
> > > > > >
> > > > > >>
> > > > > >>>
> > > > > >>> Maintainers can close patches that are no interest
nor
> > > > > >>> progress.
> > > > > >>>
> > > > > >>> Alon
> > > > > >>>
> > > > > >>
> > > > > >>
> > > > >
> > > > >
> > > > _______________________________________________
> > > > vdsm-devel mailing list
> > > > vdsm-devel(a)lists.fedorahosted.org
> > > > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > >
> > >
> >
>
10:18 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Ayal Baron" <abaron(a)redhat.com>
To: "Alon Bar-Lev" <alonbl(a)redhat.com>
Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
Sent: Tuesday, September 24, 2013 10:09:46 AM
Subject: Re: [vdsm] stale gerrit patches
----- Original Message -----
>
>
> ----- Original Message -----
> > From: "Ayal Baron" <abaron(a)redhat.com>
> > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
> > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > Sent: Tuesday, September 24, 2013 9:20:55 AM
> > Subject: Re: [vdsm] stale gerrit patches
> >
> >
> >
> > ----- Original Message -----
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Ayal Baron" <abaron(a)redhat.com>
> > > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > > Cc: "Itamar Heim" <iheim(a)redhat.com>,
"engine-devel"
> > > > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > > > Sent: Tuesday, September 24, 2013 12:21:23 AM
> > > > Subject: Re: [vdsm] stale gerrit patches
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Itamar Heim" <iheim(a)redhat.com>
> > > > > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > > > > Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
> > > > > > <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > > > Sent: Monday, September 23, 2013 1:54:39 PM
> > > > > > Subject: Re: [vdsm] stale gerrit patches
> > > > > >
> > > > > > On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
> > > > > > >
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > >> From: "Itamar Heim"
<iheim(a)redhat.com>
> > > > > > >> To: "Alon Bar-Lev"
<alonbl(a)redhat.com>
> > > > > > >> Cc: "David Caro"
<dcaroest(a)redhat.com>, "engine-devel"
> > > > > > >> <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > > > >> Sent: Monday, September 23, 2013 1:50:35 PM
> > > > > > >> Subject: Re: [vdsm] stale gerrit patches
> > > > > > >>
> > > > > > >> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> > > > > > >>>
> > > > > > >>>
> > > > > > >>> ----- Original Message -----
> > > > > > >>>> From: "Itamar Heim"
<iheim(a)redhat.com>
> > > > > > >>>> To: "David Caro"
<dcaroest(a)redhat.com>
> > > > > > >>>> Cc: "engine-devel"
<engine-devel(a)ovirt.org>,
> > > > > > >>>> vdsm-devel(a)lists.fedorahosted.org
> > > > > > >>>> Sent: Monday, September 23, 2013 1:47:47
PM
> > > > > > >>>> Subject: Re: [vdsm] stale gerrit patches
> > > > > > >>>>
> > > > > > >>>> On 09/23/2013 01:46 PM, David Caro wrote:
> > > > > > >>>>> On Mon 23 Sep 2013 12:36:58 PM CEST,
Itamar Heim wrote:
> > > > > > >>>>>> we have some very old gerrit
patches.
> > > > > > >>>>>> I'm for abandoning patches
which were not touched over 60
> > > > > > >>>>>> days
> > > > > > >>>>>> (to
> > > > > > >>>>>> begin with, I think the number
should actually be lower).
> > > > > > >>>>>> they can always be re-opened by
any interested party post
> > > > > > >>>>>> their
> > > > > > >>>>>> closure.
> > > > > > >>>>>>
> > > > > > >>>>>> i.e., looking at gerrit, the patch
list should actually
> > > > > > >>>>>> get
> > > > > > >>>>>> attention,
> > > > > > >>>>>> and not be a few worth looking at,
with a "lot of old
> > > > > > >>>>>> patches"
> > > > > > >>>>>>
> > > > > > >>>>>> thoughts?
> > > > > > >>>>>>
> > > > > > >>>>>> Thanks,
> > > > > > >>>>>> Itamar
> > > > > > >>>>>>
_______________________________________________
> > > > > > >>>>>> vdsm-devel mailing list
> > > > > > >>>>>> vdsm-devel(a)lists.fedorahosted.org
> > > > > > >>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > > > > >>>>>
> > > > > > >>>>> It might helpful to have a cron-like
script that checks the
> > > > > > >>>>> age
> > > > > > >>>>> of
> > > > > > >>>>> the
> > > > > > >>>>> posts and first notifies the sender,
the reviewers and the
> > > > > > >>>>> maintainer,
> > > > > > >>>>> and if the patch is not updated in a
certain period just
> > > > > > >>>>> abandons
> > > > > > >>>>> it.
> > > > > > >>>>>
> > > > > > >>>>
> > > > > > >>>> yep - warn after X days via email to just
owner (or all
> > > > > > >>>> subscribed
> > > > > > >>>> to
> > > > > > >>>> the patch), and close if no activity for
X+14 days or
> > > > > > >>>> something
> > > > > > >>>> like
> > > > > > >>>> that.
> > > > > > >>>
> > > > > > >>> This will be annoying.
> > > > > > >>>
> > > > > > >>> And there are patches that pending with good
reason.
> > > > > > >>
> > > > > > >> pending for 60 days with zero activity on them (no
comment, no
> > > > > > >> rebase,
> > > > > > >> nothing)?
> > > > > > >
> > > > > > >
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
> > > > > >
> > > > > > so how does it help us to have these patches, some without
any
> > > > > > comment
> > > > > > from any reviewer.
> > > > > > lets get them reviewed and decide one way or the other,
rather
> > > > > > than
> > > > > > let
> > > > > > them get old and stay forever
> > > > >
> > > > > Again... maintainer can close these if he likes.
> > > > > Owner can close these if he likes.
> > > >
> > > > right, but why?
> > > > a patch without activity being abandoned might actually spur someone
> > > > into
> > > > motion (rebasing and resubmitting, prodding maintainers etc).
> > > > I'm +1 for automatically abandoning old patches.
> > > >
> > >
> > > I do not understand why maintainer should not have human interaction
> > > with
> > > its
> > > contributers.
> >
> > I do not understand the relation between the subject and the things
> > you're
> > saying.
> > Right now these patches are stale and are rotting, abandoning them could
> > actually spur those interactions into motion.
>
> You prefer machines to interact with contributers to kick them in motion.
> I believe that human interaction and discussion between maintainer and
> contributer is the way to go.
> It is much more polite and cooperative for maintainer that is not aware of
> anything blocking a progress to kindly interact with contributer and
> finally
> close the change if contributer is unresponsive and/or change has no value.
Personally I see nothing impolite about automatically abandoning patches if
it is clear to contributors that this the expected behaviour.
It has nothing to do with polite, but build relationship between people and not force
people to reopen important changes and explain them-selves every time a machine decides
to.
Other projects abandon automatically after a week and from what
I've seen
that is working well to get things in motion and get those interactions that
you (and I) want, rolling.
The herd argument is never accepted by me, the herd seldom has definite wisdom.
I would like maintainers to build human relationship with their contributers it is more
important than having one or two extra changes in queue, as these relationships will serve
us at other plains as well.
So our mission is indeed different... you are interested in rolling, while I am in
creating ecosystem of people, which eventually will roll much faster.
>
> >
> > >
> > > > >
> > > > > The problem is that maintainers avoid closing.
> > > > > And that there are people who submitted patches without CC
anyone
> > > > > and
> > > > > gone.
> > > > >
> > > > > So a simple logic can be applied after we add metadata into
tree:
> > > > >
> > > > > 1. If no maintainer is CCed on change, close that change within
> > > > > short
> > > > > cycle
> > > > > (can be even a week).
> > > > > 2. Maintainer to close patches that have no interest in.
> > > > >
> > > > > >
> > > > > > >
> > > > > > >>
> > > > > > >>>
> > > > > > >>> Maintainers can close patches that are no
interest nor
> > > > > > >>> progress.
> > > > > > >>>
> > > > > > >>> Alon
> > > > > > >>>
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > > >
> > > > > _______________________________________________
> > > > > vdsm-devel mailing list
> > > > > vdsm-devel(a)lists.fedorahosted.org
> > > > > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > > >
> > > >
> > >
> >
>
11:06 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
----- Original Message -----
> From: "Ayal Baron" <abaron(a)redhat.com>
> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> Cc: "Itamar Heim" <iheim(a)redhat.com>, "engine-devel"
> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> Sent: Tuesday, September 24, 2013 10:09:46 AM
> Subject: Re: [vdsm] stale gerrit patches
>
>
>
> ----- Original Message -----
> >
> >
> > ----- Original Message -----
> > > From: "Ayal Baron" <abaron(a)redhat.com>
> > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > Cc: "Itamar Heim" <iheim(a)redhat.com>,
"engine-devel"
> > > <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
> > > Sent: Tuesday, September 24, 2013 9:20:55 AM
> > > Subject: Re: [vdsm] stale gerrit patches
> > >
> > >
> > >
> > > ----- Original Message -----
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Ayal Baron" <abaron(a)redhat.com>
> > > > > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
> > > > > Cc: "Itamar Heim" <iheim(a)redhat.com>,
"engine-devel"
> > > > > <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > > Sent: Tuesday, September 24, 2013 12:21:23 AM
> > > > > Subject: Re: [vdsm] stale gerrit patches
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Itamar Heim"
<iheim(a)redhat.com>
> > > > > > > To: "Alon Bar-Lev"
<alonbl(a)redhat.com>
> > > > > > > Cc: "David Caro"
<dcaroest(a)redhat.com>, "engine-devel"
> > > > > > > <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > > > > Sent: Monday, September 23, 2013 1:54:39 PM
> > > > > > > Subject: Re: [vdsm] stale gerrit patches
> > > > > > >
> > > > > > > On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
> > > > > > > >
> > > > > > > >
> > > > > > > > ----- Original Message -----
> > > > > > > >> From: "Itamar Heim"
<iheim(a)redhat.com>
> > > > > > > >> To: "Alon Bar-Lev"
<alonbl(a)redhat.com>
> > > > > > > >> Cc: "David Caro"
<dcaroest(a)redhat.com>, "engine-devel"
> > > > > > > >> <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> > > > > > > >> Sent: Monday, September 23, 2013 1:50:35 PM
> > > > > > > >> Subject: Re: [vdsm] stale gerrit patches
> > > > > > > >>
> > > > > > > >> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>> ----- Original Message -----
> > > > > > > >>>> From: "Itamar Heim"
<iheim(a)redhat.com>
> > > > > > > >>>> To: "David Caro"
<dcaroest(a)redhat.com>
> > > > > > > >>>> Cc: "engine-devel"
<engine-devel(a)ovirt.org>,
> > > > > > > >>>> vdsm-devel(a)lists.fedorahosted.org
> > > > > > > >>>> Sent: Monday, September 23, 2013
1:47:47 PM
> > > > > > > >>>> Subject: Re: [vdsm] stale gerrit
patches
> > > > > > > >>>>
> > > > > > > >>>> On 09/23/2013 01:46 PM, David Caro
wrote:
> > > > > > > >>>>> On Mon 23 Sep 2013 12:36:58 PM
CEST, Itamar Heim wrote:
> > > > > > > >>>>>> we have some very old gerrit
patches.
> > > > > > > >>>>>> I'm for abandoning
patches which were not touched over
> > > > > > > >>>>>> 60
> > > > > > > >>>>>> days
> > > > > > > >>>>>> (to
> > > > > > > >>>>>> begin with, I think the
number should actually be
> > > > > > > >>>>>> lower).
> > > > > > > >>>>>> they can always be re-opened
by any interested party
> > > > > > > >>>>>> post
> > > > > > > >>>>>> their
> > > > > > > >>>>>> closure.
> > > > > > > >>>>>>
> > > > > > > >>>>>> i.e., looking at gerrit, the
patch list should actually
> > > > > > > >>>>>> get
> > > > > > > >>>>>> attention,
> > > > > > > >>>>>> and not be a few worth
looking at, with a "lot of old
> > > > > > > >>>>>> patches"
> > > > > > > >>>>>>
> > > > > > > >>>>>> thoughts?
> > > > > > > >>>>>>
> > > > > > > >>>>>> Thanks,
> > > > > > > >>>>>> Itamar
> > > > > > > >>>>>>
_______________________________________________
> > > > > > > >>>>>> vdsm-devel mailing list
> > > > > > > >>>>>>
vdsm-devel(a)lists.fedorahosted.org
> > > > > > > >>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > > > > > >>>>>
> > > > > > > >>>>> It might helpful to have a
cron-like script that checks
> > > > > > > >>>>> the
> > > > > > > >>>>> age
> > > > > > > >>>>> of
> > > > > > > >>>>> the
> > > > > > > >>>>> posts and first notifies the
sender, the reviewers and
> > > > > > > >>>>> the
> > > > > > > >>>>> maintainer,
> > > > > > > >>>>> and if the patch is not updated
in a certain period just
> > > > > > > >>>>> abandons
> > > > > > > >>>>> it.
> > > > > > > >>>>>
> > > > > > > >>>>
> > > > > > > >>>> yep - warn after X days via email to
just owner (or all
> > > > > > > >>>> subscribed
> > > > > > > >>>> to
> > > > > > > >>>> the patch), and close if no activity
for X+14 days or
> > > > > > > >>>> something
> > > > > > > >>>> like
> > > > > > > >>>> that.
> > > > > > > >>>
> > > > > > > >>> This will be annoying.
> > > > > > > >>>
> > > > > > > >>> And there are patches that pending with
good reason.
> > > > > > > >>
> > > > > > > >> pending for 60 days with zero activity on
them (no comment,
> > > > > > > >> no
> > > > > > > >> rebase,
> > > > > > > >> nothing)?
> > > > > > > >
> > > > > > > >
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
> > > > > > >
> > > > > > > so how does it help us to have these patches, some
without any
> > > > > > > comment
> > > > > > > from any reviewer.
> > > > > > > lets get them reviewed and decide one way or the
other, rather
> > > > > > > than
> > > > > > > let
> > > > > > > them get old and stay forever
> > > > > >
> > > > > > Again... maintainer can close these if he likes.
> > > > > > Owner can close these if he likes.
> > > > >
> > > > > right, but why?
> > > > > a patch without activity being abandoned might actually spur
> > > > > someone
> > > > > into
> > > > > motion (rebasing and resubmitting, prodding maintainers etc).
> > > > > I'm +1 for automatically abandoning old patches.
> > > > >
> > > >
> > > > I do not understand why maintainer should not have human interaction
> > > > with
> > > > its
> > > > contributers.
> > >
> > > I do not understand the relation between the subject and the things
> > > you're
> > > saying.
> > > Right now these patches are stale and are rotting, abandoning them
> > > could
> > > actually spur those interactions into motion.
> >
> > You prefer machines to interact with contributers to kick them in motion.
> > I believe that human interaction and discussion between maintainer and
> > contributer is the way to go.
> > It is much more polite and cooperative for maintainer that is not aware
> > of
> > anything blocking a progress to kindly interact with contributer and
> > finally
> > close the change if contributer is unresponsive and/or change has no
> > value.
>
> Personally I see nothing impolite about automatically abandoning patches if
> it is clear to contributors that this the expected behaviour.
It has nothing to do with polite, but build relationship between people and
not force people to reopen important changes and explain them-selves every
time a machine decides to.
> Other projects abandon automatically after a week and from what I've seen
> that is working well to get things in motion and get those interactions
> that
> you (and I) want, rolling.
The herd argument is never accepted by me, the herd seldom has definite
wisdom.
I would like maintainers to build human relationship with their contributers
it is more important than having one or two extra changes in queue, as these
relationships will serve us at other plains as well.
So our mission is indeed different... you are interested in rolling, while I
am in creating ecosystem of people, which eventually will roll much faster.
I'm amused by your insistent efforts in trying to spin what I say and misinterpret my
words.
I am interested in exactly the same thing as you are. Practically though, you are not
suggesting anything different than what exists today which is getting us today's
results which neither you nor I are satisfied with. I am trying to change the dynamics
and test what works to get things in the direction we both want them to, you are saying
'this is the way things should be' and are not willing to try new things that may
actually get us there.
> >
> > >
> > > >
> > > > > >
> > > > > > The problem is that maintainers avoid closing.
> > > > > > And that there are people who submitted patches without CC
anyone
> > > > > > and
> > > > > > gone.
> > > > > >
> > > > > > So a simple logic can be applied after we add metadata into
tree:
> > > > > >
> > > > > > 1. If no maintainer is CCed on change, close that change
within
> > > > > > short
> > > > > > cycle
> > > > > > (can be even a week).
> > > > > > 2. Maintainer to close patches that have no interest in.
> > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > >>
> > > > > > > >>>
> > > > > > > >>> Maintainers can close patches that are no
interest nor
> > > > > > > >>> progress.
> > > > > > > >>>
> > > > > > > >>> Alon
> > > > > > > >>>
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > > >
> > > > > > _______________________________________________
> > > > > > vdsm-devel mailing list
> > > > > > vdsm-devel(a)lists.fedorahosted.org
> > > > > > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
> > > > > >
> > > > >
> > > >
> > >
> >
>
5:16 a.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
on 2013/09/24 05:21, Ayal Baron wrote:
----- Original Message -----
>
>
> ----- Original Message -----
>> From: "Itamar Heim" <iheim(a)redhat.com>
>> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
>> Cc: "David Caro" <dcaroest(a)redhat.com>, "engine-devel"
>> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
>> Sent: Monday, September 23, 2013 1:54:39 PM
>> Subject: Re: [vdsm] stale gerrit patches
>>
>> On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>>> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
>>>> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
>>>> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
>>>> Sent: Monday, September 23, 2013 1:50:35 PM
>>>> Subject: Re: [vdsm] stale gerrit patches
>>>>
>>>> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>>>>> To: "David Caro" <dcaroest(a)redhat.com>
>>>>>> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
>>>>>> vdsm-devel(a)lists.fedorahosted.org
>>>>>> Sent: Monday, September 23, 2013 1:47:47 PM
>>>>>> Subject: Re: [vdsm] stale gerrit patches
>>>>>>
>>>>>> On 09/23/2013 01:46 PM, David Caro wrote:
>>>>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>>>>>>>> we have some very old gerrit patches.
>>>>>>>> I'm for abandoning patches which were not touched
over 60 days (to
>>>>>>>> begin with, I think the number should actually be
lower).
>>>>>>>> they can always be re-opened by any interested party post
their
>>>>>>>> closure.
>>>>>>>>
>>>>>>>> i.e., looking at gerrit, the patch list should actually
get
>>>>>>>> attention,
>>>>>>>> and not be a few worth looking at, with a "lot of
old patches"
>>>>>>>>
>>>>>>>> thoughts?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Itamar
>>>>>>>> _______________________________________________
>>>>>>>> vdsm-devel mailing list
>>>>>>>> vdsm-devel(a)lists.fedorahosted.org
>>>>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>>>>>>>
>>>>>>> It might helpful to have a cron-like script that checks the
age of
>>>>>>> the
>>>>>>> posts and first notifies the sender, the reviewers and the
>>>>>>> maintainer,
>>>>>>> and if the patch is not updated in a certain period just
abandons it.
>>>>>>>
>>>>>>
>>>>>> yep - warn after X days via email to just owner (or all
subscribed to
>>>>>> the patch), and close if no activity for X+14 days or something
like
>>>>>> that.
>>>>>
>>>>> This will be annoying.
>>>>>
>>>>> And there are patches that pending with good reason.
>>>>
>>>> pending for 60 days with zero activity on them (no comment, no rebase,
>>>> nothing)?
>>>
>>>
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
>>
>> so how does it help us to have these patches, some without any comment
>> from any reviewer.
>> lets get them reviewed and decide one way or the other, rather than let
>> them get old and stay forever
>
> Again... maintainer can close these if he likes.
> Owner can close these if he likes.
right, but why?
a patch without activity being abandoned might actually spur someone into motion
(rebasing and resubmitting, prodding maintainers etc).
I'm +1 for automatically abandoning old patches.
At least we all agree on that old patches should be abandoned.
I think we can do this in a semi-automatic way. A cron job checks the
patch's freshness, and sends an email to warn the author and reviewers
of an old patch. If the someone has a good reason to keep the patch, he
can leave a comment on the gerrit web page saying "I want to #keep the
patch# because ...". Then the system skips the patches whose last
comment contains "#keep the patch#". If no one cares it, the patch is
abandoned after some time.
--
Thanks and best regards!
Zhou Zheng Sheng / 周征晟
E-mail: zhshzhou(a)linux.vnet.ibm.com
Telephone: 86-10-82454397
12:52 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Zhou Zheng Sheng"
<zhshzhou(a)linux.vnet.ibm.com>
To: "Ayal Baron" <abaron(a)redhat.com>
Cc: "engine-devel" <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
Sent: Wednesday, September 25, 2013 5:16:16 AM
Subject: Re: [Engine-devel] [vdsm] stale gerrit patches
on 2013/09/24 05:21, Ayal Baron wrote:
>
>
> ----- Original Message -----
>>
>>
>> ----- Original Message -----
>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
>>> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
>>> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
>>> Sent: Monday, September 23, 2013 1:54:39 PM
>>> Subject: Re: [vdsm] stale gerrit patches
>>>
>>> On 09/23/2013 01:52 PM, Alon Bar-Lev wrote:
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>>>> To: "Alon Bar-Lev" <alonbl(a)redhat.com>
>>>>> Cc: "David Caro" <dcaroest(a)redhat.com>,
"engine-devel"
>>>>> <engine-devel(a)ovirt.org>, vdsm-devel(a)lists.fedorahosted.org
>>>>> Sent: Monday, September 23, 2013 1:50:35 PM
>>>>> Subject: Re: [vdsm] stale gerrit patches
>>>>>
>>>>> On 09/23/2013 01:49 PM, Alon Bar-Lev wrote:
>>>>>>
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>> From: "Itamar Heim" <iheim(a)redhat.com>
>>>>>>> To: "David Caro" <dcaroest(a)redhat.com>
>>>>>>> Cc: "engine-devel"
<engine-devel(a)ovirt.org>,
>>>>>>> vdsm-devel(a)lists.fedorahosted.org
>>>>>>> Sent: Monday, September 23, 2013 1:47:47 PM
>>>>>>> Subject: Re: [vdsm] stale gerrit patches
>>>>>>>
>>>>>>> On 09/23/2013 01:46 PM, David Caro wrote:
>>>>>>>> On Mon 23 Sep 2013 12:36:58 PM CEST, Itamar Heim wrote:
>>>>>>>>> we have some very old gerrit patches.
>>>>>>>>> I'm for abandoning patches which were not
touched over 60 days (to
>>>>>>>>> begin with, I think the number should actually be
lower).
>>>>>>>>> they can always be re-opened by any interested party
post their
>>>>>>>>> closure.
>>>>>>>>>
>>>>>>>>> i.e., looking at gerrit, the patch list should
actually get
>>>>>>>>> attention,
>>>>>>>>> and not be a few worth looking at, with a "lot
of old patches"
>>>>>>>>>
>>>>>>>>> thoughts?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Itamar
>>>>>>>>> _______________________________________________
>>>>>>>>> vdsm-devel mailing list
>>>>>>>>> vdsm-devel(a)lists.fedorahosted.org
>>>>>>>>>
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
>>>>>>>>
>>>>>>>> It might helpful to have a cron-like script that checks
the age of
>>>>>>>> the
>>>>>>>> posts and first notifies the sender, the reviewers and
the
>>>>>>>> maintainer,
>>>>>>>> and if the patch is not updated in a certain period just
abandons
>>>>>>>> it.
>>>>>>>>
>>>>>>>
>>>>>>> yep - warn after X days via email to just owner (or all
subscribed to
>>>>>>> the patch), and close if no activity for X+14 days or
something like
>>>>>>> that.
>>>>>>
>>>>>> This will be annoying.
>>>>>>
>>>>>> And there are patches that pending with good reason.
>>>>>
>>>>> pending for 60 days with zero activity on them (no comment, no
rebase,
>>>>> nothing)?
>>>>
>>>>
http://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste...
>>>
>>> so how does it help us to have these patches, some without any comment
>>> from any reviewer.
>>> lets get them reviewed and decide one way or the other, rather than let
>>> them get old and stay forever
>>
>> Again... maintainer can close these if he likes.
>> Owner can close these if he likes.
>
> right, but why?
> a patch without activity being abandoned might actually spur someone into
> motion (rebasing and resubmitting, prodding maintainers etc).
> I'm +1 for automatically abandoning old patches.
>
At least we all agree on that old patches should be abandoned.
I think we can do this in a semi-automatic way. A cron job checks the
patch's freshness, and sends an email to warn the author and reviewers
of an old patch. If the someone has a good reason to keep the patch, he
can leave a comment on the gerrit web page saying "I want to #keep the
patch# because ...". Then the system skips the patches whose last
comment contains "#keep the patch#". If no one cares it, the patch is
abandoned after some time.
+1 for Zhou Zheng Sheng.
Much better suggestion than automatically forgetting old patches by removing them.
A reminder can be sent after couple of weeks or even a month, and auto abandon the patch
if no response added to the bug within a week.
I like this suggestion if we want to add automation for this process (as we all prefer
automation when possible), and it'll probably help a bit to clean our gerrit dash
board
--
Thanks and best regards!
Zhou Zheng Sheng / 周征晟
E-mail: zhshzhou(a)linux.vnet.ibm.com
Telephone: 86-10-82454397
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
1:07 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
Hi,
On 09/23/2013 12:36 PM, Itamar Heim wrote:
we have some very old gerrit patches.
I'm for abandoning patches which were not touched over 60 days (to begin
with, I think the number should actually be lower).
they can always be re-opened by any interested party post their closure.
i.e., looking at gerrit, the patch list should actually get attention,
and not be a few worth looking at, with a "lot of old patches"
I'm coming late to this discussion, but I see that there were some
dissenting views from people who want maintainers to be able to store
"in-progress" patches in Gerrit.
I am all in favour of treating Gerrit like we treat a bug tracker. If
something is opened in the bug tracker, it should be a bug, an open bug
is something to be fixed or closed, not to be left indefinitely. An open
patch needs to be rejected, reviewed, revised or committed. I don't
think Gerrit is the place for in-progress patches (use private branches
for that).
Cheers,
Dave.
--
Dave Neary - Community Action and Impact
Open Source and Standards, Red Hat - http://community.redhat.com
Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13
1:16 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
----- Original Message -----
From: "Dave Neary" <dneary(a)redhat.com>
To: "Itamar Heim" <iheim(a)redhat.com>
Cc: "engine-devel" <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
Sent: Wednesday, October 9, 2013 12:07:45 PM
Subject: Re: [vdsm] stale gerrit patches
Hi,
On 09/23/2013 12:36 PM, Itamar Heim wrote:
> we have some very old gerrit patches.
> I'm for abandoning patches which were not touched over 60 days (to begin
> with, I think the number should actually be lower).
> they can always be re-opened by any interested party post their closure.
>
> i.e., looking at gerrit, the patch list should actually get attention,
> and not be a few worth looking at, with a "lot of old patches"
I'm coming late to this discussion, but I see that there were some
dissenting views from people who want maintainers to be able to store
"in-progress" patches in Gerrit.
I am all in favour of treating Gerrit like we treat a bug tracker. If
something is opened in the bug tracker, it should be a bug, an open bug
is something to be fixed or closed, not to be left indefinitely. An open
patch needs to be rejected, reviewed, revised or committed. I don't
think Gerrit is the place for in-progress patches (use private branches
for that).
Just point out that you can also use 'drafts' to store those in progress changes:
http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-...
Cheers,
Dave.
--
Dave Neary - Community Action and Impact
Open Source and Standards, Red Hat - http://community.redhat.com
Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13
_______________________________________________
vdsm-devel mailing list
vdsm-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
1:18 p.m.
New subject: [Engine-devel] [vdsm] stale gerrit patches
On Wed, Oct 09, 2013 at 06:16:09AM -0400, David Caro Estevez wrote:
----- Original Message -----
> From: "Dave Neary" <dneary(a)redhat.com>
> To: "Itamar Heim" <iheim(a)redhat.com>
> Cc: "engine-devel" <engine-devel(a)ovirt.org>,
vdsm-devel(a)lists.fedorahosted.org
> Sent: Wednesday, October 9, 2013 12:07:45 PM
> Subject: Re: [vdsm] stale gerrit patches
>
> Hi,
>
> On 09/23/2013 12:36 PM, Itamar Heim wrote:
> > we have some very old gerrit patches.
> > I'm for abandoning patches which were not touched over 60 days (to begin
> > with, I think the number should actually be lower).
> > they can always be re-opened by any interested party post their closure.
> >
> > i.e., looking at gerrit, the patch list should actually get attention,
> > and not be a few worth looking at, with a "lot of old patches"
>
> I'm coming late to this discussion, but I see that there were some
> dissenting views from people who want maintainers to be able to store
> "in-progress" patches in Gerrit.
>
> I am all in favour of treating Gerrit like we treat a bug tracker. If
> something is opened in the bug tracker, it should be a bug, an open bug
> is something to be fixed or closed, not to be left indefinitely. An open
> patch needs to be rejected, reviewed, revised or committed. I don't
> think Gerrit is the place for in-progress patches (use private branches
> for that).
Just point out that you can also use 'drafts' to store those in progress changes:
http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-...
+1 for drafts. git review -D submits your patches as drafts.
4061
days inactive
4077
days old
20 comments
9 participants
participants (9)
-
Alon Bar-Lev -
Ayal Baron -
Dave Neary -
David Caro -
David Caro Estevez
-
Ewoud Kohl van Wijngaarden -
Itamar Heim -
Yaniv Bronheim -
Zhou Zheng Sheng