Tal Nisan has submitted this change and it was merged.
Change subject: engine: Adjust Un/LabelNetworkCommand to use
commandBase.runInternalAction
......................................................................
engine: Adjust Un/LabelNetworkCommand to use commandBase.runInternalAction
UnlabelNetworkCommand and LabelNetworkCommand call UpdateNetworkCommand
internally. For unknown reason they used getBackend().runAction(..) for
this purpose.
Since the call to UpdateNetworkCommand is internal runInternalAction(..)
should be called.
Due to the last changes to CommandBase- commandBase.runInternalAction(..)
should be used.
Change-Id: Ibbe6c0e74129c2ae25d540331a93225181ae41c8
Bug-Url:
https://bugzilla.redhat.com/1123636
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
(cherry picked from commit e71e719e0f8e90b30fb0f7c57ce7de4b07cb963d)
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/LabelNetworkCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkModification.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UnlabelNetworkCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
5 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/30774
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbe6c0e74129c2ae25d540331a93225181ae41c8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server